anycable-rails 0.6.5 → 1.0.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d538541df27b5712aadd225d788d43c7d6de563a15dcbb85dd9ef51ff1b13be4
-  data.tar.gz: e7e5c055860a07f2554af925cee5076a07f97cfcdfa7d540891cb187bbc32f72
+  metadata.gz: 3ebb4dc7b8483998770f7168cc8884d8a56a0e5376e04550b2f98b1d11046cdf
+  data.tar.gz: 29a21773378af2c3bcc6cd3265d58d028a7bef7b8fc2be13bafda3f54677d8b1
 SHA512:
-  metadata.gz: 007b964f71b796feb189e76d82f2ae3e16c679c56811b9a1b7105bc5663e5e432bcebe4f9a16a971e3819be658f2fcfb8198576d7c9d75495dcc9dcd9db7949e
-  data.tar.gz: 257f761cfdd1fc3b05d8e1446297a7b31119c667e88e73db1a72485252f5f57e672ee6ac3c39b72e32286b4994d7b62f30f888c4aa12039202c8ccc93fb8df38
+  metadata.gz: cde255681a0348c2edc41fc3130d632f8f17ea02937691b62a388f8a73a699b9e1669e9c7ea55f1dad3a74b6e0d289a3a07feda97adbcbbfcc5d1e316213a704
+  data.tar.gz: 88c80148d66a610472bf8a129a381198d044c89884a800f4209c19f67a6cf527763620bfd804b03cbddb0f6752b6e69c8065e4bfbf1c33da11e66cb7def49688

data/CHANGELOG.md

@@ -2,141 +2,59 @@
 
 ## master
 
-## 0.6.5 (2020-02-05)
+## 1.0.0.rc3 (2020-06-24)
 
-- Make channel not found exception more descriptive. ([@palkan][])
+- Make AnyCable patches compatible with Action Cable testing. ([@palkan][])
 
-Previusly, we returned `Undefined method handle_subscribe for nil` when Action Cable
-couldn't resolve the channel class. Now we return `Channel not found: <name>`.
+- Do not add localhost `redis_url` to `anycable.yml` when Docker development method is chosen in `anycable:setup`. ([@palkan][])
 
-- Require a minimum version of Ruby when installing the gem. ([@bibendi][])
-
-- Add ability to develop the gem with Docker. ([@bibendi][])
-
-## 0.6.4 (2019-06-26) 👶
-
-- Fix Compatibility bug when using with AnyCable. ([@palkan][])
-
-  Compatibility patching (with `prepend` + `super`) conflicted with
-  the `ActionCable::Channel::Base` patching in the core functionality (which uses `alias`).
-
-  See [#95](https://github.com/anycable/anycable-rails/issues/95).
-
-## 0.6.3 (2019-03-26)
-
-- Fix connection factory reloading for development sake. ([@sponomarev][])
-
-- Add `:anycable` subscription adapter alias. ([@sponomarev][])
-
-- Don't set AnyCable connection factory for incompatible adapter ([@sponomarev][])
-
-  `anycable` server won't start with unpatched vanilla `ApplicationCable::Connection`.
-
-  Motivation in [#74](https://github.com/anycable/anycable-rails/issues/74).
-
-- Fix instance detection inside complex cases in compatibility cops ([@sponomarev][])
-
-## 0.6.2 (2019-01-10)
-
-- Fixed `anycable` 0.6.1 compatibility. ([@palkan][])
-
-- Broadcast logs to STDOUT in development only when server is running. ([@palkan][])
-
-  Fixes #59.
-
-## 0.6.1 (2018-11-15)
-
-- Fix regression introduced in [e64a366e](https://github.com/anycable/anycable-rails/commit/e64a366ea21293925e0c5c0b8e6595d65d5d0981#diff-fd0e56a6e825002eac978507c3581af7R14) ([@palkan][])
-
-`Connection` patch could be loaded after `identify_by` is called, thus breaking
-identifiers.
-
-## 0.6.0 (2018-11-15)
+## 1.0.0.rc2 (2020-06-16)
 
-**NOTE**: this version has been yanked from RubyGems due to the regression bug. Use 0.6.1.
+- Fix connection identifiers deserialization regression. ([@palkan][])
 
-- [PR #56](https://github.com/anycable/anycable-rails/pull/56) Request verification based on ActionCable config. ([@DmitryTsepelev][])
+Using non-strings or non-GlobalId-encoded objects was broken.
 
-- Add WS server session ID to log tags if present. ([@palkan][])
+- Improve `anycable:setup` generator. ([@palkan][])
 
-- Support tagged logging. ([@palkan][])
+Update Docker snippet, do not enable persistent sessions automatically,
+fix setting `config.action_cable.url` in environment configuration.
 
-- Action Cable monkey-patches are only loaded in the context of AnyCable CLI. ([@palkan][])
+## 1.0.0.rc1 (2020-06-10)
 
-  No need to think about `requie` and `group` for `anycable-rails`, just add it to Gemfile.
+- Add `state_attr_accessor` for channels. ([@palkan][])
 
-- Add `:any_cable` subscription adapter for Action Cable. ([@palkan][])
+Just like `attr_accessor` but "persists" the state between RPC calls.
 
-  Use `:any_cable` adapter for Action Cable to broadcast data to AnyCable.
+- Add `Channel#stop_stream_from` support. ([@palkan][])
 
-  No more `pubsub` monkey-patches 🎉.
+- Add `RemoteConnections` support. ([@palkan][])
 
-- Added Rails executor/reloader support. ([@palkan][])
+- Add `AnyCable::Rails.enabled?` method which returns true if Action Cable uses AnyCable adapter. ([@palkan][])
 
-- **[Breaking]** No more generators. ([@palkan][])
+- Add `anycable:download` generator to download `anycable-go` binary. ([@palkan][])
 
-  No need to generate AnyCable runner script since `anycable` gem ships with
-  the CLI.
+- **Ruby 2.5+ is required**. ([@palkan][])
 
-- Add dynamic (`AnyCable::CompatibilityError`) compatibility checks. ([@DmitryTsepelev][])
+- Support `disconnect` messages. ([@palkan][])
 
-- Added static (RuboCop) compatibility checks. ([@DmitryTsepelev][])
+Added in Rails 6 (see [PR#34194](https://github.com/rails/rails/pull/34194)).
 
-  See https://github.com/anycable/anycable-rails/issues/52
+- Add ability to persist _dirty_ `request.session` between RPC calls. ([@palkan][])
 
-## 0.5.4 (2018-06-13)
+This feature emulates the Action Cable behaviour where it's possible to use `request.session` as a shared Hash-like store.
+This could be used by some applications (e.g., [StimulusReflex](https://github.com/hopsoft/stimulus_reflex)-based).
 
-- Fix duplicate logs in development. ([@palkan][])
+You must turn this feature on by setting `persistent_session_enabled: true` in the AnyCable configuration.
 
-  Fixes https://github.com/anycable/anycable_demo/issues/5.
+- Add ability to use Rack middlewares when build a request for a connection. ([@bibendi][])
 
-## 0.5.3
+- Add set up generator to configure a Rails application by running `bin/rails g anycable:setup`. ([@bibendi][])
 
-- Fix return value of `Connection#handle_close`. ([@palkan][])
-
-  Should always be `true`, we do not expect a failure here.
-
-## 0.5.2
-
-- Add config/anycable.yml to Rails generator. ([@alekseyl][])
-
-## 0.5.1
-
-- Improve Rails integration. ([@palkan][])
-
-Log to STDOUT in development.
-Make order of initializers more deterministic.
-Show warning if AnyCable is loaded after application initialization.
-
-## 0.5.0
-
-- [#17](https://github.com/anycable/anycable-rails/issues/17) Refactor logging. ([@palkan][])
-
-Use Rails logger everywhere.
-
-Add access logs ([anycable/anycable#20](https://github.com/anycable/anycable/issues/20)).
-
-## 0.4.7
-
-- Minor fixes. ([@palkan][])
-
-## 0.4.6
-
-- Disable mounting default Action Cable server when AnyCable is loaded. ([@palkan][])
-
-## 0.4.5
-
-- Handle tagged logger. ([@palkan][])
-
-Ignore tagged logger features ('cause we do not have _persistent_ logger).
-
-## 0.4.4
-
-- Fix bug with ActiveRecord connections (https://github.com/anycable/anycable/issues/9). ([@palkan][])
+- Require a minimum version of Ruby when installing the gem. ([@bibendi][])
 
-## 0.4.0
+- Add ability to develop the gem with Docker. ([@bibendi][])
 
-- Initial version. ([@palkan][])
+See [Changelog](https://github.com/anycable/anycable-rails/blob/0-6-stable/CHANGELOG.md) for versions <1.0.0.
 
 [@palkan]: https://github.com/palkan
 [@alekseyl]: https://github.com/alekseyl

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2017 palkan
+Copyright 2017-2020 palkan
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,6 +1,8 @@
-[![GitPitch](https://gitpitch.com/assets/badge.svg)](https://gitpitch.com/anycable/anycable/master?grs=github) [![Gem Version](https://badge.fury.io/rb/anycable-rails.svg)](https://rubygems.org/gems/anycable-rails) [![Build Status](https://travis-ci.org/anycable/anycable-rails.svg?branch=master)](https://travis-ci.org/anycable/anycable-rails)
+[![GitPitch](https://gitpitch.com/assets/badge.svg)](https://gitpitch.com/anycable/anycable/master?grs=github)
+[![Gem Version](https://badge.fury.io/rb/anycable-rails.svg)](https://rubygems.org/gems/anycable-rails)
+[![Build](https://github.com/anycable/anycable-rails/workflows/Build/badge.svg)](https://github.com/anycable/anycable-rails/actions)
 [![Gitter](https://img.shields.io/badge/gitter-join%20chat%20%E2%86%92-brightgreen.svg)](https://gitter.im/anycable/Lobby)
-[![Documentation](https://img.shields.io/badge/docs-link-brightgreen.svg)](https://docs.anycable.io/#/ruby/rails)
+[![Documentation](https://img.shields.io/badge/docs-link-brightgreen.svg)](https://docs.anycable.io/v1/#/ruby/rails)
 
 # AnyCable Rails
 
@@ -10,27 +12,23 @@ With AnyCable you can use channels, client-side JS, broadcasting - (almost) all
 
 You can even use Action Cable in development and not be afraid of [compatibility issues](#compatibility).
 
-💾 [Example Application](https://github.com/anycable/anycable_demo)
+**Important** This is a readme for the upcoming v1.0 release. For v0.6.x see the readme from the [0-6-stable](https://github.com/anycable/anycable-rails/tree/0-6-stable) branch.
 
-📑 [Documentation](https://docs.anycable.io).
+<!-- 💾 [Example Application](https://github.com/anycable/anycable_demo) -->
 
+📑 [Documentation](https://docs.anycable.io/v1/#/ruby/rails).
 
 <a href="https://evilmartians.com/">
 <img src="https://evilmartians.com/badges/sponsored-by-evil-martians.svg" alt="Sponsored by Evil Martians" width="236" height="54"></a>
 
 ## Requirements
 
-- Ruby >= 2.4; **NOTE:** for Ruby 2.6 use RC version of `google-protobuf` gem. In your Gemfile: `gem "google-protobuf", '>=3.7.0.rc.2'`
-- Rails >= 5.0;
-- Redis (see [other options]() for broadcasting)
-
-## How It Works?
-
-<img src="https://trello-attachments.s3.amazonaws.com/5781e0ed48e4679e302833d3/820x987/5b6a305417b04e20e75f49c5816e027c/Anycable_vs_ActionCable_copy.jpg" width="400" />
+- Ruby >= 2.5
+- Rails >= 5.2
+- Redis (see [other options](https://github.com/anycable/anycable/issues/2) for broadcasting)
 
 ## Usage
 
-
 Add `anycable-rails` gem to your Gemfile:
 
 ```ruby
@@ -40,14 +38,25 @@ gem "anycable-rails"
 gem "redis", ">= 4.0"
 ```
 
-(and don't forget to run `bundle install`).
+### Interactive set up
+
+After the gem was installed, you can run an interactive wizard to configure your Rails application for using with AnyCable by running a generator:
+
+```sh
+bundle exec rails g anycable:setup
+```
+
+### Manual set up
 
-Next, specify AnyCable subscription adapter for Action Cable:
+Specify AnyCable subscription adapter for Action Cable:
 
 ```yml
 # config/cable.yml
-production:
+development:
   adapter: any_cable # or anycable
+
+production:
+  adapter: any_cable
 ```
 
 and specify AnyCable WebSocket server URL:
@@ -66,7 +75,7 @@ config.action_cable.url = "wss://ws.example.com/cable"
 
 Then, run AnyCable RPC server:
 
-```ruby
+```sh
 $ bundle exec anycable
 
 # don't forget to provide Rails env
@@ -74,42 +83,30 @@ $ bundle exec anycable
 $ RAILS_ENV=production bundle exec anycable
 ```
 
-And, finally, run AnyCable WebSocket server, e.g. [anycable-go](https://docs.anycable.io/#/anycable-go/getting_started):
+And, finally, run AnyCable WebSocket server, e.g. [anycable-go](https://docs.anycable.io/v1/#/anycable-go/getting_started):
 
 ```sh
 anycable-go --host=localhost --port=3334
 ```
 
-See [documentation](https://docs.anycable.io/#/ruby/rails) for more information on AnyCable + Rails usage.
+See [documentation](https://docs.anycable.io/v1/#/ruby/rails) for more information on AnyCable + Rails usage.
 
 ## Action Cable Compatibility
 
-See [documentation](https://docs.anycable.io/#/ruby/compatibility).
-
-## Links
-
-- [AnyCable: Action Cable on steroids!](https://evilmartians.com/chronicles/anycable-actioncable-on-steroids)
-
-- [From Action to Any](https://medium.com/@leshchuk/from-action-to-any-1e8d863dd4cf) by [@alekseyl](https://github.com/alekseyl)
-
-## Talks
-
-- One cable to rule them all, RubyKaigi 2018, [slides](https://speakerdeck.com/palkan/rubykaigi-2018-anycable-one-cable-to-rule-them-all) and [video](https://www.youtube.com/watch?v=jXCPuNICT8s) (EN)
-
-- Wroc_Love.rb 2018 [slides](https://speakerdeck.com/palkan/wroc-love-dot-rb-2018-cables-cables-cables) and [video](https://www.youtube.com/watch?v=AUxFFOehiy0) (EN)
-
-## Compatible WebSocket servers
-
-- [AnyCable Go](https://github.com/anycable/anycable-go)
-- [ErlyCable](https://github.com/anycable/erlycable)
+See [documentation](https://docs.anycable.io/v1/#/ruby/compatibility).
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/anycable/anycable-rails.
+Bug reports and pull requests are welcome on GitHub at [https://github.com/anycable/anycable-rails](https://github.com/anycable/anycable-rails).
 
 ## Development
 
 If you are familiar with Docker, you can use [DIP](https://github.com/bibendi/dip) to start developing the gem quickly.
 
 ## License
+
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
+
+## Security Contact
+
+To report a security vulnerability, please contact us at `anycable@evilmartians.com`. We will coordinate the fix and disclosure.

data/lib/action_cable/subscription_adapter/any_cable.rb

@@ -7,7 +7,8 @@ module ActionCable
     # AnyCable subscription adapter delegates broadcasts
     # to AnyCable
     class AnyCable < Base
-      def initialize(*); end
+      def initialize(*)
+      end
 
       def broadcast(channel, payload)
         ::AnyCable.broadcast(channel, payload)

data/lib/anycable/rails.rb

@@ -3,6 +3,9 @@
 require "anycable"
 require "anycable/rails/version"
 require "anycable/rails/config"
+require "anycable/rails/rack"
+
+require "globalid"
 
 module AnyCable
   # Rails handler for AnyCable
@@ -11,8 +14,40 @@ module AnyCable
 
     ADAPTER_ALIASES = %w[any_cable anycable].freeze
 
-    def self.compatible_adapter?(adapter)
-      ADAPTER_ALIASES.include?(adapter)
+    class << self
+      def enabled?
+        adapter = ::ActionCable.server.config.cable&.fetch("adapter", nil)
+        compatible_adapter?(adapter)
+      end
+
+      def compatible_adapter?(adapter)
+        ADAPTER_ALIASES.include?(adapter)
+      end
+
+      # Serialize connection/channel state variable to string
+      # using GlobalID where possible or JSON (if json: true)
+      def serialize(obj, json: false)
+        obj.try(:to_gid_param) || (json ? obj.to_json : obj)
+      end
+
+      # Deserialize previously serialized value from string to
+      # Ruby object.
+      # If the resulting object is a Hash, make it indifferent
+      def deserialize(str, json: false)
+        str.yield_self do |val|
+          next val unless val.is_a?(String)
+
+          gval = GlobalID::Locator.locate(val)
+          return gval if gval
+
+          next val unless json
+
+          JSON.parse(val)
+        end.yield_self do |val|
+          next val.with_indifferent_access if val.is_a?(Hash)
+          val
+        end
+      end
     end
   end
 end

data/lib/anycable/rails/actioncable/channel.rb

@@ -28,6 +28,10 @@ module ActionCable
         connection.socket.subscribe identifier, broadcasting
       end
 
+      def stop_stream_from(broadcasting)
+        connection.socket.unsubscribe identifier, broadcasting
+      end
+
       def stop_all_streams
         connection.socket.unsubscribe_from_all identifier
       end

data/lib/anycable/rails/actioncable/connection.rb

@@ -1,43 +1,52 @@
 # frozen_string_literal: true
 
 require "action_cable/connection"
+require "anycable/rails/actioncable/connection/serializable_identification"
 require "anycable/rails/refinements/subscriptions"
 require "anycable/rails/actioncable/channel"
+require "anycable/rails/actioncable/remote_connections"
+require "anycable/rails/session_proxy"
 
 module ActionCable
   module Connection
     # rubocop: disable Metrics/ClassLength
     class Base # :nodoc:
-      # We store logger tags in identifiers to be able
+      # We store logger tags in the connection state to be able
       # to re-use them in the subsequent calls
       LOG_TAGS_IDENTIFIER = "__ltags__"
 
       using AnyCable::Refinements::Subscriptions
 
+      include SerializableIdentification
+
       attr_reader :socket
 
+      alias anycable_socket socket
+
+      delegate :env, :session, to: :request
+
       class << self
         def call(socket, **options)
-          new(socket, options)
+          new(socket, nil, options)
         end
+      end
 
-        def identified_by(*identifiers)
-          super
-          Array(identifiers).each do |identifier|
-            define_method(identifier) do
-              instance_variable_get(:"@#{identifier}") || fetch_identifier(identifier)
-            end
-          end
+      def initialize(socket, env, identifiers: "{}", subscriptions: [])
+        if env
+          # If env is set, then somehow we're in the context of Action Cable
+          # Return and print a warning in #process
+          @request = ActionDispatch::Request.new(env)
+          return
         end
-      end
 
-      def initialize(socket, identifiers: "{}", subscriptions: [])
         @ids = ActiveSupport::JSON.decode(identifiers)
 
-        @ltags = ids.delete(LOG_TAGS_IDENTIFIER)
+        @ltags = socket.cstate.read(LOG_TAGS_IDENTIFIER).yield_self do |raw_tags|
+          next unless raw_tags
+          ActiveSupport::JSON.decode(raw_tags)
+        end
 
         @cached_ids = {}
-        @env = socket.env
         @coder = ActiveSupport::JSON
         @socket = socket
         @subscriptions = ActionCable::Connection::Subscriptions.new(self)
@@ -46,15 +55,32 @@ module ActionCable
         subscriptions.each { |id| @subscriptions.fetch(id) }
       end
 
+      def process
+        # Use Rails logger here to print to stdout in development
+        logger.error invalid_request_message
+        logger.info finished_request_message
+        [404, {"Content-Type" => "text/plain"}, ["Page not found"]]
+      end
+
+      def invalid_request_message
+        "You're trying to connect to Action Cable server while using AnyCable. " \
+        "See https://docs.anycable.io/v1/#/troubleshooting?id=server-raises-an-argumenterror-exception-when-client-tries-to-connect"
+      end
+
       def handle_open
         logger.info started_request_message if access_logs?
 
-        verify_origin!
+        verify_origin! || return
 
         connect if respond_to?(:connect)
+
+        socket.cstate.write(LOG_TAGS_IDENTIFIER, fetch_ltags.to_json)
+
         send_welcome_message
       rescue ActionCable::Connection::Authorization::UnauthorizedError
-        reject_request
+        reject_request(
+          ActionCable::INTERNAL[:disconnect_reasons]&.[](:unauthorized) || "unauthorized"
+        )
       end
 
       def handle_close
@@ -84,7 +110,12 @@ module ActionCable
       end
       # rubocop:enable Metrics/MethodLength
 
-      def close
+      def close(reason: nil, reconnect: nil)
+        transmit(
+          type: ActionCable::INTERNAL[:message_types].fetch(:disconnect, "disconnect"),
+          reason: reason,
+          reconnect: reconnect
+        )
         socket.close
       end
 
@@ -92,37 +123,14 @@ module ActionCable
         socket.transmit encode(cable_message)
       end
 
-      # Generate identifiers info.
-      # Converts GlobalID compatible vars to corresponding global IDs params.
-      def identifiers_hash
-        obj = { LOG_TAGS_IDENTIFIER => fetch_ltags }
-
-        identifiers.each_with_object(obj) do |id, acc|
-          obj = instance_variable_get("@#{id}")
-          next unless obj
-
-          acc[id] = obj.try(:to_gid_param) || obj
-        end.compact
-      end
-
-      def identifiers_json
-        identifiers_hash.to_json
-      end
-
-      # Fetch identifier and deserialize if neccessary
-      def fetch_identifier(name)
-        @cached_ids[name] ||= @cached_ids.fetch(name) do
-          val = ids[name.to_s]
-          next val unless val.is_a?(String)
-
-          GlobalID::Locator.locate(val) || val
-        end
-      end
-
       def logger
         @logger ||= TaggedLoggerProxy.new(AnyCable.logger, tags: ltags || [])
       end
 
+      def request
+        @request ||= build_rack_request
+      end
+
       private
 
       attr_reader :ids, :ltags
@@ -158,19 +166,33 @@ module ActionCable
       end
 
       def verify_origin!
-        return unless socket.env.key?("HTTP_ORIGIN")
+        return true unless socket.env.key?("HTTP_ORIGIN")
 
-        return if allow_request_origin?
+        return true if allow_request_origin?
 
-        raise(
-          ActionCable::Connection::Authorization::UnauthorizedError,
-          "Origin is not allowed"
+        reject_request(
+          ActionCable::INTERNAL[:disconnect_reasons]&.[](:invalid_request) || "invalid_request"
         )
+        false
       end
 
-      def reject_request
+      def reject_request(reason, reconnect = false)
         logger.info finished_request_message("Rejected") if access_logs?
-        close
+        close(
+          reason: reason,
+          reconnect: reconnect
+        )
+      end
+
+      def build_rack_request
+        environment = Rails.application.env_config.merge(socket.env)
+        AnyCable::Rails::Rack.app.call(environment)
+
+        ActionDispatch::Request.new(environment)
+      end
+
+      def request_loaded?
+        instance_variable_defined?(:@request)
       end
     end
     # rubocop:enable Metrics/ClassLength