anycable-rails-core 1.4.2 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 713258efa713cd94cb2aa57891bf52f2483732f6e84b918a90d77924bc9d78e2
-  data.tar.gz: 45151b26a79c7ab05ba42629fcbb2c64a147142a39fe8d9eaff54dbce3b905c6
+  metadata.gz: 62bc4f7d0aef85236e0ff6a983e2a8c2db681397a70dacc91c85bbd4662377e8
+  data.tar.gz: 20cae16d638d1c47a96d5b235350c156d5e98f597858f72c9acab35aba3b0f0f
 SHA512:
-  metadata.gz: d98ee91a26f73b7e9ff7c60820211ddebf53566520903f6ca26be838f4c27fed6f0a2a36787fe3207b569f32881c83efd263517eaa71a5f74bdee00dd61c63ff
-  data.tar.gz: e0a86e5ccbef6d7735f71663a5a9511dc9dd3a7a7df8fa1ffd4e3cccbf653184c0048cbbd22007f21614f4d78f30ee5aa4bb55b275964f1b9b690e3927c27069
+  metadata.gz: bbb7e9670097c6ee0ce230f1a8226ffe0449c2cf4556b84bf465638fef385140c0aadbf2378477e37d09969617e74c66acda8c3c1f0075280abdc1a32792da58
+  data.tar.gz: 3a5498a417a077468f7adc6638c31f7d92a304f541475957bc74233e674c9cc6fc010ce432c9699b0eba2d308c8c1aacb4d85a21a7da7f48f8773162ece3c3fd

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## master
 
+## 1.4.4 (2024-03-08) 🌷
+
+- Minor fixes
+
+## 1.4.3 (2023-12-13)
+
+- Fix console logging in Rails 7.1 when the app's logger has no broadcast support. ([@palkan][])
+
 ## 1.4.2 (2023-10-15)
 
 - Print warning if the database pool size is less than RPC pool size. ([@palkan][])

data/lib/anycable/rails/action_cable_ext/remote_connections.rb

@@ -5,9 +5,18 @@ require "action_cable/remote_connections"
 ActionCable::RemoteConnections::RemoteConnection.include(AnyCable::Rails::Connections::SerializableIdentification)
 
 ActionCable::RemoteConnections::RemoteConnection.prepend(Module.new do
-  def disconnect(reconnect: true)
-    # Legacy Action Cable functionality if case we're not fully migrated yet
-    super() unless AnyCable::Rails.enabled?
-    ::AnyCable.broadcast_adapter.broadcast_command("disconnect", identifier: identifiers_json, reconnect: reconnect)
+  # Rails <7.1 has no `reconnect` argument
+  if ActionCable::RemoteConnections::RemoteConnection.instance_method(:disconnect).arity == 0
+    def disconnect(reconnect: true)
+      # Legacy Action Cable functionality if case we're not fully migrated yet
+      super() unless AnyCable::Rails.enabled?
+      ::AnyCable.broadcast_adapter.broadcast_command("disconnect", identifier: identifiers_json, reconnect: reconnect)
+    end
+  else
+    def disconnect(reconnect: true)
+      # Legacy Action Cable functionality if case we're not fully migrated yet
+      super unless AnyCable::Rails.enabled?
+      ::AnyCable.broadcast_adapter.broadcast_command("disconnect", identifier: identifiers_json, reconnect: reconnect)
+    end
   end
 end)

data/lib/anycable/rails/railtie.rb

@@ -33,8 +33,10 @@ module AnyCable
             # Rails 7.1+
             if AnyCable.logger.respond_to?(:broadcast_to)
               AnyCable.logger.broadcast_to(console)
-            else
+            elsif ActiveSupport::Logger.respond_to?(:broadcast)
               AnyCable.logger.extend(ActiveSupport::Logger.broadcast(console))
+            elsif defined?(ActiveSupport::BroadcastLogger)
+              AnyCable.logger = ActiveSupport::BroadcastLogger.new(AnyCable.logger, console)
             end
           end
 

data/lib/anycable/rails/version.rb

@@ -2,6 +2,6 @@
 
 module AnyCable
   module Rails
-    VERSION = "1.4.2"
+    VERSION = "1.4.4"
   end
 end

data/lib/generators/anycable/setup/setup_generator.rb

@@ -74,7 +74,7 @@ module AnyCableRailsGenerators
       answer = DEVELOPMENT_METHODS.index(options[:devenv]) || 99
 
       until DEVELOPMENT_METHODS[answer.to_i]
-        answer = ask "Which environment do you use for development? (1) Local, (2) Docker, (0) Skip"
+        answer = ask "Do you want to run anycable-go locally or as a Docker container? (1) Local, (2) Docker, (0) Skip"
       end
 
       case env = DEVELOPMENT_METHODS[answer.to_i]
@@ -224,7 +224,8 @@ module AnyCableRailsGenerators
 
     def install_for_local
       inside("bin") do
-        template "anycable-go", chmod: 0o755
+        template "anycable-go"
+        chmod "anycable-go", 0755, verbose: false # rubocop:disable Style/NumericLiteralPrefix
       end
 
       if file_exists?(".gitignore")
@@ -269,7 +270,7 @@ module AnyCableRailsGenerators
     end
 
     def anycable_go_version
-      @anycable_go_version ||= (normalize_version(options[:version]) || "latest")
+      @anycable_go_version ||= normalize_version(options[:version]) || "latest"
     end
 
     def normalize_version(version)

data/lib/generators/anycable/setup/templates/config/initializers/anycable.rb.tt

@@ -4,6 +4,10 @@
 # Devise current user via `env["warden"].user`.
 #
 # See <%= DOCS_ROOT %>/ruby/authentication
-AnyCable::Rails::Rack.middleware.use Warden::Manager do |config|
-  Devise.warden_config = config
+#
+# NOTE: This is only needed in environments where you use AnyCable.
+if defined?(AnyCable::Rails)
+  AnyCable::Rails::Rack.middleware.use Warden::Manager do |config|
+    Devise.warden_config = config
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anycable-rails-core
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.4
 platform: ruby
 authors:
 - palkan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-16 00:00:00.000000000 Z
+date: 2024-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: anycable-core
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.8
+rubygems_version: 3.4.20
 signing_key:
 specification_version: 4
 summary: AnyCable integration for Rails (w/o RPC dependencies)