anycable-core 1.5.0.rc.1 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3469966952c29b422b3177acbb3402fc9bf500786d55774f9b3311b904548bb
-  data.tar.gz: 7e5a7302b61c07af90f61b11878212a464ba1eac0f7d6b664f91b8dcbd3fe9e6
+  metadata.gz: e580fb7244e7eb0d8ad4d749ec3eaec19e5490152c39c1f30f42b53249185536
+  data.tar.gz: 7da10692cea6e5d1d9ced38075c649077eed8ed5a5c49cdaac446cb7dbe686ff
 SHA512:
-  metadata.gz: 57e7aafe42eeddf359db963a688cf89acf9b109935f4561ba2eb4cb9c994e3a47d44b721b24f717be41630d4b8234d5f77a12d91246b0033e2385772287c43af
-  data.tar.gz: 53785ae7eaf8c86d1f164a89dbfeaee2063be1c4180f2a263cb2f47ca3ca41bc528f545ba65c1232c691fa6515bd4be39e9f6200b903b9b2bb8af02f09f37ccc
+  metadata.gz: 196239a321ae0f634b2cbe61b81d83e454b3be116b0748ca80b07405ecc1e333258735b9195f7e6b927c30dc0677101805f0dbad267b15beb96b17ca20823b7a
+  data.tar.gz: 6430837a566150c68611488d82ccf1e0955953f1ef4ecf32df3b00ace5c255dc5755f051e4ee3fb3ab18d0c286e1e214ec759b6fc4fea6a698e34a51e80ad03c

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## master
 
+## 1.5.1 (2024-06-14) 🇪🇺 ⚽️
+
+- Fixed compatibility with Rack 3.1 ([@earlopain][])
+
+## 1.5.0 (2024-04-01)
+
+- Fixed gRPC keepalive settings to align with the Go server client. ([@palkan][])
+
 - Added JWT utils. ([@palkan][])
 
 You can now generate and verify AnyCable JWT tokens without using additional dependencies:
@@ -207,3 +215,4 @@ See [Changelog](https://github.com/anycable/anycable/blob/0-6-stable/CHANGELOG.m
 [@smasry]: https://github.com/smasry
 [@Envek]: https://github.com/Envek
 [@cylon-v]: https://github.com/cylon-v
+[@earlopain]: https://github.com/earlopain

data/lib/anycable/grpc/config.rb

@@ -35,7 +35,15 @@ module AnyCable
           poll_period: rpc_poll_period,
           pool_keep_alive: rpc_pool_keep_alive,
           tls_credentials: tls_credentials,
-          server_args: enhance_grpc_server_args(normalized_grpc_server_args)
+          server_args: enhance_grpc_server_args(normalized_grpc_server_args).tap do |sargs|
+            # Provide keepalive defaults unless explicitly set.
+            # They must MATCH the corresponding Go client defaults:
+            # https://github.com/anycable/anycable-go/blob/62e77e7f759aa9253c2bd23812dd59ec8471db86/rpc/rpc.go#L512-L515
+            #
+            # See also https://github.com/grpc/grpc/blob/master/doc/keepalive.md and https://grpc.github.io/grpc/core/group__grpc__arg__keys.html
+            sargs["grpc.keepalive_permit_without_calls"] ||= 1
+            sargs["grpc.http2.min_recv_ping_interval_without_data_ms"] ||= 10_000
+          end
         }
       end
 

data/lib/anycable/httrpc/server.rb

@@ -27,8 +27,9 @@ module AnyCable
         return [404, {}, ["Not found"]] unless AnyCable.rpc_handler.supported?(rpc_command)
 
         # read request body and it's empty, return 422
-        request_body = env["rack.input"].read
-        return [422, {}, ["Empty request body"]] if request_body.empty?
+        # rack.input is optional starting in Rack 3.1
+        request_body = env["rack.input"]&.read
+        return [422, {}, ["Empty request body"]] if request_body.nil? || request_body.empty?
 
         payload =
           case rpc_command

data/lib/anycable/socket.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 module AnyCable
+  WHISPER_KEY = "$w"
+
   # Socket mock to be used with application connection
   class Socket
     # Represents the per-connection store
@@ -59,10 +61,21 @@ module AnyCable
 
     def unsubscribe(_channel, broadcasting)
       streams[:stop] << broadcasting
+
+      if istate.read(WHISPER_KEY) == broadcasting
+        istate.write(WHISPER_KEY, "")
+      end
+    end
+
+    def whisper(_channel, broadcasting)
+      istate.write(WHISPER_KEY, broadcasting)
     end
 
     def unsubscribe_from_all(_channel)
       @stop_all_streams = true
+      if istate.read(WHISPER_KEY)
+        istate.write(WHISPER_KEY, "")
+      end
     end
 
     def streams
@@ -141,22 +154,30 @@ module AnyCable
       # (not all of them though, just those enough for Action Cable to work)
       # See https://rubydoc.info/github/rack/rack/master/file/SPEC
       # and https://github.com/rack/rack/blob/master/lib/rack/lint.rb
-      {
+      env = {
         "REQUEST_METHOD" => "GET",
         "SCRIPT_NAME" => "",
         "PATH_INFO" => "/",
         "QUERY_STRING" => "",
         "SERVER_NAME" => "",
         "SERVER_PORT" => "80",
+        "SERVER_PROTOCOL" => "HTTP/1.1",
         "rack.url_scheme" => "http",
         "rack.input" => StringIO.new("", "r").tap { |io| io.set_encoding(Encoding::ASCII_8BIT) },
-        "rack.version" => ::Rack::VERSION,
         "rack.errors" => StringIO.new("").tap { |io| io.set_encoding(Encoding::ASCII_8BIT) },
         "rack.multithread" => true,
         "rack.multiprocess" => false,
         "rack.run_once" => false,
         "rack.hijack?" => false
       }
+
+      # Rack 3.1 removes `Rack::VERSION`. rack.version is optional (deprecated) since Rack 3.0
+      if ::Rack::RELEASE < "3.0"
+        rversion = ::Rack::VERSION
+        # @type var rversion : String
+        env["rack.version"] = rversion
+      end
+      env
     end
 
     def build_headers(headers)

data/lib/anycable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AnyCable
-  VERSION = "1.5.0.rc.1"
+  VERSION = "1.5.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anycable-core
 version: !ruby/object:Gem::Version
-  version: 1.5.0.rc.1
+  version: 1.5.1
 platform: ruby
 authors:
 - palkan
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-13 00:00:00.000000000 Z
+date: 2024-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: anyway_config
@@ -28,16 +28,16 @@ dependencies:
   name: google-protobuf
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.25'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.25'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -277,7 +277,7 @@ metadata:
   homepage_uri: https://anycable.io/
   source_code_uri: http://github.com/anycable/anycable
   funding_uri: https://github.com/sponsors/anycable
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -288,12 +288,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.4.20
-signing_key:
+rubygems_version: 3.4.19
+signing_key: 
 specification_version: 4
 summary: AnyCable core RPC implementation
 test_files: []