any_sms 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4ea6a7e81eb0c54c44900ee3389fc9db1e150b54
-  data.tar.gz: 250a5d9943723104eb332ec503fb5a38a313a623
+  metadata.gz: dd201b20e9e6f5f8c4cbd818a78cf76cb2e375d7
+  data.tar.gz: e3cb1236b0ef59051cd464795ff8686c68a41cd0
 SHA512:
-  metadata.gz: 3ff7f28fb99ff628fe20bcfe44c59d6fe0e2cda9ec6c876af2d23d84694febc9a9b58e388404c5612a955758a31011637e78e58331bfe437361a4b3cf84bb92f
-  data.tar.gz: b51a1f1302d4eaf978fe5485924b145665ec9fb1597693098f35aaf25252107f504bd15efe630d5bbbeb64d27c396074fcfac80b28b80b887e3d977cf7a8a9fe
+  metadata.gz: 6218c8ad05efaccbe8243a4892e03e696ca4aa0bb239a3415f6c1997fcd306a30c02980a2f1641cb5e9cfccbce4e481ca9e554b1faec75debe1d2a7a26a91c66
+  data.tar.gz: bcc041dc093a9a18983c6314f92e1a756f5d2897c72884b8351e5b6f2cbb6bac633f6463a9ef394b3b598fdd2920d328345421721eb31ec9cda6e0e3dea6c1c3

data/.rubocop.yml

@@ -8,6 +8,10 @@ Style/StringLiterals:
 Metrics/LineLength:
   Max: 90
 
+Metrics/BlockLength:
+  Exclude:
+    - "**/*_spec.rb"
+
 Style/ClassAndModuleChildren:
   Enabled: false
 

data/.travis.yml

@@ -6,4 +6,5 @@ install:
   - bundle install --retry=3
 script:
   - bundle exec rake
+  - bundle exec rubocop --version
   - bundle exec rubocop

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2016 Fedcomp
+Copyright (c) 2016-2017 Fedcomp
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -3,18 +3,15 @@
 [![Build Status](https://travis-ci.org/Fedcomp/any_sms.svg?branch=master)](https://travis-ci.org/Fedcomp/any_sms)
 [![Gem Version](https://badge.fury.io/rb/any_sms.svg)](https://badge.fury.io/rb/any_sms)
 
-Unified way to send SMS in ruby!
-Allows you to switch SMS services
-without having to rewrite any code that actually sends SMS.
-Supports multiple backends.
-Sending SMS is not pain anymore!
+Simple and flexible solution to send sms in ruby,
+supporting variety of sms services.
 
 ## Installation and usage
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem "any_sms"
+gem "any_sms", "~> 0.4.0"
 ```
 
 Then somewhere in your initialization code:
@@ -258,8 +255,8 @@ For now you may just mock `AnySMS.send_sms` and check it was executed.
 Bug reports and pull requests are welcome on GitHub at https://github.com/Fedcomp/any_sms
 
 ## Submitting a Pull Request
-1. Fork the [official repository](https://github.com/Fedcomp/any_sms).
-2. Create a topic branch.
+1. Fork the [official repository](https://github.com/Fedcomp/any_sms/fork).
+2. Create a feature/bugfix branch.
 3. Implement your feature or bug fix.
 4. Add, commit, and push your changes.
 5. Submit a pull request.

data/any_sms.gemspec

@@ -8,7 +8,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Fedcomp"]
   spec.email         = ["aglergen@gmail.com"]
 
-  spec.summary       = "Easily send sms using various sms backends!"
+  spec.summary       = "Simple and flexible solution to send sms in ruby, " \
+                       "supporting variety of sms services."
 
   spec.homepage      = "https://github.com/Fedcomp/any_sms"
   spec.license       = "MIT"
@@ -26,13 +27,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.12"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
 
   spec.add_development_dependency "guard", "~> 2.14"
   spec.add_development_dependency "guard-rspec", "~> 4.7"
+  spec.add_development_dependency "guard-yard"
   spec.add_development_dependency "pry-byebug", "~> 3.4"
   spec.add_development_dependency "rubocop"
-  spec.add_development_dependency "guard-yard"
 end

data/lib/any_sms/backend/base.rb

@@ -16,7 +16,7 @@ module AnySMS::Backend
     #
     # @param _phone [String] Phone number to send sms (not used in this implementation)
     # @param _text  [String] Sms text (not used in this implementation)
-    def send_sms(_phone, _text)
+    def send_sms(_phone, _text, _args = {})
       raise NotImplementedError,
             "You should create your own class for every sms service you use"
     end

data/lib/any_sms/backend/logger.rb

@@ -2,7 +2,7 @@
 class AnySMS::Backend::Logger < AnySMS::Backend::Base
   # Log level validation, all invalid values lead to ArgumentError.
   # Has anyone heard how to receive log levels from ruby logger itself?
-  LOG_SEVERITY = [:debug, :info, :warn, :error, :fatal, :unknown].freeze
+  LOG_SEVERITY = %i[debug info warn error fatal unknown].freeze
 
   # @param logger [::Logger] Class implementing logger interface
   # @param severity [Symbol] Severity to log with
@@ -20,7 +20,7 @@ class AnySMS::Backend::Logger < AnySMS::Backend::Base
   #
   # @param phone [String] Phone number to send sms
   # @param text  [String] Sms text
-  def send_sms(phone, text)
+  def send_sms(phone, text, _args = {})
     @logger.send(@severity, "[SMS] #{phone}: #{text}")
     respond_with_status :success
   end

data/lib/any_sms/backend/null_sender.rb

@@ -5,7 +5,7 @@ class AnySMS::Backend::NullSender < AnySMS::Backend::Base
   #
   # @param _phone [String] Phone number to send sms (not used in this implementation)
   # @param _text  [String] Sms text (not used in this implementation)
-  def send_sms(_phone, _text)
+  def send_sms(_phone, _text, _args = {})
     respond_with_status :success
   end
 end

data/lib/any_sms/matchers/send_sms.rb

@@ -38,13 +38,13 @@ RSpec::Matchers.define :send_sms do |options|
   failure_message do
     message = "expected block to send "
 
-    if @phone && @text
-      message += "sms message" \
-                 " to phone number \"#{@phone}\"" \
-                 " with text \"#{@text}\""
-    else
-      message += "any sms message"
-    end
+    message += if @phone && @text
+                 "sms message" \
+                            " to phone number \"#{@phone}\"" \
+                            " with text \"#{@text}\""
+               else
+                 "any sms message"
+               end
 
     "#{message}, nothing was sent"
   end
@@ -66,3 +66,4 @@ RSpec::Matchers.define :send_sms do |options|
     @result ||= AnySMS::Response.new(status: :success)
   end
 end
+# rubocop:enable Metrics/BlockLength

data/lib/any_sms/sending.rb

@@ -5,11 +5,12 @@ module AnySMS
     #
     # @param phone [String] Phone number for sms
     # @param text  [String] Text for sms
-    # @param args  [Hash] Additional options for delivery. Currently only :backend
+    # @param backend  [Symbol] Keyword argument to specify non-default backend
+    # @param args  [Hash] Additional options for delivery bypassed to final backend
     def send_sms(phone, text, args = {})
       backend_name = args.delete(:backend)
       backend_class(backend_name).new(backend_params(backend_name))
-                                 .send_sms(phone, text)
+                                 .send_sms(phone, text, args)
     end
 
     private

data/lib/any_sms/version.rb

@@ -1,3 +1,3 @@
 module AnySMS
-  VERSION = "0.3.0".freeze
+  VERSION = "0.4.0".freeze
 end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: any_sms
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Fedcomp
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-24 00:00:00.000000000 Z
+date: 2018-01-19 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.12'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -81,35 +67,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4.7'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: guard-yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.4'
 - !ruby/object:Gem::Dependency
-  name: guard-yard
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -169,8 +155,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
-summary: Easily send sms using various sms backends!
+summary: Simple and flexible solution to send sms in ruby, supporting variety of sms
+  services.
 test_files: []