another_toy_robot 0.1.11 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9c89aa2204dd819da5f7da04a0d2340aa949a06c
-  data.tar.gz: 8968eb0fb994e02235392bf16902a0251fae5f9b
+  metadata.gz: 55f824721df20bab7fca05a862acfba15aa0be7b
+  data.tar.gz: 97ee1296da13b1b7d3464c9ee3cb5c6c8d084dfb
 SHA512:
-  metadata.gz: ced10d993eefbb960628dcea6f1ee01c282ff24500dee200ea2e8a73594b259a7283af1ffd9cc0562d84b959c3b838300a73e79775f329a470f7710ea00fbeee
-  data.tar.gz: c6a24154fc734f686603e37c12d95a3283fb7b91a54999f454f83a4438de07a9c46e3eb42f155bcad88755e2888077204b2c944b933fc5f557ab110c47b84247
+  metadata.gz: d02212f8b657911404346f3ba7cb10cc129dd2a5877a6b39339926f974b92dfea79f0ad06e566f562d539d6214e81e7db91627e20f365ea0e18926b5b08f7261
+  data.tar.gz: a387500683a0e490d23c5bdaef8ad847388a6d0c723564f1842b0af8dbe8ee326090a0b35e18bb1eb9db2faff201022f756fb8ce004ac27ee1fafc8562f4f367

data/README.md

@@ -74,7 +74,7 @@ require "another_toy_robot"
 AnotherToyRobot.main
 ```
 
-`AnotherToyRobot#main` instantiates a new `Client`. The `Client` instantiates an `Arena` and `Robot` objects. The new `Robot` is initialised with `NullPosition` in the `Arena`.
+`AnotherToyRobot#main` instantiates a new `Client`. The `Client` instantiates a new `Robot` and `Arena`. The new `Robot` is initialised with `NullPosition`, and assigned the new arena.
 
 The main loop does the following:
 
@@ -99,14 +99,10 @@ This process continues until an `"exit"` command is received, breaking the loop.
 ### Considerations
 Given the requirement for a command line interface to interact with the robot, I settled on the well established and widely used command pattern.
 
-The `Input` wrapper allows new commands to be easily added. E.g. Creating a new file `lib/another_toy_robot/random_command.rb` and requiring it, would be all that is required for the application to accept the `"random"` command, and it would have access to an array of parameters. Validations can also be added by defining a `valid?` method on the command object. See the `lib/another_toy_robot/place_command.rb` for an example.
+The `Input` wrapper allows new commands to be easily added. E.g. Creating a new file `lib/another_toy_robot/random_command.rb` and requiring it, is all that is required for the application to accept the `"random"` command, and it would have access to an array of parameters. Validations can also be added by defining a `valid?` method on the command object. See the `lib/another_toy_robot/place_command.rb` for an example.
 
 I'm particularly happy with the `Position` class and the `Direction` modules. Together as a unit they have absolutely no dependencies and could be easily reused with new features, new objects, or with changing specifications. It would be reasonably straight forward to add a second robot, or a third dimension.
 
-Currently the `Robot` must be instantiated with an `Arena`. Originally, I had also employed the null object pattern for the `Arena` as well as the position, but as it turned out, with the current specification, there is no situation where a robot is not in an arena, so it was unneeded and removed, reducing overall complexity of the application.
-
-As GINnFIN helpfully pointed out in the [Reddit discussion](https://www.reddit.com/r/ruby/comments/5fptz9/i_did_the_toy_robot_challenge_ive_tried_to_be/), the `Position` `#left` and `#right` methods do necessarily need to return a new instance of `Position`, and could instead mutate the current position in place. While this is true, there is a pleasing symmetry in each of the current `Position` methods returning a new instance of position that would would be lost if these were to be changed. I'm not entirely sure which is better, but have decided to keep the current implementation, as different behaviour for the `place` and `move` methods to the `left` and `right` methods may be unnecessarily increasing the conceptual complexity of the app.
-
 ### Licence
 [MIT](https://tldrlegal.com/license/mit-license)
 

data/another_toy_robot.gemspec

@@ -6,7 +6,7 @@ require "another_toy_robot/version"
 Gem::Specification.new do |spec|
   spec.name                  = "another_toy_robot"
   spec.version               = AnotherToyRobot::VERSION
-  spec.date                  = "2016-12-05"
+  spec.date                  = "2016-12-07"
   spec.authors               = "Sheldon J. Johnson"
   spec.email                 = "sheldon.j.johnson@outlook.com"
   spec.homepage              = "https://github.com/drzel/another_toy_robot"

data/lib/another_toy_robot/arena.rb

@@ -4,7 +4,7 @@ class Arena
     @rows    = 0...height
   end
 
-  def inbounds?(x_coord, y_coord)
-    @columns.cover?(x_coord) && @rows.cover?(y_coord)
+  def inbounds?(position)
+    @columns.cover?(position.x_coord) && @rows.cover?(position.y_coord)
   end
 end

data/lib/another_toy_robot/client.rb

@@ -3,8 +3,10 @@ require "another_toy_robot/robot"
 
 class Client
   def initialize
+    @robot = Robot.new
     @table = Arena.new width: 5, height: 5
-    @robot = Robot.new arena: @table
+
+    @robot.arena = @table
   end
 
   def command_for(input)

data/lib/another_toy_robot/input.rb

@@ -11,28 +11,22 @@ class Input
   end
 
   def new_command(target)
-    to_class.new target: target, params: params
+    command_class.new target: target, params: params
   end
 
   private
 
-  def basename
-    @basename ||= @input.split(" ").first
-  end
-
   def params
     @params ||= @input.split(" ").drop 1
   end
 
-  def classname
-    @classname ||= "#{basename.capitalize}Command"
+  def basename
+    @basename ||= @input.split(" ").first
   end
 
-  def to_class
-    if Object.const_defined? classname
-      Object.const_get classname
-    else
-      InvalidCommand
-    end
+  def command_class
+    klass = "#{basename.capitalize}Command"
+    return InvalidCommand unless Object.const_defined? klass
+    Object.const_get klass
   end
 end

data/lib/another_toy_robot/null_arena.rb

@@ -0,0 +1,5 @@
+class NullArena
+  def inbounds?(*)
+    true
+  end
+end

data/lib/another_toy_robot/robot.rb

@@ -1,11 +1,13 @@
 require "another_toy_robot/position"
 require "another_toy_robot/null_position"
 require "another_toy_robot/arena"
+require "another_toy_robot/null_arena"
 
 class Robot
-  attr_reader :position, :arena
+  attr_accessor :arena
+  attr_reader :position
 
-  def initialize(position: NullPosition.new, arena: Arena.new)
+  def initialize(position: NullPosition.new, arena: NullArena.new)
     @position = position
     @arena    = arena
   end
@@ -33,8 +35,7 @@ class Robot
   private
 
   def safely_go_to(position)
-    return unless position.x_coord && position.y_coord
-    return unless @arena.inbounds? position.x_coord, position.y_coord
+    return unless @arena.inbounds? position
     @position = position
   end
 end

data/lib/another_toy_robot/version.rb

@@ -1,3 +1,3 @@
 module AnotherToyRobot
-  VERSION = "0.1.11".freeze
+  VERSION = "0.1.12".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: another_toy_robot
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - Sheldon J. Johnson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-05 00:00:00.000000000 Z
+date: 2016-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -110,6 +110,7 @@ files:
 - lib/another_toy_robot/invalid_command.rb
 - lib/another_toy_robot/left_command.rb
 - lib/another_toy_robot/move_command.rb
+- lib/another_toy_robot/null_arena.rb
 - lib/another_toy_robot/null_position.rb
 - lib/another_toy_robot/place_command.rb
 - lib/another_toy_robot/position.rb