annotate 2.6.1 → 2.6.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZWI2ZDRiZDhkOTkwNDNmMDMxYWU2ZTY3NWEyYzMyMzVlYTc2OTFmMA==
+    OTk0YjllMjkxZmIzMDQwNDA3ZTNjZGYyOTFjM2E4NDNhYzgyN2RiNQ==
   data.tar.gz: !binary |-
-    OWQ0MTY4ZjZmZWFmNDU0Yzc4NDgzNmNkNjM5MmNlN2U3NjQzZWM4OQ==
+    NGE3NjA2ODE2ZGExNDZiNGMzOWRiM2I4MDFiZDg2NGFmNmM3NjdhOA==
 SHA512:
   metadata.gz: !binary |-
-    MDdkYmQ1ZjE0ZTQ4ZWYyNzYxMGQ3YTNlZDMxZDRmZGJiNzlkZTc0ZjgxNGFk
-    NDAwZjVmOGNmM2Y3OTRiNWE4ZjYwOWU4NGIwNWE4ZmI3MzI2YjZiOWJlZWQz
-    YTlkZWQ5NjUxOGVjM2VjMmFlMTJlZDVkZGZlMTA1Yzk0NGYwNDA=
+    ZDIwZTMxMDBhOTg2MzEzZmY2N2M4ZTY1MTdjMjQ5ZjE2YTYyNjNmNGQ3N2Vi
+    NWUxNzM1YzdmZDc4NjRlYTQyYjk0ZmZhMmRlYWUzN2E0NmY5NjhmM2QyOGU5
+    NWZhODZkMGJiMjdmMzNjODkwOWIyM2JkMGYwNDQwZDZjNzM1YmU=
   data.tar.gz: !binary |-
-    ZTZkMDkzODI2MTQ1MjY3ZjgzNjFjMjUxNTcwMzVjM2JhYmQzYzJmZGFiYjE4
-    NjcwNDg1MDk5ZTMwMmI5YzJmNjk0ZThmYzM1ZWEyNjQ4NzdlMDM1MTJiMDRm
-    MjQ2ZDY0NjJkMzUxNWZkNGQ0M2FmMjY1MjM5N2EyOTc1ZmY1OGE=
+    ZDZjM2M2YjczZmEzMDM1NDVjNWIyMmJhM2UzOTZiZTlkM2I0OGVmZmRmNWQ3
+    ZGNjNzdkYWJmZWFhNzMzMWU2MDZhNGZmM2RiZjJkN2YyMzUwNmI5ZDU0ODhj
+    ZjVkNzhmZTJhYjk1MTRjYjg4N2JmODIyMTc0MzA2NDBmZGI1ZjI=

data/CHANGELOG.rdoc

@@ -1,3 +1,8 @@
+== 2.6.2
+* Retain the current annotate block unless --force is specified
+* Always load models, since they may not be autoloaded by Rails
+* The pg array type is now detected (see #158)
+
 == 2.6.0.beta2
 
 * support for composite_primary_keys (garysweaver)

data/annotate.gemspec

@@ -1,20 +1,18 @@
-# This file is auto-generated!
-# DO NOT EDIT THIS FILE DIRECTLY!
-# Instead, edit the Rakefile and run 'rake gems:gemspec'.# -*- encoding: utf-8 -*-
+# -*- encoding: utf-8 -*-
 # stub: annotate 2.6.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "annotate"
-  s.version = "2.6.1"
+  s.version = "2.6.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Cuong Tran", "Alex Chaffee", "Marcos Piccinini", "Turadg Aleahmad", "Jon Frisby"]
-  s.date = "2013-12-21"
+  s.date = "2014-02-26"
   s.description = "Annotates Rails/ActiveRecord Models, routes, fixtures, and others based on the database schema."
-  s.email = ["alex@stinky.com", "ctran@pragmaquest.com", "x@nofxx.com", "turadg@aleahmad.net", "jon@cloudability.com"]
+  s.email = ["alex@stinky.com", "cuong.tran@gmail.com", "x@nofxx.com", "turadg@aleahmad.net", "jon@cloudability.com"]
   s.executables = ["annotate"]
   s.extra_rdoc_files = ["README.rdoc", "CHANGELOG.rdoc", "TODO.rdoc"]
-  s.files = ["AUTHORS.rdoc", "CHANGELOG.rdoc", "LICENSE.txt", "README.rdoc", "TODO.rdoc", "annotate.gemspec", "bin/annotate", "lib/annotate.rb", "lib/annotate/active_record_patch.rb", "lib/annotate/annotate_models.rb", "lib/annotate/annotate_routes.rb", "lib/annotate/tasks.rb", "lib/annotate/version.rb", "lib/generators/annotate/USAGE", "lib/generators/annotate/install_generator.rb", "lib/generators/annotate/templates/auto_annotate_models.rake", "lib/tasks/annotate_models.rake", "lib/tasks/annotate_routes.rake", "tasks/migrate.rake"]
+  s.files = ["AUTHORS.rdoc", "CHANGELOG.rdoc", "LICENSE.txt", "README.rdoc", "TODO.rdoc", "annotate.gemspec", "bin/annotate", "lib/annotate.rb", "lib/annotate/active_record_patch.rb", "lib/annotate/annotate_models.rb", "lib/annotate/annotate_routes.rb", "lib/annotate/tasks.rb", "lib/annotate/version.rb", "lib/generators/annotate/USAGE", "lib/generators/annotate/install_generator.rb", "lib/generators/annotate/templates/auto_annotate_models.rake", "lib/tasks/annotate_models.rake", "lib/tasks/annotate_routes.rake", "lib/tasks/migrate.rake"]
   s.homepage = "http://github.com/ctran/annotate_models"
   s.licenses = ["Ruby"]
   s.require_paths = ["lib"]

data/bin/annotate

@@ -119,8 +119,8 @@ OptionParser.new do |opts|
     end
   end
 
-  opts.on('-e', '--exclude [DIRS]', ['tests','fixtures','factories'], "Do not annotate fixtures, test files, and/or factories") do |exclusions|
-    exclusions ||= %w(tests fixtures factories)  
+  opts.on('-e', '--exclude [tests,fixtures,factories]', Array, "Do not annotate fixtures, test files, and/or factories") do |exclusions|
+    exclusions ||= %w(tests fixtures factories)
     exclusions.each { |exclusion| ENV["exclude_#{exclusion}"] = "yes" }
   end
 

data/lib/annotate/annotate_models.rb

@@ -31,8 +31,8 @@ module AnnotateModels
   FABRICATORS_SPEC_DIR  = File.join("spec", "fabricators")
 
   TEST_PATTERNS = [
-    [UNIT_TEST_DIR,  "%MODEL_NAME%_test.rb"],
-    [SPEC_MODEL_DIR, "%MODEL_NAME%_spec.rb"],
+    File.join(UNIT_TEST_DIR,  "%MODEL_NAME%_test.rb"),
+    File.join(SPEC_MODEL_DIR, "%MODEL_NAME%_spec.rb"),
   ]
 
   FIXTURE_PATTERNS = [
@@ -131,6 +131,11 @@ module AnnotateModels
           end
         end
 
+        # Check out if we got an array column
+        if col.respond_to?(:array) && col.array
+          attrs << "is an Array"
+        end
+
         # Check out if we got a geometric column
         # and print the type and SRID
         if col.respond_to?(:geometry_type)
@@ -227,27 +232,23 @@ module AnnotateModels
         if old_columns == new_columns && !options[:force]
           return false
         else
+          # Replace inline the old schema info with the new schema info
+          new_content = old_content.sub(PATTERN, info_block + "\n")
 
-# todo: figure out if we need to extract any logic from this merge chunk
-# <<<<<<< HEAD
-#           # Replace the old schema info with the new schema info
-#           new_content = old_content.sub(/^# #{COMPAT_PREFIX}.*?\n(#.*\n)*\n*/, info_block)
-#           # But, if there *was* no old schema info, we simply need to insert it
-#           if new_content == old_content
-#             old_content.sub!(encoding, '')
-#             new_content = options[:position] == 'after' ?
-#               (encoding_header + (old_content =~ /\n$/ ? old_content : old_content + "\n") + info_block) :
-#               (encoding_header + info_block + old_content)
-#           end
-# =======
-
-          # Strip the old schema info, and insert new schema info.
-          old_content.sub!(encoding, '')
-          old_content.sub!(PATTERN, '')
-
-          new_content = options[position].to_s == 'after' ?
-            (encoding_header + (old_content.rstrip + "\n\n" + info_block)) :
-            (encoding_header + info_block + "\n" + old_content)
+          if new_content.end_with? (info_block + "\n")
+            new_content = old_content.sub(PATTERN, "\n" + info_block)
+          end
+           
+          # if there *was* no old schema info (no substitution happened) or :force was passed,
+          # we simply need to insert it in correct position
+          if new_content == old_content || options[:force]
+            old_content.sub!(encoding, '')
+            old_content.sub!(PATTERN, '')
+
+            new_content = options[position].to_s == 'after' ?
+              (encoding_header + (old_content.rstrip + "\n\n" + info_block)) :
+              (encoding_header + info_block + "\n" + old_content)
+          end
 
           File.open(file_name, "wb") { |f| f.puts new_content }
           return true
@@ -301,8 +302,7 @@ module AnnotateModels
 
         unless options[:exclude_tests]
           did_annotate = TEST_PATTERNS.
-            map { |pat| [pat[0], resolve_filename(pat[1], model_name, table_name)] }.
-            map { |pat| find_test_file(*pat) }.
+            map { |file| resolve_filename(file, model_name, table_name) }.
             map { |file| annotate_one_file(file, info, :position_in_test, options_with_position(options, :position_in_test)) }.
             detect { |result| result } || did_annotate
         end
@@ -370,7 +370,7 @@ module AnnotateModels
     # in subdirectories without namespacing.
     def get_model_class(file)
       # this is for non-rails projects, which don't get Rails auto-require magic
-      require File.expand_path("#{model_dir}/#{file}") unless Module.const_defined?(:Rails)
+      require File.expand_path("#{model_dir}/#{file}")
       model_path = file.gsub(/\.rb$/, '')
       get_loaded_model(model_path) || get_loaded_model(model_path.split('/').last)
     end
@@ -441,16 +441,7 @@ module AnnotateModels
             model_file_name = File.join(model_dir, file)
             deannotated_klass = true if(remove_annotation_of_file(model_file_name))
 
-            TEST_PATTERNS.
-              map { |pat| [pat[0], resolve_filename(pat[1], model_name, table_name)]}.
-              map { |pat| find_test_file(*pat) }.each do |file|
-                if(File.exist?(file))
-                  remove_annotation_of_file(file)
-                  deannotated_klass = true
-                end
-              end
-
-            (FIXTURE_PATTERNS + FACTORY_PATTERNS).
+            (TEST_PATTERNS + FIXTURE_PATTERNS + FACTORY_PATTERNS).
               map { |file| resolve_filename(file, model_name, table_name) }.
               each do |file|
                 if File.exist?(file)
@@ -468,10 +459,6 @@ module AnnotateModels
       puts "Removed annotations from: #{deannotated.join(', ')}"
     end
 
-    def find_test_file(dir, file_name)
-      Dir.glob(File.join(dir, "**", file_name)).first || File.join(dir, file_name)
-    end
-
     def resolve_filename(filename_template, model_name, table_name)
       return filename_template.
         gsub('%MODEL_NAME%', model_name).

data/lib/annotate/version.rb

@@ -1,5 +1,5 @@
 module Annotate
   def self.version
-    '2.6.1'
+    '2.6.2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: annotate
 version: !ruby/object:Gem::Version
-  version: 2.6.1
+  version: 2.6.2
 platform: ruby
 authors:
 - Cuong Tran
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-21 00:00:00.000000000 Z
+date: 2014-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -50,7 +50,7 @@ description: Annotates Rails/ActiveRecord Models, routes, fixtures, and others b
   on the database schema.
 email:
 - alex@stinky.com
-- ctran@pragmaquest.com
+- cuong.tran@gmail.com
 - x@nofxx.com
 - turadg@aleahmad.net
 - jon@cloudability.com
@@ -80,7 +80,7 @@ files:
 - lib/generators/annotate/templates/auto_annotate_models.rake
 - lib/tasks/annotate_models.rake
 - lib/tasks/annotate_routes.rake
-- tasks/migrate.rake
+- lib/tasks/migrate.rake
 homepage: http://github.com/ctran/annotate_models
 licenses:
 - Ruby