anniversary 1.0.2 → 2.0.0

data/README.markdown

@@ -15,6 +15,14 @@ Your age in years, is actually the number of birthdays you have had, or to use a
 
 There are complications since some months are shorter than others, so geting this right is a bit tricky.  Hence Anniversary
 
+## UPDATE
+
+Well I said it was tricky.  While responding to some comments on my blog article, I realized that monthiversaries (and anniversaries of leap days) should always happen either on the same day in the month (if the month is long enough) or the first of the next month if not.  Note that if a month is too short then there will be two monthiversaries in the next month, once on the first, and a second on the actual day.
+
+In version 1 of the gem, I had the extra monthiversary in March fall on different days depending on whether or not the age was being calculated for a leap year or not.  This new version always places the extra monthiversaries on the first of the next month, see the update to my blog article for the rationale.
+
+Because this is a breaking change I've bumped the major version number.
+
 ## Installation
 
   gem install anniversary

data/lib/anniversary/date_additions.rb

@@ -22,7 +22,7 @@ class Date
       days_in_month = 29 if (month == 2) && ((year % 4 == 0) && ((year % 400 == 0) || (year % 100 != 0)))
       if (days_in_month < day)
         month += 1
-        day = day - days_in_month
+        day = 1
       end
       civil(year, month, day)
     end

data/lib/anniversary/version.rb

@@ -1,3 +1,3 @@
 module Anniversary
-  VERSION = "1.0.2"
+  VERSION = "2.0.0"
 end

data/spec/lib/date_additions_spec.rb

@@ -12,12 +12,12 @@ describe "::Date" do
       Date.civil_with_missing_day_correction(2011, 9, 31).should == Date.civil(2011, 10, 1)
     end
 
-    it "should handle a multi-day jump in a leap year" do
-      Date.civil_with_missing_day_correction(2012, 2, 31).should == Date.civil(2012, 3, 2)
+    it "should give March 1, for February '31' in a leap year" do
+      Date.civil_with_missing_day_correction(2012, 2, 31).should == Date.civil(2012, 3, 1)
     end
 
-    it "should handle a multi-day jump in a non-leap year" do
-      Date.civil_with_missing_day_correction(2011, 2, 31).should == Date.civil(2011, 3, 3)
+    it "should give March 1, for February '31' in a leap year" do
+      Date.civil_with_missing_day_correction(2011, 2, 31).should == Date.civil(2011, 3, 1)
     end
   end
 
@@ -83,11 +83,11 @@ describe "::Date" do
        end
 
        it "should handle the case of March 1, January 31 in the same non leap year" do
-         Date.civil(2010,3,1).years_months_days_since(Date.civil(2010,1,31)).should == [0, 0, 29]
+         Date.civil(2010,3,1).years_months_days_since(Date.civil(2010,1,31)).should == [0, 2, 0]
        end
 
        it "should handle the case of March 1, January 31 in the same leap year" do
-         Date.civil(2008,3,1).years_months_days_since(Date.civil(2008,1,31)).should == [0, 0, 30]
+         Date.civil(2008,3,1).years_months_days_since(Date.civil(2008,1,31)).should == [0, 2, 0]
        end
 
        it "should handle the first case brought up by pit capitan's comment on the blog" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: anniversary
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 15
   prerelease: false
   segments: 
-  - 1
-  - 0
   - 2
-  version: 1.0.2
+  - 0
+  - 0
+  version: 2.0.0
 platform: ruby
 authors: 
 - Rick Denatale