ann-flavor-flutter 0.4.8 → 0.4.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a70549206a408d933bf2258bf1c8b21ba4b1439d926e106a67f08564a2eac3fe
-  data.tar.gz: 0ff6ede39627802182e5ace0a13ab8d5a48075539f65827a52dbd9bfcc838373
+  metadata.gz: 148c47a3d06aabc1cf846252061bb38bbb0cbd67e27048bd04cfdb9a059b399e
+  data.tar.gz: 39cf77d42b97848a64a19f5ebfb8c995df92b37132995f7c60b7bbcc7fbae3c0
 SHA512:
-  metadata.gz: d3d91d71d2a5321d94b3211cc0818430a4525ef5fb65ca8d80e9cad5c2471f111556aee73452a6265179f4569e591c2f79661024c0959ead917b94115f1a445a
-  data.tar.gz: 6e90f40ea8ea0736b6984c30389916cbbe395116b7efdb4defde155da342174c0c62cec528c726fd698f9f6715d6821b67020518acb1a5db58d755e4b765c729
+  metadata.gz: 8cd05ae6c3b175a9fa68efa35ed3504a46667e7a85c9a36962e748d727fc0fb5d362e3fe0d2c8df2ab1ca59ca6e7c28f39f97f8390c8bcbf32d51f58bd6c5b41
+  data.tar.gz: 1322abdd31694ff5118a6c222604a75a1359ca98eb3724c316b59a680b561152886f513216c293e5f43755a16c09f10c936605de8a40f3ffc8a9e83f21e40495

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.4.9
+
+### Fixed
+- `YamlSpecLoader#get_display_name`/`#get_version_name`/`#get_version_code`/`#get_gms_ads_id` were hardcoded to resolve against the `release` build type regardless of the caller's actual build — a sibling of the `#get_package_id` bug fixed under plan-030 Phase 6 / REQ-CDEL-00070, but not applied to these four getters at the time. `PodspecBridge` now threads its real `@build_type` through to all of them (matching `#bundle_id`), so a debug build correctly picks up any `build_types.debug`-level `name_suffix`/`version_name`/`version_code` override instead of silently resolving the release value.
+
 ## 0.4.8
 
 ### Added

data/lib/ann_flavor_flutter/version.rb

@@ -1,3 +1,3 @@
 module AnnFlavorFlutter
-  VERSION = "0.4.8"
+  VERSION = "0.4.9"
 end

data/lib/fastlane/plugin/ann_flavor_flutter/helper/podspec_bridge.rb

@@ -114,7 +114,7 @@ module FastlaneFlutterFlavor
     end
 
     def display_name
-      @loader.get_display_name(@platform, @flavor)
+      @loader.get_display_name(@platform, @flavor, @build_type)
     end
 
     def bundle_id
@@ -122,15 +122,15 @@ module FastlaneFlutterFlavor
     end
 
     def version_name
-      @loader.get_version_name(@platform, @flavor)
+      @loader.get_version_name(@platform, @flavor, @build_type)
     end
 
     def version_code
-      @loader.get_version_code(@platform, @flavor)
+      @loader.get_version_code(@platform, @flavor, @build_type)
     end
 
     def gms_ads_id
-      @loader.get_gms_ads_id(@platform, @flavor)
+      @loader.get_gms_ads_id(@platform, @flavor, @build_type)
     end
 
     def team_id

data/lib/fastlane/plugin/ann_flavor_flutter/helper/utils_spec_loader.rb

@@ -179,21 +179,27 @@ module FastlaneFlutterFlavor
       resolved&.effective_id
     end
 
-    # @return [String, nil] The merged app name.
-    def get_display_name(platform, flavor_name)
-      resolved = resolve(platform, flavor_name, 'release')
+    # @return [String, nil] The merged app name for the given build type. Was
+    #   previously hardcoded to 'release' regardless of the caller's actual
+    #   build — a sibling of the get_package_id fix (plan-030 Phase 6 /
+    #   REQ-CDEL-00070): PodspecBridge#display_name now threads its real
+    #   @build_type through instead of relying on this default.
+    def get_display_name(platform, flavor_name, build_type = 'release')
+      resolved = resolve(platform, flavor_name, build_type)
       resolved&.effective_name
     end
 
-    # @return [String, nil] The merged version name.
-    def get_version_name(platform, flavor_name)
-      resolved = resolve(platform, flavor_name, 'release')
+    # @return [String, nil] The merged version name for the given build type.
+    #   Was previously hardcoded to 'release' — see get_display_name.
+    def get_version_name(platform, flavor_name, build_type = 'release')
+      resolved = resolve(platform, flavor_name, build_type)
       resolved&.effective_version_name
     end
 
-    # @return [String, nil] The path to the version_code.
-    def get_version_code(platform, flavor_name)
-      resolved = resolve(platform, flavor_name, 'release')
+    # @return [String, nil] The version_code for the given build type. Was
+    #   previously hardcoded to 'release' — see get_display_name.
+    def get_version_code(platform, flavor_name, build_type = 'release')
+      resolved = resolve(platform, flavor_name, build_type)
       return nil unless resolved
       resolved.effective_version_code.to_i.to_s
     end
@@ -295,8 +301,9 @@ module FastlaneFlutterFlavor
       resolved&.effective_name
     end
 
-    def get_gms_ads_id(platform, flavor_name)
-      resolved = resolve(platform, flavor_name, 'release')
+    # Was previously hardcoded to 'release' — see get_display_name.
+    def get_gms_ads_id(platform, flavor_name, build_type = 'release')
+      resolved = resolve(platform, flavor_name, build_type)
       resolved&.effective_gms_ads_id
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ann-flavor-flutter
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.4.9
 platform: ruby
 authors:
 - ANN Solutions