ann-flavor-cocoapods 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eebdd0861c6e897e517afc185dbe5093672eee28a4549ab869aef3105144b72a
-  data.tar.gz: 9976784a3f67eca1be9c0e2ed08bfe2bde6671fe845321dbc39c4b432b90fc46
+  metadata.gz: 26c819f56bb3a959737651233fbdbed8e0bd887ddcdfbf0fd0c157c26b99a011
+  data.tar.gz: d322f020327b3b62f3eb02922a01d1af90040a2b5595614a37795eacf311a2cf
 SHA512:
-  metadata.gz: ada32883a563af3301da9355cfc65fde024ff4a34194e59eaee2a7d6dc863c3d47a2574c3712aebf66e4b4fa29f444b96b70188016fde24810ba8656a975f0d8
-  data.tar.gz: a0691d77e669115cb8ff313d53ad4d4267551ce8c3836fa8101b2e8a5a3342f599552d6cd197f0589a3f52e9e8082dacdd92ea5b7246944c852b69871b70c625
+  metadata.gz: 85564c5fcc276b9f448381fc8cb3d334ca65d9bedbccd2b40fe25b46e43775afc50f66b7a2c6394ab032a118ecb8e3b1335b596c89f0c5dc79d7945bc52bc7ac
+  data.tar.gz: e2e76a0da4568f8bc5a040d1f3f0422a8844b1da28b0b34b6324fda2c56d7c47eceec963ae644c82044f266b20193fe29d9572cce60a7dbf59933ac8df9a2221

data/CHANGELOG.md

@@ -1,5 +1,28 @@
 # Changelog
 
+## 0.4.4
+
+### Fixed
+- **"Cycle inside Runner" could still occur even after 0.4.1-0.4.3.**
+  Confirmed live (again, against `ledger`) that declaring `input_paths` on
+  `[CP] Check Pods Manifest.lock`'s own output (introduced in 0.4.1 as the
+  original fix, kept through 0.4.2/0.4.3 as "belt-and-suspenders") was
+  actually the *cause* of the cycle, not a fix for it: `[ann-flavor] Merge
+  Entitlements`/`[ann-flavor] Merge Info.plist`'s output feeds
+  `ProcessProductPackaging` (signing), which Xcode's new build system gates
+  behind a chain of task producers (`ModuleVerifierTaskProducer` et al) —
+  and `Check Pods Manifest.lock`'s own output is *itself* gated behind that
+  same chain. Declaring it as an input routed these phases through that
+  chain from the other direction, closing a genuine cycle with the Firebase
+  framework-copy phases (also gated behind it) regardless of
+  `build_phases` position. Fixed by removing the `input_paths` declaration
+  entirely — `output_paths` plus running after the Pods/framework-copy
+  phases (the 0.4.2 position fix, kept) is sufficient on its own; this
+  phase never actually needed Check Pods Manifest.lock's result as an
+  input. Xcode's own error message ("moving Check Pods Manifest.lock so it
+  runs before the phase that depends on its outputs") was describing a
+  self-inflicted dependency, not a real requirement.
+
 ## 0.4.3
 
 ### Fixed

data/lib/ann_flavor_cocoapods/podfile_helper.rb

@@ -912,10 +912,11 @@ module AnnFlavorCocoapods
       # output_paths) -- suppresses "input file not found" for INFOPLIST_FILE
       # referencing a path nothing else produces until this phase runs.
       phase.output_paths = ['$(DERIVED_FILE_DIR)/Info-merged.plist']
-      # Belt-and-suspenders alongside the append-at-end position fix below --
-      # explicitly orders this phase after CocoaPods' own "[CP] Check Pods
-      # Manifest.lock" phase regardless of list position.
-      phase.input_paths = ['$(DERIVED_FILE_DIR)/Pods-Runner-checkManifestLockResult.txt']
+      # NOT declaring input_paths on Check Pods Manifest.lock's output here
+      # (tried in v0.4.1) -- see the identical, fuller explanation on
+      # inject_merge_entitlements_phase below for why that direction was
+      # actually the cause of the real "Cycle inside Runner" failure, not a
+      # (partial) fix for it.
 
       # Appended at the END of build_phases, not unshifted to the front --
       # see the identical, fuller explanation on inject_merge_entitlements_phase
@@ -1027,11 +1028,26 @@ module AnnFlavorCocoapods
       phase.shell_script = script
       phase.show_env_vars_in_log = '0'
       phase.output_paths = ['$(DERIVED_FILE_DIR)/Entitlements-merged.entitlements']
-      # Belt-and-suspenders alongside the append-at-end position fix below --
-      # explicitly orders this phase after CocoaPods' own "[CP] Check Pods
-      # Manifest.lock" phase regardless of list position.
-      phase.input_paths = ['$(DERIVED_FILE_DIR)/Pods-Runner-checkManifestLockResult.txt']
-
+      # NOT declaring input_paths on Check Pods Manifest.lock's own output
+      # here (tried in v0.4.1/0.4.2/0.4.3 as "belt-and-suspenders"). Confirmed
+      # live (yet again, against ledger) that this input_paths declaration is
+      # what CAUSES the real "Cycle inside Runner" failure, not a partial fix
+      # for it: this phase's output feeds ProcessProductPackaging (signing),
+      # which Xcode's new build system gates behind a chain of task producers
+      # (ModuleVerifierTaskProducer et al) — declaring Check Pods Manifest
+      # .lock's result file as this phase's OWN input routes this phase
+      # through that SAME gate chain from the other direction, since Check
+      # Pods Manifest.lock's output is itself gated behind
+      # ModuleVerifierTaskProducer too. The Firebase framework-copy phases
+      # are gated behind that identical chain — closing a genuine cycle no
+      # matter where this phase sits in build_phases. Xcode's own error
+      # message ("moving Check Pods Manifest.lock so it runs before the
+      # phase that depends on its outputs") is describing exactly this
+      # self-inflicted dependency, not a real requirement — this phase never
+      # actually needed Check Pods Manifest.lock's result as an input;
+      # output_paths + running after the Pods/framework-copy phases (via
+      # position, below) is sufficient on its own.
+      #
       # Appended at the END of build_phases, not unshifted to the front.
       # v0.4.1 tried fixing this phase's real "Cycle inside Runner" Xcode
       # build failure (confirmed live against ledger, a project with real

data/lib/ann_flavor_cocoapods/version.rb

@@ -1,3 +1,3 @@
 module AnnFlavorCocoapods
-  VERSION = "0.4.3"
+  VERSION = "0.4.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ann-flavor-cocoapods
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - ANN Solutions