ann-flavor-cocoapods 0.4.2 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae5474a82cba4428fdfaf19c72bb2c7ac53b219bb50baf70ff246988947cb83f
-  data.tar.gz: 5c57f69715847b50fc8fa930f6c182cc074c37389c1f0184734a73c09ee2d5a0
+  metadata.gz: 26c819f56bb3a959737651233fbdbed8e0bd887ddcdfbf0fd0c157c26b99a011
+  data.tar.gz: d322f020327b3b62f3eb02922a01d1af90040a2b5595614a37795eacf311a2cf
 SHA512:
-  metadata.gz: 61bef50c9f7da4eada063a61ed60184de9790105eafee5c63c064e8c48419c96003d79ebdd77f3a70e0e32a75b160bd7c7b637d6c1cc5f6f70d6b2e0c85b6a69
-  data.tar.gz: 196fbefce09aff6c9055616a6a073a11c22687868e2aca9f0c9c1086d010849b032d40e3a3247e3d4281ca9d0543bd8ea1eb5bc1145bcf47a6f5bdf12fd9b6ef
+  metadata.gz: 85564c5fcc276b9f448381fc8cb3d334ca65d9bedbccd2b40fe25b46e43775afc50f66b7a2c6394ab032a118ecb8e3b1335b596c89f0c5dc79d7945bc52bc7ac
+  data.tar.gz: e2e76a0da4568f8bc5a040d1f3f0422a8844b1da28b0b34b6324fda2c56d7c47eceec963ae644c82044f266b20193fe29d9572cce60a7dbf59933ac8df9a2221

data/CHANGELOG.md

@@ -1,5 +1,48 @@
 # Changelog
 
+## 0.4.4
+
+### Fixed
+- **"Cycle inside Runner" could still occur even after 0.4.1-0.4.3.**
+  Confirmed live (again, against `ledger`) that declaring `input_paths` on
+  `[CP] Check Pods Manifest.lock`'s own output (introduced in 0.4.1 as the
+  original fix, kept through 0.4.2/0.4.3 as "belt-and-suspenders") was
+  actually the *cause* of the cycle, not a fix for it: `[ann-flavor] Merge
+  Entitlements`/`[ann-flavor] Merge Info.plist`'s output feeds
+  `ProcessProductPackaging` (signing), which Xcode's new build system gates
+  behind a chain of task producers (`ModuleVerifierTaskProducer` et al) —
+  and `Check Pods Manifest.lock`'s own output is *itself* gated behind that
+  same chain. Declaring it as an input routed these phases through that
+  chain from the other direction, closing a genuine cycle with the Firebase
+  framework-copy phases (also gated behind it) regardless of
+  `build_phases` position. Fixed by removing the `input_paths` declaration
+  entirely — `output_paths` plus running after the Pods/framework-copy
+  phases (the 0.4.2 position fix, kept) is sufficient on its own; this
+  phase never actually needed Check Pods Manifest.lock's result as an
+  input. Xcode's own error message ("moving Check Pods Manifest.lock so it
+  runs before the phase that depends on its outputs") was describing a
+  self-inflicted dependency, not a real requirement.
+
+## 0.4.3
+
+### Fixed
+- **0.4.2's fix produced a silently-corrupt `project.pbxproj`.** Moving
+  `[ann-flavor] Merge Entitlements`/`[ann-flavor] Merge Info.plist` from
+  `build_phases.unshift` to `build_phases.push` (to fix "Cycle inside
+  Runner") used the wrong method: `Xcodeproj::Project::ObjectList`
+  (`build_phases`'s real class) overrides `<<`/`insert`/`unshift`/`delete`
+  to register an added object in the project's global objects table, but
+  does **not** override `push` — plain `Array#push` silently bypasses that
+  registration. The phase ended up referenced in `buildPhases` with no
+  matching object anywhere else in `project.pbxproj`, which Xcode then
+  failed to build with `Build input file cannot be found:
+  '.../Entitlements-merged.entitlements'. Did you forget to declare this
+  file as an output of a script phase...?` — confirmed live against
+  `ledger`. Fixed by using `<<` instead of `push` in both phases' injection
+  code. Added regression coverage asserting the phase is genuinely present
+  in `project.objects`, not just the `build_phases` array — the exact
+  distinction `push` silently violated.
+
 ## 0.4.2
 
 ### Fixed

data/lib/ann_flavor_cocoapods/podfile_helper.rb

@@ -912,10 +912,11 @@ module AnnFlavorCocoapods
       # output_paths) -- suppresses "input file not found" for INFOPLIST_FILE
       # referencing a path nothing else produces until this phase runs.
       phase.output_paths = ['$(DERIVED_FILE_DIR)/Info-merged.plist']
-      # Belt-and-suspenders alongside the append-at-end position fix below --
-      # explicitly orders this phase after CocoaPods' own "[CP] Check Pods
-      # Manifest.lock" phase regardless of list position.
-      phase.input_paths = ['$(DERIVED_FILE_DIR)/Pods-Runner-checkManifestLockResult.txt']
+      # NOT declaring input_paths on Check Pods Manifest.lock's output here
+      # (tried in v0.4.1) -- see the identical, fuller explanation on
+      # inject_merge_entitlements_phase below for why that direction was
+      # actually the cause of the real "Cycle inside Runner" failure, not a
+      # (partial) fix for it.
 
       # Appended at the END of build_phases, not unshifted to the front --
       # see the identical, fuller explanation on inject_merge_entitlements_phase
@@ -926,8 +927,19 @@ module AnnFlavorCocoapods
       # Repositions unconditionally, even when `existing` -- see the identical
       # note on inject_merge_entitlements_phase for why (a pre-v0.4.2 project
       # would otherwise never actually get repositioned on re-`pod install`).
+      #
+      # Uses << , NOT push -- Xcodeproj::Project::ObjectList (build_phases'
+      # real class) overrides <</insert/unshift/delete to also update the
+      # object's reference count/registration in the project's global
+      # objects table, but does NOT override push. Array#push silently falls
+      # through to the plain Array behavior, leaving the phase referenced in
+      # buildPhases but never actually registered as a project object --
+      # confirmed live: this produced a real, silently-corrupt
+      # project.pbxproj (a dangling buildPhases reference to a UUID with no
+      # matching object), which then failed at Xcode build time with "Build
+      # input file cannot be found" for this phase's declared output.
       target.build_phases.delete(phase) if existing
-      target.build_phases.push(phase)
+      target.build_phases << phase
     end
 
     # Composes the final .entitlements file Xcode actually signs with, from
@@ -1016,11 +1028,26 @@ module AnnFlavorCocoapods
       phase.shell_script = script
       phase.show_env_vars_in_log = '0'
       phase.output_paths = ['$(DERIVED_FILE_DIR)/Entitlements-merged.entitlements']
-      # Belt-and-suspenders alongside the append-at-end position fix below --
-      # explicitly orders this phase after CocoaPods' own "[CP] Check Pods
-      # Manifest.lock" phase regardless of list position.
-      phase.input_paths = ['$(DERIVED_FILE_DIR)/Pods-Runner-checkManifestLockResult.txt']
-
+      # NOT declaring input_paths on Check Pods Manifest.lock's own output
+      # here (tried in v0.4.1/0.4.2/0.4.3 as "belt-and-suspenders"). Confirmed
+      # live (yet again, against ledger) that this input_paths declaration is
+      # what CAUSES the real "Cycle inside Runner" failure, not a partial fix
+      # for it: this phase's output feeds ProcessProductPackaging (signing),
+      # which Xcode's new build system gates behind a chain of task producers
+      # (ModuleVerifierTaskProducer et al) — declaring Check Pods Manifest
+      # .lock's result file as this phase's OWN input routes this phase
+      # through that SAME gate chain from the other direction, since Check
+      # Pods Manifest.lock's output is itself gated behind
+      # ModuleVerifierTaskProducer too. The Firebase framework-copy phases
+      # are gated behind that identical chain — closing a genuine cycle no
+      # matter where this phase sits in build_phases. Xcode's own error
+      # message ("moving Check Pods Manifest.lock so it runs before the
+      # phase that depends on its outputs") is describing exactly this
+      # self-inflicted dependency, not a real requirement — this phase never
+      # actually needed Check Pods Manifest.lock's result as an input;
+      # output_paths + running after the Pods/framework-copy phases (via
+      # position, below) is sufficient on its own.
+      #
       # Appended at the END of build_phases, not unshifted to the front.
       # v0.4.1 tried fixing this phase's real "Cycle inside Runner" Xcode
       # build failure (confirmed live against ledger, a project with real
@@ -1044,8 +1071,15 @@ module AnnFlavorCocoapods
       # front from the old unshift) -- otherwise re-running `pod install`
       # after upgrading the gem would never actually move it, and the real
       # bug would persist for every already-affected consumer.
+      #
+      # Uses << , NOT push -- see the identical, fuller explanation on
+      # inject_merge_info_plist_phase above. Array#push silently bypasses
+      # ObjectList's reference-count/registration bookkeeping, producing a
+      # real, silently-corrupt project.pbxproj (buildPhases referencing a
+      # UUID with no matching object) that fails at Xcode build time with
+      # "Build input file cannot be found" -- confirmed live against ledger.
       target.build_phases.delete(phase) if existing
-      target.build_phases.push(phase)
+      target.build_phases << phase
     end
 
     # Removes a previously-injected Merge Entitlements phase when no flavor

data/lib/ann_flavor_cocoapods/version.rb

@@ -1,3 +1,3 @@
 module AnnFlavorCocoapods
-  VERSION = "0.4.2"
+  VERSION = "0.4.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ann-flavor-cocoapods
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.4
 platform: ruby
 authors:
 - ANN Solutions