ann-flavor-cocoapods 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae5474a82cba4428fdfaf19c72bb2c7ac53b219bb50baf70ff246988947cb83f
-  data.tar.gz: 5c57f69715847b50fc8fa930f6c182cc074c37389c1f0184734a73c09ee2d5a0
+  metadata.gz: eebdd0861c6e897e517afc185dbe5093672eee28a4549ab869aef3105144b72a
+  data.tar.gz: 9976784a3f67eca1be9c0e2ed08bfe2bde6671fe845321dbc39c4b432b90fc46
 SHA512:
-  metadata.gz: 61bef50c9f7da4eada063a61ed60184de9790105eafee5c63c064e8c48419c96003d79ebdd77f3a70e0e32a75b160bd7c7b637d6c1cc5f6f70d6b2e0c85b6a69
-  data.tar.gz: 196fbefce09aff6c9055616a6a073a11c22687868e2aca9f0c9c1086d010849b032d40e3a3247e3d4281ca9d0543bd8ea1eb5bc1145bcf47a6f5bdf12fd9b6ef
+  metadata.gz: ada32883a563af3301da9355cfc65fde024ff4a34194e59eaee2a7d6dc863c3d47a2574c3712aebf66e4b4fa29f444b96b70188016fde24810ba8656a975f0d8
+  data.tar.gz: a0691d77e669115cb8ff313d53ad4d4267551ce8c3836fa8101b2e8a5a3342f599552d6cd197f0589a3f52e9e8082dacdd92ea5b7246944c852b69871b70c625

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## 0.4.3
+
+### Fixed
+- **0.4.2's fix produced a silently-corrupt `project.pbxproj`.** Moving
+  `[ann-flavor] Merge Entitlements`/`[ann-flavor] Merge Info.plist` from
+  `build_phases.unshift` to `build_phases.push` (to fix "Cycle inside
+  Runner") used the wrong method: `Xcodeproj::Project::ObjectList`
+  (`build_phases`'s real class) overrides `<<`/`insert`/`unshift`/`delete`
+  to register an added object in the project's global objects table, but
+  does **not** override `push` — plain `Array#push` silently bypasses that
+  registration. The phase ended up referenced in `buildPhases` with no
+  matching object anywhere else in `project.pbxproj`, which Xcode then
+  failed to build with `Build input file cannot be found:
+  '.../Entitlements-merged.entitlements'. Did you forget to declare this
+  file as an output of a script phase...?` — confirmed live against
+  `ledger`. Fixed by using `<<` instead of `push` in both phases' injection
+  code. Added regression coverage asserting the phase is genuinely present
+  in `project.objects`, not just the `build_phases` array — the exact
+  distinction `push` silently violated.
+
 ## 0.4.2
 
 ### Fixed

data/lib/ann_flavor_cocoapods/podfile_helper.rb

@@ -926,8 +926,19 @@ module AnnFlavorCocoapods
       # Repositions unconditionally, even when `existing` -- see the identical
       # note on inject_merge_entitlements_phase for why (a pre-v0.4.2 project
       # would otherwise never actually get repositioned on re-`pod install`).
+      #
+      # Uses << , NOT push -- Xcodeproj::Project::ObjectList (build_phases'
+      # real class) overrides <</insert/unshift/delete to also update the
+      # object's reference count/registration in the project's global
+      # objects table, but does NOT override push. Array#push silently falls
+      # through to the plain Array behavior, leaving the phase referenced in
+      # buildPhases but never actually registered as a project object --
+      # confirmed live: this produced a real, silently-corrupt
+      # project.pbxproj (a dangling buildPhases reference to a UUID with no
+      # matching object), which then failed at Xcode build time with "Build
+      # input file cannot be found" for this phase's declared output.
       target.build_phases.delete(phase) if existing
-      target.build_phases.push(phase)
+      target.build_phases << phase
     end
 
     # Composes the final .entitlements file Xcode actually signs with, from
@@ -1044,8 +1055,15 @@ module AnnFlavorCocoapods
       # front from the old unshift) -- otherwise re-running `pod install`
       # after upgrading the gem would never actually move it, and the real
       # bug would persist for every already-affected consumer.
+      #
+      # Uses << , NOT push -- see the identical, fuller explanation on
+      # inject_merge_info_plist_phase above. Array#push silently bypasses
+      # ObjectList's reference-count/registration bookkeeping, producing a
+      # real, silently-corrupt project.pbxproj (buildPhases referencing a
+      # UUID with no matching object) that fails at Xcode build time with
+      # "Build input file cannot be found" -- confirmed live against ledger.
       target.build_phases.delete(phase) if existing
-      target.build_phases.push(phase)
+      target.build_phases << phase
     end
 
     # Removes a previously-injected Merge Entitlements phase when no flavor

data/lib/ann_flavor_cocoapods/version.rb

@@ -1,3 +1,3 @@
 module AnnFlavorCocoapods
-  VERSION = "0.4.2"
+  VERSION = "0.4.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ann-flavor-cocoapods
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - ANN Solutions