anchor_view_components 0.43.0 → 0.44.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed9aaede95489205c325ca4ab6820458d84a5131d47aac172a0212f52fd4e228
-  data.tar.gz: c1eee26d158f6e4276dbbce9813e89a43f06151980a76823a1f91ac6863956a0
+  metadata.gz: b272707b7b7780690e4bd12712dfae937b8fd30e97cc4eaf9ab86b15a83a9122
+  data.tar.gz: ef9c2b7c05ccbbc0e24ef552da216c0e502e6d57d83c1b5101c53b5e665912cc
 SHA512:
-  metadata.gz: 18d8e1894f3e249b37e803df49fb741d550229242f80ed91279eeb3d06efa242146737a25d55320b2f15569ac3dae4f187e99bada58feb4b879523fd6be2435c
-  data.tar.gz: 736ecc7b962bbafcf45e7f45af8a04f279f552eec2f2712aa115b23246a13ae0bc8dc44af958ea231bc470aad5f69e0001ddd7f45676278cb439c30e8ecc8569
+  metadata.gz: 2f0273735e483b4b93949b639ac1c76191fda722709efd043908bee522f853a9ae500d57a127b32bdab5f65232a3769755a98fce1cce4e082038d998f149c324
+  data.tar.gz: e27c29a51d263e4d55ec537515d18215ed280fc6f19df997cb9d4733c6ebc60c6495b80fd4679882b77e3cbea629249ed1f0284665453e8e01288179773308d7

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.44.0
+
+### Minor Changes
+
+- a9e927c: Removed the deprecated `tag` parameter from the Button component.
+- 3f6ff7b: When a dialog is closed, any inner form error messages will be removed.
+- e2941f0: Added a `supporting_text` slot to the `Page::Footer` component, which renders
+  text next to the buttons.
+
 ## 0.43.0
 
 ### Minor Changes

data/app/components/anchor/autocomplete/results_component.html.erb

@@ -1,9 +1,8 @@
 <% results.each do |result| %>
   <%= tag.li(
-    **merge_options(
-      { data: result.data },
+    **merge_options(wrapper_options,
       class: "list-group-item",
-      data: { autocomplete_value: result.value },
+      data: result.data.merge(autocomplete_value: result.value),
       role: "option",
     )
   ) do %>

data/app/components/anchor/autocomplete/results_component.rb

@@ -3,10 +3,10 @@ module Anchor
     class ResultsComponent < Component
       Result = Data.define(:text, :value, :data)
 
-      def initialize(data:)
+      def initialize(data:, **kwargs)
         @data = data
 
-        super
+        super(**kwargs)
       end
 
       private

data/app/components/anchor/banner_component.rb

@@ -34,13 +34,11 @@ module Anchor
       warning: "text-warning",
     }.freeze
 
-    def initialize(**kwargs)
-      @icon = ICON_MAPPINGS[kwargs[:variant]] ||
-        ICON_MAPPINGS[VARIANT_DEFAULT]
-      @icon_variant = ICON_VARIANT_MAPPINGS[kwargs[:variant]] ||
-        ICON_VARIANT_MAPPINGS[VARIANT_DEFAULT]
+    def initialize(variant: VARIANT_DEFAULT, **kwargs)
+      @icon = ICON_MAPPINGS[variant]
+      @icon_variant = ICON_VARIANT_MAPPINGS[variant]
 
-      super
+      super(variant:, **kwargs)
     end
 
     private

data/app/components/anchor/button_component.rb

@@ -35,7 +35,6 @@ module Anchor
     end
 
     def initialize(
-      tag: nil,
       type: TYPE_DEFAULT,
       size: SIZE_DEFAULT,
       href: nil,
@@ -43,12 +42,6 @@ module Anchor
       full_width: false,
       **kwargs
     )
-      if tag
-        ActiveSupport::Deprecation.warn(
-          "`tag` is now set automatically and should no longer be used."
-        )
-      end
-
       @type = fetch_or_fallback(TYPE_OPTIONS, type, TYPE_DEFAULT)
       @size = SIZE_MAPPINGS[fetch_or_fallback(SIZE_OPTIONS, size,
         SIZE_DEFAULT)]

data/app/components/anchor/component.rb

@@ -16,7 +16,7 @@ module Anchor
         .merge(class: classes)
         .reject { |_, v| deep_blank?(v) }
 
-      super
+      super # rubocop:disable Anchor/AvoidImplicitSuper
     end
 
     private

data/app/components/anchor/dialog_component.html.erb

@@ -10,6 +10,7 @@
   ],
   data: {
     controller: "dialog",
+    action: "close->dialog#reset",
     testid: title_id,
   },
 })) do %>

data/app/components/anchor/dialog_controller.ts

@@ -8,4 +8,12 @@ export default class extends Controller<HTMLDialogElement> {
   close(): void {
     this.element.close();
   }
+
+  reset(): void {
+    this.#resetErrorMessages();
+  }
+
+  #resetErrorMessages(): void {
+    this.element.querySelectorAll("[data-error='true']").forEach((element) => element.remove());
+  }
 }

data/app/components/anchor/link_component.rb

@@ -10,7 +10,7 @@ module Anchor
     def initialize(href:, **kwargs)
       @href = href
 
-      super
+      super(**kwargs)
     end
 
     attr_reader :href

data/app/components/anchor/page/footer_component.html.erb

@@ -1,10 +1,11 @@
 <%= tag.footer(**merge_options(wrapper_options,
   class: class_names(
     Anchor::PageComponent::HORIZONTAL_PADDING_CLASS,
-    "py-5 flex justify-end gap-4 border-t bg-white border-subdued sticky bottom-0",
+    "py-5 flex items-center justify-end gap-4 border-t bg-white border-subdued sticky bottom-0",
   ),
   data: { testid: "page-footer" }),
 ) do %>
+  <%= supporting_text %>
   <%= delete_button unless done_button? %>
   <%= cancel_button unless done_button? %>
   <%= save_button unless done_button? %>

data/app/components/anchor/page/footer_component.rb

@@ -34,6 +34,14 @@ module Anchor
           **kwargs
         )
       }
+
+      renders_one :supporting_text, lambda { |supporting_text, **kwargs|
+        anchor_text(
+          supporting_text,
+          class: "text-secondary",
+          **kwargs
+        )
+      }
     end
   end
 end

data/lib/anchor/view_components/version.rb

@@ -1,5 +1,5 @@
 module Anchor
   module ViewComponents
-    VERSION = "0.43.0".freeze
+    VERSION = "0.44.0".freeze
   end
 end

data/lib/cops/anchor/avoid_implicit_super.rb

@@ -0,0 +1,23 @@
+module Anchor
+  class AvoidImplicitSuper < RuboCop::Cop::Cop
+    MSG = "Avoid implicit `super` calls. Prefer `super(**kwargs)`, " \
+          "`super()`, or a mix of explicit/implicit arguments, e.g. " \
+          "`super(id:, title:, **kwargs)`.".freeze
+
+    def_node_matcher :initialize_with_implicit_super?, <<~PATTERN
+      (def :initialize _ (begin ... $`zsuper ...))
+    PATTERN
+
+    def on_def(node)
+      return unless (zsuper = initialize_with_implicit_super?(node))
+
+      add_offense(zsuper, message:)
+    end
+
+    private
+
+    def message
+      MSG
+    end
+  end
+end

data/previews/anchor/dialog_component_preview/with_form.html.erb

@@ -0,0 +1,21 @@
+<% invalid_user = FakeUser.new(name: "").tap(&:validate) %>
+
+<%= anchor_dialog(
+  id: "my-dialog",
+  title: "Dialog Title",
+) do |dialog| %>
+  <% dialog.with_show_button_content("Open dialog") %>
+
+  <% dialog.with_body do %>
+    <%= anchor_form_with(model: invalid_user, url: false, id: 'a-form') do |form| %>
+      <%= form.label(:name) %>
+      <%= form.text_field(:name, required: true) %>
+      <%= form.error_message_for(:name) %>
+    <% end %>
+  <% end %>
+
+  <% dialog.with_footer do %>
+    <%= anchor_button("Cancel", data: { action: "dialog#close" }) %>
+    <%= anchor_button("Save", variant: :primary, type: :submit, form: 'a-form') %>
+  <% end %>
+<% end %>

data/previews/anchor/dialog_component_preview.rb

@@ -16,6 +16,8 @@ module Anchor
       end
     end
 
+    def with_form; end
+
     def with_footer; end
 
     def positioned_right; end

data/previews/anchor/page_component_preview/with_supporting_text_and_buttons.html.erb

@@ -0,0 +1,24 @@
+<%= anchor_page do |page| %>
+  <% page.with_header do |header| %>
+    <% header.with_breadcrumbs do |breadcrumbs| %>
+      <% breadcrumbs.with_item(href: "#").with_content("Breadcrumb 1") %>
+      <% breadcrumbs.with_item(href: "").with_content("Breadcrumb 2") %>
+    <% end %>
+    <% header.with_title("Page title") %>
+  <% end %>
+  <% page.with_body do |body| %>
+    <%= anchor_form_with(url: false, id: "form") do |form| %>
+      <%= tag.div class: "max-w-sm" do %>
+        <%= form.label :name, "Name" %>
+        <%= form.text_field(
+      :name,
+    ) %>
+      <% end %>
+    <% end %>
+  <% end %>
+  <% page.with_footer do |footer| %>
+    <% footer.with_cancel_button(href: "#") %>
+    <% footer.with_save_button(form: "form") %>
+    <% footer.with_supporting_text("Optional text") %>
+  <% end %>
+<% end %>

data/previews/anchor/page_component_preview.rb

@@ -15,5 +15,7 @@ module Anchor
     def with_done_button; end
 
     def with_cancel_and_save_buttons; end
+
+    def with_supporting_text_and_buttons; end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anchor_view_components
 version: !ruby/object:Gem::Version
-  version: 0.43.0
+  version: 0.44.0
 platform: ruby
 authors:
 - Buoy Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-01-04 00:00:00.000000000 Z
+date: 2024-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -191,6 +191,7 @@ files:
 - lib/anchor/view_components/svg_resolver.rb
 - lib/anchor/view_components/version.rb
 - lib/anchor_view_components.rb
+- lib/cops/anchor/avoid_implicit_super.rb
 - previews/anchor/action_menu_component_preview.rb
 - previews/anchor/action_menu_component_preview/autoplacement.html.erb
 - previews/anchor/action_menu_component_preview/custom_trigger.html.erb
@@ -209,6 +210,7 @@ files:
 - previews/anchor/dialog_component_preview/positioned_right.html.erb
 - previews/anchor/dialog_component_preview/with_custom_show_button.html.erb
 - previews/anchor/dialog_component_preview/with_footer.html.erb
+- previews/anchor/dialog_component_preview/with_form.html.erb
 - previews/anchor/filter_component_preview.rb
 - previews/anchor/forms_preview.rb
 - previews/anchor/icon_component_preview.rb
@@ -223,6 +225,7 @@ files:
 - previews/anchor/page_component_preview/with_done_button.html.erb
 - previews/anchor/page_component_preview/with_page_header_custom_content.html.erb
 - previews/anchor/page_component_preview/with_search.html.erb
+- previews/anchor/page_component_preview/with_supporting_text_and_buttons.html.erb
 - previews/anchor/panel_component_preview.rb
 - previews/anchor/panel_component_preview/with_banner.html.erb
 - previews/anchor/preview.rb