analdiffist 0.1.1 → 0.2.0

data/Gemfile

@@ -4,8 +4,8 @@ gem "reek"
 gem "flog"
 
 group :development do
-  gem "rspec", "~> 2.3.0"
+  gem "rspec", "~> 2.5.0"
   gem "bundler", "~> 1.0.0"
   gem "jeweler", "~> 1.5.2"
-  gem "rcov", ">= 0"
+  gem "autotest"
 end

data/Gemfile.lock

@@ -1,6 +1,9 @@
 GEM
   remote: http://rubygems.org/
   specs:
+    ZenTest (4.5.0)
+    autotest (4.4.6)
+      ZenTest (>= 4.4.1)
     diff-lcs (1.1.2)
     flog (2.5.1)
       ruby_parser (~> 2.0)
@@ -11,19 +14,18 @@ GEM
       git (>= 1.2.5)
       rake
     rake (0.8.7)
-    rcov (0.9.9)
     reek (1.2.8)
       ruby2ruby (~> 1.2)
       ruby_parser (~> 2.0)
       sexp_processor (~> 3.0)
-    rspec (2.3.0)
-      rspec-core (~> 2.3.0)
-      rspec-expectations (~> 2.3.0)
-      rspec-mocks (~> 2.3.0)
-    rspec-core (2.3.1)
-    rspec-expectations (2.3.0)
+    rspec (2.5.0)
+      rspec-core (~> 2.5.0)
+      rspec-expectations (~> 2.5.0)
+      rspec-mocks (~> 2.5.0)
+    rspec-core (2.5.1)
+    rspec-expectations (2.5.0)
       diff-lcs (~> 1.1.2)
-    rspec-mocks (2.3.0)
+    rspec-mocks (2.5.0)
     ruby2ruby (1.2.5)
       ruby_parser (~> 2.0)
       sexp_processor (~> 3.0)
@@ -35,9 +37,9 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  autotest
   bundler (~> 1.0.0)
   flog
   jeweler (~> 1.5.2)
-  rcov
   reek
-  rspec (~> 2.3.0)
+  rspec (~> 2.5.0)

data/README.md

@@ -2,6 +2,7 @@ analdiffist
 ============
 
 A professional twice over: an analyst and a diffist.
+[http://www.youtube.com/watch?v=UrIpPqcln6Y](http://www.youtube.com/watch?v=UrIpPqcln6Y)
 
 analdiffist uses [flog](http://ruby.sadi.st/Flog.html) and [reek](https://github.com/kevinrutherford/reek/wiki) to analyze ruby code.
 Given two git refs (for example *master* and *feature-branch*), it will show you any differences in code metrics introduced between the refs.

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.2.0

data/analdiffist.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{analdiffist}
-  s.version = "0.1.1"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Adam Pearson", "Dave Foley"]
-  s.date = %q{2011-03-09}
+  s.date = %q{2011-04-08}
   s.default_executable = %q{analdiffist}
   s.description = %q{A tool for comparing the complexity and code smells between two git revisions}
   s.email = %q{davidmfoley@gmail.com}
@@ -29,6 +29,22 @@ Gem::Specification.new do |s|
     "VERSION",
     "analdiffist.gemspec",
     "bin/analdiffist",
+    "lib/anal_diffist.rb",
+    "lib/analdiffist/diff_set.rb",
+    "lib/analdiffist/flog_parser.rb",
+    "lib/analdiffist/reek_metrics.rb",
+    "lib/analdiffist/reek_parser.rb",
+    "lib/analdiffist/standard_diffist.rb",
+    "lib/analdiffist/target_finder.rb",
+    "lib/analdiffist/text_based_diffist.rb",
+    "spec/fixtures/other_smelly_file.rb",
+    "spec/fixtures/smelly_file.rb",
+    "spec/lib/analdiffist/diff_set_spec.rb",
+    "spec/lib/analdiffist/flog_parser_spec.rb",
+    "spec/lib/analdiffist/reek_metrics_spec.rb",
+    "spec/lib/analdiffist/reek_parser_spec.rb",
+    "spec/lib/analdiffist/standard_diffist_spec.rb",
+    "spec/lib/analdiffist/target_finder_spec.rb",
     "spec/spec_helper.rb"
   ]
   s.homepage = %q{http://github.com/radamant/analdiffist}
@@ -37,6 +53,14 @@ Gem::Specification.new do |s|
   s.rubygems_version = %q{1.5.2}
   s.summary = %q{A professional twice over: an analyst and a diffist.}
   s.test_files = [
+    "spec/fixtures/other_smelly_file.rb",
+    "spec/fixtures/smelly_file.rb",
+    "spec/lib/analdiffist/diff_set_spec.rb",
+    "spec/lib/analdiffist/flog_parser_spec.rb",
+    "spec/lib/analdiffist/reek_metrics_spec.rb",
+    "spec/lib/analdiffist/reek_parser_spec.rb",
+    "spec/lib/analdiffist/standard_diffist_spec.rb",
+    "spec/lib/analdiffist/target_finder_spec.rb",
     "spec/spec_helper.rb"
   ]
 
@@ -46,25 +70,25 @@ Gem::Specification.new do |s|
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<reek>, [">= 0"])
       s.add_runtime_dependency(%q<flog>, [">= 0"])
-      s.add_development_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.5.0"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
-      s.add_development_dependency(%q<rcov>, [">= 0"])
+      s.add_development_dependency(%q<autotest>, [">= 0"])
     else
       s.add_dependency(%q<reek>, [">= 0"])
       s.add_dependency(%q<flog>, [">= 0"])
-      s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_dependency(%q<rspec>, ["~> 2.5.0"])
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
-      s.add_dependency(%q<rcov>, [">= 0"])
+      s.add_dependency(%q<autotest>, [">= 0"])
     end
   else
     s.add_dependency(%q<reek>, [">= 0"])
     s.add_dependency(%q<flog>, [">= 0"])
-    s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+    s.add_dependency(%q<rspec>, ["~> 2.5.0"])
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
-    s.add_dependency(%q<rcov>, [">= 0"])
+    s.add_dependency(%q<autotest>, [">= 0"])
   end
 end
 

data/bin/analdiffist

@@ -1,94 +1,7 @@
 #! /usr/bin/env ruby
 
-require 'tmpdir'
+require 'anal_diffist'
 
-def main
-  current_branch = get_current_branch
-  puts "current branch: #{current_branch}"
-  stashed = try_to_stash
-
-  ref = get_refs_to_diff current_branch
-
-  file_1 = analyze_ref(ref[0])
-  file_2 = analyze_ref(ref[1])
-
-  begin
-    echo_exec "git checkout #{current_branch}" if current_branch != ref[1]
-  rescue Exception
-  end
-
-  if stashed
-    echo "unstashing"
-    echo_exec "git stash apply"
-  end
-
-  diff file_1, file_2
-end
-
-def get_current_branch
-  current_branch_raw = echo_exec "git branch --no-color"
-  lines = current_branch_raw.split("\n")
-  current_branch_line = lines.detect{|x| x[0] == '*'}
-  current_branch = current_branch_line.split(' ')[1]
-end
-
-def get_refs_to_diff current_branch
-  [ ARGV[0] || "origin/master", ARGV[1] || current_branch]
-end
-
-def analyze_ref ref_name
-  file = get_file_name ref_name
-  begin
-    echo_exec "git checkout #{ref_name}"
-    do_analytics file, ref_name
-  rescue Exception
-  end
-
-  file
-end
-
-def get_file_name ref_name
-
-  File.join(Dir.tmpdir, "#{ref_name.gsub('/', '_')}-analytics.txt")
-end
-
-def do_analytics dest_filename, ref_name
-  puts 'writing analytics to ' + dest_filename
-  reek_result = `reek -q app lib`
-  flog_result = `flog -g app lib`
-  File.open(dest_filename, 'w') do |f|
-    f.write"--- Analytics for #{ref_name} ---\n\n"
-
-    f.write"\n\n--- FLOG ---\n\n"
-    f.write clean_up_flog(flog_result)
-
-    f.write"\n\n--- REEK ---\n\n"
-    f.write reek_result
-  end
-end
-
-def clean_up_flog(flog_result)
-  flog_result.gsub(/:[0-9]+$/, '')
-end
-
-def echo s
-  puts s
-end
-
-def echo_exec command
-  puts command
-  result = `#{command}`
-  puts result
-  result
-end
-
-def try_to_stash
-  result = echo_exec "git stash"
-  !(result =~ /No local changes to save/)
-end
-
-def diff f1, f2
-  echo_exec "git diff --color=always -U0 -- '#{f1}' '#{f2}'"
-end
-
-main
+start_ref = ARGV[0]
+end_ref = ARGV[1]
+AnalDiffist::Anal.new.run(start_ref, end_ref)

data/lib/anal_diffist.rb

@@ -0,0 +1,79 @@
+module AnalDiffist
+  require 'analdiffist/target_finder'
+  require 'analdiffist/reek_metrics'
+  require 'analdiffist/reek_parser'
+  require 'analdiffist/flog_parser'
+  require 'analdiffist/diff_set'
+  require 'analdiffist/text_based_diffist'
+  require 'analdiffist/standard_diffist'
+
+  class Diffist
+  end
+
+  require 'tmpdir'
+  class Anal < Diffist
+    def initialize
+      @diffist = AnalDiffist::StandardDiffist.new
+    end
+
+    def run(start_ref, end_ref)
+      current_branch = get_current_branch
+      stashed = try_to_stash
+
+      ref = get_refs_to_diff current_branch, start_ref, end_ref
+      puts "\nAnaldiffizing: #{ref.join(" -> ")}"
+      analyze_ref(ref[0])
+      analyze_ref(ref[1])
+
+      begin
+        if current_branch != ref[1]
+          puts "  checking out original revision: #{current_branch}"
+          checkout_revision current_branch
+        end
+      rescue Exception
+      end
+
+      if stashed
+        puts "unstashing"
+        `git stash apply`
+      end
+
+      @diffist.report_results
+    end
+
+    def get_current_branch
+      current_branch_raw = `git branch --no-color`
+      lines = current_branch_raw.split("\n")
+      current_branch_line = lines.detect{|x| x[0] == '*'}
+      current_branch = current_branch_line.split(' ')[1]
+    end
+
+    def get_refs_to_diff current_branch, start_ref, end_ref
+      [ start_ref || "origin/master", end_ref || current_branch]
+    end
+
+    def analyze_ref ref_name
+      begin
+        checkout_revision ref_name
+        puts "  analyzing revision: #{ref_name}"
+        @diffist.do_analytics ref_name
+      rescue Exception
+        puts "Error in analyze_ref: " + $!.to_s
+      end
+
+    end
+
+    def checkout_revision ref_name
+        puts "  checking out revision: #{ref_name}"
+        `git checkout -q #{ref_name}`
+    end
+
+    def try_to_stash
+      result =  `git stash`
+      stashed = !(result =~ /No local changes to save/)
+      puts "stashed local uncommitted changes" if stashed
+      stashed
+    end
+
+  end
+end

data/lib/analdiffist/diff_set.rb

@@ -0,0 +1,30 @@
+module AnalDiffist
+  class DiffSet
+    def initialize before, after
+      @before = before
+      @after = after
+    end
+
+    def added_problems
+      compare(@after, @before)
+    end
+
+    def removed_problems
+      compare(@before, @after)
+    end
+
+    private
+    def compare(a,b)
+      #TODO: move this comparison into the class?
+      a.map do |problem| 
+        matching_problem = b.detect {|problem2| [problem.type, problem.context] == [problem2.type, problem2.context] }
+
+          problem.diff(matching_problem)
+
+      end.reject {|x| x.nil?}
+    end
+  end
+
+  class ScoreDiffSet
+  end
+end

data/lib/analdiffist/flog_parser.rb

@@ -0,0 +1,55 @@
+require 'flog'
+module AnalDiffist
+  class FlogParser
+    def initialize paths, threshold = 10.0
+      @paths = paths
+      @flog_threshold = threshold
+    end
+
+    def problems
+      f = Flog.new
+      f.flog(@paths)
+      problems = []
+      f.each_by_score{|class_method, score, ignore_for_now| problems << FlogProblem.new(class_method, score)}
+      problems.select {|p| p.score >= @flog_threshold}
+    end
+  end
+
+  class FlogProblem
+    attr_accessor :context, :score
+    def initialize class_method, score
+      @context = class_method || '(none)'
+      @score = score
+    end
+
+    def type
+      'flog score'
+    end
+
+    def diff other
+      return self if other.nil?
+      return nil if other.score >= score
+      FlogDiff.new(@context, other.score, score)
+    end
+
+    def description
+      "Flog score: #{score}"
+    end
+  end
+  class FlogDiff
+    attr_accessor :context, :score
+    def initialize context, previous_score, current_score
+      @context = context
+      @current_score = current_score
+      @previous_score = previous_score
+    end
+
+    def score
+      (@current_score - @previous_score).round(1)
+    end
+
+    def description
+      "Flog: #{@current_score.round(1)} (+#{(@current_score - @previous_score).round(1)})"
+    end
+  end
+end

data/lib/analdiffist/reek_metrics.rb

@@ -0,0 +1,4 @@
+module AnalDiffist
+  class ReekMetrics
+  end
+end

data/lib/analdiffist/reek_parser.rb

@@ -0,0 +1,39 @@
+require 'reek'
+module AnalDiffist
+  class ReekParser
+    attr_accessor :problems
+
+    def initialize(paths)
+      examiner = Reek::Examiner.new(paths)
+      @problems = examiner.smells.map {|smell| ReekProblem.new(smell)}
+    end
+
+    def diff(previous)
+      AnalDiffist::DiffSet.new(previous.problems, self.problems)
+    end
+  end
+
+  class ReekProblem
+    def initialize smell
+      @smell = smell
+    end
+
+    def type
+      @smell.subclass.to_s || ''
+    end
+
+    def context
+      @smell.location["context"]
+    end
+
+    def diff other
+      self if other.nil?
+    end
+    def score
+      1
+    end
+    def description
+      "Reek: #{type}"
+    end
+  end
+end

data/lib/analdiffist/standard_diffist.rb

@@ -0,0 +1,64 @@
+module AnalDiffist
+  class StandardDiffist
+    def initialize options = {}
+      @targets = options[:targets] || AnalDiffist::TargetFinder.new
+      @reporter = options[:reporter] || AnalDiffist::StdOutReporter.new
+      @parsers = options[:parsers] || [FlogParser, ReekParser]
+
+      @revisions = []
+    end
+
+    def do_analytics name
+      #puts 'analyzing ' + name
+      #puts @revisions.inspect
+      @revisions << ProblemSet.new(name, @parsers, @targets)
+      #puts @revisions.inspect
+    end
+
+    def report_results
+      #puts @revisions.inspect
+      before = @revisions[0]
+      after = @revisions[1]
+      diff = DiffSet.new(before.problems, after.problems)
+
+      @reporter.report(diff, before.name, after.name)
+
+    end
+
+    private
+
+    class ProblemSet
+      attr_accessor :problems, :name
+      def initialize name, parsers, targets
+        @name = name
+        @problems = []
+        parsers.each do |parser|
+          parser_instance = parser.new(targets.targets)
+          problems = parser_instance.problems
+          @problems += (problems || [])
+        end
+      end
+    end
+  end
+
+  class StdOutReporter
+    def report diff, from_rev, to_rev
+      puts "\n\nAnaldifference between revisions: \n #{from_rev}\n #{to_rev}"
+      puts "\nAdded:\n"
+      puts describe(diff.added_problems)
+      puts "\nRemoved:\n"
+      puts describe(diff.removed_problems)
+      puts "\n\n"
+    end
+
+    def describe(problems)
+      by_context = problems.group_by {|prob| prob.context}
+      results = []
+      by_context.keys.sort.each do |k|  
+        results << "  #{k}"
+        results << by_context[k].map {|p| "    #{p.description}"}.join("\n")
+      end.collect
+      results.join("\n")
+    end
+  end
+end

data/lib/analdiffist/target_finder.rb

@@ -0,0 +1,17 @@
+module AnalDiffist
+  class TargetFinder
+    def initialize
+    end
+    def targets
+      @targets = []
+      @targets << "lib" if Dir.exists?("lib")
+      @targets << "app" if Dir.exists?("app")
+      @targets
+    end
+
+    def to_s
+      targets.join(' ')
+    end
+
+  end
+end

data/lib/analdiffist/text_based_diffist.rb

@@ -0,0 +1,46 @@
+
+module AnalDiffist
+  class TextBasedDiffist
+    def initialize
+      @targets = AnalDiffist::TargetFinder.new
+      @files = []
+    end
+    def report_results
+      puts 'results:'
+      diff @files[0], @files[1]
+    end
+
+    def do_analytics ref_name
+      dest_filename = get_file_name ref_name
+
+      puts
+      puts 'collecting reek'
+      reek_result = `reek -q #{@targets}`
+      puts 'collecting flog'
+      flog_result = `flog -g #{@targets}`
+      File.open(dest_filename, 'w') do |f|
+        puts 'writing analytics to ' + dest_filename
+        f.write"--- Analytics for #{ref_name} ---\n\n"
+
+        f.write"\n\n--- FLOG ---\n\n"
+        f.write clean_up_flog(flog_result)
+
+        f.write"\n\n--- REEK ---\n\n"
+        f.write reek_result
+      end
+
+      @files << dest_filename
+    end
+
+    def get_file_name ref_name
+      File.join(Dir.tmpdir, "#{ref_name.gsub('/', '_')}-analytics.txt")
+    end
+
+    def clean_up_flog(flog_result)
+      flog_result.gsub(/:[0-9]+$/, '')
+    end
+    def diff f1, f2
+      puts `git diff --color=always -U0 -- '#{f1}' '#{f2}'`
+    end
+  end
+end

data/spec/fixtures/other_smelly_file.rb

@@ -0,0 +1,16 @@
+class SmellyFile
+  def self.class_variable
+    @@class_variable = 42
+  end
+
+  def duplication
+    if some_method
+      some_method
+    end
+
+    some_method
+  end
+
+  def some_method
+  end
+end

data/spec/fixtures/smelly_file.rb

@@ -0,0 +1,16 @@
+class SmellyFile
+  def self.class_variable
+    @@class_variable = 42
+  end
+
+  def duplication
+    if some_method
+      some_method
+    end
+
+    some_method
+  end
+
+  def some_method
+  end
+end

data/spec/lib/analdiffist/diff_set_spec.rb

@@ -0,0 +1,83 @@
+require  'spec_helper'
+
+describe 'diffing two files' do
+  context 'single problem added' do
+    before do
+      @diff = AnalDiffist::DiffSet.new([], [test_problem('foo', 'bar')])
+    end
+    it 'should find a new reek' do
+      added_problems = @diff.added_problems
+      added_problems.length.should == 1
+      added_problems.first.type.should == 'foo'
+      added_problems.first.context == 'bar'
+    end
+    it 'should not have any removed reeks' do
+      @diff.removed_problems.should == []
+    end
+  end
+
+  context 'single problem removed' do
+    before do
+      @diff = AnalDiffist::DiffSet.new( [test_problem('foo', 'bar')], [])
+    end
+    it 'should find a removed reek' do
+      removed_problems = @diff.removed_problems
+      removed_problems.length.should == 1
+      removed_problems.first.type.should == 'foo'
+      removed_problems.first.context == 'bar'
+    end
+    it 'should not have any added reeks' do
+      @diff.added_problems.should == []
+    end
+  end
+
+  context 'one removed, one added, one remains' do
+    before do
+      before = [test_problem('foo', 'bar'), test_problem('removed', 'removed')]
+      after = [test_problem('foo', 'bar'), test_problem('added', 'added')]
+      @diff = AnalDiffist::DiffSet.new(before, after)
+    end
+
+    it 'should find a removed reek' do
+      removed_problems = @diff.removed_problems
+      removed_problems.length.should == 1
+      removed_problems.first.type.should == 'removed'
+      removed_problems.first.context == 'removed'
+    end
+
+    it 'should find an added problem' do
+      added_problems = @diff.added_problems
+      added_problems.length.should == 1
+      added_problems.first.type.should == 'added'
+      added_problems.first.context == 'added'
+    end
+  end
+
+  context 'when scores change' do
+    before do
+      before = [AnalDiffist::FlogProblem.new('bar', 7.1)]
+      after = [AnalDiffist::FlogProblem.new('bar', 8.5)]
+      @diff = AnalDiffist::DiffSet.new(before, after)
+    end
+
+    it 'should identify as added' do
+      added_problems = @diff.added_problems
+      added_problems.length.should == 1
+      added_problems.first.score.round(1).should == 1.4
+    end
+  end
+
+  def test_problem type, context, score = 1
+    smell = double("fake problem")
+    smell.stub(:subclass) {type}
+    smell.stub(:location) {context}
+    return AnalDiffist::ReekProblem.new(smell)
+
+    double('fake problem').tap do |p|
+      p.stub(:type) {type}
+      p.stub(:context) {context}
+      p.stub(:score) {score}
+      p.stub(:diff) {p}
+    end
+  end
+end

data/spec/lib/analdiffist/flog_parser_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe AnalDiffist::FlogParser do
+  context 'analyzing a class' do
+    before do
+      file_parser = get_parser_for('smelly_file.rb')
+      @problems = file_parser.problems
+    end
+    def get_parser_for(fixture_file)
+      file_name = File.join(File.dirname(__FILE__), '../../fixtures/', fixture_file)
+      AnalDiffist::FlogParser.new(file_name, 1.0)
+    end
+    it 'should have an entry for the test method with a non zero score' do
+      duplication = @problems.detect {|p| p.context == 'SmellyFile#duplication'}
+      duplication.score.should > 0
+    end
+  end
+end

data/spec/lib/analdiffist/reek_metrics_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+
+describe AnalDiffist::ReekMetrics do
+end

data/spec/lib/analdiffist/reek_parser_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe AnalDiffist::ReekParser do
+  context 'a smelly file' do
+    before do
+      smelly_file_parser = get_parser_for('smelly_file.rb')
+      @problems = smelly_file_parser.problems
+    end
+
+    it 'has a duplication warning for the duplication method' do
+      smells = get_smells_for('SmellyFile#duplication')
+      smells[0].type.should == 'DuplicateMethodCall'
+    end
+
+    it 'should have some results' do
+      @problems.length.should > 0
+    end
+
+    it 'creates a diff' do
+      smelly_file_parser = get_parser_for('smelly_file.rb')
+      other_smelly_file_parser = get_parser_for('other_smelly_file.rb')
+      diff = smelly_file_parser.diff(other_smelly_file_parser)
+      diff.should be
+    end
+
+    def get_smells_for context
+      @problems.select {|reek| reek.context == context}
+    end
+  end
+
+  def get_parser_for(fixture_file)
+    file_name = File.join(File.dirname(__FILE__), '../../fixtures/', fixture_file)
+    AnalDiffist::ReekParser.new([file_name])
+  end
+end

data/spec/lib/analdiffist/standard_diffist_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe AnalDiffist::StandardDiffist do
+  class FakeParser
+    def problems
+      []
+    end
+  end
+
+  it 'should work' do
+    @diffist = AnalDiffist::StandardDiffist.new :parsers => [FakeParser]
+    @diffist.do_analytics('foo')
+    @diffist.do_analytics('bar')
+  end
+
+  it 'should work!' do
+    @diffist = AnalDiffist::StandardDiffist.new
+    @diffist.do_analytics('foo')
+    @diffist.do_analytics('bar')
+  end
+end

data/spec/lib/analdiffist/target_finder_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe AnalDiffist::TargetFinder do
+  describe "#targets" do
+
+    before { Dir.stub(:exists?){false} }
+
+    subject { AnalDiffist::TargetFinder.new.targets }
+
+    context 'when ./lib exists' do
+      before { Dir.stub(:exists?).with('lib'){true} }
+      it{should include("lib")}
+    end
+
+    context 'when ./app exists' do
+      before { Dir.stub(:exists?).with('app'){true} }
+      it{should include("app")}
+    end
+
+  end
+
+  describe "#to_s" do
+    subject do
+      atf = AnalDiffist::TargetFinder.new.tap do |t|
+        t.stub(:targets){['analyst', 'therapist']}
+      end
+      atf.to_s
+    end
+
+    it{ should == "analyst therapist"}
+  end
+end

data/spec/spec_helper.rb

@@ -1,8 +1,7 @@
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'rspec'
-require 'analdiffist'
-
+require 'anal_diffist'
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}

metadata

@@ -2,7 +2,7 @@
 name: analdiffist
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors: 
 - Adam Pearson
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-09 00:00:00 -08:00
+date: 2011-04-08 00:00:00 -07:00
 default_executable: analdiffist
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -43,7 +43,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 2.3.0
+        version: 2.5.0
   type: :development
   prerelease: false
   version_requirements: *id003
@@ -70,7 +70,7 @@ dependencies:
   prerelease: false
   version_requirements: *id005
 - !ruby/object:Gem::Dependency 
-  name: rcov
+  name: autotest
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -100,6 +100,22 @@ files:
 - VERSION
 - analdiffist.gemspec
 - bin/analdiffist
+- lib/anal_diffist.rb
+- lib/analdiffist/diff_set.rb
+- lib/analdiffist/flog_parser.rb
+- lib/analdiffist/reek_metrics.rb
+- lib/analdiffist/reek_parser.rb
+- lib/analdiffist/standard_diffist.rb
+- lib/analdiffist/target_finder.rb
+- lib/analdiffist/text_based_diffist.rb
+- spec/fixtures/other_smelly_file.rb
+- spec/fixtures/smelly_file.rb
+- spec/lib/analdiffist/diff_set_spec.rb
+- spec/lib/analdiffist/flog_parser_spec.rb
+- spec/lib/analdiffist/reek_metrics_spec.rb
+- spec/lib/analdiffist/reek_parser_spec.rb
+- spec/lib/analdiffist/standard_diffist_spec.rb
+- spec/lib/analdiffist/target_finder_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
 homepage: http://github.com/radamant/analdiffist
@@ -115,7 +131,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 2617333102341510059
+      hash: -4153762444283860543
       segments: 
       - 0
       version: "0"
@@ -133,4 +149,12 @@ signing_key:
 specification_version: 3
 summary: "A professional twice over: an analyst and a diffist."
 test_files: 
+- spec/fixtures/other_smelly_file.rb
+- spec/fixtures/smelly_file.rb
+- spec/lib/analdiffist/diff_set_spec.rb
+- spec/lib/analdiffist/flog_parser_spec.rb
+- spec/lib/analdiffist/reek_metrics_spec.rb
+- spec/lib/analdiffist/reek_parser_spec.rb
+- spec/lib/analdiffist/standard_diffist_spec.rb
+- spec/lib/analdiffist/target_finder_spec.rb
 - spec/spec_helper.rb