amsi 1.0.1 → 1.1.0

data/lib/amsi/model/base.rb

@@ -49,11 +49,12 @@ module Amsi
       #
       # @param attrs [Hash<String, Object>] the response hash from AMSI.
       #   Attribute keys are case insensitive.
-      def initialize(attrs = {})
+      def initialize(attrs = {}, timezone = nil)
         attrs.each do |attr, value|
           attribute = self.class.attribute_store.find(attr)
           next unless attribute
-          parser = AttributeParser.new(value: value, type: attribute.type)
+
+          parser = AttributeParser.new(value: value, type: attribute.type, timezone: timezone)
           instance_variable_set("@#{attribute.name}", parser.parse)
         end
       end

data/lib/amsi/model/guest_card.rb

@@ -12,7 +12,7 @@ module Amsi
 
       date_time_attrs :create_date
 
-      alias :id :guest_card_id
+      alias id guest_card_id
     end
   end
 end

data/lib/amsi/model/guest_card_result.rb

@@ -8,15 +8,15 @@ module Amsi
         SUCCESS = 'SUCCESS'.freeze
       end
 
-      string_attrs *%i[
-        guest_card_id
-        property_id
-        status
-      ]
+      string_attrs(*%i[
+                     guest_card_id
+                     property_id
+                     status
+                   ])
 
       integer_attrs :contact_seq_no
 
-      alias_method :contact_sequence_number, :contact_seq_no
+      alias contact_sequence_number contact_seq_no
 
       def success?
         status == Status::SUCCESS

data/lib/amsi/model/lease.rb

@@ -15,44 +15,42 @@ module Amsi
         CANCELLED = 'X'.freeze
       end
 
-      date_attrs *%i[
-        application_date
-        lease_begin_date
-        lease_end_date
-        lease_sign_date
-        move_in_date
-       ]
-
-      string_attrs *%i[
-        bldg_id
-        external_reference_id
-        occu_status_code
-        occu_status_code_description
-        property_id
-        resi_id
-        unit_id
-        lease_marketing_source
-        guest_card_no
-      ]
+      date_attrs(*%i[
+                   application_date
+                   lease_begin_date
+                   lease_end_date
+                   lease_sign_date
+                   move_in_date
+                 ])
+
+      string_attrs(*%i[
+                     bldg_id
+                     external_reference_id
+                     occu_status_code
+                     occu_status_code_description
+                     property_id
+                     resi_id
+                     unit_id
+                     lease_marketing_source
+                     guest_card_no
+                   ])
 
       decimal_attrs :rent_amount
 
       date_time_attrs :guest_first_contact_date
 
-      alias_method :begin_date, :lease_begin_date
-      alias_method :end_date, :lease_end_date
-      alias_method :sign_date, :lease_sign_date
-      alias_method :lead_id, :guest_card_no
-      alias_method :lead_date, :guest_first_contact_date
-      alias_method :lead_source_code, :lease_marketing_source
-      alias_method :building_id, :bldg_id
-      alias_method :resident_id, :resi_id
-      alias_method :occupant_status_code, :occu_status_code
-      alias_method :occupant_status_code_description,
-                   :occu_status_code_description
-
-      attr_accessor :occupants
-      attr_accessor :guest_card
+      alias begin_date lease_begin_date
+      alias end_date lease_end_date
+      alias sign_date lease_sign_date
+      alias lead_id guest_card_no
+      alias lead_date guest_first_contact_date
+      alias lead_source_code lease_marketing_source
+      alias building_id bldg_id
+      alias resident_id resi_id
+      alias occupant_status_code occu_status_code
+      alias occupant_status_code_description occu_status_code_description
+
+      attr_accessor :occupants, :guest_card
       attr_writer :matched_guest_cards
 
       def matched_guest_cards

data/lib/amsi/model/leasing_agent.rb

@@ -3,15 +3,15 @@ require_relative 'base'
 module Amsi
   module Model
     class LeasingAgent < Base
-      string_attrs *%i[
-        agent_active_flag
-        agent_code
-        agent_name
-        property_id
-      ]
+      string_attrs(*%i[
+                     agent_active_flag
+                     agent_code
+                     agent_name
+                     property_id
+                   ])
 
-      alias_method :code, :agent_code
-      alias_method :name, :agent_name
+      alias code agent_code
+      alias name agent_name
 
       def active?
         agent_active_flag == 'Y'

data/lib/amsi/model/manager.rb

@@ -3,14 +3,14 @@ require_relative 'base'
 module Amsi
   module Model
     class Manager < Base
-      string_attrs *%i[
-        fax
-        first_name
-        last_name
-        middle_name
-        phone
-        salutation
-      ]
+      string_attrs(*%i[
+                     fax
+                     first_name
+                     last_name
+                     middle_name
+                     phone
+                     salutation
+                   ])
     end
   end
 end

data/lib/amsi/model/marketing_source.rb

@@ -3,15 +3,15 @@ require_relative 'base'
 module Amsi
   module Model
     class MarketingSource < Base
-      string_attrs *%i[
-        property_id
-        source_code
-        source_desc
-        source_active_flag
-      ]
+      string_attrs(*%i[
+                     property_id
+                     source_code
+                     source_desc
+                     source_active_flag
+                   ])
 
-      alias_method :code, :source_code
-      alias_method :description, :source_desc
+      alias code source_code
+      alias description source_desc
 
       def active?
         source_active_flag == 'Y'

data/lib/amsi/model/occupant.rb

@@ -3,30 +3,30 @@ require_relative 'base'
 module Amsi
   module Model
     class Occupant < Base
-      string_attrs *%i[
-        bldg_id
-        email
-        external_reference_id
-        occu_first_name
-        occu_last_name
-        occu_seq_no
-        phone_1_no
-        phone_2_no
-        property_id
-        resi_id
-        responsible_flag
-        unit_id
-      ]
+      string_attrs(*%i[
+                     bldg_id
+                     email
+                     external_reference_id
+                     occu_first_name
+                     occu_last_name
+                     occu_seq_no
+                     phone_1_no
+                     phone_2_no
+                     property_id
+                     resi_id
+                     responsible_flag
+                     unit_id
+                   ])
 
       decimal_attrs :rent_amount
 
-      alias_method :building_id, :bldg_id
-      alias_method :resident_id, :resi_id
-      alias_method :sequence_number, :occu_seq_no
-      alias_method :first_name, :occu_first_name
-      alias_method :last_name, :occu_last_name
-      alias_method :phone_1, :phone_1_no
-      alias_method :phone_2, :phone_2_no
+      alias building_id bldg_id
+      alias resident_id resi_id
+      alias sequence_number occu_seq_no
+      alias first_name occu_first_name
+      alias last_name occu_last_name
+      alias phone_1 phone_1_no
+      alias phone_2 phone_2_no
     end
   end
 end

data/lib/amsi/model/property.rb

@@ -5,27 +5,27 @@ module Amsi
     class Property < Base
       date_attrs :live_date
 
-      string_attrs *%i[
-        property_id
-        property_name_1
-        property_name_2
-        property_addr_email
-        live_flag
-      ]
+      string_attrs(*%i[
+                     property_id
+                     property_name_1
+                     property_name_2
+                     property_addr_email
+                     live_flag
+                   ])
 
-      attr_accessor *%i[
-        address
-        leasing_agents
-        manager
-        marketing_sources
-        remit_to_address
-        unit_types
-      ]
+      attr_accessor(*%i[
+                      address
+                      leasing_agents
+                      manager
+                      marketing_sources
+                      remit_to_address
+                      unit_types
+                    ])
 
-      alias_method :email, :property_addr_email
-      alias_method :id, :property_id
-      alias_method :name, :property_name_1
-      alias_method :name_2, :property_name_2
+      alias email property_addr_email
+      alias id property_id
+      alias name property_name_1
+      alias name_2 property_name_2
 
       def live?
         live_flag == 'Y'

data/lib/amsi/model/unit_type.rb

@@ -3,36 +3,36 @@ require_relative 'base'
 module Amsi
   module Model
     class UnitType < Base
-      decimal_attrs *%i[
-        baths
-        market_rent
-        sec_min
-        standard_renew
-        mtm_renew
-        other_renew
-      ]
+      decimal_attrs(*%i[
+                      baths
+                      market_rent
+                      sec_min
+                      standard_renew
+                      mtm_renew
+                      other_renew
+                    ])
 
-      integer_attrs *%i[
-        bedrooms
-        rooms
-        sqftg
-        unit_type_count
-      ]
+      integer_attrs(*%i[
+                      bedrooms
+                      rooms
+                      sqftg
+                      unit_type_count
+                    ])
 
-      string_attrs *%i[
-        property_id
-        unit_subtype
-        unit_type
-        unit_type_desc
-      ]
+      string_attrs(*%i[
+                     property_id
+                     unit_subtype
+                     unit_type
+                     unit_type_desc
+                   ])
 
-      alias_method :count, :unit_type_count
-      alias_method :description, :unit_type_desc
-      alias_method :minimum_security_deposit, :sec_min
-      alias_method :month_to_month_renew, :mtm_renew
-      alias_method :sqft, :sqftg
-      alias_method :subtype, :unit_subtype
-      alias_method :type, :unit_type
+      alias count unit_type_count
+      alias description unit_type_desc
+      alias minimum_security_deposit sec_min
+      alias month_to_month_renew mtm_renew
+      alias sqft sqftg
+      alias subtype unit_subtype
+      alias type unit_type
     end
   end
 end

data/lib/amsi/parameter/prospect.rb

@@ -4,10 +4,9 @@ module Amsi
       attr_reader :daytime_phone, :email, :first_name, :last_name
 
       def initialize(
-        daytime_phone: nil,
+        last_name:, daytime_phone: nil,
         email: nil,
-        first_name: nil,
-        last_name:
+        first_name: nil
       )
         @daytime_phone = daytime_phone
         @email = email

data/lib/amsi/request/add_guest_card.rb

@@ -16,16 +16,13 @@ module Amsi
     # @see request/base.rb for additional params required by every request.
     class AddGuestCard < Base
       def after_initialize(
-        appointment_date: nil,
+        contact_type:, property_id:, prospect:, appointment_date: nil,
         comments: nil,
         contact_datetime: nil,
-        contact_type:,
         date_needed: nil,
         initial_source_id: nil,
         lease_term_desired: nil,
         leasing_agent_id: nil,
-        property_id:,
-        prospect:,
         qualified: nil,
         requirements: nil,
         unit_subtype: nil,

data/lib/amsi/request/get_property_residents.rb

@@ -16,7 +16,7 @@ module Amsi
     #   Valid values in: Amsi::Model::Lease::Status
     # @see request/base.rb for additional params required by every request.
     class GetPropertyResidents < Base
-      def after_initialize(property_id:, lease_status:, include_marketing_source: false, params:)
+      def after_initialize(property_id:, lease_status:, params:, include_marketing_source: false)
         @property_id = property_id
         @lease_status = lease_status
         @include_marketing_source = include_marketing_source

data/lib/amsi/request_section/add_guest_card.rb

@@ -7,16 +7,13 @@ module Amsi
       private_constant :DATE_FORMAT
 
       def initialize(
-        appointment_date: nil,
+        contact_type:, property_id:, prospect:, appointment_date: nil,
         comments: nil,
         contact_datetime: nil,
-        contact_type:,
         date_needed: nil,
         initial_source_id: nil,
         lease_term_desired: nil,
         leasing_agent_id: nil,
-        property_id:,
-        prospect:,
         requirements: nil,
         qualified: nil,
         unit_subtype: nil,
@@ -81,9 +78,11 @@ module Amsi
             edex.unitsubtype(unit_subtype) if unit_subtype
             edex.leasingagentid(leasing_agent_id) if leasing_agent_id
             edex.requirements(requirements) if requirements
-            edex.comments do |comments_xml|
-              comments_xml.comment_(comments, date: format_date(Date.today))
-            end if comments
+            if comments
+              edex.comments do |comments_xml|
+                comments_xml.comment_(comments, date: format_date(Date.today))
+              end
+            end
           end
         end.doc.root
       end

data/lib/amsi/request_section/property_list_filter.rb

@@ -3,11 +3,11 @@ module Amsi
     # Generate the property list filter elements of an AMSI request
     class PropertyListFilter
       def initialize(
-          include_leasing_agents: false,
-          include_marketing_sources: false,
-          include_unit_types: false,
-          property_id: nil
-        )
+        include_leasing_agents: false,
+        include_marketing_sources: false,
+        include_unit_types: false,
+        property_id: nil
+      )
         @include_leasing_agents = include_leasing_agents
         @include_marketing_sources = include_marketing_sources
         @include_unit_types = include_unit_types

data/lib/amsi/utils/snowflake_event_tracker.rb

@@ -7,21 +7,17 @@ module Amsi
       IMPORT_PMS_PROSPECT_EVENT = 'import_pms_prospect'
 
       def self.track_pms_resident_event(
-          remote_lease_id: nil,
-          import_resident_id:,
-          resident_type:,
-          request_params:,
-          move_in_date: nil,
-          lease_to: nil,
-          lease_from: nil,
-          first_name_present: false,
-          last_name_present: false,
-          email_present: false,
-          phones_count: 0,
-          unit_name:,
-          resident_id: nil,
-          error: nil
-        )
+        import_resident_id:, resident_type:, request_params:, unit_name:, remote_lease_id: nil,
+        move_in_date: nil,
+        lease_to: nil,
+        lease_from: nil,
+        first_name_present: false,
+        last_name_present: false,
+        email_present: false,
+        phones_count: 0,
+        resident_id: nil,
+        error: nil
+      )
         EventTracker.track_process_events(name: IMPORT_PMS_RESIDENT_EVENT) do |events|
           events.add_imported_event(
             EventTracker::ResourceFactory.build_pms_resident(
@@ -63,17 +59,12 @@ module Amsi
       end
 
       def self.track_pms_prospect_event(
-          remote_lease_id: nil,
-          request_params:,
-          first_name_present:,
-          last_name_present:,
-          email_present:,
-          phone_present:,
-          contact_date: nil,
-          contact_source: nil,
-          remote_prospect_id: nil,
-          error: nil
-        )
+        request_params:, first_name_present:, last_name_present:, email_present:, phone_present:, remote_lease_id: nil,
+        contact_date: nil,
+        contact_source: nil,
+        remote_prospect_id: nil,
+        error: nil
+      )
         EventTracker.track_process_events(name: IMPORT_PMS_PROSPECT_EVENT) do |events|
           events.add_imported_event(
             EventTracker::ResourceFactory.build_pms_prospect(
@@ -97,7 +88,7 @@ module Amsi
                 first_name_present: first_name_present,
                 last_name_present: last_name_present,
                 email_present: email_present,
-                phone_present: phone_present,
+                phone_present: phone_present
               ),
               contact_date: contact_date,
               contact_source: contact_source,

data/lib/amsi/validator/base.rb

@@ -6,7 +6,7 @@ module Amsi
   module Validator
     class Base
       def send_pms_resident_event(lease:, params:, error_message: nil)
-        remote_lease_id, lease_to, lease_from = [ nil ] * 3
+        remote_lease_id, lease_to, lease_from = [nil] * 3
         if lease
           unit_name = lease.unit_id
           move_in_date = lease.move_in_date
@@ -18,7 +18,7 @@ module Amsi
           Utils::SnowflakeEventTracker.track_pms_resident_event(
             remote_lease_id: remote_lease_id,
             import_resident_id: import_resident_id(params),
-            resident_type: index == 0 ? 'PRIMARY': 'ROOMMATE',
+            resident_type: index == 0 ? 'PRIMARY' : 'ROOMMATE',
             request_params: pms_resident_request_params(params),
             move_in_date: move_in_date&.to_time,
             lease_to: lease_to,

data/lib/amsi/validator/prospect_event_validator.rb

@@ -4,12 +4,9 @@ require_relative 'base'
 module Amsi
   module Validator
     class ProspectEventValidator < Base
+      def initialize(response = nil); end
 
-      def initialize(response = nil)
-      end
-
-      def validate!
-      end
+      def validate!; end
 
       # Send parased response's individual prospect data to Snowflake via event tracker
       def send_event(lease, params)

data/lib/amsi/validator/request_errors.rb

@@ -26,7 +26,8 @@ module Amsi
       #   node in the contents
       def validate!
         return unless error?
-        raise Amsi::Error::BadRequest.new([error])
+
+        raise Amsi::Error::BadRequest, [error]
       end
 
       private

data/lib/amsi/validator/request_fault.rb

@@ -14,6 +14,7 @@ module Amsi
       # @raise [Amsi::Error::RequestFault] if the response has a fault
       def validate!
         return unless error?
+
         raise Error::RequestFault.new(error_message, fault_code, details)
       end
 
@@ -27,6 +28,7 @@ module Amsi
 
       def details
         return unless fault['detail']
+
         app_fault = fault['detail'].values.first
         FaultDetails.new(
           app_fault['CustomMessage'],
@@ -41,6 +43,7 @@ module Amsi
 
       def fault_code
         return unless fault
+
         code = fault['faultcode']
         code = code['__content__'] if code.is_a?(Hash)
         code.strip
@@ -48,6 +51,7 @@ module Amsi
 
       def error_message
         return unless fault
+
         fault_string = fault['faultstring']
         fault_string = fault_string['__content__'] if fault_string.is_a?(Hash)
         fault_string.strip

data/lib/amsi/validator/resident_event_validator.rb

@@ -4,12 +4,9 @@ require_relative 'base'
 module Amsi
   module Validator
     class ResidentEventValidator < Base
+      def initialize(response = nil); end
 
-      def initialize(response = nil)
-      end
-
-      def validate!
-      end
+      def validate!; end
 
       # Send parased response's individual resident data to Snowflake via event tracker
       def send_event(lease, params)

data/lib/amsi/version.rb

@@ -1,3 +1,3 @@
 module Amsi
-  VERSION = '1.0.1'
+  VERSION = '1.1.0'
 end

data/lib/amsi.rb

@@ -1,4 +1,4 @@
-require_relative '../config/multi_xml.rb'
+require_relative '../config/multi_xml'
 
 require 'amsi/error/bad_request'
 require 'amsi/error/invalid_response'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: amsi
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Justin Richard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-14 00:00:00.000000000 Z
+date: 2022-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -174,6 +174,8 @@ files:
 - ".ci"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - CHANGELOG.txt
 - CODEOWNERS
 - Gemfile