amqp 0.8.0.rc13 → 0.8.0.rc14

data/spec/integration/regressions/concurrent_publishing_on_the_same_channel_spec.rb

@@ -0,0 +1,91 @@
+# encoding: utf-8
+
+require "spec_helper"
+
+include PlatformDetection
+
+# Only run this for MRI.
+#
+# rubinius implementation of ThreadGroup has a bug: it references objects without checking
+# whether they are alive. So sandbox this test for other Rubies for now. Per discussion with
+# brixen in #travis, see also https://gist.github.com/1100572.
+#
+# JRuby is having weird CI issues, too. Still investigating them. MK.
+if mri?
+  describe "Concurrent publishing on a shared channel from multiple threads" do
+
+    #
+    # Environment
+    #
+
+    include EventedSpec::AMQPSpec
+    default_options AMQP_OPTS
+    default_timeout 15
+
+    amqp_before do
+      @channel   = AMQP::Channel.new
+      @channel.on_error do |ch, close|
+        raise "Channel-level error!: #{close.inspect}"
+      end
+      @channel.connection.on_error do |conn, connection_close|
+        raise "Handling a connection-level exception: #{connection_close.reply_text}"
+      end
+    end
+
+
+    let(:inputs) do
+      [
+        { :index=>{:_routing=>530,:_index=>"optimizer",:_type=>"earnings",:_id=>530}},
+        { :total_conversions=>0,:banked_clicks=>0,:total_earnings=>0,:pending_conversions=>0,:paid_net_earnings=>0,:banked_conversions=>0,:pending_earnings=>0,:optimizer_id=>530,:total_impressions=>0,:banked_earnings=>0,:bounce_count=>0,:time_on_page=>0,:total_clicks=>0,:entrances=>0,:pending_clicks=>0,:paid_earnings=>0},
+
+        { :index=>{:_routing=>430,:_index=>"optimizer",:_type=>"earnings",:_id=>430}},
+        { :total_conversions=>1443,:banked_clicks=>882,:total_earnings=>5796.3315841537,:pending_conversions=>22,:paid_net_earnings=>4116.90224486802,:banked_conversions=>1086,:pending_earnings=>257.502767857143,:optimizer_id=>430,:total_impressions=>6370497,:banked_earnings=>122.139339285714,:bounce_count=>6825,:time_on_page=>0,:total_clicks=>38143,:entrances=>12336,:pending_clicks=>1528,:paid_earnings=>5670.78224486798},
+
+        { :index=>{:_routing=>506,:_index=>"optimizer",:_type=>"earnings",:_id=>506}},
+        { :total_conversions=>237,:banked_clicks=>232,:total_earnings=>550.6212071428588277,:pending_conversions=>9,:paid_net_earnings=>388.021207142857,:banked_conversions=>225,:pending_earnings=>150.91,:optimizer_id=>506,:total_impressions=>348319,:banked_earnings=>12.92,:bounce_count=>905,:time_on_page=>0,:total_clicks=>4854,:entrances=>1614,:pending_clicks=>1034,:paid_earnings=>537.501207142858},
+
+        {:index=>{:_routing=>345,:_index=>"optimizer",:_type=>"earnings",:_id=>345}},
+        {:total_conversions=>0,:banked_clicks=>0,:total_earnings=>0,:pending_conversions=>0,:paid_net_earnings=>0,:banked_conversions=>0,:pending_earnings=>0,:optimizer_id=>345,:total_impressions=>0,:banked_earnings=>0,:bounce_count=>0,:time_on_page=>0,:total_clicks=>0,:entrances=>0,:pending_clicks=>0,:paid_earnings=>0}
+      ]
+    end
+    let(:messages) { inputs.map {|i| MultiJson.encode(i) } * 3 }
+
+
+
+    #
+    # Examples
+    #
+
+    it "DOES NOT result in frames being delivered out of order (no UNEXPECTED_FRAME connection exceptions)" do
+      received_messages = []
+      queue    = @channel.queue("amqpgem.tests.concurrent_publishing", :auto_delete => true)
+      exchange = @channel.default_exchange
+      exchange.on_return do |method, header, body|
+        raise "Message was returned: #{method.reply_text}"
+      end
+
+      queue.subscribe do |metadata, payload|
+        received_messages << payload
+      end
+
+      EventMachine.add_timer(2.0) do
+        # ZOMG THREADS!
+        20.times do
+          Thread.new do
+            messages.each do |message|
+              exchange.publish(message, :routing_key => queue.name, :immediate => true, :mandatory => true)
+            end
+          end
+        end
+      end
+
+
+      # let it run for several seconds because you know, concurrency issues do not always manifest themselves
+      # immediately. MK.
+      done(14.0) {
+        # we don't care about the exact number of messages sent or received, just the fact that there are
+        # no UNEXPECTED_FRAME connection-level exceptions. MK.
+      }
+    end
+  end  
+end

data/spec/integration/regressions/empty_message_body_spec.rb

@@ -0,0 +1,56 @@
+# encoding: utf-8
+
+require "spec_helper"
+
+describe "Messages with empty bodies" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_options AMQP_OPTS
+  default_timeout 5
+
+  amqp_before do
+    @channel   = AMQP::Channel.new
+    @channel.on_error do |ch, close|
+      raise "Channel-level error!: #{close.inspect}"
+    end
+
+    @queue    = @channel.queue("", :auto_delete => true)
+    @exchange = @channel.direct("amqpgem.tests.integration.direct.exchange", :auto_delete => true)
+
+    @queue.bind(@exchange, :routing_key => "builds.all")
+  end
+
+
+
+  it "can be mixed with any other messages" do
+    mailbox1  = Array.new
+    mailbox2  = Array.new
+
+    consumer1 = AMQP::Consumer.new(@channel, @queue).consume
+    consumer2 = AMQP::Consumer.new(@channel, @queue).consume
+
+
+    consumer1.on_delivery do |metadata, payload|
+      mailbox1 << payload
+    end
+    consumer2.on_delivery do |metadata, payload|
+      mailbox2 << payload
+    end
+
+
+    EventMachine.add_timer(0.5) do
+      12.times { @exchange.publish("",  :routing_key => "builds.all") }
+      12.times { @exchange.publish(".", :routing_key => "all.builds") }
+      12.times { @exchange.publish("",  :routing_key => "all.builds") }
+    end
+
+    done(1.5) {
+      mailbox1.size.should == 6
+      mailbox2.size.should == 6
+    }
+  end
+end

data/spec/integration/regressions/issue66_spec.rb

@@ -1,4 +1,5 @@
-# -*- coding: utf-8 -*-
+# encoding: utf-8
+
 require "spec_helper"
 
 describe "Immediate disconnection" do

data/spec/integration/reply_queue_communication_spec.rb

@@ -1,4 +1,5 @@
-# -*- coding: utf-8 -*-
+# encoding: utf-8
+
 require "spec_helper"
 
 describe "Exclusive server-named queue" do

data/spec/integration/store_and_forward_spec.rb

@@ -1,4 +1,5 @@
-# -*- coding: utf-8 -*-
+# encoding: utf-8
+
 require "spec_helper"
 
 describe "Store-and-forward routing" do
@@ -64,7 +65,7 @@ describe "Store-and-forward routing" do
         end
 
         # 6 seconds are for Rubinius, it is surprisingly slow on this workload
-        done(4.0) {
+        done(6.0) {
           number_of_received_messages.should == expected_number_of_messages
           @queue.unsubscribe
         }
@@ -84,7 +85,7 @@ describe "Store-and-forward routing" do
         end
 
         # 6 seconds are for Rubinius, it is surprisingly slow on this workload
-        done(3.0) {
+        done(6.0) {
           number_of_received_messages.should == expected_number_of_messages
           @queue.unsubscribe
         }

data/spec/integration/topic_subscription_spec.rb

@@ -1,4 +1,5 @@
-# -*- coding: utf-8 -*-
+# encoding: utf-8
+
 require "spec_helper"
 describe "Topic-based subscription" do
 

data/spec/integration/tx_commit_spec.rb

@@ -0,0 +1,124 @@
+# encoding: utf-8
+require 'spec_helper'
+
+
+describe "Messages published before AMQP transaction commits" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_timeout 1.5
+
+  amqp_before do
+    @producer_channel    = AMQP::Channel.new
+    @consumer_channel    = AMQP::Channel.new
+  end
+
+  # ...
+
+
+  #
+  # Examples
+  #
+
+  it "are not accessible to AMQP consumers" do
+    exchange = @producer_channel.fanout("amq.fanout")
+    queue    = @consumer_channel.queue("", :exclusive => true)
+
+    queue.bind(exchange).subscribe do |metadata, payload|
+      fail "Consumer received a message before transaction committed"
+    end
+
+    @producer_channel.tx_select
+    EventMachine.add_timer(0.5) do
+      50.times { exchange.publish("before tx.commit") }
+      # @producer_channel.tx_commit
+    end
+
+    done(1.2)
+  end # it
+end # describe
+
+
+
+
+describe "AMQP transaction commit" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_timeout 1.5
+
+  amqp_before do
+    @producer_channel    = AMQP::Channel.new
+    @consumer_channel    = AMQP::Channel.new
+  end
+
+  # ...
+
+
+  #
+  # Examples
+  #
+
+  it "causes messages published since the last tx.select to be delivered to AMQP consumers" do
+    exchange = @producer_channel.fanout("amq.fanout")
+    queue    = @consumer_channel.queue("", :exclusive => true)
+
+    queue.bind(exchange).subscribe { |metadata, payload| done }
+
+    @producer_channel.tx_select
+    EventMachine.add_timer(0.5) do
+      50.times { exchange.publish("before tx.commit") }
+      @producer_channel.tx_commit
+    end
+
+    done(1.2)
+  end # it
+end # describe
+
+
+
+
+describe "AMQP transaction commit attempt on a non-transactional channel" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_timeout 1.5
+
+  amqp_before do
+    @producer_channel    = AMQP::Channel.new
+    @consumer_channel    = AMQP::Channel.new
+  end
+
+  # ...
+
+
+  #
+  # Examples
+  #
+
+  it "causes channel-level exception" do
+    exchange = @producer_channel.fanout("amq.fanout")
+    queue    = @consumer_channel.queue("", :exclusive => true)
+
+    queue.bind(exchange).subscribe do |metadata, payload|
+      fail "Consumer received a message before transaction committed"
+    end
+
+    @producer_channel.on_error do |ch, channel_close|
+      puts "#{channel_close.reply_text}"
+      done
+    end
+    EventMachine.add_timer(0.5) { @producer_channel.tx_commit }
+
+    done(1.2)
+  end # it
+end # describe

data/spec/integration/tx_rollback_spec.rb

@@ -0,0 +1,167 @@
+# encoding: utf-8
+require 'spec_helper'
+
+
+describe "AMQP transaction rollback" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_timeout 3.5
+
+  amqp_before do
+    @producer_channel    = AMQP::Channel.new
+    @consumer_channel    = AMQP::Channel.new
+  end
+
+  # ...
+
+
+  #
+  # Examples
+  #
+
+  it "voids messages published since the last tx.select" do
+    exchange = @producer_channel.fanout("amq.fanout")
+    queue    = @consumer_channel.queue("", :exclusive => true)
+
+    queue.bind(exchange).subscribe do |metadata, payload|
+      fail "Consumer received a message before transaction committed"
+    end
+
+    @producer_channel.tx_select
+    EventMachine.add_timer(0.5) do
+      50.times { exchange.publish("before tx.commit") }
+      @producer_channel.tx_rollback
+    end
+
+    done(2.5)
+  end # it
+end # describe
+
+
+
+
+describe "AMQP connection closure that follows tx.select" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_timeout 3.5
+
+  amqp_before do
+    @producer_channel    = AMQP::Channel.new
+    @consumer_channel    = AMQP::Channel.new
+  end
+
+  # ...
+
+
+  #
+  # Examples
+  #
+
+  it "voids messages published since the last tx.select" do
+    exchange = @producer_channel.fanout("amq.fanout")
+    queue    = @consumer_channel.queue("", :exclusive => true)
+
+    queue.bind(exchange).subscribe do |metadata, payload|
+      fail "Consumer received a message before transaction committed"
+    end
+
+    @producer_channel.tx_select
+    EventMachine.add_timer(0.5) do
+      3.times { exchange.publish("before tx.commit") }
+      @producer_channel.connection.close
+    end
+
+    done(2.5)
+  end # it
+end # describe
+
+
+
+
+describe "AMQP channel closure that follows tx.select" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_timeout 3.5
+
+  amqp_before do
+    @producer_channel    = AMQP::Channel.new
+    @consumer_channel    = AMQP::Channel.new
+  end
+
+  # ...
+
+
+  #
+  # Examples
+  #
+
+  it "voids messages published since the last tx.select" do
+    exchange = @producer_channel.fanout("amq.fanout")
+    queue    = @consumer_channel.queue("", :exclusive => true)
+
+    queue.bind(exchange).subscribe do |metadata, payload|
+      fail "Consumer received a message before transaction committed"
+    end
+
+    @producer_channel.tx_select
+    EventMachine.add_timer(0.5) do
+      3.times { exchange.publish("before tx.commit") }
+      @producer_channel.close
+    end
+
+    done(2.5)
+  end # it
+end # describe
+
+
+
+describe "AMQP transaction rollback attempt on a non-transactional channel" do
+
+  #
+  # Environment
+  #
+
+  include EventedSpec::AMQPSpec
+  default_timeout 3.5
+
+  amqp_before do
+    @producer_channel    = AMQP::Channel.new
+    @consumer_channel    = AMQP::Channel.new
+  end
+
+  # ...
+
+
+  #
+  # Examples
+  #
+
+  it "causes channel-level exception" do
+    exchange = @producer_channel.fanout("amq.fanout")
+    queue    = @consumer_channel.queue("", :exclusive => true)
+
+    queue.bind(exchange).subscribe do |metadata, payload|
+      fail "Consumer received a message before transaction committed"
+    end
+
+    @producer_channel.on_error do |ch, channel_close|
+      puts "#{channel_close.reply_text}"
+      done
+    end
+    EventMachine.add_timer(0.5) { @producer_channel.tx_rollback }
+
+    done(2.5)
+  end # it
+end # describe