amqp-subscribe-many 0.1.4 → 0.1.5

data/Gemfile

@@ -5,6 +5,7 @@ gem "amqp", ">= 0.9.6"
 group :development do
   gem "bundler"
   gem "minitest", ">= 3.0"
+  gem "simplecov", :require => false
   gem "mocha"
   gem "jeweler"
   gem "redcarpet"

data/Gemfile.lock

@@ -25,6 +25,9 @@ GEM
     rdoc (3.12)
       json (~> 1.4)
     redcarpet (2.1.1)
+    simplecov (0.4.2)
+      simplecov-html (~> 0.4.4)
+    simplecov-html (0.4.5)
     yard (0.8.2.1)
 
 PLATFORMS
@@ -37,4 +40,5 @@ DEPENDENCIES
   minitest (>= 3.0)
   mocha
   redcarpet
+  simplecov
   yard

data/Makefile

@@ -4,7 +4,7 @@ BUNDLE=`which bundle`
 # Targets
 #
 
-.PHONY: deps doc
+.PHONY: deps test doc
 
 all: deps test
 

data/README.md

@@ -2,3 +2,77 @@ Publish One, Subscribe Many
 ===========
 
 [![Build Status](https://secure.travis-ci.org/brendanhay/amqp-subscribe-many.png)](http://travis-ci.org/brendanhay/amqp-subscribe-many)
+
+
+Table of Contents
+-----------------
+
+* [Introduction](#introduction)
+* [Testing](#test)
+* [Contribute](#contribute)
+* [Licence](#licence)
+
+
+<a name="introduction" />
+
+Introduction
+------------
+
+This gem is a _reference implementation_ for a Publish One, Subscribe Many pattern which is in use at [SoundCloud](http://soundcloud.com).
+
+The pattern assumes a single load balanced publish point and multiple direct consumption points as outlined in the follow diagram:
+
+![Publish One, Subscribe Many](https://raw.github.com/brendanhay/amqp-subscribe-many/master/img/amqp-subscribe-many.png)
+
+In this scenario, a worker's single publish connection is load balanced to a broker. The workers have consumer connections to all possible brokers ensuring
+that no matter which broker a message ends up on the consumer can receive it.
+
+Exchanges, queues, and bindings need to be declared upon connection, ensuring that all brokers will converge on the same set of routing information.
+
+Some buzzwor{th,d}y advantages of this setup include:
+
+* Partitioned Load
+* Horizontal Scalability
+* High Availability (across the logical topology)
+
+Drawbacks:
+
+* More complex client code
+* Another hop in the form of the load-balancer
+* A node going down, needs to be brought back up to access the messages
+
+A common error is to conflate availability and durability. In this case, they are treated as seperate concerns with the form of availability on offer refering to the ability of all connected clients to get a message from point to point under most conditions.
+
+Durability requires messages to be published as persistent and manual intervention in the case of a node crash to bring the failed node (or disk) back into consumer awareness, to ensure the messages are flushed.
+
+The code in this repository can be used either as a gem available on [rubygems.org](rubygems.org/gems/amqp-subscribe-many) or as a guide to implement the above pattern using the ruby-amqp gem.
+
+See `./examples/run` for usage.
+
+
+<a name="test" />
+
+Testing
+-------
+
+Run all the tests:
+
+```shell
+make test
+```
+
+
+<a name="contribute" />
+
+Contribute
+----------
+
+For any problems, comments or feedback please create an issue [here on GitHub](github.com/brendanhay/amqp-subscribe-many/issues).
+
+
+<a name="licence" />
+
+Licence
+-------
+
+amqp-subscribe-many is released under the [Mozilla Public License Version 2.0](http://www.mozilla.org/MPL/)

data/Rakefile

@@ -22,7 +22,7 @@ require "rake"
 require "rake/testtask"
 
 Rake::TestTask.new do |t|
-  t.libs.concat ["lib", "test"]
+  t.libs << "lib"
   t.test_files = FileList["test/*_test.rb"]
   t.verbose = true
 end
@@ -49,7 +49,7 @@ Jeweler::RubygemsDotOrgTasks.new
 
 Jeweler::Tasks.new do |gem|
   gem.name        = "amqp-subscribe-many"
-  gem.version     = "0.1.4"
+  gem.version     = "0.1.5"
   gem.homepage    = "http://github.com/brendanhay/amqp-subscribe-many"
   gem.license     = "MPL"
   gem.summary     = "An implementation of the publish one, subscribe many pattern"

data/amqp-subscribe-many.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{amqp-subscribe-many}
-  s.version = "0.1.4"
+  s.version = "0.1.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{brendanhay}]
-  s.date = %q{2012-07-10}
+  s.date = %q{2012-09-07}
   s.description = %q{Codifies best practices and configuration when consuming from multiple AMQP brokers simultaneously}
   s.email = %q{brendan@soundcloud.com}
   s.extra_rdoc_files = [
@@ -29,6 +29,7 @@ Gem::Specification.new do |s|
     "examples/duplex_processor.rb",
     "examples/producer_processor.rb",
     "examples/run",
+    "img/amqp-subscribe-many.png",
     "lib/messaging.rb",
     "lib/messaging/client.rb",
     "lib/messaging/configuration.rb",
@@ -42,7 +43,7 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/brendanhay/amqp-subscribe-many}
   s.licenses = [%q{MPL}]
   s.require_paths = [%q{lib}]
-  s.rubygems_version = %q{1.8.7}
+  s.rubygems_version = %q{1.8.6}
   s.summary = %q{An implementation of the publish one, subscribe many pattern}
 
   if s.respond_to? :specification_version then
@@ -52,6 +53,7 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<amqp>, [">= 0.9.6"])
       s.add_development_dependency(%q<bundler>, [">= 0"])
       s.add_development_dependency(%q<minitest>, [">= 3.0"])
+      s.add_development_dependency(%q<simplecov>, [">= 0"])
       s.add_development_dependency(%q<mocha>, [">= 0"])
       s.add_development_dependency(%q<jeweler>, [">= 0"])
       s.add_development_dependency(%q<redcarpet>, [">= 0"])
@@ -60,6 +62,7 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<amqp>, [">= 0.9.6"])
       s.add_dependency(%q<bundler>, [">= 0"])
       s.add_dependency(%q<minitest>, [">= 3.0"])
+      s.add_dependency(%q<simplecov>, [">= 0"])
       s.add_dependency(%q<mocha>, [">= 0"])
       s.add_dependency(%q<jeweler>, [">= 0"])
       s.add_dependency(%q<redcarpet>, [">= 0"])
@@ -69,6 +72,7 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<amqp>, [">= 0.9.6"])
     s.add_dependency(%q<bundler>, [">= 0"])
     s.add_dependency(%q<minitest>, [">= 3.0"])
+    s.add_dependency(%q<simplecov>, [">= 0"])
     s.add_dependency(%q<mocha>, [">= 0"])
     s.add_dependency(%q<jeweler>, [">= 0"])
     s.add_dependency(%q<redcarpet>, [">= 0"])

data/lib/messaging/client.rb

@@ -39,7 +39,7 @@ module Messaging
           log.error("Connection to #{uri.inspect} lost, reconnecting")
 
           if (402..540).include?(error.reply_code)
-            raise(MessagingError, "Channel exception: #{error.reply_text.inspect}")
+            raise(MessagingError, "Connection exception: #{error.reply_text.inspect}")
           end
 
           conn.periodically_reconnect(delay)
@@ -137,11 +137,13 @@ module Messaging
     # @return [Boolean]
     # @api private
     def default_exchange?(name)
-      ["amq.direct",
+      ["",
+       "amq.default",
+       "amq.direct",
        "amq.fanout",
        "amq.topic",
-       "amqp.headers",
-       "amqp.match"].include?(name)
+       "amq.headers",
+       "amq.match"].include?(name)
     end
   end
 

data/lib/messaging/producer.rb

@@ -11,16 +11,16 @@ module Messaging
     # @param payload [Object]
     # @return [Messaging::Producer]
     # @api public
-    def publish(exchange, type, key, payload)
+    def publish(exchange, type, key, payload, options = {})
       ex = producer_exchanges[exchange] ||=
         declare_exchange(producer_channel, exchange, type, config.exchange_options)
 
       log.debug("Publishing to exchange #{exchange.inspect} via #{key.inspect}")
 
-      ex.publish(payload, {
+      ex.publish(payload, options.merge({
         :exchange    => exchange,
         :routing_key => key
-      })
+      }))
 
       self
     end

data/test/test_helper.rb

@@ -1,3 +1,7 @@
+require "simplecov"
+
+SimpleCov.start
+
 require "minitest/autorun"
 require "mocha"
 require "messaging"
@@ -14,3 +18,5 @@ class MiniTestSetup < MiniTest::Unit
 end
 
 MiniTest::Unit.runner = MiniTestSetup.new
+
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: amqp-subscribe-many
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-10 00:00:00.000000000Z
+date: 2012-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amqp
-  requirement: &70129985708800 !ruby/object:Gem::Requirement
+  requirement: &70256241444900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 0.9.6
   type: :runtime
   prerelease: false
-  version_requirements: *70129985708800
+  version_requirements: *70256241444900
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70129985708200 !ruby/object:Gem::Requirement
+  requirement: &70256241482320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70129985708200
+  version_requirements: *70256241482320
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70129985707620 !ruby/object:Gem::Requirement
+  requirement: &70256241481600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,21 @@ dependencies:
         version: '3.0'
   type: :development
   prerelease: false
-  version_requirements: *70129985707620
+  version_requirements: *70256241481600
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: &70256241480400 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70256241480400
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70129985690080 !ruby/object:Gem::Requirement
+  requirement: &70256241477160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70129985690080
+  version_requirements: *70256241477160
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70129985689500 !ruby/object:Gem::Requirement
+  requirement: &70256241476540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70129985689500
+  version_requirements: *70256241476540
 - !ruby/object:Gem::Dependency
   name: redcarpet
-  requirement: &70129985688900 !ruby/object:Gem::Requirement
+  requirement: &70256241475320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70129985688900
+  version_requirements: *70256241475320
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70129985688300 !ruby/object:Gem::Requirement
+  requirement: &70256241490260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +98,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70129985688300
+  version_requirements: *70256241490260
 description: Codifies best practices and configuration when consuming from multiple
   AMQP brokers simultaneously
 email: brendan@soundcloud.com
@@ -109,6 +120,7 @@ files:
 - examples/duplex_processor.rb
 - examples/producer_processor.rb
 - examples/run
+- img/amqp-subscribe-many.png
 - lib/messaging.rb
 - lib/messaging/client.rb
 - lib/messaging/configuration.rb
@@ -133,7 +145,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1145550775653272819
+      hash: 2625083279973371652
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -142,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.7
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: An implementation of the publish one, subscribe many pattern