amq-client 0.7.0.alpha35 → 0.8.0

data/spec/integration/eventmachine/basic_cancel_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/basic_consume_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 
@@ -6,9 +8,9 @@ require 'integration/eventmachine/spec_helper'
 # See basic_ack_spec for example with acks
 #
 
-describe AMQ::Client::EventMachineClient, "Basic.Consume" do
+describe AMQ::Client::EventMachineClient, "AMQP consumer" do
   include EventedSpec::SpecHelper
-  default_timeout 4
+  default_timeout 5
 
   context "sending 100 messages" do
     let(:messages) { (0..99).map {|i| "Message #{i}" } }
@@ -32,7 +34,7 @@ describe AMQ::Client::EventMachineClient, "Basic.Consume" do
             end
           end
 
-          done(1.5) {
+          done(3.5) {
             @received_messages.should =~ messages
           }
         end
@@ -62,8 +64,8 @@ describe AMQ::Client::EventMachineClient, "Basic.Consume" do
           end
 
           # We're opening another channel and starting consuming the same queue,
-          # assuming 1.5 secs was enough to receive all the messages
-          delayed(1.5) do
+          # assuming 2.0 secs was enough to receive all the messages
+          delayed(2.0) do
             other_channel = AMQ::Client::Channel.new(client, 2)
             other_channel.open do
               other_channel.qos(0, 1) # Maximum prefetch size = 1
@@ -79,7 +81,7 @@ describe AMQ::Client::EventMachineClient, "Basic.Consume" do
         end
 
 
-        done(2.5) {
+        done(4.5) {
           @rereceived_messages.should == []
           @received_messages.should =~ messages
         }
@@ -87,3 +89,85 @@ describe AMQ::Client::EventMachineClient, "Basic.Consume" do
     end # it "should not leave messages in the queues with noack=true"
   end # context "sending 100 messages"
 end # describe AMQ::Client::EventMachineClient, "Basic.Consume"
+
+
+
+
+describe "Multiple", AMQ::Client::Async::Consumer do
+  include EventedSpec::SpecHelper
+  default_timeout 4
+
+  context "sharing the same queue with equal prefetch levels" do
+    let(:messages) { (0..99).map {|i| "Message #{i}" } }
+
+    it "have messages distributed to them in the round-robin manner" do
+      @consumer1_mailbox = []
+      @consumer2_mailbox = []
+      @consumer3_mailbox = []
+
+      em_amqp_connect do |client|
+        channel = AMQ::Client::Channel.new(client, 1)
+        channel.open do
+          queue = AMQ::Client::Queue.new(client, channel).declare(false, false, false, true)
+          queue.bind("amq.fanout")
+
+          consumer1 = AMQ::Client::Async::Consumer.new(channel, queue, "#{queue.name}-consumer-#{Time.now}")
+          consumer2 = AMQ::Client::Async::Consumer.new(channel, queue)
+          consumer3 = AMQ::Client::Async::Consumer.new(channel, queue, "#{queue.name}-consumer-#{rand}-#{Time.now}", false, true)
+
+
+          consumer1.consume.on_delivery do |method, header, payload|
+            @consumer1_mailbox << payload
+          end
+
+          consumer2.consume(true).on_delivery do |method, header, payload|
+            @consumer2_mailbox << payload
+          end
+
+          consumer3.consume(false) do
+            puts "Consumer 3 is ready"
+          end
+          consumer3.on_delivery do |method, header, payload|
+            @consumer3_mailbox << payload
+          end
+
+
+          exchange = AMQ::Client::Exchange.new(client, channel, "amq.fanout", :fanout)
+          messages.each do |message|
+            exchange.publish(message)
+          end
+        end
+
+        done(1.5) {
+          @consumer1_mailbox.size.should == 34
+          @consumer2_mailbox.size.should == 33
+          @consumer3_mailbox.size.should == 33
+        }
+      end
+    end # it
+  end # context
+end # describe
+
+
+
+describe AMQ::Client::Async::Consumer do
+  include EventedSpec::SpecHelper
+  default_timeout 4
+
+  context "registered with a callback" do
+    it "runs that callback when basic.consume-ok arrives" do
+      em_amqp_connect do |client|
+        channel = AMQ::Client::Channel.new(client, 1)
+        channel.open do
+          queue = AMQ::Client::Queue.new(client, channel).declare(false, false, false, true)
+          queue.bind("amq.fanout")
+
+          consumer1 = AMQ::Client::Async::Consumer.new(channel, queue, "#{queue.name}-consumer-#{Time.now}")
+          consumer1.consume do
+            done
+          end # consume do
+        end # open do
+      end # em_amqp_connect
+    end # it
+  end # context
+end # describe

data/spec/integration/eventmachine/basic_get_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/basic_return_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/channel_close_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/channel_flow_spec.rb

@@ -1,9 +1,11 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 
 describe AMQ::Client::EventMachineClient, "Channel#flow" do
   include EventedSpec::SpecHelper
-  default_timeout 1
+  default_timeout 2
 
   it "controls channel flow state" do
     em_amqp_connect do |client|
@@ -24,7 +26,7 @@ describe AMQ::Client::EventMachineClient, "Channel#flow" do
         end # channel.flow
       end # channel.open
 
-      done(0.5) { flow_states.should == [false, true] }
+      done(1.0) { flow_states.should == [false, true] }
     end # em_amqp_connect
   end # it
 end # describe

data/spec/integration/eventmachine/concurrent_basic_publish_spec.rb

@@ -0,0 +1,79 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'integration/eventmachine/spec_helper'
+
+
+include PlatformDetection
+
+if mri?
+  require "multi_json"
+
+  describe AMQ::Client::EventMachineClient, "Basic.Publish" do
+    include EventedSpec::SpecHelper
+    default_timeout 21.0
+
+    context "when messages are published across threads" do
+      let(:inputs) do
+        [
+          { :index=>{:_routing=>530,:_index=>"optimizer",:_type=>"earnings",:_id=>530}},
+          { :total_conversions=>0,:banked_clicks=>0,:total_earnings=>0,:pending_conversions=>0,:paid_net_earnings=>0,:banked_conversions=>0,:pending_earnings=>0,:optimizer_id=>530,:total_impressions=>0,:banked_earnings=>0,:bounce_count=>0,:time_on_page=>0,:total_clicks=>0,:entrances=>0,:pending_clicks=>0,:paid_earnings=>0},
+
+          { :index=>{:_routing=>430,:_index=>"optimizer",:_type=>"earnings",:_id=>430}},
+          { :total_conversions=>1443,:banked_clicks=>882,:total_earnings=>5796.3315841537,:pending_conversions=>22,:paid_net_earnings=>4116.90224486802,:banked_conversions=>1086,:pending_earnings=>257.502767857143,:optimizer_id=>430,:total_impressions=>6370497,:banked_earnings=>122.139339285714,:bounce_count=>6825,:time_on_page=>0,:total_clicks=>38143,:entrances=>12336,:pending_clicks=>1528,:paid_earnings=>5670.78224486798},
+
+          { :index=>{:_routing=>506,:_index=>"optimizer",:_type=>"earnings",:_id=>506}},
+          { :total_conversions=>237,:banked_clicks=>232,:total_earnings=>550.6212071428588277,:pending_conversions=>9,:paid_net_earnings=>388.021207142857,:banked_conversions=>225,:pending_earnings=>150.91,:optimizer_id=>506,:total_impressions=>348319,:banked_earnings=>12.92,:bounce_count=>905,:time_on_page=>0,:total_clicks=>4854,:entrances=>1614,:pending_clicks=>1034,:paid_earnings=>537.501207142858},
+
+          {:index=>{:_routing=>345,:_index=>"optimizer",:_type=>"earnings",:_id=>345}},
+          {:total_conversions=>0,:banked_clicks=>0,:total_earnings=>0,:pending_conversions=>0,:paid_net_earnings=>0,:banked_conversions=>0,:pending_earnings=>0,:optimizer_id=>345,:total_impressions=>0,:banked_earnings=>0,:bounce_count=>0,:time_on_page=>0,:total_clicks=>0,:entrances=>0,:pending_clicks=>0,:paid_earnings=>0}
+        ]
+      end
+      let(:messages) { inputs.map {|i| MultiJson.encode(i) } * 3 }
+
+      # the purpose of this is to make sure UNEXPECTED_FRAME issues are gone
+      it "synchronizes on channel" do
+        @received_messages = []
+
+        @received_messages = []
+        em_amqp_connect do |client|
+          client.on_error do |conn, connection_close|
+            fail "Handling a connection-level exception: #{connection_close.reply_text}"
+          end
+
+          channel = AMQ::Client::Channel.new(client, 1)
+          channel.open do
+            queue = AMQ::Client::Queue.new(client, channel).declare(false, false, false, true)
+            queue.bind("amq.fanout")
+
+            queue.consume(true) do |amq_method|
+              queue.on_delivery do |method, header, payload|
+                @received_messages << payload
+              end
+
+              exchange = AMQ::Client::Exchange.new(client, channel, "amq.fanout", :fanout)
+              EventMachine.add_timer(2.0) do
+                # ZOMG THREADS!
+                30.times do
+                  Thread.new do
+                    messages.each do |message|
+                      exchange.publish(message, queue.name, {}, false, true)
+                    end
+                  end
+                end
+              end
+            end
+
+            # let it run for several seconds because you know, concurrency issues do not always manifest themselves
+            # immediately. MK.
+            done(14.0) {
+              # we don't care about the exact number, just the fact that there are
+              # no UNEXPECTED_FRAME connection-level exceptions. MK.
+              @received_messages.size.should > 120
+            }
+          end
+        end # em_amqp_connect
+      end # it
+    end # context
+  end # describe
+end

data/spec/integration/eventmachine/connection_close_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/connection_start_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/exchange_declare_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 
@@ -8,7 +10,7 @@ describe AMQ::Client::EventMachineClient, "Exchange.Declare" do
   #
 
   include EventedSpec::SpecHelper
-  default_timeout 1
+  default_timeout 2
   let(:exchange_name) { "amq-client.testexchange.#{Time.now.to_i}" }
 
 
@@ -25,7 +27,7 @@ describe AMQ::Client::EventMachineClient, "Exchange.Declare" do
           channel.open do
             begin
               AMQ::Client::Exchange.new(client, channel, exchange_name, "my_shiny_metal_exchange_type")
-            rescue AMQ::Client::Exchange::IncompatibleExchangeTypeError => e
+            rescue AMQ::Client::UnknownExchangeTypeError => e
               done
             end
           end # channel.open

data/spec/integration/eventmachine/queue_declare_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/regressions/amqp_gem_issue66_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 

data/spec/integration/eventmachine/spec_helper.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require "amq/client/adapters/event_machine"
 require "amq/client/queue"
 require "amq/client/exchange"

data/spec/integration/eventmachine/tx_commit_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 require 'spec_helper'
 require 'integration/eventmachine/spec_helper'
 
@@ -9,7 +10,7 @@ describe AMQ::Client::EventMachineClient, "Tx.Commit" do
   #
 
   include EventedSpec::SpecHelper
-  default_timeout 2
+  default_timeout 4
 
   let(:message) { "Hello, world!" }
 

data/spec/integration/eventmachine/tx_rollback_spec.rb

@@ -4,7 +4,7 @@ require 'integration/eventmachine/spec_helper'
 
 describe AMQ::Client::EventMachineClient, "Tx.Rollback" do
   include EventedSpec::SpecHelper
-  default_timeout 2
+  default_timeout 4
   let(:message) { "Hello, world!" }
   it "should cancel all the changes done during transaction" do
     pending("Need to figure out details with AMQP protocol on that matter")

data/spec/regression/bad_frame_slicing_in_adapters_spec.rb

@@ -1,3 +1,5 @@
+# encoding: binary
+
 require 'spec_helper'
 require 'integration/coolio/spec_helper'
 require 'integration/eventmachine/spec_helper'

data/spec/spec_helper.rb

@@ -6,10 +6,13 @@ Bundler.setup
 Bundler.require(:default, :test)
 
 require 'amq/client'
+
 #
 # Ruby version-specific
 #
 
+require "effin_utf8"
+
 case RUBY_VERSION
 when "1.8.7" then
   class Array
@@ -22,4 +25,11 @@ end
 
 RSpec.configure do |c|
   c.filter_run_excluding :nojruby => true if RUBY_PLATFORM =~ /java/
+end
+
+
+module PlatformDetection
+  def mri?
+    !defined?(RUBY_ENGINE) || (defined?(RUBY_ENGINE) && ("ruby" == RUBY_ENGINE))
+  end
 end

data/spec/unit/client/settings_spec.rb

@@ -18,9 +18,98 @@ describe AMQ::Client::Settings do
     end
 
     it "should merge custom settings from AMQP URL with default settings" do
-      pending "AMQP URL parsing" do
-        settings = AMQ::Client::Settings.configure("amqp://tagadab")
-        settings[:host].should eql("tagadab")
+      settings = AMQ::Client::Settings.configure("amqp://tagadab")
+      settings[:host].should eql("tagadab")
+    end
+  end
+
+  describe ".parse_amqp_url(connection_string)" do
+    context "when schema is not one of [amqp, amqps]" do
+      it "raises ArgumentError" do
+        expect {
+          described_class.parse_amqp_url("http://dev.rabbitmq.com")
+        }.to raise_error(ArgumentError, /amqp or amqps schema/)
+      end
+    end
+
+
+    it "handles amqp:// URIs w/o path part" do
+      val = described_class.parse_amqp_url("amqp://dev.rabbitmq.com")
+
+      val[:vhost].should be_nil # in this case, default / will be used
+      val[:host].should == "dev.rabbitmq.com"
+      val[:port].should == 5672
+      val[:scheme].should == "amqp"
+      val[:ssl].should be_false
+    end
+
+    it "handles amqps:// URIs w/o path part" do
+      val = described_class.parse_amqp_url("amqps://dev.rabbitmq.com")
+
+      val[:vhost].should be_nil
+      val[:host].should == "dev.rabbitmq.com"
+      val[:port].should == 5671
+      val[:scheme].should == "amqps"
+      val[:ssl].should be_true
+    end
+
+
+    context "when URI ends in a slash" do
+      it "parses vhost as an empty string" do
+        val = described_class.parse_amqp_url("amqp://dev.rabbitmq.com/")
+
+        val[:host].should == "dev.rabbitmq.com"
+        val[:port].should == 5672
+        val[:scheme].should == "amqp"
+        val[:ssl].should be_false
+        val[:vhost].should == ""
+      end
+    end
+
+
+    context "when URI ends in /%2Fvault" do
+      it "parses vhost as /vault" do
+        val = described_class.parse_amqp_url("amqp://dev.rabbitmq.com/%2Fvault")
+
+        val[:host].should == "dev.rabbitmq.com"
+        val[:port].should == 5672
+        val[:scheme].should == "amqp"
+        val[:ssl].should be_false
+        val[:vhost].should == "/vault"
+      end
+    end
+
+
+    context "when URI is amqp://dev.rabbitmq.com/a.path.without.slashes" do
+      it "parses vhost as a.path.without.slashes" do
+        val = described_class.parse_amqp_url("amqp://dev.rabbitmq.com/a.path.without.slashes")
+
+        val[:host].should == "dev.rabbitmq.com"
+        val[:port].should == 5672
+        val[:scheme].should == "amqp"
+        val[:ssl].should be_false
+        val[:vhost].should == "a.path.without.slashes"
+      end
+    end
+
+    context "when URI is amqp://dev.rabbitmq.com/a/path/with/slashes" do
+      it "raises an ArgumentError" do
+        lambda { described_class.parse_amqp_url("amqp://dev.rabbitmq.com/a/path/with/slashes") }.should raise_error(ArgumentError)
+      end
+    end
+
+
+    context "when URI has username:password, for instance, amqp://hedgehog:t0ps3kr3t@hub.megacorp.internal" do
+      it "parses them out" do
+        val = described_class.parse_amqp_url("amqp://hedgehog:t0ps3kr3t@hub.megacorp.internal")
+
+        val[:host].should == "hub.megacorp.internal"
+        val[:port].should == 5672
+        val[:scheme].should == "amqp"
+        val[:ssl].should be_false
+        val[:user].should == "hedgehog"
+        val[:pass].should == "t0ps3kr3t"
+        val[:vhost].should be_nil # in this case, default / will be used
       end
     end
   end