amplitude-experiment 1.2.5 → 1.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39fff5d1285490313a587d9df46b1cf68bb84c5672d9927871ba83b195bbf613
-  data.tar.gz: 8f26de2e9de3585d5696646cd384841a732e9c0944520b479dc42ab423f5f168
+  metadata.gz: 2c2b4d645d6bc1a63154135eca42b2123dbaef5fb6597e77ea3c4d602235bbe7
+  data.tar.gz: b521d6b1f7af00b62fc9ec14e8c8e1db63a63b9330e8e73139fcf09ffb5f5dca
 SHA512:
-  metadata.gz: 96bb141478ceb429381894466cd63fd937ddd8e27d4d5ac4ee4b02ed6bacfef34750f151fbfffbc088fb5562e3ee2aef23e4da9ed8907f591a37a9195fc5e8b9
-  data.tar.gz: 631d94a409a81132540504f135b56b2b6ccdfb407e9e11f250486ee9cf6d74e481e5a2dc3e23e652ed07b42abde9ffb9d2cbd9f17e1128c4248b1e55e53e2d61
+  metadata.gz: 68d5921c26baf78c5f1dcff97e4b58124e35f5be6de93b02be240e593c12f67d32ecba973ea95cb8df66908132c280a55e94d9be2025f351c536129663359570
+  data.tar.gz: 5a66ce54c1ed89ae0bef261578ad006151c34292805aa6cf68725b7a61085089de4a96769401a52631fb2a57a759d89b0b7fe6a2e570ca25af49415badd5a1c2

data/lib/amplitude-experiment.rb

@@ -15,6 +15,7 @@ require 'experiment/local/assignment/assignment_service'
 require 'experiment/local/assignment/assignment_config'
 require 'experiment/util/lru_cache'
 require 'experiment/util/hash'
+require 'experiment/error'
 
 # Amplitude Experiment Module
 module AmplitudeExperiment

data/lib/experiment/error.rb

@@ -0,0 +1,11 @@
+module AmplitudeExperiment
+  # FetchError
+  class FetchError < StandardError
+    attr_reader :status_code
+
+    def initialize(status_code, message)
+      super(message)
+      @status_code = status_code
+    end
+  end
+end

data/lib/experiment/remote/client.rb

@@ -61,12 +61,14 @@ module AmplitudeExperiment
       do_fetch(user, @config.fetch_timeout_millis)
     rescue StandardError => e
       @logger.error("[Experiment] Fetch failed: #{e.message}")
-      begin
-        return retry_fetch(user)
-      rescue StandardError => err
-        @logger.error("[Experiment] Retry Fetch failed: #{err.message}")
+      if should_retry_fetch?(e)
+        begin
+          retry_fetch(user)
+        rescue StandardError => err
+          @logger.error("[Experiment] Retry Fetch failed: #{err.message}")
+        end
       end
-      throw e
+      raise e
     end
 
     # @param [User] user
@@ -108,6 +110,8 @@ module AmplitudeExperiment
       end_time = Time.now
       elapsed = (end_time - start_time) * 1000.0
       @logger.debug("[Experiment] Fetch complete in #{elapsed.round(3)} ms")
+      raise FetchError.new(response.code.to_i, "Fetch error response: status=#{response.code} #{response.message}") if response.code != '200'
+
       json = JSON.parse(response.body)
       variants = parse_json_variants(json)
       @logger.debug("[Experiment] Fetched variants: #{variants}")
@@ -140,5 +144,11 @@ module AmplitudeExperiment
       user.library = "experiment-ruby-server/#{VERSION}"
       user
     end
+
+    def should_retry_fetch?(err)
+      return err.status_code < 400 || err.status_code >= 500 || err.status_code == 429 if err.is_a?(FetchError)
+
+      true
+    end
   end
 end

data/lib/experiment/version.rb

@@ -1,3 +1,3 @@
 module AmplitudeExperiment
-  VERSION = '1.2.5'.freeze
+  VERSION = '1.2.6'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: amplitude-experiment
 version: !ruby/object:Gem::Version
-  version: 1.2.5
+  version: 1.2.6
 platform: ruby
 authors:
 - Amplitude
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-30 00:00:00.000000000 Z
+date: 2024-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -176,6 +176,7 @@ files:
 - lib/amplitude/utils.rb
 - lib/amplitude/workers.rb
 - lib/experiment/cookie.rb
+- lib/experiment/error.rb
 - lib/experiment/factory.rb
 - lib/experiment/local/assignment/assignment.rb
 - lib/experiment/local/assignment/assignment_config.rb