amplitude-experiment 1.1.3 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79931b2e41b024a2ae5503ff41321635959bfe3ea12ebdec92d565c03ef75072
-  data.tar.gz: f7247ded087e26ad540f22e3e306c8870c33c241e408f214c98839020acddccc
+  metadata.gz: d4c7cef3c90843aec26f85cc3706300eb1f6bff3f64c1db9b4162bdf20dc1119
+  data.tar.gz: bd937b2d414b7b52b3accf57de14ac556a1789f83dd1e5d1625727ae5c9a0222
 SHA512:
-  metadata.gz: be36e288fa8892698c510b810580834445f75959511ea15b38fec4b079ca91235c920a27ed9ce6f69c6e05609d2b31db6c79cd0d888e59dde68eb7c74e849cf1
-  data.tar.gz: a2d892e60a65bd0f9a4b85d8994aeb26bf9b27d97a7397b8d6999aa408797d84f534d25d9d3a6c967def88c0ee0d313bc349dddd1f5b0a45224e65a656261c9b
+  metadata.gz: c927c9bc9808738b641cdf6666e7fa3220dad2d68b275d2d9b4269ebedf5ade2cd421a4e7c77a4283d8c0c0cfd9be2579d209ac9e4430b989dcf6dd864b98b4b
+  data.tar.gz: b388bc2f602af8031e5fb01cdd862ea31149a142d0fcf559703cdb2a76554cc051a339be8e8670862a129669a09535342ed3a766411c931c9a1c1ec019dbd082

data/lib/experiment/local/client.rb

@@ -64,7 +64,7 @@ module AmplitudeExperiment
     def parse_results(result, flag_keys)
       variants = {}
       result.each do |key, value|
-        next if value['isDefaultVariant'] || (flag_keys.empty? && flag_keys.include?(key))
+        next if value['isDefaultVariant'] || (!flag_keys.empty? && !flag_keys.include?(key))
 
         variant_key = value['variant']['key']
         variant_payload = value['variant']['payload']

data/lib/experiment/local/fetcher.rb

@@ -9,7 +9,7 @@ module AmplitudeExperiment
       @api_key = api_key
       @server_url = server_url
       @logger = logger
-      @http = PersistentHttpClient.get(server_url, { read_timeout: FLAG_CONFIG_TIMEOUT })
+      @http = PersistentHttpClient.get(server_url, { read_timeout: FLAG_CONFIG_TIMEOUT }, @api_key)
     end
 
     # Fetch local evaluation mode flag configs from the Experiment API server.

data/lib/experiment/persistent_http_client.rb

@@ -1,14 +1,20 @@
 module AmplitudeExperiment
-  # Persist Http Client to reuse connection and reduce IO
+  # Persist Http Client to reuse connection and reduce IO. Connections are
+  # shared by api key.
+  #
+  # WARNING: these connections are not safe for concurrent requests. Callers
+  # must synchronize requests per connection.
   class PersistentHttpClient
     DEFAULT_OPTIONS = { read_timeout: 80 }.freeze
 
     class << self
       # url: URI / String
       # options: any options that Net::HTTP.new accepts
-      def get(url, options = {})
+      # api_key: the deployment key for ensuring different deployments don't
+      # share connections.
+      def get(url, options, api_key)
         uri = url.is_a?(URI) ? url : URI(url)
-        connection_manager.get_client(uri, options)
+        connection_manager.get_client(uri, options, api_key)
       end
 
       private
@@ -72,7 +78,7 @@ module AmplitudeExperiment
         self.last_used = Time.now
       end
 
-      def get_client(uri, options)
+      def get_client(uri, options, api_key)
         mutex.synchronize do
           # refresh the last time a client was used,
           # this prevents the client from becoming stale
@@ -81,7 +87,7 @@ module AmplitudeExperiment
           # we use params as a cache key for clients.
           # 2 connections to the same host but with different
           # options are going to use different HTTP clients
-          params = [uri.host, uri.port, options]
+          params = [uri.host, uri.port, options, api_key]
           client = clients_store[params]
 
           return client if client

data/lib/experiment/remote/client.rb

@@ -99,7 +99,7 @@ module AmplitudeExperiment
         'Content-Type' => 'application/json;charset=utf-8'
       }
       read_timeout = timeout_millis / 1000 if (timeout_millis / 1000) > 0
-      http = PersistentHttpClient.get(@uri, { read_timeout: read_timeout })
+      http = PersistentHttpClient.get(@uri, { read_timeout: read_timeout }, @api_key)
       request = Net::HTTP::Post.new(@uri, headers)
       request.body = user_context.to_json
       if request.body.length > 8000

data/lib/experiment/version.rb

@@ -1,3 +1,3 @@
 module AmplitudeExperiment
-  VERSION = '1.1.3'.freeze
+  VERSION = '1.1.5'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: amplitude-experiment
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.5
 platform: ruby
 authors:
 - Amplitude
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-13 00:00:00.000000000 Z
+date: 2023-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: psych