amplitude-experiment 1.1.1 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f1a1506a90fa83f40415c6524e7f298ed5173128ff646e11e414f108c8e2f17
-  data.tar.gz: 869a2a9b4f6ff51d0bacf68539e2840d6d229dba821c04419edfe90e383cf638
+  metadata.gz: 79931b2e41b024a2ae5503ff41321635959bfe3ea12ebdec92d565c03ef75072
+  data.tar.gz: f7247ded087e26ad540f22e3e306c8870c33c241e408f214c98839020acddccc
 SHA512:
-  metadata.gz: bb65907db678517994db78e505f511a9b1d757fe1a9da95a7aa1455e1aae3b830494be51b3b72076fc90d57654f33756c146efd5385a98c79e5b50944962c102
-  data.tar.gz: b85101341b8edf212426689aaf23a2ebbed40fc17ab76ca419add6714c6c2a1019438fb05f203ed49037b0552e5e4b1b99cf433ed5ff655e567ffea84915b478
+  metadata.gz: be36e288fa8892698c510b810580834445f75959511ea15b38fec4b079ca91235c920a27ed9ce6f69c6e05609d2b31db6c79cd0d888e59dde68eb7c74e849cf1
+  data.tar.gz: a2d892e60a65bd0f9a4b85d8994aeb26bf9b27d97a7397b8d6999aa408797d84f534d25d9d3a6c967def88c0ee0d313bc349dddd1f5b0a45224e65a656261c9b

data/README.md

@@ -10,6 +10,8 @@
 # Experiment Ruby SDK
 Amplitude Ruby Server SDK for Experiment.
 
+> ⚠️ **Local evaluation process fork safety:** When using a `LocalEvaluationClient` and forking the process, you must call `#start` _after forking_ to update the flag configuration state on the new process. For example, in Puma, this means calling `#start` in the [`on_worker_boot` hook](https://www.rubydoc.info/gems/puma/Puma%2FDSL:on_worker_boot). 
+
 ## Installation
 Into Gemfile from rubygems.org:
 ```ruby
@@ -24,7 +26,6 @@ To install beta versions:
 gem install amplitude-experiment --pre
 ```
 
-
 ## Remote Evaluation Quick Start
 ```ruby
 require 'amplitude-experiment'

data/amplitude-experiment.gemspec

@@ -16,9 +16,10 @@ Gem::Specification.new do |spec|
                                    'amplitude-experiment.gemspec',
                                    'Gemfile',
                                    'lib/experiment/local/evaluation/lib/**/*']
-  spec.require_paths         = ["lib"]
+  spec.require_paths         = ['lib']
   spec.extra_rdoc_files      = ['README.md']
 
+  spec.add_development_dependency 'psych', '~> 4.0'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rdoc', '= 6.4'
   spec.add_development_dependency 'rspec', '~> 3.6'
@@ -26,7 +27,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov', '~> 0.21'
   spec.add_development_dependency 'webmock', '~> 3.14'
   spec.add_development_dependency 'yard', '~> 0.9'
-  spec.add_development_dependency 'psych', '~> 4.0'
   spec.metadata['rubygems_mfa_required'] = 'false'
   spec.add_runtime_dependency 'ffi', '~> 1.15.5'
 end

data/lib/experiment/factory.rb

@@ -2,7 +2,6 @@
 module AmplitudeExperiment
   @local_instance = {}
   @remote_instance = {}
-  @default_instance = '$default_instance'
 
   # Initializes a singleton Client. This method returns a default singleton instance, subsequent calls to
   #  init will return the initial instance regardless of input.
@@ -10,10 +9,8 @@ module AmplitudeExperiment
   # @param [String] api_key The environment API Key
   # @param [Config] config Optional Config.
   def self.initialize_remote(api_key, config = nil)
-    unless @local_instance.key?(@default_instance)
-      @local_instance.store(@default_instance, RemoteEvaluationClient.new(api_key, config))
-    end
-    @local_instance.fetch(@default_instance)
+    @remote_instance.store(api_key, RemoteEvaluationClient.new(api_key, config)) unless @remote_instance.key?(api_key)
+    @remote_instance.fetch(api_key)
   end
 
   # Initializes a local evaluation Client. A local evaluation client can evaluate local flags or experiments for a
@@ -23,9 +20,7 @@ module AmplitudeExperiment
   # @param [String] api_key The environment API Key
   # @param [Config] config Optional Config.
   def self.initialize_local(api_key, config = nil)
-    unless @remote_instance.key?(@default_instance)
-      @remote_instance.store(@default_instance, LocalEvaluationClient.new(api_key, config))
-    end
-    @remote_instance.fetch(@default_instance)
+    @local_instance.store(api_key, LocalEvaluationClient.new(api_key, config)) unless @local_instance.key?(api_key)
+    @local_instance.fetch(api_key)
   end
 end

data/lib/experiment/local/client.rb

@@ -38,9 +38,9 @@ module AmplitudeExperiment
 
       user_str = user.to_json
       @logger.debug("[Experiment] Evaluate: User: #{user_str} - Rules: #{flags}") if @config.debug
-      results_json = evaluation(flags, user_str)
-      @logger.debug("[Experiment] evaluate - result: #{results_json}") if @config.debug
-      parse_results_json(results_json, flag_keys)
+      result = evaluation(flags, user_str)
+      @logger.debug("[Experiment] evaluate - result: #{result}") if @config.debug
+      parse_results(result, flag_keys)
     end
 
     # Fetch initial flag configurations and start polling for updates.
@@ -61,8 +61,7 @@ module AmplitudeExperiment
 
     private
 
-    def parse_results_json(results_json, flag_keys)
-      result = JSON.parse(results_json)
+    def parse_results(result, flag_keys)
       variants = {}
       result.each do |key, value|
         next if value['isDefaultVariant'] || (flag_keys.empty? && flag_keys.include?(key))

data/lib/experiment/local/evaluation/evaluation.rb

@@ -1,5 +1,6 @@
 # rubocop:disable all
 require 'ffi'
+require 'json'
 
 # The evaluation wrapper
 module EvaluationInterop
@@ -59,7 +60,13 @@ end
 def evaluation(rule_json, user_json)
   lib = EvaluationInterop.libevaluation_interop_symbols()
   fn = lib[:kotlin][:root][:evaluate]
-  evaluation_result = fn.call(rule_json, user_json)
-  evaluation_result.read_string
+  result_json = fn.call(rule_json, user_json).read_string
+  result = JSON.parse(result_json)
+  if result["error"] != nil
+    raise "#{result["error"]}"
+  elsif result["result"] == nil
+    raise "Evaluation result is nil."
+  end
+  result["result"]
 end
 # rubocop:disable all

data/lib/experiment/version.rb

@@ -1,3 +1,3 @@
 module AmplitudeExperiment
-  VERSION = '1.1.1'.freeze
+  VERSION = '1.1.3'.freeze
 end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: amplitude-experiment
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.3
 platform: ruby
 authors:
 - Amplitude
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-22 00:00:00.000000000 Z
+date: 2023-06-13 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: psych
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -108,20 +122,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
-- !ruby/object:Gem::Dependency
-  name: psych
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: ffi
   requirement: !ruby/object:Gem::Requirement