amplitude-experiment 1.1.0 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff36301b51f9c519b85c5361aa6e50e45d0e55738ee6d36e10b3599e6b91b98b
-  data.tar.gz: 6e03119d4dd2b6f33c4f0ba312043aac2eb688f211cf827a046d90457a40dcdb
+  metadata.gz: 53e7251a50e66bfd3145abbf399860592fec625dba57df40b84cd2f235a41fd3
+  data.tar.gz: 7405cf8193e72163cc9df7d216460e2eee5b3352ff255e97eed7ec7f5de7367a
 SHA512:
-  metadata.gz: cf4ab1ee2bdc9dc1d40c0b95cbb2a6f4559a7473fa64997045bbb7b0bc9ac3a5c05cc5826a3f411198e3807f41e57de9c491cf44bbe2409c02fd368174d425a5
-  data.tar.gz: 9fb0b7f55cde6e6e51774b5dc434c8f9ec4707b94a03576636a5bec115c23f4e60d09a93fb855595f41be65b8a9ef0b912c671587df16bbe5587950b267e3a5a
+  metadata.gz: cb9498e7a4bd0112e981732e136b2b6907fd34bc9c8bb645e41645c6074edcd891e95bee9919dc987bafdd4bd26969c07e6400884051375756dbb4524d83ba11
+  data.tar.gz: 990927832f1a67b211f982c4a350997d2a2cb91b0d2a62d605b412547e835404145b5546271f4af9dd75af4582b64fb887529f380c1ee4980ac9e81330e581c6

data/amplitude-experiment.gemspec

@@ -16,9 +16,10 @@ Gem::Specification.new do |spec|
                                    'amplitude-experiment.gemspec',
                                    'Gemfile',
                                    'lib/experiment/local/evaluation/lib/**/*']
-  spec.require_paths         = ["lib"]
+  spec.require_paths         = ['lib']
   spec.extra_rdoc_files      = ['README.md']
 
+  spec.add_development_dependency 'psych', '~> 4.0'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rdoc', '= 6.4'
   spec.add_development_dependency 'rspec', '~> 3.6'
@@ -26,7 +27,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov', '~> 0.21'
   spec.add_development_dependency 'webmock', '~> 3.14'
   spec.add_development_dependency 'yard', '~> 0.9'
-  spec.add_development_dependency 'psych', '~> 4.0'
   spec.metadata['rubygems_mfa_required'] = 'false'
   spec.add_runtime_dependency 'ffi', '~> 1.15.5'
 end

data/lib/experiment/local/client.rb

@@ -20,7 +20,7 @@ module AmplitudeExperiment
                       else
                         Logger::INFO
                       end
-      @fetcher = LocalEvaluationFetcher.new(api_key, @config.debug, @config.server_url)
+      @fetcher = LocalEvaluationFetcher.new(api_key, @logger, @config.server_url)
       raise ArgumentError, 'Experiment API key is empty' if @api_key.nil? || @api_key.empty?
     end
 
@@ -38,9 +38,9 @@ module AmplitudeExperiment
 
       user_str = user.to_json
       @logger.debug("[Experiment] Evaluate: User: #{user_str} - Rules: #{flags}") if @config.debug
-      results_json = evaluation(flags, user_str)
-      @logger.debug("[Experiment] evaluate - result: #{results_json}") if @config.debug
-      parse_results_json(results_json, flag_keys)
+      result = evaluation(flags, user_str)
+      @logger.debug("[Experiment] evaluate - result: #{result}") if @config.debug
+      parse_results(result, flag_keys)
     end
 
     # Fetch initial flag configurations and start polling for updates.
@@ -61,8 +61,7 @@ module AmplitudeExperiment
 
     private
 
-    def parse_results_json(results_json, flag_keys)
-      result = JSON.parse(results_json)
+    def parse_results(result, flag_keys)
       variants = {}
       result.each do |key, value|
         next if value['isDefaultVariant'] || (flag_keys.empty? && flag_keys.include?(key))

data/lib/experiment/local/evaluation/evaluation.rb

@@ -1,5 +1,6 @@
 # rubocop:disable all
 require 'ffi'
+require 'json'
 
 # The evaluation wrapper
 module EvaluationInterop
@@ -59,7 +60,13 @@ end
 def evaluation(rule_json, user_json)
   lib = EvaluationInterop.libevaluation_interop_symbols()
   fn = lib[:kotlin][:root][:evaluate]
-  evaluation_result = fn.call(rule_json, user_json)
-  evaluation_result.read_string
+  result_json = fn.call(rule_json, user_json).read_string
+  result = JSON.parse(result_json)
+  if result["error"] != nil
+    raise "#{result["error"]}"
+  elsif result["result"] == nil
+    raise "Evaluation result is nil."
+  end
+  result["result"]
 end
 # rubocop:disable all

data/lib/experiment/local/fetcher.rb

@@ -5,11 +5,11 @@ module AmplitudeExperiment
   class LocalEvaluationFetcher
     FLAG_CONFIG_TIMEOUT = 5000
 
-    def initialize(api_key, debug, server_url = 'https://api.lab.amplitude.com')
+    def initialize(api_key, logger, server_url = 'https://api.lab.amplitude.com')
       @api_key = api_key
       @server_url = server_url
-      @debug = debug
-      @http =  PersistentHttpClient.get(server_url, { read_timeout: FLAG_CONFIG_TIMEOUT })
+      @logger = logger
+      @http = PersistentHttpClient.get(server_url, { read_timeout: FLAG_CONFIG_TIMEOUT })
     end
 
     # Fetch local evaluation mode flag configs from the Experiment API server.
@@ -27,7 +27,7 @@ module AmplitudeExperiment
       response = @http.request(request)
       raise "flagConfigs - received error response: #{response.code}: #{response.body}" unless response.is_a?(Net::HTTPOK)
 
-      @logger.debug("[Experiment] Fetch flag configs: #{response.body}") if @debug
+      @logger.debug("[Experiment] Fetch flag configs: #{response.body}")
       response.body
     end
 
@@ -47,7 +47,7 @@ module AmplitudeExperiment
       raise "flagConfigs - received error response: #{response.code}: #{response.body}" unless response.is_a?(Net::HTTPOK)
 
       flag_configs = parse(response.body)
-      @logger.debug("[Experiment] Fetch flag configs: #{request.body}") if @debug
+      @logger.debug("[Experiment] Fetch flag configs: #{request.body}")
       flag_configs
     end
 

data/lib/experiment/version.rb

@@ -1,3 +1,3 @@
 module AmplitudeExperiment
-  VERSION = '1.1.0'.freeze
+  VERSION = '1.1.2'.freeze
 end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: amplitude-experiment
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.2
 platform: ruby
 authors:
 - Amplitude
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-14 00:00:00.000000000 Z
+date: 2023-06-10 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: psych
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -108,20 +122,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
-- !ruby/object:Gem::Dependency
-  name: psych
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: ffi
   requirement: !ruby/object:Gem::Requirement