amounts 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf7f88449ef3636b2ad506b569793e7943f6cd16b82bb1013d8eb7c8a866c41b
-  data.tar.gz: 49e3027de827e8cd1747fd5df795e3a605736a6192298cc403a1a9de19ad158f
+  metadata.gz: 95dbf17ecb45d86b36277c6ecdaf611bdcb99d12eb97a3fc42b5f3bf2cd1ec50
+  data.tar.gz: 67fcceae2bae4582f4c4e2866f453727a23f444703e47717ab9e7420e8ff20de
 SHA512:
-  metadata.gz: 51e5cc2f4c0e9c1cad9289933283c9d687c36618edb09ed7524c7a366e104c98d46386ebafac1db67f129c72a2605248d3a0bf44b4962cc83aab4ae7154c7af6
-  data.tar.gz: 738dcbbc4f4aae614d002f4c127ecdb820585e0fee51ec61ddc9381d55acd264ea7db87d1150afb15a96bd803af03d9f2dbd9b672415d4fdf81ec3400e67f06c
+  metadata.gz: 15833dd17e8b167cfc61812af65dc0addad29912459a3886df4bd54b01cd8c43d055654cd971838a1c9b5fc76bca8cf83e8eaa72e25eaa4901eef93177275e4a
+  data.tar.gz: 002e0c5539b2ed22551a87d0d696a8cbfd2b87565b3c991a91fbbacb3c81e722d3b8b1af62bf1aa0604e08691805bfb2375cf2015f06bd57c62228525b9454ca

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## 0.0.3 - 2026-04-26
+
+### Fixed
+
+- Rational scalars and rates are now accepted everywhere they are documented to
+  work: `Amount#*`, `Amount#/`, `Amount#to(rate:)`, `Amount.register_default_rate`,
+  and `display_units[unit][:scale]`. Previously each of these called
+  `BigDecimal(value.to_s)`, which raises `ArgumentError` for `Rational#to_s`
+  (`"3/2"`). All five sites now go through a single internal helper,
+  `Amount.coerce_decimal`, that handles `BigDecimal`, `Rational`, and string-or-
+  numeric inputs uniformly.
+- `Amount.load` wraps a missing `:atomic` or `:symbol` key as
+  `Amount::InvalidInput` (`"amount payload missing key: atomic"`) instead of
+  leaking a raw `KeyError`. This matches the AR adapter's `Type#cast_hash`
+  behavior so callers can rescue a single error class.
+
 ## 0.0.2 - 2026-04-26
 
 ### Fixed

data/lib/amount/display.rb

@@ -32,7 +32,7 @@ class Amount
     # @return [BigDecimal]
     def in_unit(unit)
       unit_spec = fetch_display_unit(unit)
-      @amount.decimal * BigDecimal(unit_spec[:scale].to_s)
+      @amount.decimal * Amount.coerce_decimal(unit_spec[:scale])
     end
 
     private
@@ -44,7 +44,7 @@ class Amount
 
     def render_display_unit(unit, direction)
       spec = fetch_display_unit(unit)
-      scaled = @amount.decimal * BigDecimal(spec[:scale].to_s)
+      scaled = @amount.decimal * Amount.coerce_decimal(spec[:scale])
       decimals = spec[:ui_decimals] || @entry.ui_decimals
       rounded = round(scaled, decimals, direction)
 

data/lib/amount/registry.rb

@@ -151,7 +151,7 @@ class Amount
 
       @lock.synchronize do
         ensure_unlocked!
-        @default_rates[[from, to]] = BigDecimal(rate.to_s)
+        @default_rates[[from, to]] = Amount.coerce_decimal(rate)
       end
     end
 

data/lib/amount/serializer.rb

@@ -22,6 +22,8 @@ class Amount
         payload.fetch(:symbol) { payload.fetch("symbol") },
         from: :atomic
       )
+    rescue KeyError => e
+      raise InvalidInput, "amount payload missing key: #{e.key}"
     end
 
     def self.validate_version!(version)

data/lib/amount/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Amount
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/amount.rb

@@ -102,6 +102,22 @@ class Amount
       super
     end
 
+    # Coerces a numeric input to BigDecimal in a way that preserves Rational
+    # values. `BigDecimal(value.to_s)` raises `ArgumentError` for Rational
+    # because `Rational#to_s` produces strings like `"3/2"`. This helper is
+    # the single place every call site should use to convert a scalar / rate /
+    # display-unit scale into a BigDecimal.
+    #
+    # @param value [Numeric, BigDecimal, Rational, String]
+    # @return [BigDecimal]
+    def coerce_decimal(value)
+      case value
+      when BigDecimal then value
+      when Rational then BigDecimal(value, Float::DIG + 4)
+      else BigDecimal(value.to_s)
+      end
+    end
+
     # Temporarily swaps the global registry. Intended for tests.
     #
     # @param registry [Amount::Registry]
@@ -281,7 +297,7 @@ class Amount
   #   Amount.usdc("1.25") * 2
   def *(scalar)
     ensure_scalar!(scalar)
-    build((BigDecimal(@atomic) * BigDecimal(scalar.to_s)).to_i)
+    build((BigDecimal(@atomic) * Amount.coerce_decimal(scalar)).to_i)
   end
 
   # @param other [Amount, Numeric]
@@ -302,7 +318,7 @@ class Amount
       ensure_scalar!(other)
       raise ZeroDivisionError if other.zero?
 
-      build((BigDecimal(@atomic) / BigDecimal(other.to_s)).to_i)
+      build((BigDecimal(@atomic) / Amount.coerce_decimal(other)).to_i)
     end
   end
 
@@ -411,7 +427,7 @@ class Amount
     rate = resolve_rate(target_symbol, rate)
     target_entry = self.class.registry.lookup(target_symbol)
 
-    decimal_result = decimal * BigDecimal(rate.to_s)
+    decimal_result = decimal * Amount.coerce_decimal(rate)
     atomic_result = (decimal_result * (BigDecimal(10)**target_entry.decimals)).to_i
 
     target_entry.amount_class.new(atomic_result, target_symbol, from: :atomic)

data/test/test_amount.rb

@@ -229,6 +229,8 @@ class AmountTest < Minitest::Test
     assert_equal Amount.new("3", :USDC), Amount.new("1", :USDC) * 3
     assert_equal Amount.new("1.5", :USDC), Amount.new("1", :USDC) * 1.5
     assert_equal Amount.new("2", :USDC), Amount.new("-1", :USDC) * -2
+    assert_equal Amount.new("3", :USDC), Amount.new("2", :USDC) * BigDecimal("1.5")
+    assert_equal Amount.new("3", :USDC), Amount.new("2", :USDC) * Rational(3, 2)
   end
 
   def test_amount_times_amount_raises
@@ -240,6 +242,8 @@ class AmountTest < Minitest::Test
   def test_scalar_division_returns_amount
     assert_equal Amount.new("0.5", :USDC), Amount.new("1", :USDC) / 2
     assert_equal Amount.new("2", :USDC), Amount.new("-1", :USDC) / -0.5
+    assert_equal Amount.new("2", :USDC), Amount.new("3", :USDC) / Rational(3, 2)
+    assert_equal Amount.new("2", :USDC), Amount.new("3", :USDC) / BigDecimal("1.5")
   end
 
   def test_amount_division_returns_ratio
@@ -353,6 +357,33 @@ class AmountTest < Minitest::Test
     assert_equal :GOLD, gold.symbol
   end
 
+  def test_to_with_rational_rate
+    converted = Amount.new("4", :USDC).to(:USD, rate: Rational(1, 2))
+
+    assert_equal BigDecimal("2"), converted.decimal
+    assert_equal :USD, converted.symbol
+  end
+
+  def test_register_default_rate_accepts_rational
+    Amount.register_default_rate :USDC, :USD, Rational(1, 2)
+
+    assert_equal BigDecimal("0.5"), Amount.registry.default_rate(:USDC, :USD)
+    assert_equal BigDecimal("0.5"), Amount.new("1", :USDC).to(:USD).decimal
+  end
+
+  def test_display_units_with_rational_scale
+    Amount.registry.clear!
+    Amount.register :METAL, decimals: 4, display_symbol: "x", display_position: :suffix,
+      ui_decimals: 2,
+      display_units: { half: { scale: Rational(1, 2), symbol: "h", ui_decimals: 2 } },
+      default_display: :half
+
+    metal = Amount.new("1", :METAL)
+
+    assert_equal BigDecimal("0.5"), metal.in_unit(:half)
+    assert_match(/\A0\.50/, metal.ui(unit: :half))
+  end
+
   def test_to_without_rate_requires_default
     assert_raises(Amount::Registry::NoDefaultRate) do
       Amount.new("1", :USDC).to(:GOLD)
@@ -406,6 +437,14 @@ class AmountTest < Minitest::Test
     assert_equal Amount.new("1.5", :USDC), amount
   end
 
+  def test_load_wraps_missing_keys_as_invalid_input
+    error = assert_raises(Amount::InvalidInput) { Amount.load(v: 1, symbol: "USDC") }
+    assert_match(/missing key: atomic/, error.message)
+
+    error = assert_raises(Amount::InvalidInput) { Amount.load({}) }
+    assert_match(/missing key/, error.message)
+  end
+
   def test_load_rejects_unknown_serialization_version
     assert_raises(Amount::InvalidInput) do
       Amount.load(v: 2, atomic: "1500000", symbol: "USDC")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: amounts
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Seb Scholl