amount_field_rails3 3.0.0 → 3.0.1

data/.gitignore

@@ -1,5 +1,6 @@
 *.gem
 .bundle
+.rvmrc
 Gemfile.lock
 pkg/*
 doc

data/History.txt

@@ -1,3 +1,8 @@
+== 3.0.1 2011-09-14
+
+* Fix issue "ActiveRecord::DangerousAttributeError:configuration=" 
+  (see https://github.com/thomasbaustert/amount_field/issues/1)
+
 == 3.0.0 2011-03-29
 
 * Migrate to Rails3

data/lib/amount_field/validations.rb

@@ -2,8 +2,11 @@ module AmountField #:nodoc:
   module ActiveRecord #:nodoc: 
     module Validations
 
+      # Note: Don't use mattr_accessor here because it will define 'def configuration=' too which leads to error 
+      # "ActiveRecord::DangerousAttributeError:configuration=" in case the AR model has an attribute 'configuration'.
       @@configuration = {}
-      mattr_accessor :configuration
+      def self.configuration=(c); @@configuration = c; end
+      def self.configuration; @@configuration; end
 
       def self.included(base) # :nodoc:
         base.extend ClassMethods
@@ -15,7 +18,7 @@ module AmountField #:nodoc:
           # code before validates_each is called only once!
           configuration = attr_names.extract_options!
 
-          define_special_setter(attr_names, configuration)
+          define_special_setter(attr_names)
 
           # the following code defines the callbacks methods that are called on every validation
           validates_each(attr_names, configuration) do |record, attr_name, value|
@@ -55,7 +58,7 @@ module AmountField #:nodoc:
         
         private
 
-          def define_special_setter(attr_names, configuration)
+          def define_special_setter(attr_names)
             attr_names.each do |attr_name| 
               class_eval <<-EOV
                 def #{special_method_name(attr_name)}=(value)

data/lib/amount_field/version.rb

@@ -1,3 +1,3 @@
 module AmountField
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

data/test/test_helper.rb

@@ -21,6 +21,11 @@ ActiveRecord::Schema.define(:version => 1) do
     t.column "stock_price", :decimal, :precision => 12, :scale => 2
     t.column "float_price", :float
   end
+
+  create_table "test_products_with_configuration", :force => true do |t|    
+    t.column "configuration", :string
+    t.column "price", :decimal, :precision => 12, :scale => 2
+  end
 end
 
 class ActiveSupport::TestCase

data/test/validations_test.rb

@@ -50,8 +50,7 @@ class ValidationsTest < ActiveSupport::TestCase
       '1.234.567,89' => 1234567.89 
     }
   end
-  
-  
+                                  
   test "orignal setter accept ruby value if set via new" do
     product = TestProduct.new(:price => 12.34)
     assert_in_delta 12.34, product.price, 0.001
@@ -385,5 +384,17 @@ class ValidationsTest < ActiveSupport::TestCase
     assert p.errors.full_messages.include?("Price is not a number")
   end
 
+  test "configuration must not interfere with an active record model attribute" do
+    class TestProductWithAttributeConfiguration < ActiveRecord::Base
+      set_table_name 'test_products_with_configuration'
+      validates_amount_format_of :price
+    end
+    with_locale('de') do
+      p = TestProductWithAttributeConfiguration.new(:amount_field_price => "1,23", :configuration => "TEXT")
+      assert p.valid?
+      assert_equal "TEXT", p.configuration
+    end
+  end
+  
 end
 

metadata

@@ -1,45 +1,35 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: amount_field_rails3
-version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 3
-  - 0
-  - 0
-  version: 3.0.0
+version: !ruby/object:Gem::Version
+  version: 3.0.1
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Thomas Baustert
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-04-04 00:00:00 +02:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-09-14 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: mysql2
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2161516960 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-description: Rails gem/plugin that accepts (amount) values in german or us format like 1.234,56 or 1,234.56
-email: 
+  prerelease: false
+  version_requirements: *2161516960
+description: Rails gem/plugin that accepts (amount) values in german or us format
+  like 1.234,56 or 1,234.56
+email:
 - business@thomasbaustert.de
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - Gemfile
 - History.txt
@@ -64,39 +54,32 @@ files:
 - test/test_helper.rb
 - test/validations_test.rb
 - uninstall.rb
-has_rdoc: true
 homepage: http://github.com/thomasbaustert/amount_field
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: amount_field_rails3
-rubygems_version: 1.3.7
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
-summary: Rails gem/plugin that accepts (amount) values in german or us format like 1.234,56 or 1,234.56
-test_files: 
+summary: Rails gem/plugin that accepts (amount) values in german or us format like
+  1.234,56 or 1,234.56
+test_files:
 - test/form_helper_test.rb
 - test/form_tag_helper_test.rb
 - test/models/test_product.rb