amorail 0.3.4 → 0.6.0

data/lib/amorail/entity/params.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/indifferent_access"
 
 module Amorail # :nodoc: all

data/lib/amorail/entity/{persistance.rb → persistence.rb}

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Amorail # :nodoc: all
   class Entity
     class InvalidRecord < ::Amorail::Error; end
@@ -13,6 +15,7 @@ module Amorail # :nodoc: all
 
     def save
       return false unless valid?
+
       new_record? ? push('add') : push('update')
     end
 
@@ -22,6 +25,7 @@ module Amorail # :nodoc: all
 
     def update(attrs = {})
       return false if new_record?
+
       merge_params(attrs)
       push('update')
     end
@@ -32,6 +36,7 @@ module Amorail # :nodoc: all
 
     def reload
       fail NotPersisted if id.nil?
+
       load_record(id)
     end
 
@@ -40,5 +45,24 @@ module Amorail # :nodoc: all
     def extract_data_add(response)
       response.fetch('add').first
     end
+
+    # Update response can have status 200 and contain errors.
+    # In case of errors "update" key in a response is a Hash with "errors" key.
+    # If there are no errors "update" key is an Array with entities attributes.
+    def extract_data_update(response)
+      case data = response.fetch('update')
+      when Array
+        data.first
+      when Hash
+        merge_errors(data)
+        raise(InvalidRecord)
+      end
+    end
+
+    def merge_errors(data)
+      data.fetch("errors").each do |_, message|
+        errors.add(:base, message)
+      end
+    end
   end
 end

data/lib/amorail/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Amorail Exceptions.
 # Every class is name of HTTP response error code(status)
 module Amorail

data/lib/amorail/property.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Amorail
   # Return hash key as method call
   module MethodMissing
@@ -8,6 +10,10 @@ module Amorail
         super
       end
     end
+
+    def respond_to_missing?(method_sym, *args)
+      args.size.zero? && data.key?(method_sym.to_s)
+    end
   end
 
   class Property # :nodoc: all
@@ -22,6 +28,7 @@ module Amorail
           data['custom_fields'].fetch(source_name, []).each do |contact|
             identifier = contact['code'].presence || contact['name'].presence
             next if identifier.nil?
+
             hash[identifier.downcase] = PropertyItem.new(contact)
           end
           new hash
@@ -114,6 +121,7 @@ module Amorail
           prop_item = PropertyItem.new(tt)
           identifier = tt['code'].presence || tt['name'].presence
           next if identifier.nil?
+
           hash[identifier.downcase] = prop_item
           hash[identifier] = prop_item
         end

data/lib/amorail/railtie.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 module Amorail
+  # Add amorail rake tasks
   class Railtie < Rails::Railtie
     rake_tasks do
-      load File.expand_path('../../tasks/amorail.rake', __FILE__)
+      load File.expand_path('../tasks/amorail.rake', __dir__)
     end
   end
 end

data/lib/amorail/version.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 # Amorail version
 module Amorail
-  VERSION = "0.3.4".freeze
+  VERSION = '0.6.0'
 end

data/lib/tasks/amorail.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 namespace :amorail do
   desc 'Check Amorail configuration'
   task :check do

data/spec/client_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Amorail::Client do

data/spec/company_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Amorail::Company do

data/spec/contact_link_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Amorail::ContactLink do

data/spec/contact_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Amorail::Contact do
@@ -136,6 +138,21 @@ describe Amorail::Contact do
     end
   end
 
+  describe ".where" do
+    before { contacts_where_stub(Amorail.config.api_endpoint, query: 'xxx', limit_rows: 10, limit_offset: 100) }
+
+    it "loads entities" do
+      res = described_class.where(query: 'xxx', limit_rows: 10, limit_offset: 100)
+      expect(res.size).to eq 2
+      expect(res.first.id).to eq 101
+      expect(res.last.id).to eq 102
+      expect(res.first.company_name).to eq "Foo Inc."
+      expect(res.last.email).to eq "foo2@tb.com"
+      expect(res.first.phone).to eq "1111 111 111"
+      expect(res.first.params[:id]).to eq 101
+    end
+  end
+
   describe "#save" do
     before { contact_create_stub(Amorail.config.api_endpoint) }
 

data/spec/entity_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe MyEntity do

data/spec/fixtures/{account_response.json → accounts/response_1.json}

@@ -141,9 +141,9 @@
             }
           },
           {
-            "id":  "116302",
-            "name":  "teachbase_id",
-            "multiple":  "N",
+            "id": "116302",
+            "name": "teachbase_id",
+            "multiple": "N",
             "type_id": "8"
           }
         ],
@@ -162,7 +162,7 @@
             "multiple": "N",
             "type_id": "3"
           }
-          ],
+        ],
         "companies": [
           {
             "id": "1460589",
@@ -341,4 +341,4 @@
     },
     "server_time": 1422442143
   }
-}
+}

data/spec/fixtures/{account2_response.json → accounts/response_2.json}

@@ -192,4 +192,4 @@
     },
     "server_time": 1422442143
   }
-}
+}

data/spec/fixtures/{contact_create.json → contacts/create.json}

@@ -10,4 +10,4 @@
     },
     "server_time": 1423139130
   }
-}
+}

data/spec/fixtures/{contact_find_query.json → contacts/find_many.json}

@@ -7,8 +7,7 @@
         "account_id": "8195968",
         "last_modified": 1423139130,
         "company_name": "Foo Inc.",
-        "custom_fields": 
-        [
+        "custom_fields": [
           {
             "id": "1460591",
             "name": "Email",
@@ -39,8 +38,7 @@
         "account_id": "8195968",
         "last_modified": 1423139150,
         "company_name": "Foo Inc.",
-        "custom_fields": 
-        [
+        "custom_fields": [
           {
             "id": "1460591",
             "name": "Email",
@@ -56,4 +54,4 @@
       }
     ]
   }
-}
+}

data/spec/fixtures/{contact_find.json → contacts/find_one.json}

@@ -7,12 +7,11 @@
         "account_id": "8195968",
         "last_modified": 1423139130,
         "company_name": "Foo Inc.",
-        "linked_leads_id":  [
-           "1872746",
-           "1885024"
+        "linked_leads_id": [
+          "1872746",
+          "1885024"
         ],
-        "custom_fields": 
-        [
+        "custom_fields": [
           {
             "id": "1460591",
             "name": "Email",
@@ -39,4 +38,4 @@
       }
     ]
   }
-}
+}

data/spec/fixtures/contacts/links.json

@@ -0,0 +1,16 @@
+{
+  "response": {
+    "links": [
+      {
+        "contact_id": "101",
+        "lead_id": "1",
+        "last_modified": 1374741830
+      },
+      {
+        "contact_id": "101",
+        "lead_id": "2",
+        "last_modified": 1374839942
+      }
+    ]
+  }
+}

data/spec/fixtures/{my_contact_find.json → contacts/my_contact_find.json}

@@ -7,8 +7,7 @@
         "account_id": "8195968",
         "last_modified": 1423139130,
         "company_name": "Foo Inc.",
-        "custom_fields": 
-        [
+        "custom_fields": [
           {
             "id": "1460591",
             "name": "Email",
@@ -45,4 +44,4 @@
       }
     ]
   }
-}
+}

data/spec/fixtures/contacts/update.json

@@ -0,0 +1,13 @@
+{
+  "response": {
+    "contacts": {
+      "update": [
+        {
+          "id": 12509853,
+          "last_modified": 1501256276
+        }
+      ]
+    },
+    "server_time": 1501452197
+  }
+}

data/spec/fixtures/leads/create.json

@@ -0,0 +1,13 @@
+{
+  "response": {
+    "leads": {
+      "add": [
+        {
+          "id": 3980037,
+          "request_id": 0
+        }
+      ]
+    },
+    "server_time": 1502394640
+  }
+}

data/spec/fixtures/leads/find_many.json

@@ -0,0 +1,73 @@
+{
+  "response": {
+    "leads": [
+      {
+        "id": "1",
+        "name": "Research new technologies",
+        "last_modified": 1374656336,
+        "status_id": "7046196",
+        "pipeline_id": 683506,
+        "price": "500000",
+        "responsible_user_id": "103586",
+        "tags": [
+          {
+            "id": "960472",
+            "name": "USA"
+          },
+          {
+            "id": "960854",
+            "name": "Lead"
+          }
+        ],
+        "date_create": 1386014400,
+        "account_id": "7046192",
+        "created_user_id": "4502311",
+        "custom_fields": [
+          {
+            "id": "484604",
+            "name": "field",
+            "values": [
+              {
+                "value": "text"
+              }
+            ]
+          }
+        ]
+      },
+      {
+        "id": "2",
+        "name": "Sell it!",
+        "last_modified": 1374656336,
+        "status_id": "7046196",
+        "pipeline_id": 683506,
+        "price": "100000",
+        "responsible_user_id": "103586",
+        "tags": [
+          {
+            "id": "960472",
+            "name": "USA"
+          },
+          {
+            "id": "960854",
+            "name": "Lead"
+          }
+        ],
+        "date_create": 1386014400,
+        "account_id": "7046192",
+        "created_user_id": "4502311",
+        "custom_fields": [
+          {
+            "id": "484604",
+            "name": "field",
+            "values": [
+              {
+                "value": "text"
+              }
+            ]
+          }
+        ]
+      }
+    ],
+    "server_time": 1374839787
+  }
+}

data/spec/fixtures/leads/links.json

@@ -0,0 +1,16 @@
+{
+  "response": {
+    "links": [
+      {
+        "contact_id": "101",
+        "lead_id": "2",
+        "last_modified": 1374839942
+      },
+      {
+        "contact_id": "102",
+        "lead_id": "2",
+        "last_modified": 1374839942
+      }
+    ]
+  }
+}

data/spec/fixtures/leads/update.json

@@ -0,0 +1,13 @@
+{
+  "response": {
+    "leads": {
+      "update": [
+        {
+          "id": 3103031,
+          "last_modified": 1502393989
+        }
+      ]
+    },
+    "server_time": 1502393993
+  }
+}

data/spec/fixtures/leads/update_errors.json

@@ -0,0 +1,12 @@
+{
+  "response": {
+    "leads": {
+      "update": {
+        "errors": {
+          "3103031": "Last modified date is older than in database"
+        }
+      }
+    },
+    "server_time": 1502391257
+  }
+}