amfetamine 0.3.2 → 0.3.3

data/CHANGELOG.md

@@ -0,0 +1,40 @@
+## 0.3.3
+
+* fix for double Array error messages bug for remote (server) validations [Issue #6]
+
+## 0.3.2
+
+* fix for Object#save return value with disabled caching
+
+## 0.3.1
+
+* `memcached_instance` Dalli::Client configuration setting changes (it should now start with "memcached://")
+
+## 0.3.0
+
+* Caching is now turned off by default in Rails development/test modes
+* Add `class_name` and `foreign_key` options to relationships, which allows mapping resources to local Amfetamine classes with different names
+
+## 0.2.12
+
+* Add abillity to deactivate caching, using `disable_caching=` on either the config or an object
+* Starting builds against other ruby versions
+
+## 0.2.11
+
+* Rewrote specs to be idempotent when randomized
+* Fixed a lot of specs for travis in general
+
+## 0.2.10
+
+* Removed verbosity from tests
+* Dropped support for Ruby 1.8.7
+* Sourcecode is now available on github
+
+## 0.2.9
+
+* Cleaning up
+
+## 0.2.8
+
+* Attributes are now set dynamically. This **overrides** anything you set on `amfetamine_attributes`. This should reduce a lot of bloat.

data/lib/amfetamine/rest_helpers.rb

@@ -28,8 +28,10 @@ module Amfetamine
         true
       when :errors
         Amfetamine.logger.warn "Errors from response\n #{response[:body]}"
-        response[:body].each do |attr, mesg|
-          errors.add(attr.to_sym, mesg )
+        response[:body].each do |attr, error_messages|
+          error_messages.each do |msg|
+            errors.add(attr.to_sym, msg)
+          end
         end
         false
       when :server_error

data/lib/amfetamine/version.rb

@@ -1,3 +1,3 @@
 module Amfetamine
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

data/spec/amfetamine/base_spec.rb

@@ -14,7 +14,7 @@ describe Amfetamine::Base do
 
   end
 
-  describe "Class dummy, setup with amfetamine::base" do
+  describe "Class dummy, setup with Amfetamine::Base" do
     let(:dummy) { build(:dummy) }
     let(:dummy2) { build(:dummy) }
     subject { Dummy}
@@ -83,7 +83,6 @@ describe Amfetamine::Base do
       it "should create an object if data is correct" do
         Dummy.prevent_external_connections! do |r|
           r.post(:code => 201) {}
-
           new_dummy = Dummy.create({:title => 'test', :description => 'blabla'})
           new_dummy.should be_a(Dummy)
           new_dummy.should_not be_new
@@ -91,15 +90,22 @@ describe Amfetamine::Base do
         end
       end
 
-      it "should return errors if data is incorrect" do
+      it "sets errors hash if local validations fail" do
+        new_dummy = Dummy.create({ title: 'test' })
+        new_dummy.should be_new
+        new_dummy.errors.messages.should eql({ description: ["can't be blank"] })
+        new_dummy.should_not be_cached
+      end
+
+      it "sets errors hash if remote validations fail" do
+        error_message = "has already been taken"
         Dummy.prevent_external_connections! do |r|
-          r.post(:code => 422) {{:description => ['can\'t be blank']}}
-          new_dummy = Dummy.create({:title => 'test'})
+          r.post(code: 422) { { title: [error_message] } }
+          new_dummy = Dummy.create({ title: 'test', description: 'test' })
           new_dummy.should be_new
-          new_dummy.errors.messages.should eq({:description => ['can\'t be blank']})
+          new_dummy.errors.messages.should eql({ title: [error_message] })
           new_dummy.should_not be_cached
         end
-
       end
     end
 
@@ -127,15 +133,18 @@ describe Amfetamine::Base do
         Dummy.disable_caching = false
       end
 
-      it "should show errors if response is not succesful" do
-        Dummy.prevent_external_connections! do |r|
-          r.put(:code => 422) { [:title => ['can\'t be blank']]}
+      it "sets errors hash if local validations fail" do
+        dummy.update_attributes({ title: "" })
+        dummy.errors.messages.should eql({ title: ["can't be blank"] })
+      end
 
-          dummy.update_attributes({:title => ''})
+      it "sets errors hash if remote validations fail" do
+        error_message = "has already been taken"
+        Dummy.prevent_external_connections! do |r|
+          r.put(code: 422) { { title: [error_message] } }
+          dummy.update_attributes({ title: "abc" })
+          dummy.errors.messages.should eql({ title: [error_message] })
         end
-
-        dummy.should_not be_new
-        dummy.errors.messages.should eq({:title => ['can\'t be blank']})
       end
 
       it "should not do a request if the data doesn't change" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: amfetamine
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-13 00:00:00.000000000 Z
+date: 2012-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -280,7 +280,7 @@ files:
 - .rspec
 - .travis.yml
 - .vagrant
-- CHANGELOG
+- CHANGELOG.md
 - Gemfile
 - README.md
 - Rakefile
@@ -333,7 +333,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2740467481176466622
+      hash: 1384160561817165326
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -342,7 +342,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2740467481176466622
+      hash: 1384160561817165326
 requirements: []
 rubyforge_project: amfetamine
 rubygems_version: 1.8.24

data/CHANGELOG

@@ -1,28 +0,0 @@
-0.3.2
-- fix for Object#save return value with disabled caching
-
-0.3.1
-- memcached_instance Dalli::Client configuration setting changes (it should now start with "memcached://")
-
-0.3.0
-- Caching is now turned off by default in Rails development/test modes
-- Add `class_name` and `foreign_key` options to relationships, which allows mapping resources to local Amfetamine classes with different names
-
-0.2.12
-- Add abillity to deactivate caching, using disable_caching= on either the config or an object.
-- Starting builds against other ruby versions
-
-0.2.11
-- Rewrote specs to be idempotent when randomized
-- Fixed a lot of specs for travis in general
-
-0.2.10
-- Removed verbosity from tests
-- Dropped support for Ruby 1.8.7
-- Sourcecode is now available on github
-
-0.2.9
-- Cleaning up
-
-0.2.8
-- Attributes are now set dynamically. This OVERIDES anything you set on 'amfetamine_attributes'. This should reduce a lot of bloat.