amex 0.3.1 → 0.3.2

data/Gemfile

@@ -2,4 +2,4 @@ source "http://rubygems.org"
 
 gem 'httparty', '0.9.0'
 gem 'nokogiri', '1.5.6'
-gem 'amex', '0.3.1'
+gem 'amex', '0.3.2'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 GEM
   remote: http://rubygems.org/
   specs:
-    amex (0.3.0)
+    amex (0.3.2)
       httparty
       nokogiri
     httparty (0.9.0)
@@ -15,6 +15,6 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  amex (= 0.3.0)
+  amex (= 0.3.2)
   httparty (= 0.9.0)
   nokogiri (= 1.5.6)

data/README.md

@@ -20,6 +20,8 @@ __v0.3.0__ - Adds support for loading the transactions from the most recent stat
 (but it's broken because I forgot to change something from testing :( )
 __v0.3.1__ - Working version of v0.3.0 that will successfully load transactions
 from the most recent statement
+__v0.3.2__ - Generates a fake HardwareId in the first request, since I'm
+paranoid about American Express blocking 'dummy_device_id'
 
 ### Usage
 

data/lib/amex/client.rb

@@ -13,27 +13,6 @@ module Amex
       @password = password
     end
 
-    def request_xml
-      xml = File.read(
-        File.expand_path(File.dirname(__FILE__) + '/data/request.xml')
-      )
-
-      username = @username
-      password = @password
-      timestamp = Time.now.to_i
-
-      ERB.new(xml).result(binding)
-    end
-
-    def statement_request_xml(card_index)
-      xml = File.read(
-        File.expand_path(File.dirname(__FILE__) + '/data/statement_request.xml')
-      )
-
-      security_token = @security_token
-      ERB.new(xml).result(binding)
-    end
-
     def accounts
       # This only supports one account for now, because I'm lazy and I
       # hate traversing XML...
@@ -101,5 +80,44 @@ module Amex
 
     end
 
+    private
+
+    def request_xml
+      # Generates XML for the first request for account information, taking
+      # an XML template and interpolating some parts with ERB
+
+      xml = File.read(
+        File.expand_path(File.dirname(__FILE__) + '/data/request.xml')
+      )
+
+      username = @username
+      password = @password
+      timestamp = Time.now.to_i
+
+      ERB.new(xml).result(binding)
+    end
+
+    def statement_request_xml(card_index)
+      # Generates XML for grabbing the last statement's transactions for a
+      # card, using the card_index attribute from an account's XML
+
+      xml = File.read(
+        File.expand_path(File.dirname(__FILE__) + '/data/statement_request.xml')
+      )
+
+      security_token = @security_token
+      ERB.new(xml).result(binding)
+    end
+
+    def hardware_id
+      # Generates a fake HardwareId - a 40 character alphanumeric lower-case
+      # string, which is passed in with the original API request
+
+      chars = 'abcdefghjkmnpqrstuvwxyz1234567890'
+      id = ''
+      40.times { id << chars[rand(chars.size)] }
+      id
+    end
+
   end
 end

data/lib/amex/data/request.xml

@@ -5,6 +5,6 @@
 <ServiceVersion>1.0</ServiceVersion>
 <Locale>en_GB</Locale>
 <ServiceName>AccountSummaryService</ServiceName>
-<DeviceInfo><HardwareId>dummy_hardware_id</HardwareId><OSBuild>iPhone OS 6.0.1</OSBuild><DeviceModel>iPhone</DeviceModel><Timestamp><%= timestamp %></Timestamp><TimeZoneOffset>0</TimeZoneOffset></DeviceInfo>
+<DeviceInfo><HardwareId><%= hardware_id %></HardwareId><OSBuild>iPhone OS 6.0.1</OSBuild><DeviceModel>iPhone</DeviceModel><Timestamp><%= timestamp %></Timestamp><TimeZoneOffset>0</TimeZoneOffset></DeviceInfo>
 <LoginCredentials><UserID><%= username %></UserID><Password><%= password %></Password><RememberMeUIFlagSelected>false</RememberMeUIFlagSelected><ProfileDataContent></ProfileDataContent></LoginCredentials>
 </XMLRequest>

data/lib/amex/version.rb

@@ -1,3 +1,3 @@
 module Amex
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: amex
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
   prerelease: 
 platform: ruby
 authors:
@@ -57,6 +57,7 @@ files:
 - amex-0.1.0.gem
 - amex-0.2.0.gem
 - amex-0.3.0.gem
+- amex-0.3.1.gem
 - amex.gemspec
 - example.rb
 - lib/amex.rb