amazing_print 1.3.0 → 1.5.0

data/spec/ext/active_record_spec.rb

@@ -23,11 +23,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
                   :rank => 1
         }
       EOS
-      if RUBY_VERSION < '1.9'
-        str.sub!('?', 'Sat Oct 10 12:30:00 UTC 1992')
-      else
-        str.sub!('?', '1992-10-10 12:30:00 UTC')
-      end
+      str.sub!('?', '1992-10-10 12:30:00 UTC')
       expect(out).to be_similar_to(str)
     end
 
@@ -51,13 +47,8 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
             }
         ]
       EOS
-      if RUBY_VERSION < '1.9'
-        str.sub!('??', 'Sat Oct 10 12:30:00 UTC 1992')
-        str.sub!('?!', 'Mon May 26 14:15:00 UTC 2003')
-      else
-        str.sub!('??', '1992-10-10 12:30:00 UTC')
-        str.sub!('?!', '2003-05-26 14:15:00 UTC')
-      end
+      str.sub!('??', '1992-10-10 12:30:00 UTC')
+      str.sub!('?!', '2003-05-26 14:15:00 UTC')
       expect(out).to be_similar_to(str)
     end
 
@@ -83,13 +74,8 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
             }
         ]
       EOS
-      if RUBY_VERSION < '1.9'
-        str.sub!('??', 'Sat Oct 10 12:30:00 UTC 1992')
-        str.sub!('?!', 'Mon May 26 14:15:00 UTC 2003')
-      else
-        str.sub!('??', '1992-10-10 12:30:00 UTC')
-        str.sub!('?!', '2003-05-26 14:15:00 UTC')
-      end
+      str.sub!('??', '1992-10-10 12:30:00 UTC')
+      str.sub!('?!', '2003-05-26 14:15:00 UTC')
       expect(out).to be_similar_to(str)
     end
   end
@@ -99,7 +85,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should show the entire record' do
+    it 'shows the entire record' do
       e = Email.create(email_address: 'foo@bar.com')
       u = User.last
       u.emails << e
@@ -139,21 +125,13 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
         elsif activerecord_5_0?
           ActiveRecordData.raw_5_0_diana
         elsif activerecord_4_2?
-          if RUBY_VERSION > '1.9.3'
-            ActiveRecordData.raw_4_2_diana
-          else
-            ActiveRecordData.raw_4_2_diana_legacy
-          end
+          ActiveRecordData.raw_4_2_diana
         elsif activerecord_4_1?
           ActiveRecordData.raw_4_1_diana
         elsif activerecord_4_0?
           ActiveRecordData.raw_4_0_diana
         elsif activerecord_3_2?
-          if RUBY_VERSION > '1.9.3'
-            ActiveRecordData.raw_3_2_diana
-          else
-            ActiveRecordData.raw_3_2_diana_legacy
-          end
+          ActiveRecordData.raw_3_2_diana
         end
 
       if RUBY_PLATFORM == 'java' && !activerecord_6_1?
@@ -181,21 +159,13 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
         elsif activerecord_5_0?
           ActiveRecordData.raw_5_0_multi
         elsif activerecord_4_2?
-          if RUBY_VERSION > '1.9.3'
-            ActiveRecordData.raw_4_2_multi
-          else
-            ActiveRecordData.raw_4_2_multi_legacy
-          end
+          ActiveRecordData.raw_4_2_multi
         elsif activerecord_4_1?
           ActiveRecordData.raw_4_1_multi
         elsif activerecord_4_0?
           ActiveRecordData.raw_4_0_multi
         elsif activerecord_3_2?
-          if RUBY_VERSION > '1.9.3'
-            ActiveRecordData.raw_3_2_multi
-          else
-            ActiveRecordData.raw_3_2_multi_legacy
-          end
+          ActiveRecordData.raw_3_2_multi
         end
 
       if RUBY_PLATFORM == 'java' && !activerecord_6_1?
@@ -216,7 +186,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should print the class' do
+    it 'prints the class' do
       expect(@ap.awesome(User)).to eq <<~EOS.strip
         class User < ActiveRecord::Base {
                     :id => :integer,
@@ -228,7 +198,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       EOS
     end
 
-    it 'should print the class for non-direct subclasses of ActiveRecord::Base' do
+    it 'prints the class for non-direct subclasses of ActiveRecord::Base' do
       out = @ap.awesome(SubUser)
       expect(out).to eq <<~EOS.strip
         class SubUser < User {
@@ -241,11 +211,11 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       EOS
     end
 
-    it 'should print ActiveRecord::Base objects (ex. ancestors)' do
+    it 'prints ActiveRecord::Base objects (ex. ancestors)' do
       expect { @ap.awesome(User.ancestors) }.not_to raise_error
     end
 
-    it 'should print valid HTML for subclasses' do
+    it 'prints valid HTML for subclasses' do
       @ap = AmazingPrint::Inspector.new(html: true)
       expect(@ap.awesome(SubUser)).to match('SubUser &lt; User')
     end
@@ -257,7 +227,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should format class methods properly' do
+    it 'formats class methods properly' do
       # spec 1
       out = @ap.awesome(User.methods.grep(/first/))
 
@@ -266,24 +236,24 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
           expect(out).to match(
             /\s+first\(\*args,\s&block\)\s+#<Class:\w+>\s+\(ActiveRecord::Querying\)/
           )
-        elsif RUBY_VERSION >= '3.0.0'
+        elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
+          expect(out).to match(
+            /\s*first\(\*(\*|args),\s+\?,\s+&(&|block)\)\s+#<Class:User> \(ActiveRecord::Querying\)/
+          )
+        elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.0.0')
           expect(out).to match(
             /\s*first\(\*(\*|args),\s+&(&|block)\)\s+#<Class:User> \(ActiveRecord::Querying\)/
           )
-        elsif RUBY_VERSION >= '2.7.2'
+        elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7.2')
           expect(out).to match(
             /\s*first\(\*(\*|args),\s+&(&|block)\)\s+User/
           )
-        elsif RUBY_VERSION >= '2.7.0'
+        elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.6.7')
           expect(out).to match(
             /\s*first\(\*(\*|args),\s+&(&|block)\)\s+#<Class:ActiveRecord::Base> \(ActiveRecord::Querying\)/
           )
-        elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./
+        elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4.4')
           expect(out).to match(/\sfirst\(\*arg.*?\)\s+User/)
-        elsif RUBY_VERSION >= '1.9'
-          expect(out).to match(/\sfirst\(\*args,\s&block\)\s+Class \(ActiveRecord::Querying\)/)
-        else
-          expect(out).to match(/\sfirst\(\*arg1\)\s+Class \(ActiveRecord::Querying\)/)
         end
       else
         expect(out).to match(/\sfirst\(\*arg.*?\)\s+User \(ActiveRecord::Base\)/)
@@ -295,16 +265,16 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
         expect(out).to match(
           /\sprimary_key\(.*?\)\s+#<Class:\w+>\s\(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/
         )
-      elsif RUBY_VERSION >= '3.0.0'
+      elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.0.0')
         expect(out).to match(/\sprimary_key\(.*?\)\s+#<Class:User> \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
-      elsif RUBY_VERSION =~ /^2\.7\.(0|1)/
+      elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.6.7') && Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7.0')
+        expect(out).to match(/\sprimary_key\(.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
+      elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4.4') || Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7.2')
+        expect(out).to match(/\sprimary_key\(.*?\)\s+User/)
+      elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7.0')
         expect(out).to match(
           /\sprimary_key\(.*?\)\s+.+Class.+\(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/
         )
-      elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
-        expect(out).to match(/\sprimary_key\(.*?\)\s+User/)
-      else
-        expect(out).to match(/\sprimary_key\(.*?\)\s+Class \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
       end
 
       # spec 3
@@ -312,20 +282,16 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
 
       if ActiveRecord::VERSION::MAJOR < 3
         expect(out).to match(/\svalidate\(\*arg.*?\)\s+User \(ActiveRecord::Base\)/)
-      else
-        if RUBY_PLATFORM == 'java'
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:\w+> \(ActiveModel::Validations::ClassMethods\)/)
-        elsif RUBY_VERSION >= '3.0.0'
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:User> \(ActiveModel::Validations::ClassMethods\)/)
-        elsif RUBY_VERSION =~ /2\.7\.(0|1)/
-          expect(out).to match(
-            /\svalidate\(\*args.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveModel::Validations::ClassMethods\)/
-          )
-        elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+User/)
-        else
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+Class \(ActiveModel::Validations::ClassMethods\)/)
-        end
+      elsif RUBY_PLATFORM == 'java'
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:\w+> \(ActiveModel::Validations::ClassMethods\)/)
+      elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.0.0')
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:User> \(ActiveModel::Validations::ClassMethods\)/)
+      elsif (Gem::Version.new('2.6.7')..Gem::Version.new('2.7.1')).cover? Gem::Version.new(RUBY_VERSION)
+        expect(out).to match(
+          /\svalidate\(\*args.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveModel::Validations::ClassMethods\)/
+        )
+      elsif Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4.4') || Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7.2')
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+User/)
       end
     end
   end

data/spec/ext/active_support_spec.rb

@@ -15,21 +15,21 @@ RSpec.describe 'AmazingPrint::ActiveSupport', skip: -> { !ExtVerifier.has_rails?
     @ap = AmazingPrint::Inspector.new
   end
 
-  it 'should format ActiveSupport::TimeWithZone as regular Time' do
+  it 'formats ActiveSupport::TimeWithZone as regular Time' do
     Time.zone = 'Eastern Time (US & Canada)'
     time = Time.utc(2007, 2, 10, 20, 30, 45).in_time_zone
     expect(@ap.send(:awesome, time))
       .to eq("\e[0;32mSat, 10 Feb 2007 #{expected_ar_time_str} EST -05:00\e[0m")
   end
 
-  it 'should format HashWithIndifferentAccess as regular Hash' do
+  it 'formats HashWithIndifferentAccess as regular Hash' do
     hash = HashWithIndifferentAccess.new({ hello: 'world' })
     expect(@ap.send(:awesome, hash)).to eq("{\n    \"hello\"\e[0;37m => \e[0m\e[0;33m\"world\"\e[0m\n}")
   end
 
   # ActiveSupport sticks in instance variables to the date object. Make sure
   # we ignore that and format Date instance as regular date.
-  it 'should formate Date object as date' do
+  it 'formates Date object as date' do
     date = Date.new(2003, 5, 26)
     expect(date.ai(plain: true)).to eq('Mon, 26 May 2003')
     expect(date.ai).to eq("\e[0;32mMon, 26 May 2003\e[0m")

data/spec/ext/mongo_mapper_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_mapper? }.call do
@@ -27,11 +29,11 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     # before { @ap.options[:raw] = true }
     before { @ap = AmazingPrint::Inspector.new(plain: true, sort_keys: true, raw: true) }
 
-    it 'should print class instance' do
+    it 'prints class instance' do
       user = MongoUser.new(first_name: 'Al', last_name: 'Capone')
 
       out = @ap.send(:awesome, user)
-               .gsub(/#\<Proc:.+?\>/, 'amazing_print_PROC_STUB')
+               .gsub(/#<Proc:.+?>/, 'amazing_print_PROC_STUB')
                .gsub(/BSON::ObjectId\('[\da-f]+?'\)/, "BSON::ObjectId('123456789')")
 
       str = if MongoMapper::Version >= '0.13'
@@ -129,7 +131,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
       expect(out).to be_similar_to(str)
     end
 
-    it 'should print the class' do
+    it 'prints the class' do
       expect(@ap.send(:awesome, MongoUser)).to eq <<~EOS.strip
         class MongoUser < Object {
                    "_id" => :object_id,
@@ -139,7 +141,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
       EOS
     end
 
-    it 'should print the class when type is undefined' do
+    it 'prints the class when type is undefined' do
       class Chamelion
         include MongoMapper::Document
         key :last_attribute
@@ -178,7 +180,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned off (default)' do
-      it 'should render the class as normal' do
+      it 'renders the class as normal' do
         expect(@ap.send(:awesome, Parent)).to eq <<~EOS.strip
           class Parent < Object {
                "_id" => :object_id,
@@ -187,7 +189,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
         EOS
       end
 
-      it 'should render an instance as normal' do
+      it 'renders an instance as normal' do
         parent = Parent.new(name: 'test')
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -201,11 +203,11 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned on and inline embedded turned off' do
-      before :each do
+      before do
         @ap = AmazingPrint::Inspector.new(plain: true, mongo_mapper: { show_associations: true })
       end
 
-      it 'should render the class with associations shown' do
+      it 'renders the class with associations shown' do
         expect(@ap.send(:awesome, Parent)).to eq <<~EOS.strip
           class Parent < Object {
                   "_id" => :object_id,
@@ -216,7 +218,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
         EOS
       end
 
-      it 'should render an instance with associations shown' do
+      it 'renders an instance with associations shown' do
         parent = Parent.new(name: 'test')
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -232,7 +234,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned on and inline embedded turned on' do
-      before :each do
+      before do
         @ap = AmazingPrint::Inspector.new plain: true,
                                           mongo_mapper: {
                                             show_associations: true,
@@ -240,7 +242,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
                                           }
       end
 
-      it 'should render an instance with associations shown and embeds there' do
+      it 'renders an instance with associations shown and embeds there' do
         parent = Parent.new(name: 'test', child: Child.new(data: 5))
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -259,3 +261,5 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/mongoid_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.call do
@@ -23,7 +25,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     @ap = AmazingPrint::Inspector.new plain: true, sort_keys: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = MongoUser.new first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -38,7 +40,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(out).to be_similar_to(str, { skip_bson: true })
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     class_spec = <<~EOS.strip
       class MongoUser < Object {
                  :_id => :"bson/object_id",
@@ -50,7 +52,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(@ap.send(:awesome, MongoUser)).to eq class_spec
   end
 
-  it 'should print the class when type is undefined' do
+  it 'prints the class when type is undefined' do
     class Chamelion
       include Mongoid::Document
       field :last_attribute
@@ -66,3 +68,5 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(@ap.send(:awesome, Chamelion)).to eq class_spec
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/nobrainer_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer? }.call do
@@ -30,7 +32,7 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     @ap = AmazingPrint::Inspector.new plain: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = SomeModel.new first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -45,7 +47,7 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     expect(out).to eq(str)
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     class_spec = <<~EOS.strip
       class SomeModel < Object {
                   :id => :string,
@@ -58,3 +60,5 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     expect(@ap.send(:awesome, SomeModel)).to eq class_spec
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/nokogiri_spec.rb

@@ -3,12 +3,12 @@
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Nokogiri' do
-  it 'should colorize tags' do
+  it 'colorizes tags' do
     xml = Nokogiri::XML('<html><body><h1></h1></body></html>')
     # FIXME: Due to something strange with Nokogiri and JRuby, we need to remove extra blank lines.
     output = xml.ai.gsub(/\n\n/, "\n")
     expect(output).to eq <<~EOS
-      <?xml version=\"1.0\"?>\e[1;32m
+      <?xml version="1.0"?>\e[1;32m
       \e[0m<\e[1;36mhtml\e[0m>\e[1;32m
         \e[0m<\e[1;36mbody\e[0m>\e[1;32m
           \e[0m<\e[1;36mh1\e[0m/>\e[1;32m
@@ -17,10 +17,10 @@ RSpec.describe 'AmazingPrint/Nokogiri' do
     EOS
   end
 
-  it 'should colorize contents' do
+  it 'colorizes contents' do
     xml = Nokogiri::XML('<html><body><h1>Hello</h1></body></html>')
     expect(xml.ai).to eq <<~EOS
-      <?xml version=\"1.0\"?>\e[1;32m
+      <?xml version="1.0"?>\e[1;32m
       \e[0m<\e[1;36mhtml\e[0m>\e[1;32m
         \e[0m<\e[1;36mbody\e[0m>\e[1;32m
           \e[0m<\e[1;36mh1\e[0m>\e[1;32mHello\e[0m<\e[1;36m/h1\e[0m>\e[1;32m
@@ -29,16 +29,16 @@ RSpec.describe 'AmazingPrint/Nokogiri' do
     EOS
   end
 
-  it 'should colorize class and id' do
+  it 'colorizes class and id' do
     xml = Nokogiri::XML('<html><body><h1><span class="world" id="hello"></span></h1></body></html>')
     # FIXME: Due to something strange with Nokogiri and JRuby, we need to remove extra blank lines.
     output = xml.ai.gsub(/\n\n/, "\n")
     expect(output).to eq <<~EOS
-      <?xml version=\"1.0\"?>\e[1;32m
+      <?xml version="1.0"?>\e[1;32m
       \e[0m<\e[1;36mhtml\e[0m>\e[1;32m
         \e[0m<\e[1;36mbody\e[0m>\e[1;32m
           \e[0m<\e[1;36mh1\e[0m>\e[1;32m
-            \e[0m<\e[1;36mspan\e[0m \e[1;33mclass=\"world\"\e[0m \e[1;33mid=\"hello\"\e[0m/>\e[1;32m
+            \e[0m<\e[1;36mspan\e[0m \e[1;33mclass="world"\e[0m \e[1;33mid="hello"\e[0m/>\e[1;32m
           \e[0m<\e[1;36m/h1\e[0m>\e[1;32m
         \e[0m<\e[1;36m/body\e[0m>\e[1;32m
       \e[0m<\e[1;36m/html\e[0m>

data/spec/ext/ripple_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call do
@@ -24,7 +26,7 @@ RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call
     @ap = AmazingPrint::Inspector.new plain: true, sort_keys: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = RippleUser.new _id: '12345', first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -37,7 +39,7 @@ RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call
     EOS
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     expect(@ap.send(:awesome, RippleUser)).to eq <<~EOS.strip
       class RippleUser < Object {
                  :_id => :string,
@@ -47,3 +49,5 @@ RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call
     EOS
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/sequel_spec.rb

@@ -39,7 +39,7 @@ RSpec.describe 'AmazingPrint/Sequel', skip: -> { !ExtVerifier.has_sequel? }.call
   end
 
   it 'does not crash if on Sequel::Model' do
-    out = @ap.awesome(::Sequel::Model)
+    out = @ap.awesome(Sequel::Model)
     expect(out).to be_similar_to('Sequel::Model < Object')
   end
 end