amazing_print 1.3.0 → 1.4.0

data/lib/amazing_print/formatters/hash_formatter.rb

@@ -8,6 +8,7 @@ module AmazingPrint
       attr_reader :hash, :inspector, :options
 
       def initialize(hash, inspector)
+        super()
         @hash = hash
         @inspector = inspector
         @options = inspector.options
@@ -55,12 +56,12 @@ module AmazingPrint
           end
         end
 
-        should_be_limited? ? limited(data, width, hash: true) : data
+        should_be_limited? ? limited(data, width, is_hash: true) : data
       end
 
       def left_width(keys)
         result = max_key_width(keys)
-        result += indentation if options[:indent] > 0
+        result += indentation if options[:indent].positive?
         result
       end
 

data/lib/amazing_print/formatters/method_formatter.rb

@@ -8,6 +8,7 @@ module AmazingPrint
       attr_reader :method, :inspector, :options
 
       def initialize(method, inspector)
+        super()
         @method = method
         @inspector = inspector
         @options = inspector.options

data/lib/amazing_print/formatters/object_formatter.rb

@@ -8,6 +8,7 @@ module AmazingPrint
       attr_reader :object, :variables, :inspector, :options
 
       def initialize(object, inspector)
+        super()
         @object = object
         @variables = object.instance_variables
         @inspector = inspector
@@ -38,7 +39,7 @@ module AmazingPrint
             key = if key =~ /(@\w+)/
                     key.sub(Regexp.last_match(1), colorize(Regexp.last_match(1), :variable))
                   else
-                    key.sub(/(attr_\w+)\s(\:\w+)/, "#{colorize('\\1', :keyword)} #{colorize('\\2', :method)}")
+                    key.sub(/(attr_\w+)\s(:\w+)/, "#{colorize('\\1', :keyword)} #{colorize('\\2', :method)}")
                   end
           end
 

data/lib/amazing_print/formatters/simple_formatter.rb

@@ -8,6 +8,7 @@ module AmazingPrint
       attr_reader :string, :type, :inspector, :options
 
       def initialize(string, type, inspector)
+        super()
         @string = string
         @type = type
         @inspector = inspector

data/lib/amazing_print/formatters/struct_formatter.rb

@@ -8,6 +8,7 @@ module AmazingPrint
       attr_reader :struct, :variables, :inspector, :options
 
       def initialize(struct, inspector)
+        super()
         @struct = struct
         @variables = struct.members
         @inspector = inspector
@@ -38,7 +39,7 @@ module AmazingPrint
             key = if key =~ /(@\w+)/
                     key.sub(Regexp.last_match(1), colorize(Regexp.last_match(1), :variable))
                   else
-                    key.sub(/(attr_\w+)\s(\:\w+)/, "#{colorize('\\1', :keyword)} #{colorize('\\2', :method)}")
+                    key.sub(/(attr_\w+)\s(:\w+)/, "#{colorize('\\1', :keyword)} #{colorize('\\2', :method)}")
                   end
           end
 

data/lib/amazing_print/inspector.rb

@@ -5,6 +5,9 @@
 # AmazingPrint is freely distributable under the terms of MIT license.
 # See LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
+
+# rubocop:disable Metrics/ClassLength
+
 require_relative 'indentator'
 
 module AmazingPrint
@@ -13,6 +16,15 @@ module AmazingPrint
 
     AP = :__amazing_print__
 
+    ##
+    # Unload the cached dotfile and load it again.
+    #
+    def self.reload_dotfile
+      @@dotfile = nil
+      new.send :load_dotfile
+      true
+    end
+
     def initialize(options = {})
       @options = {
         indent: 4, # Number of spaces for indenting.
@@ -91,7 +103,7 @@ module AmazingPrint
         if defined? @colorize_stdout
           @colorize_stdout
         else
-          @colorize_stdout = STDOUT.tty? && (
+          @colorize_stdout = $stdout.tty? && (
             (
               ENV['TERM'] &&
               ENV['TERM'] != 'dumb'
@@ -147,18 +159,28 @@ module AmazingPrint
       @options.merge!(options)
     end
 
+    def find_dotfile
+      xdg_config_home = File.expand_path(ENV.fetch('XDG_CONFIG_HOME', '~/.config'))
+      xdg_config_path = File.join(xdg_config_home, 'aprc') # ${XDG_CONFIG_HOME}/aprc
+
+      return xdg_config_path if File.exist?(xdg_config_path)
+
+      # default to ~/.aprc
+      File.join(ENV['HOME'], '.aprc')
+    end
+
     # This method needs to be mocked during testing so that it always loads
     # predictable values
     #---------------------------------------------------------------------------
     def load_dotfile
-      dotfile = File.join(ENV['HOME'], '.aprc')
+      return if @@dotfile # Load the dotfile only once.
+
+      dotfile = find_dotfile
       load dotfile if dotfile_readable?(dotfile)
     end
 
     def dotfile_readable?(dotfile)
-      if @@dotfile_readable.nil? || @@dotfile != dotfile
-        @@dotfile_readable = File.readable?(@@dotfile = dotfile)
-      end
+      @@dotfile_readable = File.readable?(@@dotfile = dotfile) if @@dotfile_readable.nil? || @@dotfile != dotfile
       @@dotfile_readable
     end
     @@dotfile_readable = @@dotfile = nil
@@ -173,3 +195,5 @@ module AmazingPrint
     end
   end
 end
+
+# rubocop:enable Metrics/ClassLength

data/lib/amazing_print/version.rb

@@ -7,6 +7,6 @@
 #------------------------------------------------------------------------------
 module AmazingPrint
   def self.version
-    '1.3.0'
+    '1.4.0'
   end
 end

data/lib/amazing_print.rb

@@ -23,12 +23,8 @@ unless defined?(AmazingPrint::Inspector)
   # Load the following under normal circumstances as well as in Rails
   # console when required from ~/.irbrc or ~/.pryrc.
   #
-  if defined?(ActiveRecord) || AmazingPrint.rails_console?
-    require_relative 'amazing_print/ext/active_record'
-  end
-  if defined?(ActiveSupport) || AmazingPrint.rails_console?
-    require_relative 'amazing_print/ext/active_support'
-  end
+  require_relative 'amazing_print/ext/active_record' if defined?(ActiveRecord) || AmazingPrint.rails_console?
+  require_relative 'amazing_print/ext/active_support' if defined?(ActiveSupport) || AmazingPrint.rails_console?
   #
   # Load remaining extensions.
   #

data/spec/active_record_helper.rb

@@ -27,8 +27,11 @@ if ExtVerifier.has_rails?
 
   # Create models
   class User < ActiveRecord::Base; has_many :emails; end
+
   class SubUser < User; end
+
   class Email < ActiveRecord::Base; belongs_to :user; end
+
   class TableFreeModel
     include ::ActiveModel::Validations
     attr_reader(:name)

data/spec/colors_spec.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock, Style/OptionalBooleanParameter
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint' do
-  def stub_tty!(output = true, stream = STDOUT)
+  def stub_tty!(output = true, stream = $stdout)
     if output
       stream.instance_eval do
         def tty?
@@ -31,7 +33,7 @@ RSpec.describe 'AmazingPrint' do
 
     describe 'default settings (no forced colors)' do
       before do
-        AmazingPrint.force_colors! false
+        AmazingPrint.force_colors! colors: false
       end
 
       it 'colorizes tty processes by default' do
@@ -109,3 +111,5 @@ RSpec.describe 'AmazingPrint' do
     end
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock, Style/OptionalBooleanParameter

data/spec/core_ext/logger_spec.rb

@@ -6,17 +6,17 @@ require 'logger'
 require 'amazing_print/core_ext/logger'
 
 RSpec.describe 'AmazingPrint logging extensions' do
-  let(:object) { double }
-  let(:options) { { sort_keys: true } }
-
   subject(:logger) do
     Logger.new('/dev/null')
   rescue Errno::ENOENT
     Logger.new('nul')
   end
 
+  let(:object) { double }
+  let(:options) { { sort_keys: true } }
+
   describe 'ap method' do
-    it 'should awesome_inspect the given object' do
+    it 'awesome_inspects the given object' do
       expect(object).to receive(:ai)
       logger.ap object
     end
@@ -31,18 +31,18 @@ RSpec.describe 'AmazingPrint logging extensions' do
         AmazingPrint.defaults = {}
       end
 
-      it 'should fallback to the default :debug log level' do
+      it 'fallbacks to the default :debug log level' do
         expect(logger).to receive(:debug)
         logger.ap nil
       end
 
-      it 'should use the global user default if no level passed' do
+      it 'uses the global user default if no level passed' do
         AmazingPrint.defaults = { log_level: :info }
         expect(logger).to receive(:info)
         logger.ap nil
       end
 
-      it 'should use the passed in level' do
+      it 'uses the passed in level' do
         expect(logger).to receive(:warn)
         logger.ap nil, :warn
       end

data/spec/core_ext/string_spec.rb

@@ -4,11 +4,11 @@ require 'spec_helper'
 
 RSpec.describe 'String extensions' do
   %i[gray red green yellow blue purple cyan white].each_with_index do |color, i|
-    it "should have #{color} color" do
+    it "has #{color} color" do
       expect(color.to_s.send(color)).to eq("\e[1;#{30 + i}m#{color}\e[0m")
     end
 
-    it "should have #{color}ish color" do
+    it "has #{color}ish color" do
       expect(color.to_s.send(:"#{color}ish")).to eq("\e[0;#{30 + i}m#{color}\e[0m")
     end
   end

data/spec/ext/action_controller_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe 'AmazingPrint::ActionController', skip: -> { !ExtVerifier.has_rai
       ActionController::Parameters.new post: { id: 1, content: 'Some' }
     end
 
-    it 'should format as an object' do
+    it 'formats as an object' do
       expect(inspector.send(:awesome, parameters)).to match(
         /\A#?<ActionController::Parameters {"post"=>{"id"=>1, "content"=>"Some"}} permitted: false>\z/
       )
@@ -33,7 +33,7 @@ RSpec.describe 'AmazingPrint::ActionController', skip: -> { !ExtVerifier.has_rai
       ActionController::Parameters.new post: { id: 1, content: 'Some' }
     end
 
-    it 'should format as a hash' do
+    it 'formats as a hash' do
       expect(inspector.send(:awesome, parameters.permit!)).to eq expected_output
     end
   end

data/spec/ext/active_model_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe 'ActiveModel::Errors formatting', skip: -> { !ExtVerifier.has_rai
     @ap = AmazingPrint::Inspector.new(plain: true)
   end
 
-  it 'should format active_model_errors properly' do
+  it 'formats active_model_errors properly' do
     model = TableFreeModel.new
     model.errors.add(:name, "can't be blank")
 

data/spec/ext/active_record_spec.rb

@@ -99,7 +99,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should show the entire record' do
+    it 'shows the entire record' do
       e = Email.create(email_address: 'foo@bar.com')
       u = User.last
       u.emails << e
@@ -216,7 +216,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should print the class' do
+    it 'prints the class' do
       expect(@ap.awesome(User)).to eq <<~EOS.strip
         class User < ActiveRecord::Base {
                     :id => :integer,
@@ -228,7 +228,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       EOS
     end
 
-    it 'should print the class for non-direct subclasses of ActiveRecord::Base' do
+    it 'prints the class for non-direct subclasses of ActiveRecord::Base' do
       out = @ap.awesome(SubUser)
       expect(out).to eq <<~EOS.strip
         class SubUser < User {
@@ -241,11 +241,11 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       EOS
     end
 
-    it 'should print ActiveRecord::Base objects (ex. ancestors)' do
+    it 'prints ActiveRecord::Base objects (ex. ancestors)' do
       expect { @ap.awesome(User.ancestors) }.not_to raise_error
     end
 
-    it 'should print valid HTML for subclasses' do
+    it 'prints valid HTML for subclasses' do
       @ap = AmazingPrint::Inspector.new(html: true)
       expect(@ap.awesome(SubUser)).to match('SubUser &lt; User')
     end
@@ -257,7 +257,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should format class methods properly' do
+    it 'formats class methods properly' do
       # spec 1
       out = @ap.awesome(User.methods.grep(/first/))
 
@@ -274,7 +274,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
           expect(out).to match(
             /\s*first\(\*(\*|args),\s+&(&|block)\)\s+User/
           )
-        elsif RUBY_VERSION >= '2.7.0'
+        elsif RUBY_VERSION >= '2.6.7'
           expect(out).to match(
             /\s*first\(\*(\*|args),\s+&(&|block)\)\s+#<Class:ActiveRecord::Base> \(ActiveRecord::Querying\)/
           )
@@ -297,12 +297,14 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
         )
       elsif RUBY_VERSION >= '3.0.0'
         expect(out).to match(/\sprimary_key\(.*?\)\s+#<Class:User> \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
-      elsif RUBY_VERSION =~ /^2\.7\.(0|1)/
+      elsif RUBY_VERSION >= '2.6.7' && RUBY_VERSION < '2.7.0'
+        expect(out).to match(/\sprimary_key\(.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
+      elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
+        expect(out).to match(/\sprimary_key\(.*?\)\s+User/)
+      elsif RUBY_VERSION >= '2.7.0'
         expect(out).to match(
           /\sprimary_key\(.*?\)\s+.+Class.+\(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/
         )
-      elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
-        expect(out).to match(/\sprimary_key\(.*?\)\s+User/)
       else
         expect(out).to match(/\sprimary_key\(.*?\)\s+Class \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
       end
@@ -312,20 +314,18 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
 
       if ActiveRecord::VERSION::MAJOR < 3
         expect(out).to match(/\svalidate\(\*arg.*?\)\s+User \(ActiveRecord::Base\)/)
+      elsif RUBY_PLATFORM == 'java'
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:\w+> \(ActiveModel::Validations::ClassMethods\)/)
+      elsif RUBY_VERSION >= '3.0.0'
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:User> \(ActiveModel::Validations::ClassMethods\)/)
+      elsif RUBY_VERSION =~ /2\.7\.(0|1)/ || (RUBY_VERSION >= '2.6.7' && RUBY_VERSION < '2.7.0')
+        expect(out).to match(
+          /\svalidate\(\*args.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveModel::Validations::ClassMethods\)/
+        )
+      elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+User/)
       else
-        if RUBY_PLATFORM == 'java'
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:\w+> \(ActiveModel::Validations::ClassMethods\)/)
-        elsif RUBY_VERSION >= '3.0.0'
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:User> \(ActiveModel::Validations::ClassMethods\)/)
-        elsif RUBY_VERSION =~ /2\.7\.(0|1)/
-          expect(out).to match(
-            /\svalidate\(\*args.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveModel::Validations::ClassMethods\)/
-          )
-        elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+User/)
-        else
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+Class \(ActiveModel::Validations::ClassMethods\)/)
-        end
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+Class \(ActiveModel::Validations::ClassMethods\)/)
       end
     end
   end

data/spec/ext/active_support_spec.rb

@@ -15,21 +15,21 @@ RSpec.describe 'AmazingPrint::ActiveSupport', skip: -> { !ExtVerifier.has_rails?
     @ap = AmazingPrint::Inspector.new
   end
 
-  it 'should format ActiveSupport::TimeWithZone as regular Time' do
+  it 'formats ActiveSupport::TimeWithZone as regular Time' do
     Time.zone = 'Eastern Time (US & Canada)'
     time = Time.utc(2007, 2, 10, 20, 30, 45).in_time_zone
     expect(@ap.send(:awesome, time))
       .to eq("\e[0;32mSat, 10 Feb 2007 #{expected_ar_time_str} EST -05:00\e[0m")
   end
 
-  it 'should format HashWithIndifferentAccess as regular Hash' do
+  it 'formats HashWithIndifferentAccess as regular Hash' do
     hash = HashWithIndifferentAccess.new({ hello: 'world' })
     expect(@ap.send(:awesome, hash)).to eq("{\n    \"hello\"\e[0;37m => \e[0m\e[0;33m\"world\"\e[0m\n}")
   end
 
   # ActiveSupport sticks in instance variables to the date object. Make sure
   # we ignore that and format Date instance as regular date.
-  it 'should formate Date object as date' do
+  it 'formates Date object as date' do
     date = Date.new(2003, 5, 26)
     expect(date.ai(plain: true)).to eq('Mon, 26 May 2003')
     expect(date.ai).to eq("\e[0;32mMon, 26 May 2003\e[0m")

data/spec/ext/mongo_mapper_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_mapper? }.call do
@@ -27,11 +29,11 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     # before { @ap.options[:raw] = true }
     before { @ap = AmazingPrint::Inspector.new(plain: true, sort_keys: true, raw: true) }
 
-    it 'should print class instance' do
+    it 'prints class instance' do
       user = MongoUser.new(first_name: 'Al', last_name: 'Capone')
 
       out = @ap.send(:awesome, user)
-               .gsub(/#\<Proc:.+?\>/, 'amazing_print_PROC_STUB')
+               .gsub(/#<Proc:.+?>/, 'amazing_print_PROC_STUB')
                .gsub(/BSON::ObjectId\('[\da-f]+?'\)/, "BSON::ObjectId('123456789')")
 
       str = if MongoMapper::Version >= '0.13'
@@ -129,7 +131,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
       expect(out).to be_similar_to(str)
     end
 
-    it 'should print the class' do
+    it 'prints the class' do
       expect(@ap.send(:awesome, MongoUser)).to eq <<~EOS.strip
         class MongoUser < Object {
                    "_id" => :object_id,
@@ -139,7 +141,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
       EOS
     end
 
-    it 'should print the class when type is undefined' do
+    it 'prints the class when type is undefined' do
       class Chamelion
         include MongoMapper::Document
         key :last_attribute
@@ -178,7 +180,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned off (default)' do
-      it 'should render the class as normal' do
+      it 'renders the class as normal' do
         expect(@ap.send(:awesome, Parent)).to eq <<~EOS.strip
           class Parent < Object {
                "_id" => :object_id,
@@ -187,7 +189,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
         EOS
       end
 
-      it 'should render an instance as normal' do
+      it 'renders an instance as normal' do
         parent = Parent.new(name: 'test')
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -201,11 +203,11 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned on and inline embedded turned off' do
-      before :each do
+      before do
         @ap = AmazingPrint::Inspector.new(plain: true, mongo_mapper: { show_associations: true })
       end
 
-      it 'should render the class with associations shown' do
+      it 'renders the class with associations shown' do
         expect(@ap.send(:awesome, Parent)).to eq <<~EOS.strip
           class Parent < Object {
                   "_id" => :object_id,
@@ -216,7 +218,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
         EOS
       end
 
-      it 'should render an instance with associations shown' do
+      it 'renders an instance with associations shown' do
         parent = Parent.new(name: 'test')
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -232,7 +234,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned on and inline embedded turned on' do
-      before :each do
+      before do
         @ap = AmazingPrint::Inspector.new plain: true,
                                           mongo_mapper: {
                                             show_associations: true,
@@ -240,7 +242,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
                                           }
       end
 
-      it 'should render an instance with associations shown and embeds there' do
+      it 'renders an instance with associations shown and embeds there' do
         parent = Parent.new(name: 'test', child: Child.new(data: 5))
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -259,3 +261,5 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/mongoid_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.call do
@@ -23,7 +25,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     @ap = AmazingPrint::Inspector.new plain: true, sort_keys: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = MongoUser.new first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -38,7 +40,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(out).to be_similar_to(str, { skip_bson: true })
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     class_spec = <<~EOS.strip
       class MongoUser < Object {
                  :_id => :"bson/object_id",
@@ -50,7 +52,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(@ap.send(:awesome, MongoUser)).to eq class_spec
   end
 
-  it 'should print the class when type is undefined' do
+  it 'prints the class when type is undefined' do
     class Chamelion
       include Mongoid::Document
       field :last_attribute
@@ -66,3 +68,5 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(@ap.send(:awesome, Chamelion)).to eq class_spec
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/nobrainer_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer? }.call do
@@ -30,7 +32,7 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     @ap = AmazingPrint::Inspector.new plain: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = SomeModel.new first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -45,7 +47,7 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     expect(out).to eq(str)
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     class_spec = <<~EOS.strip
       class SomeModel < Object {
                   :id => :string,
@@ -58,3 +60,5 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     expect(@ap.send(:awesome, SomeModel)).to eq class_spec
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/nokogiri_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Nokogiri' do
-  it 'should colorize tags' do
+  it 'colorizes tags' do
     xml = Nokogiri::XML('<html><body><h1></h1></body></html>')
     # FIXME: Due to something strange with Nokogiri and JRuby, we need to remove extra blank lines.
     output = xml.ai.gsub(/\n\n/, "\n")
@@ -17,7 +17,7 @@ RSpec.describe 'AmazingPrint/Nokogiri' do
     EOS
   end
 
-  it 'should colorize contents' do
+  it 'colorizes contents' do
     xml = Nokogiri::XML('<html><body><h1>Hello</h1></body></html>')
     expect(xml.ai).to eq <<~EOS
       <?xml version=\"1.0\"?>\e[1;32m
@@ -29,7 +29,7 @@ RSpec.describe 'AmazingPrint/Nokogiri' do
     EOS
   end
 
-  it 'should colorize class and id' do
+  it 'colorizes class and id' do
     xml = Nokogiri::XML('<html><body><h1><span class="world" id="hello"></span></h1></body></html>')
     # FIXME: Due to something strange with Nokogiri and JRuby, we need to remove extra blank lines.
     output = xml.ai.gsub(/\n\n/, "\n")