amazing_print 1.2.0 → 1.4.0

data/spec/core_ext/logger_spec.rb

@@ -6,19 +6,24 @@ require 'logger'
 require 'amazing_print/core_ext/logger'
 
 RSpec.describe 'AmazingPrint logging extensions' do
-  before(:all) do
-    @logger = begin
-                Logger.new('/dev/null')
-              rescue Errno::ENOENT
-                Logger.new('nul')
-              end
+  subject(:logger) do
+    Logger.new('/dev/null')
+  rescue Errno::ENOENT
+    Logger.new('nul')
   end
 
+  let(:object) { double }
+  let(:options) { { sort_keys: true } }
+
   describe 'ap method' do
-    it 'should awesome_inspect the given object' do
-      object = double
+    it 'awesome_inspects the given object' do
       expect(object).to receive(:ai)
-      @logger.ap object
+      logger.ap object
+    end
+
+    it 'passes options to `ai`' do
+      expect(object).to receive(:ai).with(options)
+      logger.ap object, options
     end
 
     describe 'the log level' do
@@ -26,20 +31,39 @@ RSpec.describe 'AmazingPrint logging extensions' do
         AmazingPrint.defaults = {}
       end
 
-      it 'should fallback to the default :debug log level' do
-        expect(@logger).to receive(:debug)
-        @logger.ap(nil)
+      it 'fallbacks to the default :debug log level' do
+        expect(logger).to receive(:debug)
+        logger.ap nil
       end
 
-      it 'should use the global user default if no level passed' do
+      it 'uses the global user default if no level passed' do
         AmazingPrint.defaults = { log_level: :info }
-        expect(@logger).to receive(:info)
-        @logger.ap(nil)
+        expect(logger).to receive(:info)
+        logger.ap nil
+      end
+
+      it 'uses the passed in level' do
+        expect(logger).to receive(:warn)
+        logger.ap nil, :warn
+      end
+
+      it 'makes no difference if passed as a hash or a part of options' do
+        expect(logger).to receive(:warn)
+        logger.ap nil, { level: :warn }
       end
 
-      it 'should use the passed in level' do
-        expect(@logger).to receive(:warn)
-        @logger.ap(nil, :warn)
+      context 'when given options' do
+        it 'uses the default log level with the options' do
+          expect(logger).to receive(:debug)
+          expect(object).to receive(:ai).with(options)
+          logger.ap object, options
+        end
+
+        it 'still uses the passed in level with options' do
+          expect(logger).to receive(:warn)
+          expect(object).to receive(:ai).with(options)
+          logger.ap object, options.merge({ level: :warn })
+        end
       end
     end
   end

data/spec/core_ext/string_spec.rb

@@ -4,11 +4,11 @@ require 'spec_helper'
 
 RSpec.describe 'String extensions' do
   %i[gray red green yellow blue purple cyan white].each_with_index do |color, i|
-    it "should have #{color} color" do
+    it "has #{color} color" do
       expect(color.to_s.send(color)).to eq("\e[1;#{30 + i}m#{color}\e[0m")
     end
 
-    it "should have #{color}ish color" do
+    it "has #{color}ish color" do
       expect(color.to_s.send(:"#{color}ish")).to eq("\e[0;#{30 + i}m#{color}\e[0m")
     end
   end

data/spec/ext/action_controller_spec.rb

@@ -10,9 +10,9 @@ RSpec.describe 'AmazingPrint::ActionController', skip: -> { !ExtVerifier.has_rai
       ActionController::Parameters.new post: { id: 1, content: 'Some' }
     end
 
-    it 'should format as an object' do
-      expect(inspector.send(:awesome, parameters)).to eq(
-        '<ActionController::Parameters {"post"=>{"id"=>1, "content"=>"Some"}} permitted: false>'
+    it 'formats as an object' do
+      expect(inspector.send(:awesome, parameters)).to match(
+        /\A#?<ActionController::Parameters {"post"=>{"id"=>1, "content"=>"Some"}} permitted: false>\z/
       )
     end
   end
@@ -33,7 +33,7 @@ RSpec.describe 'AmazingPrint::ActionController', skip: -> { !ExtVerifier.has_rai
       ActionController::Parameters.new post: { id: 1, content: 'Some' }
     end
 
-    it 'should format as a hash' do
+    it 'formats as a hash' do
       expect(inspector.send(:awesome, parameters.permit!)).to eq expected_output
     end
   end

data/spec/ext/action_view_spec.rb

@@ -2,7 +2,8 @@
 
 require 'spec_helper'
 
-RSpec.describe 'AmazingPrint ActionView extensions', skip: -> { !ExtVerifier.has_rails? }.call do
+RSpec.describe 'AmazingPrint ActionView extensions',
+               skip: -> { !ExtVerifier.has_rails? || ActiveRecord::VERSION::STRING >= '6.1' }.call do
   before do
     @view = ActionView::Base.new
   end
@@ -16,4 +17,8 @@ RSpec.describe 'AmazingPrint ActionView extensions', skip: -> { !ExtVerifier.has
     markup = ' &<hello>'
     expect(@view.ap(markup)).to eq('<pre class="debug_dump"><kbd style="color:brown">&quot; &amp;&lt;hello&gt;&quot;</kbd></pre>')
   end
+
+  it 'uses HTML and does set output to HTML safe' do
+    expect(@view.ap('<p>Hello World</p>')).to be_html_safe
+  end
 end

data/spec/ext/active_model_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'active_record_helper'
+
+RSpec.describe 'ActiveModel::Errors formatting', skip: -> { !ExtVerifier.has_rails? }.call do
+  before do
+    @ap = AmazingPrint::Inspector.new(plain: true)
+  end
+
+  it 'formats active_model_errors properly' do
+    model = TableFreeModel.new
+    model.errors.add(:name, "can't be blank")
+
+    out = @ap.awesome(model.errors)
+
+    str = <<~ERRORS.strip
+      #<ActiveModel::Errors:placeholder_id> {
+             "name" => nil,
+           :details => {
+              :name => [
+                  [0] {
+                      :error => "can't be blank"
+                  }
+              ]
+          },
+          :messages => {
+              :name => [
+                  [0] "can't be blank"
+              ]
+          }
+      }
+    ERRORS
+
+    expect(out).to be_similar_to(str)
+  end
+end

data/spec/ext/active_record_spec.rb

@@ -99,7 +99,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should show the entire record' do
+    it 'shows the entire record' do
       e = Email.create(email_address: 'foo@bar.com')
       u = User.last
       u.emails << e
@@ -128,7 +128,9 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       out = @ap.awesome(@diana)
 
       raw_object_string =
-        if activerecord_6_0?
+        if activerecord_6_1?
+          ActiveRecordData.raw_6_1_diana
+        elsif activerecord_6_0?
           ActiveRecordData.raw_6_0_diana
         elsif activerecord_5_2?
           ActiveRecordData.raw_5_2_diana
@@ -154,7 +156,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
           end
         end
 
-      if RUBY_PLATFORM == 'java'
+      if RUBY_PLATFORM == 'java' && !activerecord_6_1?
         raw_object_string.gsub!(
           'ActiveRecord::ConnectionAdapters::SQLite3Adapter::SQLite3Integer',
           'ArJdbc::SQLite3::SQLite3Integer'
@@ -168,7 +170,9 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       out = @ap.awesome([@diana, @laura])
 
       raw_object_string =
-        if activerecord_6_0?
+        if activerecord_6_1?
+          ActiveRecordData.raw_6_1_multi
+        elsif activerecord_6_0?
           ActiveRecordData.raw_6_0_multi
         elsif activerecord_5_2?
           ActiveRecordData.raw_5_2_multi
@@ -194,7 +198,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
           end
         end
 
-      if RUBY_PLATFORM == 'java'
+      if RUBY_PLATFORM == 'java' && !activerecord_6_1?
         raw_object_string.gsub!(
           'ActiveRecord::ConnectionAdapters::SQLite3Adapter::SQLite3Integer',
           'ArJdbc::SQLite3::SQLite3Integer'
@@ -212,7 +216,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should print the class' do
+    it 'prints the class' do
       expect(@ap.awesome(User)).to eq <<~EOS.strip
         class User < ActiveRecord::Base {
                     :id => :integer,
@@ -224,7 +228,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       EOS
     end
 
-    it 'should print the class for non-direct subclasses of ActiveRecord::Base' do
+    it 'prints the class for non-direct subclasses of ActiveRecord::Base' do
       out = @ap.awesome(SubUser)
       expect(out).to eq <<~EOS.strip
         class SubUser < User {
@@ -237,9 +241,14 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       EOS
     end
 
-    it 'should print ActiveRecord::Base objects (ex. ancestors)' do
+    it 'prints ActiveRecord::Base objects (ex. ancestors)' do
       expect { @ap.awesome(User.ancestors) }.not_to raise_error
     end
+
+    it 'prints valid HTML for subclasses' do
+      @ap = AmazingPrint::Inspector.new(html: true)
+      expect(@ap.awesome(SubUser)).to match('SubUser &lt; User')
+    end
   end
 
   #------------------------------------------------------------------------------
@@ -248,7 +257,7 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
       @ap = AmazingPrint::Inspector.new(plain: true)
     end
 
-    it 'should format class methods properly' do
+    it 'formats class methods properly' do
       # spec 1
       out = @ap.awesome(User.methods.grep(/first/))
 
@@ -257,7 +266,15 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
           expect(out).to match(
             /\s+first\(\*args,\s&block\)\s+#<Class:\w+>\s+\(ActiveRecord::Querying\)/
           )
-        elsif RUBY_VERSION >= '2.7.0'
+        elsif RUBY_VERSION >= '3.0.0'
+          expect(out).to match(
+            /\s*first\(\*(\*|args),\s+&(&|block)\)\s+#<Class:User> \(ActiveRecord::Querying\)/
+          )
+        elsif RUBY_VERSION >= '2.7.2'
+          expect(out).to match(
+            /\s*first\(\*(\*|args),\s+&(&|block)\)\s+User/
+          )
+        elsif RUBY_VERSION >= '2.6.7'
           expect(out).to match(
             /\s*first\(\*(\*|args),\s+&(&|block)\)\s+#<Class:ActiveRecord::Base> \(ActiveRecord::Querying\)/
           )
@@ -278,12 +295,16 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
         expect(out).to match(
           /\sprimary_key\(.*?\)\s+#<Class:\w+>\s\(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/
         )
+      elsif RUBY_VERSION >= '3.0.0'
+        expect(out).to match(/\sprimary_key\(.*?\)\s+#<Class:User> \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
+      elsif RUBY_VERSION >= '2.6.7' && RUBY_VERSION < '2.7.0'
+        expect(out).to match(/\sprimary_key\(.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
+      elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
+        expect(out).to match(/\sprimary_key\(.*?\)\s+User/)
       elsif RUBY_VERSION >= '2.7.0'
         expect(out).to match(
           /\sprimary_key\(.*?\)\s+.+Class.+\(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/
         )
-      elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./
-        expect(out).to match(/\sprimary_key\(.*?\)\s+User/)
       else
         expect(out).to match(/\sprimary_key\(.*?\)\s+Class \(ActiveRecord::AttributeMethods::PrimaryKey::ClassMethods\)/)
       end
@@ -293,18 +314,18 @@ RSpec.describe 'AmazingPrint/ActiveRecord', skip: -> { !ExtVerifier.has_rails? }
 
       if ActiveRecord::VERSION::MAJOR < 3
         expect(out).to match(/\svalidate\(\*arg.*?\)\s+User \(ActiveRecord::Base\)/)
+      elsif RUBY_PLATFORM == 'java'
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:\w+> \(ActiveModel::Validations::ClassMethods\)/)
+      elsif RUBY_VERSION >= '3.0.0'
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:User> \(ActiveModel::Validations::ClassMethods\)/)
+      elsif RUBY_VERSION =~ /2\.7\.(0|1)/ || (RUBY_VERSION >= '2.6.7' && RUBY_VERSION < '2.7.0')
+        expect(out).to match(
+          /\svalidate\(\*args.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveModel::Validations::ClassMethods\)/
+        )
+      elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./ || RUBY_VERSION >= '2.7.2'
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+User/)
       else
-        if RUBY_PLATFORM == 'java'
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+#<Class:\w+> \(ActiveModel::Validations::ClassMethods\)/)
-        elsif RUBY_VERSION >= '2.7.0'
-          expect(out).to match(
-            /\svalidate\(\*args.*?\)\s+#<Class:ActiveRecord::Base> \(ActiveModel::Validations::ClassMethods\)/
-          )
-        elsif RUBY_VERSION =~ /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+User/)
-        else
-          expect(out).to match(/\svalidate\(\*arg.*?\)\s+Class \(ActiveModel::Validations::ClassMethods\)/)
-        end
+        expect(out).to match(/\svalidate\(\*arg.*?\)\s+Class \(ActiveModel::Validations::ClassMethods\)/)
       end
     end
   end

data/spec/ext/active_support_spec.rb

@@ -3,24 +3,33 @@
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint::ActiveSupport', skip: -> { !ExtVerifier.has_rails? }.call do
+  let(:expected_ar_time_str) do
+    if activerecord_6_1?
+      '15:30:45.000000000'
+    else
+      '15:30:45'
+    end
+  end
+
   before do
     @ap = AmazingPrint::Inspector.new
   end
 
-  it 'should format ActiveSupport::TimeWithZone as regular Time' do
+  it 'formats ActiveSupport::TimeWithZone as regular Time' do
     Time.zone = 'Eastern Time (US & Canada)'
     time = Time.utc(2007, 2, 10, 20, 30, 45).in_time_zone
-    expect(@ap.send(:awesome, time)).to eq("\e[0;32mSat, 10 Feb 2007 15:30:45 EST -05:00\e[0m")
+    expect(@ap.send(:awesome, time))
+      .to eq("\e[0;32mSat, 10 Feb 2007 #{expected_ar_time_str} EST -05:00\e[0m")
   end
 
-  it 'should format HashWithIndifferentAccess as regular Hash' do
+  it 'formats HashWithIndifferentAccess as regular Hash' do
     hash = HashWithIndifferentAccess.new({ hello: 'world' })
     expect(@ap.send(:awesome, hash)).to eq("{\n    \"hello\"\e[0;37m => \e[0m\e[0;33m\"world\"\e[0m\n}")
   end
 
   # ActiveSupport sticks in instance variables to the date object. Make sure
   # we ignore that and format Date instance as regular date.
-  it 'should formate Date object as date' do
+  it 'formates Date object as date' do
     date = Date.new(2003, 5, 26)
     expect(date.ai(plain: true)).to eq('Mon, 26 May 2003')
     expect(date.ai).to eq("\e[0;32mMon, 26 May 2003\e[0m")

data/spec/ext/mongo_mapper_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_mapper? }.call do
@@ -27,12 +29,12 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     # before { @ap.options[:raw] = true }
     before { @ap = AmazingPrint::Inspector.new(plain: true, sort_keys: true, raw: true) }
 
-    it 'should print class instance' do
+    it 'prints class instance' do
       user = MongoUser.new(first_name: 'Al', last_name: 'Capone')
 
       out = @ap.send(:awesome, user)
-      out.gsub!(/#\<Proc:.+?\>/, 'amazing_print_PROC_STUB')
-      out.gsub!(/BSON::ObjectId\('[\da-f]+?'\)/, "BSON::ObjectId('123456789')")
+               .gsub(/#<Proc:.+?>/, 'amazing_print_PROC_STUB')
+               .gsub(/BSON::ObjectId\('[\da-f]+?'\)/, "BSON::ObjectId('123456789')")
 
       str = if MongoMapper::Version >= '0.13'
               <<~EOS.strip
@@ -129,7 +131,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
       expect(out).to be_similar_to(str)
     end
 
-    it 'should print the class' do
+    it 'prints the class' do
       expect(@ap.send(:awesome, MongoUser)).to eq <<~EOS.strip
         class MongoUser < Object {
                    "_id" => :object_id,
@@ -139,7 +141,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
       EOS
     end
 
-    it 'should print the class when type is undefined' do
+    it 'prints the class when type is undefined' do
       class Chamelion
         include MongoMapper::Document
         key :last_attribute
@@ -178,7 +180,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned off (default)' do
-      it 'should render the class as normal' do
+      it 'renders the class as normal' do
         expect(@ap.send(:awesome, Parent)).to eq <<~EOS.strip
           class Parent < Object {
                "_id" => :object_id,
@@ -187,7 +189,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
         EOS
       end
 
-      it 'should render an instance as normal' do
+      it 'renders an instance as normal' do
         parent = Parent.new(name: 'test')
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -201,11 +203,11 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned on and inline embedded turned off' do
-      before :each do
+      before do
         @ap = AmazingPrint::Inspector.new(plain: true, mongo_mapper: { show_associations: true })
       end
 
-      it 'should render the class with associations shown' do
+      it 'renders the class with associations shown' do
         expect(@ap.send(:awesome, Parent)).to eq <<~EOS.strip
           class Parent < Object {
                   "_id" => :object_id,
@@ -216,7 +218,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
         EOS
       end
 
-      it 'should render an instance with associations shown' do
+      it 'renders an instance with associations shown' do
         parent = Parent.new(name: 'test')
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -232,7 +234,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
 
     describe 'with show associations turned on and inline embedded turned on' do
-      before :each do
+      before do
         @ap = AmazingPrint::Inspector.new plain: true,
                                           mongo_mapper: {
                                             show_associations: true,
@@ -240,7 +242,7 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
                                           }
       end
 
-      it 'should render an instance with associations shown and embeds there' do
+      it 'renders an instance with associations shown and embeds there' do
         parent = Parent.new(name: 'test', child: Child.new(data: 5))
         out = @ap.send(:awesome, parent)
         str = <<~EOS.strip
@@ -259,3 +261,5 @@ RSpec.describe 'AmazingPrint/MongoMapper', skip: -> { !ExtVerifier.has_mongo_map
     end
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/mongoid_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.call do
@@ -23,7 +25,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     @ap = AmazingPrint::Inspector.new plain: true, sort_keys: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = MongoUser.new first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -38,7 +40,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(out).to be_similar_to(str, { skip_bson: true })
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     class_spec = <<~EOS.strip
       class MongoUser < Object {
                  :_id => :"bson/object_id",
@@ -50,7 +52,7 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(@ap.send(:awesome, MongoUser)).to eq class_spec
   end
 
-  it 'should print the class when type is undefined' do
+  it 'prints the class when type is undefined' do
     class Chamelion
       include Mongoid::Document
       field :last_attribute
@@ -66,3 +68,5 @@ RSpec.describe 'AmazingPrint/Mongoid', skip: -> { !ExtVerifier.has_mongoid? }.ca
     expect(@ap.send(:awesome, Chamelion)).to eq class_spec
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/nobrainer_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer? }.call do
@@ -30,7 +32,7 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     @ap = AmazingPrint::Inspector.new plain: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = SomeModel.new first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -45,7 +47,7 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     expect(out).to eq(str)
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     class_spec = <<~EOS.strip
       class SomeModel < Object {
                   :id => :string,
@@ -58,3 +60,5 @@ RSpec.describe 'AmazingPrint/NoBrainer', skip: -> { !ExtVerifier.has_nobrainer?
     expect(@ap.send(:awesome, SomeModel)).to eq class_spec
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/ext/nokogiri_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Nokogiri' do
-  it 'should colorize tags' do
+  it 'colorizes tags' do
     xml = Nokogiri::XML('<html><body><h1></h1></body></html>')
     # FIXME: Due to something strange with Nokogiri and JRuby, we need to remove extra blank lines.
     output = xml.ai.gsub(/\n\n/, "\n")
@@ -17,7 +17,7 @@ RSpec.describe 'AmazingPrint/Nokogiri' do
     EOS
   end
 
-  it 'should colorize contents' do
+  it 'colorizes contents' do
     xml = Nokogiri::XML('<html><body><h1>Hello</h1></body></html>')
     expect(xml.ai).to eq <<~EOS
       <?xml version=\"1.0\"?>\e[1;32m
@@ -29,7 +29,7 @@ RSpec.describe 'AmazingPrint/Nokogiri' do
     EOS
   end
 
-  it 'should colorize class and id' do
+  it 'colorizes class and id' do
     xml = Nokogiri::XML('<html><body><h1><span class="world" id="hello"></span></h1></body></html>')
     # FIXME: Due to something strange with Nokogiri and JRuby, we need to remove extra blank lines.
     output = xml.ai.gsub(/\n\n/, "\n")

data/spec/ext/ripple_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call do
@@ -24,7 +26,7 @@ RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call
     @ap = AmazingPrint::Inspector.new plain: true, sort_keys: true
   end
 
-  it 'should print class instance' do
+  it 'prints class instance' do
     user = RippleUser.new _id: '12345', first_name: 'Al', last_name: 'Capone'
     out = @ap.send :awesome, user
 
@@ -37,7 +39,7 @@ RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call
     EOS
   end
 
-  it 'should print the class' do
+  it 'prints the class' do
     expect(@ap.send(:awesome, RippleUser)).to eq <<~EOS.strip
       class RippleUser < Object {
                  :_id => :string,
@@ -47,3 +49,5 @@ RSpec.describe 'AmazingPrint/Ripple', skip: -> { !ExtVerifier.has_ripple? }.call
     EOS
   end
 end
+
+# rubocop:enable Lint/ConstantDefinitionInBlock