ama_validators 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b489bd624f89d364f72259c065518a14e7e529cf
-  data.tar.gz: 0d5db6097790f0d8a9ca9a39c0dc4b67916f6151
+  metadata.gz: 7f23e65bb1adaeeeb02df1e0bb11d43ecd908607
+  data.tar.gz: a89f702c90973a5a9132b1e4ca3d37b987a06882
 SHA512:
-  metadata.gz: cf6a9dd7f796f03339d7d63d127958c12b5657c11dab18e6649e152da79b170f1ceca99a974187115844df2e1cd807b3f2d869d7ef630a3246fabd1662b299d3
-  data.tar.gz: 55c095d322cb989b85ad22c57125f99b02ef2d1792dff1041178d549abde0520627ca848519fd95d15214b7d569014012e9e0dd20e16b00e7994c1e009142cf5
+  metadata.gz: fe8346c85ebbf628ce889a17f3fa07fe7f932503cef52e9ef6381bf3490e44722fe9d720e43d68b21ab6c6ae606119dc929fa01499cacd8ba6a3f77cfc75efe1
+  data.tar.gz: a877f357e65942f009294db4745c8ed80ca595b736cfd753809784de4bde687498d61d466d952bec7efab64e153ea7def70830364980b12429f7f01b18ec7bb3

data/README.md

@@ -2,7 +2,7 @@
 
 [![Gem Version](https://badge.fury.io/rb/ama_validators.png)](http://badge.fury.io/rb/ama_validators)
 [![Code Climate](https://codeclimate.com/github/amaabca/ama_validators.png)](https://codeclimate.com/github/amaabca/ama_validators)
-[![Build Status](https://api.travis-ci.org/amaabca/ama_validators.png?branch=master)](https://travis-ci.org/amaabca/ama_validators)
+[![Build Status](https://travis-ci.org/amaabca/ama_validators.png?branch=master)](https://travis-ci.org/amaabca/ama_validators)
 [![Coverage Status](https://coveralls.io/repos/amaabca/ama_validators/badge.png)](https://coveralls.io/r/amaabca/ama_validators)
 [![Dependency Status](https://gemnasium.com/amaabca/ama_validators.png)](https://gemnasium.com/amaabca/ama_validators)
 

data/ama_validators.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["ruben.a.estevez@gmail.com"]
   spec.description   = "Compile the following validators: - Credit card - Email - Membership number - Phone number - Postal code"
   spec.summary       = "This gem will compile the following validators - Credit card - Email - Membership number - Phone number - Postal code. With this gem there is no need for the validators classes."
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/amaabca/ama_validators"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)

data/lib/ama_validators/email_format_validator.rb

@@ -1,6 +1,6 @@
 class EmailFormatValidator < ActiveModel::EachValidator
   def validate_each(object, attribute, value)
-    unless value =~ /\A[^@\s]+@([^@\s\.]+\.)+[^@\s\.]+\z/
+    unless value =~ /\A[^`@\s]+@([^@`\s\.]+\.)+[^`@\s\.]+\z/
       object.errors[attribute] << (options[:message] || "enter a valid email address (e.g. name@example.com)")
     end
   end

data/lib/ama_validators/phone_number_format_validator.rb

@@ -1,6 +1,6 @@
 class PhoneNumberFormatValidator < ActiveModel::EachValidator
   def validate_each(object, attribute, value)
-    unless value =~ /\A(1( |-)?)?(\(?[0-9]{3}\)?|[0-9]{3})( |-)?([0-9]{3}( |-)?[0-9]{4}|[a-zA-Z0-9]{7})\z/
+    unless value =~ /\A(\+?1( |-)?)?(\(?[0-9]{3}\)?|[0-9]{3})( |-)?([0-9]{3}( |-)?[0-9]{4})\z/
       object.errors[attribute] << (options[:message] || "enter a valid 10-digit number (e.g. 587-555-5555)")
     end
   end

data/lib/ama_validators/postal_code_format_validator.rb

@@ -1,7 +1,7 @@
 class PostalCodeFormatValidator < ActiveModel::EachValidator
   def validate_each(object, attribute, value)
-    unless value =~ /\A(\d{5}((-|\s)\d{4})?)|([txTX]\d[abceghjklmnprtvxyzABCEGHJKLMNPRSTVWXYZ])\ {0,1}(\d[abceghjklmnprstvxyzABCEGHJKLMNPRSTVWXYZ]\d)\z/
-      object.errors[attribute] << (options[:message] || "enter a valid AB or NT postal code (e.g. T2T 2T2)")
+    unless value =~ /\A(\d{5}((-|\s)\d{4})?)|([txTX]\d[abceghjklmnprstvwxyzABCEGHJKLMNPRSTVWXYZ])\ {0,1}(\d[abceghjklmnprstvwxyzABCEGHJKLMNPRSTVWXYZ]\d)\z/
+      object.errors[attribute] << (options[:message] || "enter a valid AB or NT postal code (e.g. T4C 1A5)")
     end
   end
 end

data/lib/ama_validators/version.rb

@@ -1,3 +1,3 @@
 module AmaValidators
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/credit_card_format_validator_spec.rb

@@ -7,20 +7,27 @@ describe CreditCardFormatValidator do
   let( :attribute ) { :credit_card }
   let (:object) { Profile.new }
 
+  invalid_credit_card_numbers = %w[9556494038121161 41128109359983 n396092084242542 535299462783972 1396092084242542]
+  valid_credit_card_numbers = %w[4556494038121161 4112810935509983 4556828677360012 5396092084242542 5180466231664941 5352994627083972]
+
 
   context 'Wrong credit card format' do
 
     context 'No message is sent on the options' do
       it 'it returns error message expecified on the validator' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, '9485582751367890')).to include('enter a valid credit card number (Visa or Mastercard)')
+        invalid_credit_card_numbers.each do |invalid_credit_card_number|
+          expect(n.validate_each(object, attribute, invalid_credit_card_number)).to include('enter a valid credit card number (Visa or Mastercard)')
+        end
       end
     end
 
     context 'Message is sent on the options' do
       it 'it returns error message expecified on the options' do
         n  = subject.new( { message: 'Test error message', attributes: :postal_code } )
-        expect(n.validate_each(object, attribute, '9485582751367890')).to include('Test error message')
+        invalid_credit_card_numbers.each do |invalid_credit_card_number|
+          expect(n.validate_each(object, attribute, invalid_credit_card_number)).to include('Test error message')
+        end
       end
     end
 
@@ -29,16 +36,20 @@ describe CreditCardFormatValidator do
   context 'Correct credit card format' do
 
     context 'No message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, '4716157014589654')).to equal(nil)
+        valid_credit_card_numbers.each do |valid_credit_card_number|
+          expect(n.validate_each(object, attribute, valid_credit_card_number)).to equal(nil)
+        end
       end
     end
 
     context 'Message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { message: 'Test error message', attributes: attribute } )
-        expect(n.validate_each(object, attribute, '5595361193388663')).to equal(nil)
+        valid_credit_card_numbers.each do |valid_credit_card_number|
+          expect(n.validate_each(object, attribute, valid_credit_card_number)).to equal(nil)
+        end
       end
     end
 

data/spec/email_format_validator_spec.rb

@@ -7,20 +7,27 @@ describe EmailFormatValidator do
   let( :attribute ) { :email }
   let (:object) { Profile.new }
 
+  invalid_addresses = %w[user@fail,com user_at.com user_fail.com user@ @fail.com ryan`1`@system88.com]
+  valid_addresses = %w[user@pass.com user_user@pass.com user.user@pass.com ryan+stage@systme88.com]
+
 
   context 'Wrong email format' do
 
     context 'No message is sent on the options' do
       it 'it returns error message expecified on the validator' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, 'fail@com')).to include('enter a valid email address (e.g. name@example.com)')
+        invalid_addresses.each do |invalid_address|
+          expect(n.validate_each(object, attribute, invalid_address)).to include('enter a valid email address (e.g. name@example.com)')
+        end
       end
     end
 
     context 'Message is sent on the options' do
       it 'it returns error message expecified on the options' do
         n  = subject.new( { message: 'Test error message', attributes: :postal_code } )
-        expect(n.validate_each(object, attribute, 'fail.com')).to include('Test error message')
+        invalid_addresses.each do |invalid_address|
+          expect(n.validate_each(object, attribute, invalid_address)).to include('Test error message')
+        end
       end
     end
 
@@ -29,16 +36,20 @@ describe EmailFormatValidator do
   context 'Correct email format' do
 
     context 'No message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, 'no_fail@mail.com')).to equal(nil)
+        valid_addresses.each do |valid_address|
+          expect(n.validate_each(object, attribute, valid_address)).to equal(nil)
+        end
       end
     end
 
     context 'Message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { message: 'Test error message', attributes: attribute } )
-        expect(n.validate_each(object, attribute, 'no_fail@mail.com')).to equal(nil)
+        valid_addresses.each do |valid_address|
+          expect(n.validate_each(object, attribute, valid_address)).to equal(nil)
+        end
       end
     end
 

data/spec/membership_number_format_validator_spec.rb

@@ -7,20 +7,27 @@ describe MembershipNumberFormatValidator do
   let( :attribute ) { :membership_number }
   let (:object) { Profile.new }
 
+  invalid_membership_numbers = %w[waffles 1234560022820001 620272089641001 62027217054490012 1202722030577003 6202822030577003]
+  valid_membership_numbers = %w[6202720022820001 6202720896410004 6202721705449001 6202722030577003]
+
 
   context 'Wrong membership number format' do
 
     context 'No message is sent on the options' do
       it 'it returns error message expecified on the validator' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, '6202721111')).to include('must be a valid membership number')
+        invalid_membership_numbers.each do |invalid_membership_number|
+          expect(n.validate_each(object, attribute, invalid_membership_number)).to include('must be a valid membership number')
+        end
       end
     end
 
     context 'Message is sent on the options' do
       it 'it returns error message expecified on the options' do
         n  = subject.new( { message: 'Test error message', attributes: :postal_code } )
-        expect(n.validate_each(object, attribute, '6202721111')).to include('Test error message')
+        invalid_membership_numbers.each do |invalid_membership_number|
+          expect(n.validate_each(object, attribute, invalid_membership_number)).to include('Test error message')
+        end
       end
     end
 
@@ -29,16 +36,20 @@ describe MembershipNumberFormatValidator do
   context 'Correct membership number format' do
 
     context 'No message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, '6202720022820001')).to equal(nil)
+        valid_membership_numbers.each do |valid_membership_number|
+          expect(n.validate_each(object, attribute, valid_membership_number)).to equal(nil)
+        end
       end
     end
 
     context 'Message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { message: 'Test error message', attributes: attribute } )
-        expect(n.validate_each(object, attribute, '6202720022820001')).to equal(nil)
+        valid_membership_numbers.each do |valid_membership_number|
+          expect(n.validate_each(object, attribute, valid_membership_number)).to equal(nil)
+        end
       end
     end
 

data/spec/phone_number_format_validator_spec.rb

@@ -7,20 +7,26 @@ describe PhoneNumberFormatValidator do
   let( :attribute ) { :phone_number }
   let (:object) { Profile.new }
 
+  invalid_phone_numbers = %w[123 780123456 1234456 666 mynumber 780myphone]
+  valid_phone_numbers = %w[587-555-5555 5875555555 1234567890 17809172969 (780)9172969 7809172969 +17809172969 +1(780)9172969]
 
   context 'Wrong phone number format' do
 
     context 'No message is sent on the options' do
       it 'it returns error message expecified on the validator' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, '777 777')).to include('enter a valid 10-digit number (e.g. 587-555-5555)')
+        invalid_phone_numbers.each do |invalid_phone_number|
+          expect(n.validate_each(object, attribute, invalid_phone_number)).to include('enter a valid 10-digit number (e.g. 587-555-5555)')
+        end
       end
     end
 
     context 'Message is sent on the options' do
       it 'it returns error message expecified on the options' do
         n  = subject.new( { message: 'Test error message', attributes: attribute } )
-        expect(n.validate_each(object, attribute, '777 777')).to include('Test error message')
+        invalid_phone_numbers.each do |invalid_phone_number|
+          expect(n.validate_each(object, attribute, invalid_phone_number)).to include('Test error message')
+        end
       end
     end
 
@@ -29,16 +35,20 @@ describe PhoneNumberFormatValidator do
   context 'Correct phone number format' do
 
     context 'No message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, '777 123 4567')).to equal(nil)
+        valid_phone_numbers.each do |valid_phone_number|
+          expect(n.validate_each(object, attribute, valid_phone_number)).to equal(nil)
+        end
       end
     end
 
     context 'Message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { message: 'Test error message', attributes: attribute } )
-        expect(n.validate_each(object, attribute, '777 123 4567')).to equal(nil)
+        valid_phone_numbers.each do |valid_phone_number|
+          expect(n.validate_each(object, attribute, valid_phone_number)).to equal(nil)
+        end
       end
     end
 

data/spec/postal_code_format_validator_spec.rb

@@ -7,20 +7,26 @@ describe PostalCodeFormatValidator do
   let( :attribute ) { :postal_code }
   let (:object) { Profile.new }
 
+  invalid_postal_codes = %w[2w2e3e b4hk6j t556v7 x2ceee t3x6sv T5j5M/]
+  valid_postal_codes = %w[T5w4g5 T5W4G5 X4H3J9 t6J4M5 x3B5X8]
 
   context 'Wrong postal code format' do
 
     context 'No message is sent on the options' do
       it 'it returns error message expecified on the validator' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, 'TTJ4M5')).to include('enter a valid AB or NT postal code (e.g. T2T 2T2)')
+        invalid_postal_codes.each do |invalid_postal_code|
+          expect(n.validate_each(object, attribute, invalid_postal_code)).to include('enter a valid AB or NT postal code (e.g. T4C 1A5)')
+        end
       end
     end
 
     context 'Message is sent on the options' do
       it 'it returns error message expecified on the options' do
         n  = subject.new( { message: 'Test error message', attributes: attribute } )
-        expect(n.validate_each(object, attribute, 'G7J4M5')).to include('Test error message')
+        invalid_postal_codes.each do |invalid_postal_code|
+          expect(n.validate_each(object, attribute, invalid_postal_code)).to include('Test error message')
+        end
       end
     end
 
@@ -29,16 +35,20 @@ describe PostalCodeFormatValidator do
   context 'Correct postal code format' do
 
     context 'No message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { attributes: attribute } )
-        expect(n.validate_each(object, attribute, 'T6J4M5')).to equal(nil)
+        valid_postal_codes.each do |valid_postal_code|
+          expect(n.validate_each(object, attribute, valid_postal_code)).to equal(nil)
+        end
       end
     end
 
     context 'Message is sent on the options' do
-      it 'it do not return error message' do
+      it 'it does not return error message' do
         n  = subject.new( { message: 'Test error message', attributes: attribute } )
-        expect(n.validate_each(object, attribute, 'T6J4M5')).to equal(nil)
+        valid_postal_codes.each do |valid_postal_code|
+          expect(n.validate_each(object, attribute, valid_postal_code)).to equal(nil)
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ama_validators
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ruben Estevez
@@ -167,7 +167,7 @@ files:
 - spec/phone_number_format_validator_spec.rb
 - spec/postal_code_format_validator_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+homepage: https://github.com/amaabca/ama_validators
 licenses:
 - MIT
 metadata: {}