alula-ruby 1.2.4 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c33d8891eaf1c48cac11a52b1afb25ac8e0b0085337035ed62cce0f149a39ca
-  data.tar.gz: a744baa78d697b48c49a1adb8a1037ecf42fc57345eb93193ee62448349aeb4b
+  metadata.gz: f70aa0a4b0c40a14dd7cfdbb1faa3655525f06212409a61eb9c4af071deead07
+  data.tar.gz: a97bd6710997caa25a901cd3000c1edabdcbd31458460a17e61658093dc7cc5b
 SHA512:
-  metadata.gz: 24325ab8af9e6e69168d7eac1f09ffd8c6b9fdabac9058d076fbf742d7049764f11c555568f3618f81950af779e3dd55a5cba6263f203a3a7852928b3f6b8a12
-  data.tar.gz: 90e797fdfe125ea6f593c5bcf425dfe17b2eb2100adb602a0277032bf9e83c93baa12052ba67a07ed3b024806f8bc34fe3cdd1aa74fe646e03557c7cc4894b0b
+  metadata.gz: 9ff58743a47fc9cc49a71c76e57302debc60acb28a13f37099385d7dbf7260f96b3381da9b6fd8423ee0877a786050a4c6cf9efc5060bf4339a6921d82fba8cb
+  data.tar.gz: f51670cb212984b3157ec25e64e07744205359e0d98c3d707ade79bded8a83fc30a0764a747b021cdd23867094c5be8e93a862ac47fa9a0c7b610ef87522a36d

data/README.md

@@ -380,7 +380,7 @@ Success responses are custom per RPC method. Some provide response data, some do
 
 After checking out the repo, run `bin/setup` to install dependencies. You can also run `bundle exec bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, and push git commits and tags.
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, commit and push your changes. GitHub Actions takes care of the gem release.
 
 ### Using Docker
 

data/VERSION.md

@@ -2,6 +2,8 @@
 
 | Version | Date      | Description                                                                 |
 | ------- | --------- | --------------------------------------------------------------------------- |
+| v1.4.0  | 2024-01-04  | Add more known errors that use a different format, bugfix for `NotImplementedError` raising         |
+| v1.3.0  | 2023-11-20  | Update NotImplemented error's message to include a JSONized hash, add more known errors that use a different format         |
 | v1.2.4  | 2023-09-15  | Update UI Settings to object         |
 | v1.2.3  | 2023-08-31  | Update typo device patchable field `uiSettings`         |
 | v1.2.2  | 2023-08-30  | Add new device patchable field `uiSettings`         |

data/alula.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "dotenv"
   spec.add_development_dependency "guard-rspec"
-  spec.add_development_dependency "nokogiri", "~> 1.10.3"
+  spec.add_development_dependency "nokogiri", "~> 1.11.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "simplecov", "~> 0.21.2"

data/lib/alula/errors.rb

@@ -71,9 +71,24 @@ module Alula
         # RPC errors are identified by jsonrpc in the body.
         return ProcedureError.new(response) if response.data['jsonrpc']
 
-
-        Alula.logger.error response
-        raise NotImplementedError.new("Unable to derive error for #{response.data['error']}")
+        # Error messages coming from the API are inconsistent.
+        # Sometimes they are in the msg key, sometimes in the message key
+        # Example: https://github.com/alula-net/alula-connect/pull/3417#issue-1985813211
+        # Here we have some errors that are actually known but at least one of them is not properly formatted by the API
+        message = response.data.dig('error', 'data', 'msg') ||
+                  response.data.dig('error', 'data', 'message') ||
+                  response.data.dig('error', 'description')
+        case message
+        when 'dealer does not exist'
+          NotFoundError.new(message)
+        when 'Insufficient User Scope'
+          InsufficientScopeError.new(message)
+        when 'Not Found'
+          NotFoundError.new(message)
+        else
+          Alula.logger.error response
+          raise NotImplementedError, "Unable to derive error for #{response.data['error'].to_json}"
+        end
       end
     end
 
@@ -100,8 +115,19 @@ module Alula
         # RPC errors are identified by jsonrpc in the body.
         return ProcedureError.new(response) if response.data['jsonrpc']
 
-        Alula.logger.error response
-        raise NotImplementedError.new("Unable to derive error for #{response.data['errors']}")
+        # See comment in the error_for_response method
+        message = error.dig('data', 'msg') || error.dig('data', 'message') || error['description']
+        case message
+        when 'dealer does not exist'
+          NotFoundError.new(message)
+        when 'Insufficient User Scope'
+          InsufficientScopeError.new(message)
+        when 'Not Found'
+          NotFoundError.new(message)
+        else
+          Alula.logger.error response
+          raise NotImplementedError, "Unable to derive error for #{response.data['errors'].to_json}"
+        end
       end
     end
   end

data/lib/alula/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Alula
-  VERSION = '1.2.4'
+  VERSION = '1.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alula-ruby
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.4.0
 platform: ruby
 authors:
 - Titus Johnson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-09-15 00:00:00.000000000 Z
+date: 2024-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: 1.11.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: 1.11.7
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement