alpha_card 0.3.0 → 0.4.0

data/spec/alpha_card/{objects → transactions}/void_spec.rb

@@ -1,26 +1,26 @@
 require 'spec_helper'
 
 describe AlphaCard::Void do
-  let(:account) { AlphaCard::Account.new('demo', 'password') }
-
   context 'with invalid attributes' do
     let(:void) { AlphaCard::Void.new(transaction_id: 'Some ID') }
+    let(:response) { void.create }
 
     it 'response with error' do
-      expect { void.create(account) }.to raise_error(AlphaCard::AlphaCardError)
+      expect(response.error?).to be_truthy
+      expect(response.message).to eq('Transaction was rejected by gateway')
     end
   end
 
   context 'with valid attributes' do
-    let(:void) { AlphaCard::Void.new(transaction_id: '2303767426') }
+    let(:void) { AlphaCard::Void.new(transaction_id: 2303767426) }
 
     let(:order) { AlphaCard::Order.new(id: '1', description: 'Test') }
-    let(:card_exp) { "#{'%02d' % Time.now.month}/#{Time.now.year.next}" }
+    let(:card_exp) { (Time.now + 31104000).strftime('%m%y') }
     let(:sale) { AlphaCard::Sale.new(card_expiration_date: card_exp, card_number: '4111111111111111', amount: '5.00') }
 
     it 'has valid request params' do
       expected_params = {
-        transactionid: '2303767426',
+        transactionid: 2303767426,
         type: 'void'
       }
 
@@ -28,12 +28,12 @@ describe AlphaCard::Void do
     end
 
     it 'processed successfully' do
-      success, response = sale.create(order, account)
-      expect(success).to be_truthy
+      response = sale.create(order)
+      expect(response.success?).to be_truthy
       expect(response.transaction_id).not_to be_nil
 
-      success, response = AlphaCard::Void.new(transaction_id: response.transaction_id).create(account)
-      expect(success).to be_truthy
+      response = AlphaCard::Void.new(transaction_id: response.transaction_id).process
+      expect(response.success?).to be_truthy
       expect(response.text).to eq('Transaction Void Successful')
     end
   end
@@ -42,7 +42,7 @@ describe AlphaCard::Void do
     let(:void) { AlphaCard::Void.new }
 
     it 'raises an InvalidObject error' do
-      expect { void.create(account) }.to raise_error(AlphaCard::InvalidObjectError)
+      expect { void.create }.to raise_error(AlphaCard::ValidationError)
     end
   end
 end

data/spec/spec_helper.rb

@@ -15,4 +15,8 @@ require 'alpha_card'
 
 RSpec.configure do |config|
   config.order = 'random'
+
+  config.before(:suite) do
+    AlphaCard::Account.use_demo_credentials!
+  end
 end

metadata

@@ -1,55 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Nikita Bulaj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-22 00:00:00.000000000 Z
+date: 2016-10-07 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: virtus
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.5
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.5
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -82,33 +62,42 @@ files:
 - Rakefile
 - alpha_card.gemspec
 - lib/alpha_card.rb
-- lib/alpha_card/alpha_card_object.rb
-- lib/alpha_card/alpha_card_response.rb
+- lib/alpha_card/account.rb
+- lib/alpha_card/attribute.rb
 - lib/alpha_card/data/avs_responses.yml
 - lib/alpha_card/data/credit_card_codes.yml
 - lib/alpha_card/data/cvv_responses.yml
 - lib/alpha_card/data/response_messages.yml
-- lib/alpha_card/errors/alpha_card_error.rb
 - lib/alpha_card/errors/api_connection_error.rb
-- lib/alpha_card/errors/invalid_object_error.rb
-- lib/alpha_card/objects/account.rb
-- lib/alpha_card/objects/billing.rb
-- lib/alpha_card/objects/capture.rb
-- lib/alpha_card/objects/order.rb
-- lib/alpha_card/objects/refund.rb
-- lib/alpha_card/objects/sale.rb
-- lib/alpha_card/objects/shipping.rb
-- lib/alpha_card/objects/update.rb
-- lib/alpha_card/objects/void.rb
+- lib/alpha_card/errors/invalid_attribute_format.rb
+- lib/alpha_card/errors/invalid_attribute_type.rb
+- lib/alpha_card/errors/invalid_attribute_value.rb
+- lib/alpha_card/errors/validation_error.rb
+- lib/alpha_card/resource.rb
+- lib/alpha_card/resources/billing.rb
+- lib/alpha_card/resources/order.rb
+- lib/alpha_card/resources/shipping.rb
+- lib/alpha_card/response.rb
+- lib/alpha_card/transaction.rb
+- lib/alpha_card/transactions/auth.rb
+- lib/alpha_card/transactions/capture.rb
+- lib/alpha_card/transactions/credit.rb
+- lib/alpha_card/transactions/refund.rb
+- lib/alpha_card/transactions/sale.rb
+- lib/alpha_card/transactions/update.rb
+- lib/alpha_card/transactions/validate.rb
+- lib/alpha_card/transactions/void.rb
 - lib/alpha_card/version.rb
-- spec/alpha_card/objects/account_spec.rb
-- spec/alpha_card/objects/capture_spec.rb
-- spec/alpha_card/objects/deprecated_methods_spec.rb
-- spec/alpha_card/objects/refund_spec.rb
-- spec/alpha_card/objects/sale_spec.rb
-- spec/alpha_card/objects/update_spec.rb
-- spec/alpha_card/objects/void_spec.rb
+- spec/alpha_card/attribute_spec.rb
 - spec/alpha_card/response_spec.rb
+- spec/alpha_card/transactions/auth_spec.rb
+- spec/alpha_card/transactions/capture_spec.rb
+- spec/alpha_card/transactions/credit_spec.rb
+- spec/alpha_card/transactions/refund_spec.rb
+- spec/alpha_card/transactions/sale_spec.rb
+- spec/alpha_card/transactions/update_spec.rb
+- spec/alpha_card/transactions/validate_spec.rb
+- spec/alpha_card/transactions/void_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/nbulaj/alpha_card
 licenses:
@@ -122,7 +111,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.2.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/alpha_card/errors/alpha_card_error.rb

@@ -1,29 +0,0 @@
-module AlphaCard
-  ##
-  # Common class for Alpha Card Gateway errors and exceptions.
-  class AlphaCardError < StandardError
-    # Alpha Card Gateway response.
-    # @attr_reader [AlphaCard::AlphaCardResponse] response
-    attr_reader :response
-    # Error message.
-    # @attr_reader [String] message
-    attr_reader :message
-
-    ##
-    # <code>AlphaCard::AlphaCardError</code> constructor.
-    #
-    # @param [String] message
-    #   Error message
-    # @param [AlphaCard::AlphaCardResponse] response
-    #   AlphaCard Gateway response
-    #
-    # @example
-    #   AlphaCard::AlphaCardError.new
-    #
-    #   #=> #<AlphaCard::AlphaCardError: AlphaCard::AlphaCardError>
-    def initialize(message = nil, response = nil)
-      @message = message
-      @response = response
-    end
-  end
-end

data/lib/alpha_card/objects/account.rb

@@ -1,48 +0,0 @@
-module AlphaCard
-  ##
-  # Implementation of Alpha Card Services account object.
-  # Contains credentials (username and password) for
-  # the Alpha Card Gateway API access.
-  class Account < AlphaCardObject
-    attribute :username, String
-    attribute :password, String
-
-    ##
-    # <code>AlphaCard::Account</code> constructor.
-    #
-    # @param [String] username
-    # @param [String] password
-    #
-    # @example
-    #   AlphaCard::Account.new('demo', 'password')
-    #
-    #   #=> #<AlphaCard::Account:0x000000039b18a8 @username="demo", @password="password">
-    def initialize(username, password)
-      self.username = username
-      self.password = password
-    end
-
-    ##
-    # Say if all the credentials of Account is filled.
-    # Username and password can't be a <code>nil</code>
-    # object or an empty <code>String</code>.
-    #
-    # @return [Boolean]
-    #   True if username and password is filled.
-    #
-    # @example
-    #   account = AlphaCard::Account.new('demo', 'password')
-    #   account.filled?
-    #
-    #   #=> true
-    #
-    #   account = AlphaCard::Account.new('', nil)
-    #   account.filled?
-    #
-    #   #=> false
-    def filled?
-      attrs = [username, password]
-      attrs.all? { |attr| attr && !attr.strip.empty? }
-    end
-  end
-end

data/lib/alpha_card/objects/billing.rb

@@ -1,31 +0,0 @@
-module AlphaCard
-  ##
-  # Implementation of Alpha Card Services order billing information.
-  # Contains all the billing information (customer name, email, email, etc).
-  class Billing < AlphaCardObject
-    attribute :first_name, String
-    attribute :last_name, String
-    attribute :email, String
-    attribute :phone, String
-    attribute :company, String
-    attribute :address_1, String
-    attribute :address_2, String
-    attribute :city, String
-    attribute :state, String
-    attribute :zip, String
-    attribute :country, String
-    attribute :fax, String
-    attribute :website, String
-
-    ##
-    # Original AlphaCard transaction variables names
-    ORIGIN_TRANSACTION_VARIABLES = {
-      first_name: :firstname,
-      last_name: :lastname,
-      address_1: :address1,
-      address_2: :address2
-    }.freeze
-
-    deprecate_old_variables!
-  end
-end

data/lib/alpha_card/objects/capture.rb

@@ -1,51 +0,0 @@
-module AlphaCard
-  ##
-  # Implementation of Alpha Card Services Capture transaction.
-  class Capture < AlphaCardObject
-    attribute :transaction_id, String
-    # Format: xx.xx
-    attribute :amount, String
-    attribute :tracking_number, String
-    attribute :shipping_carrier, String
-    attribute :order_id, String
-
-    ##
-    # Transaction type (default is 'capture')
-    #
-    # @attribute [r] type
-    attribute :type, String, default: 'capture', writer: :private
-
-    ##
-    # Original AlphaCard transaction variables names
-    ORIGIN_TRANSACTION_VARIABLES = {
-      transaction_id: :transactionid,
-      order_id: :orderid
-    }.freeze
-
-    ##
-    # Creates a Capture with the <code>AlphaCard::Account</code> credentials.
-    #
-    # @param [AlphaCard::Account] account
-    #   An <code>AlphaCard::Account</code> object.
-    #
-    # @return [Boolean]
-    #   True if capture was created successfully.
-    #   Raise an AlphaCardError exception if some error occurred.
-    #
-    # @raise [Exception]
-    #   Exception if one of required attributes doesn't specified.
-    #
-    # @example
-    #   account = AlphaCard::Account.new('demo', 'password')
-    #   capture = AlphaCard::Capture.new(transaction_id: '981562', amount: '10.05')
-    #   capture.create(account)
-    #
-    #   #=> [true, #<AlphaCard::AlphaCardResponse:0x1a0fda ...>]
-    def create(account)
-      abort_if_attributes_blank!(:amount, :transaction_id)
-
-      response = AlphaCard.request(account, attributes_for_request)
-      [response.success?, response]
-    end
-  end
-end

data/lib/alpha_card/objects/sale.rb

@@ -1,82 +0,0 @@
-module AlphaCard
-  ##
-  # Implementation of Alpha Card Services Sale transaction.
-  # Contains all the information about Customer Credit Card,
-  # such as CVV, number, expiration date, etc.
-  # Process the Alpha Card Services payment.
-  class Sale < AlphaCardObject
-    # Format: MMYY
-    attribute :card_expiration_date, String
-    attribute :card_number, String
-    attribute :amount, String
-    attribute :cvv, String
-    # Values: 'true' or 'false'
-    attribute :customer_receipt, String
-
-    ##
-    # Payment type.
-    # Values: 'creditcard' or 'check'
-    attribute :payment, String, default: 'creditcard'
-
-    ##
-    # Transaction type (default is 'sale')
-    #
-    # @attribute [r] type
-    attribute :type, String, default: 'sale', writer: :private
-
-    ##
-    # Original AlphaCard transaction variables names
-    ORIGIN_TRANSACTION_VARIABLES = {
-      card_expiration_date: :ccexp,
-      card_number: :ccnumber
-    }.freeze
-
-    deprecate_old_variables!
-
-    ##
-    # Creates the sale for the specified <code>AlphaCard::Order</code>
-    # with the <code>AlphaCard::Account</code> credentials.
-    #
-    # @param [AlphaCard::Order] params
-    #    An <code>AlphaCard::Order</code> object.
-    # @param [AlphaCard::Account] account
-    #   An <code>AlphaCard::Account</code> object.
-    #
-    # @return [Boolean]
-    #   True if sale was created successfully.
-    #   Raise an AlphaCardError exception if some error occurred.
-    #
-    # @raise [AlphaCard::InvalidObjectError]
-    #   Exception if one of required attributes doesn't specified.
-    #
-    # @example
-    #   account = AlphaCard::Account.new('demo', 'password')
-    #   order = AlphaCard::Order.new(id: 1, description: 'Test order')
-    #   sale = AlphaCard::Sale.new(card_expiration_date: '0117', card_number: '4111111111111111', amount: '5.00' )
-    #   sale.create(order, account)
-    #
-    #   #=> [true, #<AlphaCard::AlphaCardResponse:0x1a0fda ...>]
-    def create(order, account)
-      abort_if_attributes_blank!(:card_expiration_date, :card_number, :amount)
-
-      response = AlphaCard.request(account, params_for_sale(order))
-      [response.success?, response]
-    end
-
-    private
-
-    ##
-    # Returns all the necessary attributes with it's original
-    # names that must be passed with Sale transaction.
-    #
-    # @param [AlphaCard::Order] order
-    #    An <code>AlphaCard::Order</code> object.
-    #
-    # @return [Hash]
-    #   Params of *self* object merged with params
-    #   of another object (<code>AlphaCard::Order</code>)
-    def params_for_sale(order)
-      attributes_for_request.merge(order.attributes_for_request)
-    end
-  end
-end