alpha_card 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36744d2c2e89bb5acb72ae8da81b9a5c684e5d2d
-  data.tar.gz: 1b402affc8aa94c7f20ea1895f2744c265d48296
+  metadata.gz: d71d35569f21cf510852e3c35f8df41399983e8a
+  data.tar.gz: a2266edd9c1e5df53788121264173053615c0931
 SHA512:
-  metadata.gz: 15f2fe0c1206ff43f976ab80564944aad992e70fc61e4e7cabac1fccbe05f3afe08c1cbf4e8375bbf44bedf328b007e7528bf674e10e730f28ebb605acf9e700
-  data.tar.gz: 60d5b8edd45ede8faed993f8aaaf99d335349d71803b9c519b41861d50318f99690e9151ee8248dbcea727f7ae68fe2b0ecdbb408c86e8ecbb244071925648e1
+  metadata.gz: 417ac49bc0b7a982f56d7fbc16d684b616c807e88d1adf37a0d2ab7aba3920608f678aa7eb4d59f7fdb50a2b8a2c52a94ae8660443a50dc0ace98d1e8833ae14
+  data.tar.gz: cebcd84f04b491a4d0bb7ad199572d89a4efb74c0e075867037ed6d2a7c5539aa2d74dc5d5ea939fa13197ba5eaa0a45a05e34413d051db0ddef854a25bd6daa

data/Gemfile

@@ -3,5 +3,6 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'virtus'
-gem 'rest_client'
-gem 'coveralls', require: false
+gem 'rest-client'
+gem 'coveralls', require: false
+gem 'rack-test', require: false

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2014 Nikita Bulaj
+Copyright (c) 2014-2015 Nikita Bulaj
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,10 +1,11 @@
 # Ruby lib for creating payments with Alpha Card Services
 [![Gem Version](https://badge.fury.io/rb/alpha_card.svg)](http://badge.fury.io/rb/alpha_card)
-[![Dependency Status](https://gemnasium.com/budev/alpha_card.png)](https://gemnasium.com/budev/alpha_card)
-[![Code Climate](https://codeclimate.com/github/budev/alpha_card.png)](https://codeclimate.com/github/budev/alpha_card)
-[![Coverage Status](https://coveralls.io/repos/budev/alpha_card/badge.png?branch=master)](https://coveralls.io/r/budev/alpha_card?branch=master)
-[![Build Status](https://travis-ci.org/budev/alpha_card.svg?branch=master)](https://travis-ci.org/budev/alpha_card)
-[![Inline docs](http://inch-ci.org/github/budev/alpha_card.png?branch=master)](http://inch-ci.org/github/budev/alpha_card)
+[![Dependency Status](https://gemnasium.com/nbulaj/alpha_card.svg)](https://gemnasium.com/nbulaj/alpha_card)
+[![Code Climate](https://codeclimate.com/github/nbulaj/alpha_card/badges/gpa.svg)](https://codeclimate.com/github/nbulaj/alpha_card)
+[![Coverage Status](https://coveralls.io/repos/nbulaj/alpha_card/badge.svg)](https://coveralls.io/r/nbulaj/alpha_card)
+[![Build Status](https://travis-ci.org/nbulaj/alpha_card.svg?branch=master)](https://travis-ci.org/nbulaj/alpha_card)
+[![Inline docs](http://inch-ci.org/github/nbulaj/alpha_card.png?branch=master)](http://inch-ci.org/github/nbulaj/alpha_card)
+[![License](http://img.shields.io/badge/license-MIT-brightgreen.svg)](#license)
 
 This gem can help your Ruby or Ruby on Rails application to integrate with Alpha Card Service, Inc.
 
@@ -231,6 +232,7 @@ To contribute:
 
 Thanks.
 
-## Copyright
+## License
 
-Copyright (c) 2014 Nikita Bulaj (bulajnikita@gmail.com).
+Alpha Card gem is released under the [MIT License](http://www.opensource.org/licenses/MIT).
+Copyright (c) 2014-2015 Nikita Bulaj (bulajnikita@gmail.com).

data/alpha_card.gemspec

@@ -5,7 +5,7 @@ require 'alpha_card/version'
 Gem::Specification.new do |gem|
   gem.name = 'alpha_card'
   gem.version = AlphaCard::VERSION
-  gem.date = '2014-07-24'
+  gem.date = '2015-04-27'
   gem.summary = 'Alpha Card Services API for Ruby'
   gem.description = 'Gem for creating sales with Alpha Card Services'
   gem.authors = ['Nikita Bulaj']
@@ -17,7 +17,7 @@ Gem::Specification.new do |gem|
   gem.required_ruby_version = '>= 1.9.3'
 
   gem.add_dependency 'virtus', '~> 1.0'
-  gem.add_dependency 'rest_client', '~> 1.7'
+  gem.add_dependency 'rest-client', '~> 1.8'
 
   gem.add_development_dependency 'rspec', '~> 3'
 end

data/lib/alpha_card.rb

@@ -1,12 +1,12 @@
 # encoding:utf-8
 require 'yaml'
 require 'virtus'
-require 'rest_client'
+require 'rest-client'
+require 'rack/utils'
 
 # Version
 require 'alpha_card/version'
 
-require 'alpha_card/utils'
 require 'alpha_card/alpha_card_object'
 require 'alpha_card/alpha_card_response'
 

data/lib/alpha_card/alpha_card_response.rb

@@ -28,7 +28,7 @@ module AlphaCard
     #
     #   #=> #<AlphaCard::AlphaCardResponse:0x00000003f2b568 @data={"response"=>"1", "responsetext"=>"Test"}>
     def initialize(response_body)
-      @data = AlphaCard::Utils.parse_query(response_body)
+      @data = Rack::Utils.parse_query(response_body)
     end
 
     ##

data/lib/alpha_card/objects/sale.rb

@@ -41,7 +41,7 @@ module AlphaCard
     #   #=> true
     def create(order, account)
       [:ccexp, :ccnumber, :amount].each do |attr|
-        fail Exception, "No #{attr} information provided" if self[attr].nil? || self[attr].empty?
+        fail Exception, "No #{attr} information provided!" if self[attr].nil? || self[attr].empty?
       end
 
       params = filled_attributes || {}

data/lib/alpha_card/version.rb

@@ -1,5 +1,5 @@
 module AlphaCard
   ##
   # Version information for AlphaCard gem.
-  VERSION = '0.2.4'
+  VERSION = '0.2.5'
 end

data/spec/alpha_card/alpha_card_spec.rb

@@ -110,5 +110,16 @@ describe AlphaCard do
         expect(e.message).to include('Unexpected error communicating with Alpha Card Gateway')
       end
     end
+
+    context 'With request exception' do
+      let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '5.00'}) }
+
+      it 'should handle an error' do
+        AlphaCard.api_base = 'https://google.com' # todo: some other service
+        expect { sale.create(order, account) }.to raise_error(AlphaCard::APIConnectionError)
+
+        AlphaCard.api_base = 'https://secure.alphacardgateway.com/api/transact.php'
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+require 'rack/test'
+
 require 'coveralls'
 Coveralls.wear!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Nikita Bulaj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-24 00:00:00.000000000 Z
+date: 2015-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -25,19 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: rest_client
+  name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -77,12 +77,10 @@ files:
 - lib/alpha_card/objects/order.rb
 - lib/alpha_card/objects/sale.rb
 - lib/alpha_card/objects/shipping.rb
-- lib/alpha_card/utils.rb
 - lib/alpha_card/version.rb
 - spec/alpha_card/alpha_card_account_spec.rb
 - spec/alpha_card/alpha_card_response_spec.rb
 - spec/alpha_card/alpha_card_spec.rb
-- spec/alpha_card/alpha_card_utils_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/nbulaj/alpha_card
 licenses:
@@ -109,3 +107,4 @@ signing_key:
 specification_version: 4
 summary: Alpha Card Services API for Ruby
 test_files: []
+has_rdoc: 

data/lib/alpha_card/utils.rb

@@ -1,83 +0,0 @@
-module AlphaCard
-  ##
-  # Some stolen methods to clear library dependencies.
-  class Utils
-    ##
-    # This one is from the rack gem. It is useful for
-    # parsing of Alpha Card Gateway response body.
-    # @see https://github.com/rack/rack rack gem GitHub
-    class << self
-      ##
-      # Default separators for the query string.
-      DEFAULT_SEP = /[&;] */n
-
-      ##
-      # Unescapes a URI escaped string with +encoding+. +encoding+ will be the
-      # target encoding of the string returned, and it defaults to UTF-8
-      #
-      # @param [String] s
-      #   String to unescape.
-      #
-      # @param [Encoding] encoding
-      #   Type of <code>Encoding</code>.
-      #
-      # @return [String] URI encoded string
-      #
-      # @raise [ArgumentError] if invalid Encoding is passed
-      #
-      # @example
-      #
-      #   unescape('Test%20str')
-      #   #=> "Test str"
-      #
-      #   unescape('Test%20str', Encoding::WINDOWS_31J)
-      #   #=> "Test str"
-      def unescape(s, encoding = Encoding::UTF_8)
-        URI.decode_www_form_component(s, encoding)
-      end
-
-      ##
-      # Parse query string to a <code>Hash</code> by breaking it up
-      # at the '&' and ';' characters.
-      #
-      # @param [String] query
-      #   query string
-      # @param [String] d
-      #   delimiter for the params
-      # @yieldparam unescaper
-      #   method, that will unescape the param value
-      #
-      # @return [Hash] query
-      #
-      # @example
-      #
-      #   query = AlphaCard::Utils.parse_query("param1=value1&params2=")
-      #   #=> {"param1"=>"value1", "params2"=>""}
-      #
-      #   query = AlphaCard::Utils.parse_query("cars[]=Saab&cars[]=Audi")
-      #   #=> {"cars[]"=>["Saab", "Audi"]}
-      def parse_query(query, d = nil, &unescaper)
-        unescaper ||= method(:unescape)
-
-        params = {}
-
-        (query || '').split(d ? /[#{d}] */n : DEFAULT_SEP).each do |p|
-          next if p.empty?
-          k, v = p.split('=', 2).map(&unescaper)
-
-          if cur = params[k]
-            if cur.class == Array
-              params[k] << v
-            else
-              params[k] = [cur, v]
-            end
-          else
-            params[k] = v
-          end
-        end
-
-        params
-      end
-    end
-  end
-end

data/spec/alpha_card/alpha_card_utils_spec.rb

@@ -1,25 +0,0 @@
-#encoding: utf-8
-require "spec_helper"
-
-describe AlphaCard::Utils do
-  it 'parse query strings correctly' do
-    expect(AlphaCard::Utils.parse_query("foo=bar")).to eq("foo" => "bar")
-    expect(AlphaCard::Utils.parse_query('cars[]=Saab&cars[]=Audi')).to eq({'cars[]' => ['Saab', 'Audi']})
-    expect(AlphaCard::Utils.parse_query("foo=bar&foo=quux")).to eq("foo" => ["bar", "quux"])
-    expect(AlphaCard::Utils.parse_query("foo=1&bar=2")).to eq("foo" => "1", "bar" => "2")
-    expect(AlphaCard::Utils.parse_query("my+weird+field=q1%212%22%27w%245%267%2Fz8%29%3F")).to eq("my weird field" => "q1!2\"'w$5&7/z8)?")
-    expect(AlphaCard::Utils.parse_query("foo%3Dbaz=bar")).to eq("foo=baz" => "bar")
-    expect(AlphaCard::Utils.parse_query("=")).to eq("" => "")
-    expect(AlphaCard::Utils.parse_query("=value")).to eq("" => "value")
-    expect(AlphaCard::Utils.parse_query("key=")).to eq("key" => "")
-    expect(AlphaCard::Utils.parse_query("&key&")).to eq("key" => nil)
-  end
-
-  it 'unescape the characters correctly' do
-    expect(AlphaCard::Utils.unescape('%E9%9F%93', Encoding::UTF_8)).to eq('韓')
-    expect(AlphaCard::Utils.unescape("fo%3Co%3Ebar")).to eq("fo<o>bar")
-    expect(AlphaCard::Utils.unescape("a+space")).to eq("a space")
-    expect(AlphaCard::Utils.unescape("a%20space")).to eq("a space")
-    expect(AlphaCard::Utils.unescape("q1%212%22%27w%245%267%2Fz8%29%3F%5C")).to eq("q1!2\"'w$5&7/z8)?\\")
-  end
-end