alpha_card 0.1.9 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9578c7b0b9b2681146ac0370640b26ed9b6d7cd4
-  data.tar.gz: a9ade4a67954c16fc8c3bff0dd8b92838b820358
+  metadata.gz: 76fc164bc35261fa54520d3d411288fe4dac224e
+  data.tar.gz: fa87d69a8a812fca096d22e394c82ea9ef4f31cb
 SHA512:
-  metadata.gz: d9e4b44f63a547a82f1c4a4fd405790436fa663bb31aabe3ba22c995cccc5b7333b0c6f25c4bdc2802209e29c03141899d8bd1df5ed9fa95917c769eb6663a42
-  data.tar.gz: bff105616d044b9560ed7f53dc2b47702134b2aa4d3fc86f2a7939abadccebea6bcd9569b8210151f4456f817c6ffb7520c796c970fb8ddc301f5ab13cae47c5
+  metadata.gz: 5e354992f043c879b4b6f12e931417dba4356b19ad757223b875f98d00f89a50d0281b514c0c0b20aa793727da396ba760d17ae05704849033ed9ef1c0ef1a4b
+  data.tar.gz: c9533e52a55e8ab79b447c32e55e15fffe4e38064e9cd1850ddefb706c4fd3567ee8345aa2fff0d924dfa81842921674f8608fe18674078052970a89ae3dc04b

data/alpha_card.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |gem|
   gem.name = 'alpha_card'
-  gem.version = '0.1.9'
-  gem.date = '2014-07-02'
+  gem.version = '0.2.0'
+  gem.date = '2014-07-09'
   gem.summary = 'Alpha Card Services DirectPost API for Ruby'
   gem.description = 'Gem for creating sales with Alpha Card Services DirectPost API'
   gem.authors = ['Nikita Bulaj']

data/lib/alpha_card.rb

@@ -6,7 +6,9 @@ require 'rest_client'
 require 'alpha_card/utils'
 require 'alpha_card/alpha_card_object'
 require 'alpha_card/alpha_card_response'
-require 'alpha_card/alpha_card_error'
+
+require 'alpha_card/errors/alpha_card_error'
+require 'alpha_card/errors/api_connection_error'
 
 require 'alpha_card/account'
 require 'alpha_card/shipping'
@@ -25,10 +27,10 @@ module AlphaCard
   # Global Payment Systems (NDC) Credit Card Authorization Codes
   #
   # @see http://floristwiki.ftdi.com/images/c/ce/Appendix_A_-_Credit_Card_Authorization_Codes.pdf Credit Card Authorization Codes
-  CREDIT_CARD_CODES ||= YAML.load_file(File.expand_path('../alpha_card/data/codes.yml', __FILE__))
+  CREDIT_CARD_CODES ||= YAML.load_file(File.expand_path('../alpha_card/data/credit_card_codes.yml', __FILE__))
 
   class << self
-	# @return [String] Alpha Card Gateway DirectPost API URL.
+	  # @return [String] Alpha Card Gateway DirectPost API URL.
     attr_accessor :api_base
   end
 
@@ -99,7 +101,7 @@ module AlphaCard
   #   Alpha Card Services response text.
   def self.handle_alpha_card_errors(response)
     code = response.text
-    raise AlphaCardError.new(CREDIT_CARD_CODES[code] || code) unless response.success?
+    raise AlphaCardError.new(CREDIT_CARD_CODES[code] || code, response) unless response.success?
   end
 
   ##
@@ -126,7 +128,7 @@ module AlphaCard
         message = 'Unexpected error communicating with Alpha Card Gateway.'
     end
 
-    raise AlphaCardError.new(message + "\n\n(Network error: #{e.message})")
+    raise APIConnectionError.new(message + "\n\n(Network error: #{e.message})")
   end
 end
 

data/lib/alpha_card/alpha_card_response.rb

@@ -80,7 +80,7 @@ module AlphaCard
     ##
     # Indicate the state of the request to the
     # Alpha Card Gateway. Returns <i>true</i> if
-    # response was <i>approved</i>.
+    # request was <i>approved</i>.
     #
     # @return [Bool] true if request if successful
     #
@@ -97,7 +97,7 @@ module AlphaCard
     ##
     # Indicate the state of the request to the
     # Alpha Card Gateway. Returns <i>true</i> if
-    # response was <i>declined</i>.
+    # request was <i>declined</i>.
     #
     # @return [Bool] true if request was declined
     #
@@ -114,7 +114,7 @@ module AlphaCard
     ##
     # Indicate the state of the request to the
     # Alpha Card Gateway. Returns <i>true</i> if
-    # response has some <i>errors</i>.
+    # request has some <i>errors</i>.
     #
     # @return [Bool] true if request has some errors
     #

data/lib/alpha_card/errors/alpha_card_error.rb

@@ -0,0 +1,23 @@
+module AlphaCard
+  ##
+  # Common class for Alpha Card Gateway errors and exceptions.
+  class AlphaCardError < StandardError
+    attr_reader :response
+    attr_reader :message
+
+    ##
+    # <code>AlphaCard::AlphaCardError</code> constructor.
+    #
+    # @param [String] error message
+    # @param [AlphaCard::AlphaCardResponse] AlphaCard Gateway response
+    #
+    # @example
+    #   AlphaCard::AlphaCardError.new
+    #
+    #   #=> #<AlphaCard::AlphaCardError: AlphaCard::AlphaCardError>
+    def initialize(message = nil, response = nil)
+      @message = message
+      @response = response
+    end
+  end
+end

data/lib/alpha_card/errors/api_connection_error.rb

@@ -0,0 +1,6 @@
+module AlphaCard
+  ##
+  # Class for connection errors.
+  class APIConnectionError < StandardError
+  end
+end

data/spec/alpha_card/alpha_card_spec.rb

@@ -93,20 +93,20 @@ describe AlphaCard do
     let!(:socket_error) { SocketError.new }
     let!(:unclassified_error) { StandardError.new('Some error') }
 
-    it 'should raise an Exception if Rest Client Error' do
-      expect { AlphaCard.handle_connection_errors(rest_client_error) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+    it 'should raise an APIConnectionError if Rest Client Error' do
+      expect { AlphaCard.handle_connection_errors(rest_client_error) }.to raise_error(AlphaCard::APIConnectionError) do |e|
         expect(e.message).to include('Could not connect to Alpha Card Gateway')
       end
     end
 
-    it 'should raise an Exception if Socket Error' do
-      expect { AlphaCard.handle_connection_errors(socket_error) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+    it 'should raise an APIConnectionError if Socket Error' do
+      expect { AlphaCard.handle_connection_errors(socket_error) }.to raise_error(AlphaCard::APIConnectionError) do |e|
         expect(e.message).to include('Unexpected error communicating when trying to connect to Alpha Card Gateway')
       end
     end
 
-    it 'should raise an Exception if Unclassified Error' do
-      expect { AlphaCard.handle_connection_errors(unclassified_error) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+    it 'should raise an APIConnectionError if Unclassified Error' do
+      expect { AlphaCard.handle_connection_errors(unclassified_error) }.to raise_error(AlphaCard::APIConnectionError) do |e|
         expect(e.message).to include('Unexpected error communicating with Alpha Card Gateway')
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors:
 - Nikita Bulaj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-02 00:00:00.000000000 Z
+date: 2014-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -40,11 +40,12 @@ files:
 - alpha_card.gemspec
 - lib/alpha_card.rb
 - lib/alpha_card/account.rb
-- lib/alpha_card/alpha_card_error.rb
 - lib/alpha_card/alpha_card_object.rb
 - lib/alpha_card/alpha_card_response.rb
 - lib/alpha_card/billing.rb
-- lib/alpha_card/data/codes.yml
+- lib/alpha_card/data/credit_card_codes.yml
+- lib/alpha_card/errors/alpha_card_error.rb
+- lib/alpha_card/errors/api_connection_error.rb
 - lib/alpha_card/order.rb
 - lib/alpha_card/sale.rb
 - lib/alpha_card/shipping.rb

data/lib/alpha_card/alpha_card_error.rb

@@ -1,6 +0,0 @@
-module AlphaCard
-  ##
-  # Class for Alpha Card Gateway errors and exceptions.
-  class AlphaCardError < StandardError
-  end
-end