alpha_card 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 294f83e708f2952a60d2ecf8480ae58af870e368
-  data.tar.gz: 1fa31126072357beaed859e4415c03245a937e13
+  metadata.gz: f7e8e249cdf49bffd9bbda0825018bc6406e0c52
+  data.tar.gz: 6241892718864310e112ec3c39eb6cdc7efac26f
 SHA512:
-  metadata.gz: 6c715932f21918d1914c83df62fd8a96e963b5a322c20da13b7facc00efc60cb8353ca6be255f403d0b684cb5db91fb4b92f623026adb7bdafb2a415ea54bb56
-  data.tar.gz: 1e091ed0479b8d61741f7cd37fea94f2b58ef6f5c34403743d4bd846d8e985080628ecd82a04b22fa15ffff96e0a150cb88c1a4a9daca67c24cd5a34b7dab988
+  metadata.gz: d604d1ca794b016047390a7bd9915a54ae3ef4d4b25d4514808ac28f109a5f2aeb9e328793f58df4b706ddc7b3557800c15906df9893e6d23d68687a6beec605
+  data.tar.gz: 7a46b389c6aaeec686a189e5add88b864929ffe1be3169fa5f5e40c285da37efb5e593d8635367ce722329d12dc24d5781aa33970717ca6dc6d0c9c0dd35e65b

data/.travis.yml

@@ -0,0 +1,13 @@
+language: ruby
+before_install: gem install bundler
+bundler_args: --without yard guard benchmarks
+script: "rake spec"
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - jruby-19mode
+  - ruby-head
+matrix:
+  allow_failures:
+    - rvm: ruby-head

data/Gemfile

@@ -5,4 +5,4 @@ gemspec
 gem 'virtus'
 gem 'rest_client'
 gem 'rack'
-#gem 'simplecov', :require => false
+gem 'coveralls', require: false

data/README.md

@@ -1,10 +1,13 @@
 # Ruby lib for creating payments with AlphaCard DirectPost API
 [![Gem Version](https://badge.fury.io/rb/alpha_card.svg)](http://badge.fury.io/rb/alpha_card)
 [![Dependency Status](https://gemnasium.com/budev/alpha_card.png)](https://gemnasium.com/budev/alpha_card)
+[![Code Climate](https://codeclimate.com/github/budev/alpha_card.png)](https://codeclimate.com/github/budev/alpha_card)
+[![Coverage Status](https://coveralls.io/repos/budev/alpha_card/badge.png?branch=master)](https://coveralls.io/r/budev/alpha_card?branch=master)
+[![Build Status](https://travis-ci.org/budev/alpha_card.svg?branch=master)](https://travis-ci.org/budev/alpha_card)
 
-This gem can help your ruby/rails application to integrate with AlphaCard service.
+This gem can help your Ruby or Ruby on Rails application to integrate with Alpha Card Service, Inc.
 
-AlphaCard Services: 
+Alpha Card Services: 
 http://www.alphacardservices.com/
      
 Payment Gateway Integration Portal:
@@ -19,13 +22,13 @@ If using bundler, first add 'alpha_card' to your Gemfile:
 gem "alpha_card"
 ```
 
-And run
+And run:
 
 ```sh
 bundle install
 ```
 
-Otherwise simply
+Otherwise simply install the gem:
 
 ```sh
 gem install alpha_card
@@ -33,13 +36,14 @@ gem install alpha_card
 
 Dependencies required:
 
-*   ruby >= 1.9.3
-*   rest_client
-*   virtus (for nice OOP objects of AlphaCard)
+*   ruby >= 1.9.3;
+*   rack;
+*   rest_client;
+*   virtus (for nice OOP objects of AlphaCard).
 
 ## Objects
 
-To create sale with Alpha Card Services you must operate with 5 objects:
+Alpha Card sales operates with next 5 objects:
 
 *   Account
 *   Order
@@ -49,7 +53,8 @@ To create sale with Alpha Card Services you must operate with 5 objects:
 
 ### Account
 
-Specify credentials to access Alpha Card Services, Inc.
+Account represents credentials data to access Alpha Card Services, Inc.
+All sales will be created for the specified account.
 
 _Required fields_:
 
@@ -64,16 +69,14 @@ AlphaCard::Account.new(username, password)
 
 ### Order
 
-Specify Order.
+Order represents itself.
 
-_Required fields_:
+_Unnecessary fields_:
 
 *   orderid : String
 *   orderdescription : String
-
-_Unnecessary fields_:
-
 *   ponumber : String
+*   tax : String
 *   billing : AlphaCard::Billing
 *   shipping : AlphaCard::Shipping
 
@@ -83,14 +86,6 @@ _Constructor_:
 AlphaCard::Order.new({field_name: value, ...})
 ```
 
-Set up billing or shipping:
-
-```ruby
-order = AlphaCard::Order.new({})
-order.shipping = AlphaCard::Shipping.new({})
-order.billing = AlphaCard::Billing.new({})
-```
-
 ### Billing
 
 Specify Billing information for Order.
@@ -137,7 +132,7 @@ AlphaCard::Shipping.new({field_name: value, ...})
 
 ### Sale
 
-Specify and process Order payment information.
+Sale is the main object of the Alpha Card Services. It processes fees associated with credit cards.
 
 _Required fields_:
 
@@ -154,7 +149,7 @@ _Constructor_:
 AlphaCard::Sale.new({field_name: value, ...})
 ```
 
-To process the sale you must call *create(_alpha_card_order_, _alpha_card_account_)*:
+To create the payment you must call *create(_alpha_card_order_, _alpha_card_account_)* method:
 
 ```ruby
 ...
@@ -162,8 +157,7 @@ sale = AlphaCard::Sale.new({})
 sale.create(order, account)
 ```
 
-Method `create` returns _true_ if sale was created successfully and raise an `AlphaCardError` 
-exception if some of the fields is invalid.
+This method returns _true_ if sale was created successfully and raise an `AlphaCardError` exception if some of the fields is invalid.
 
 ## Example of usage
 
@@ -192,10 +186,10 @@ end
 
 `Billing` and `shipping` is an _optional_ parameters and can be not specified.
 
-_Note_: take a look to the `amount` of the Order. It's format must be 'xx.xx'. All information about formats 
+_Note_: take a look at the `amount` of the Order. It's format must be 'xx.xx'. All information about variables formats 
 can be found on _Alpha Card Payment Gateway Integration Portal_ -> _Direct Post API_ -> _Documentation_ -> _Transaction Variables_
 
-Naming convention of attributes (such as "ccexp" or "orderid") was saved due to compatibility with AlphaCard API.
+Naming convention of attributes (such as "ccexp" or "orderid") was saved for compatibility with AlphaCard API.
 
 To raise some exceptions do the next:
 

data/alpha_card.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |gem|
   gem.name = 'alpha_card'
-  gem.version = '0.1.5'
-  gem.date = '2014-06-25'
+  gem.version = '0.1.6'
+  gem.date = '2014-06-26'
   gem.summary = 'Alpha Card Services DirectPost API for Ruby'
   gem.description = 'Gem for creating sales with Alpha Card Services DirectPost API'
   gem.authors = ['Nikita Bulaj']

data/lib/alpha_card/data/codes.yml

@@ -9,7 +9,7 @@
 "CALL TK": 'Refer to TeleCheck.'
 "CALL WC": 'Refer to Worldcheck.'
 "CALL XXXXXXXXXX": 'Call indicated number.'
-"ISSUER UNAVAIL NDC": 'cannot contact issuing bank for authorization.'
+"ISSUER UNAVAIL": 'NDC cannot contact issuing bank for authorization.'
 "INVLD MERCH ID": 'Invalid Merchant ID.'
 "PIC UP": 'Authorization declined.'
 "DECLINE": 'Authorization declined.'
@@ -47,7 +47,7 @@
 "DB UNAVAIL 04": 'NDC GATEWAY cannot contact EFT network or EFT Group ID is incorrect.'
 "UNAUTH USER": 'Merchant is not set up for debit on NDC Merchant Master File.'
 "INVALID CARD": 'Debit card not on issuer file.'
-"DB ISSUER UNAVAIL EFT": 'network cannot contact issuer'
+"DB ISSUER UNAVAIL": 'EFT network cannot contact issuer'
 "INVALID POS CARD": 'Card is not eligible for POS.'
 "ACCT TYPE INVLD": 'Type of account entered cannot be accessed (checking, savings, etc.)'
 "INVALID PREFIX": 'No sharing arrangement for this card.'
@@ -55,8 +55,8 @@
 "VERIFY XXXXXXXXXX": 'Match on SCAN file. XXXXXXXXXX is routing/transit number on the negative file.'
 "INVALID LIC": 'The license or ID number entered during a check authorization transaction is incorrect.'
 "INVALID STATE CD": 'State code entered is incorrect.'
-"EDC UNAVAILABLE EDC": 'application down, try later.'
+"EDC UNAVAILABLE": 'EDC application down, try later.'
 "DB UNAVAIL 01": 'Problem at NDC routing transaction.'
-"SCAN UNAVAILABLE SCAN": 'application is down, try later.'
+"SCAN UNAVAILABLE": 'SCAN application is down, try later.'
 "EXCEEDS MAX AMT": 'Exceeds withdrawal amount limit.'
 "EXCEEDS MAX USES": 'Exceeds withdrawal frequency limit'

data/lib/alpha_card/order.rb

@@ -3,6 +3,7 @@ module AlphaCard
     attribute :orderid, Integer
     attribute :orderdescription, String
     attribute :ponumber, String
+    attribute :tax, String
 
     attribute :billing, AlphaCard::Billing
     attribute :shipping, AlphaCard::Shipping

data/lib/alpha_card/sale.rb

@@ -21,7 +21,7 @@ module AlphaCard
     #    sale.create(order, account) #=> true or false
     def create(order, account)
       [:ccexp, :ccnumber, :amount].each do |attr|
-        raise Exception.new("No #{attr.to_s} information provided") if self.send(attr.to_s).blank?
+        raise Exception.new("No #{attr} information provided") if self[attr].blank?
       end
 
       params = self.filled_attributes || {}

data/spec/alpha_card/alpha_card_spec.rb

@@ -69,6 +69,14 @@ describe AlphaCard do
     end
   end
 
+  context 'Without attributes' do
+    let!(:sale) { AlphaCard::Sale.new({}) }
+
+    it 'should raise an Exception' do
+      expect { sale.create(order, account) }.to raise_exception
+    end
+  end
+
   context 'With blank account credentials' do
     let!(:blank_account) { AlphaCard::Account.new(nil, '') }
     let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '5.00'}) }

data/spec/spec_helper.rb

@@ -1,6 +1,5 @@
-# Uncomment for coverage statistics
-# require 'simplecov'
-# SimpleCov.start
+require 'coveralls'
+Coveralls.wear!
 
 require 'bundler/setup'
 Bundler.setup

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Nikita Bulaj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-25 00:00:00.000000000 Z
+date: 2014-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -32,6 +32,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md