aloha_analyzer 0.1.9 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8468fe4dfc4cac6cf908816e029246531cf74b09
-  data.tar.gz: 437fcf53fbd6cb145b19fce4956b6bf7b8fd5dac
+  metadata.gz: c390df22ade9fd5d5fa60f666546be93d834bb9a
+  data.tar.gz: 1ca0491eed0055d5fecb8797926d4e81b9f1bf9c
 SHA512:
-  metadata.gz: 4367d362dfa777726cffe20f70f925356bf79eec7bc55ed743da748520c52a95e8c4415e0389b9b1a986101415a32fb5d8a799e070e75bf1b528159f5d71fd1d
-  data.tar.gz: 932bd15e86a4c8e702db5cdc0dd87aba576573d6a530e4af95cc79a57aa484e21545975e0eb87ae0f06a02477b22561132b1e08dc93f134d67d2197432ca49ed
+  metadata.gz: de8a6d1dcbca9b2d4b4b3c6f89bc6b82ee9d97c2d71c57e4a7dfacea77afd9b16a972a882f384ce0b902b935462ddf5c1b351a55e8c05bcfad47a3e8dfb1b35a
+  data.tar.gz: 12158be8ccded5051441322d8e2dcf5253f5e181c9977bb38a6dde54c335dc39e81f0f9f8affba9170a087666e2bffa33a9a120e076409af7374c1a1a242eec1

data/lib/aloha_analyzer/user.rb

@@ -3,52 +3,74 @@ module AlohaAnalyzer
 
     attr_reader :language
 
-    def initialize(language, users)
+    def initialize(language, users, options = {})
       @language    = language.downcase
       @users       = users
       @users_count = users.size
+      @options     = options
+      @analysis    = {}
+
       clean_language!
       clean_users_languages!
     end
 
     def analyze
-      boilerplate_analysis.tap do |analysys|
-        @users.each do |user|
-          abbreviation = user['lang']
-          if abbreviation == @language
-            analysys[:account_language][:count] += 1
-            analysys[:account_language][:users].push user
-          else
-            if analysys[:foreign_languages][abbreviation]
-              analysys[:foreign_languages][abbreviation][:count] += 1
-              analysys[:foreign_languages][abbreviation][:users].push user
-            else
-              analysys[:foreign_languages][abbreviation] = {
-                :count    => 1,
-                :language => Language.find_by_abbreviation(abbreviation),
-                :users    => [user]
-              }
-            end
-            analysys[:foreign_languages_count] += 1
-          end
-          analysys[:count] += 1
+      prepare!
+      @users.each do |user|
+        if user['lang'] == @language
+          add_account_language_user(user)
+          @analysis[:account_language][:count] += 1
+        else
+          add_foreign_language_user(user)
+          @analysis[:foreign_languages_count] += 1
         end
+        @analysis[:count] += 1
       end
+      @analysis
     end
 
-
     private
 
-    def boilerplate_analysis
-      Hash.new.tap do |analysys|
-        analysys[:account_language] = {
-          count:    0,
-          language: Language.find_by_abbreviation(@language),
-          users: []
+    def add_account_language_user(user)
+      unless too_many_users?(@analysis[:account_language][:users])
+        @analysis[:account_language][:users].push(user)
+      end
+    end
+
+    def add_foreign_language_user(user)
+      prepare_foreign_language(user['lang'])
+      @analysis[:foreign_languages][user['lang']][:count] += 1
+      unless too_many_users?(@analysis[:foreign_languages][user['lang']][:users])
+        @analysis[:foreign_languages][user['lang']][:users].push(user)
+      end
+    end
+
+    def prepare_foreign_language(abbreviation)
+      if @analysis[:foreign_languages][abbreviation].nil?
+        @analysis[:foreign_languages][abbreviation] = {
+          :count    => 0,
+          :language => Language.find_by_abbreviation(abbreviation),
+          :users    => []
         }
-        analysys[:foreign_languages_count] = 0
-        analysys[:count]                   = 0
-        analysys[:foreign_languages]       = Hash.new
+      end
+    end
+
+    def prepare!
+      @analysis[:account_language] = {
+        count:    0,
+        language: Language.find_by_abbreviation(@language),
+        users:    []
+      }
+      @analysis[:foreign_languages_count] = 0
+      @analysis[:count]                   = 0
+      @analysis[:foreign_languages]       = Hash.new
+    end
+
+    def too_many_users?(users)
+      if @options[:user_limit_per_language] && users.size >= @options[:user_limit_per_language]
+        true
+      else
+        false
       end
     end
 

data/lib/aloha_analyzer/version.rb

@@ -1,3 +1,3 @@
 module AlohaAnalyzer
-  VERSION = '0.1.9'
+  VERSION = '0.2.0'
 end

data/spec/aloha_analyzer/user_spec.rb

@@ -1,8 +1,9 @@
 require 'spec_helper'
 
 describe AlohaAnalyzer::User do
-  subject(:user) { described_class.new(language, users) }
+  subject(:user) { described_class.new(language, users, options) }
   let(:language) { 'en' }
+  let(:options)  { {} }
 
   describe '#new' do
     let(:users) { [] }
@@ -40,7 +41,7 @@ describe AlohaAnalyzer::User do
   end
 
   describe '#analyze' do
-    subject(:analyze) { described_class.new(language, users).analyze }
+    subject(:analyze) { described_class.new(language, users, options).analyze }
     context 'when no users' do
       let(:users) { [] }
 
@@ -232,5 +233,25 @@ describe AlohaAnalyzer::User do
           end
         end
       end
+
+      context 'when user limit per language' do
+        let(:options) { { user_limit_per_language: 1} }
+        let(:users) {
+          [
+            {'id' => '1', 'lang' => 'en'},
+            {'id' => '2', 'lang' => 'fr'},
+            {'id' => '3', 'lang' => 'en'},
+            {'id' => '4', 'lang' => 'fr'},
+            {'id' => '5', 'lang' => 'fr'}
+          ]
+        }
+
+        it 'does not add more users per language' do
+          subject[:account_language][:users].size.should eq 1
+          subject[:account_language][:count].should eq 2
+          subject[:foreign_languages]['fr'][:users].size.should eq 1
+          subject[:foreign_languages]['fr'][:count].should eq 3
+        end
+      end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aloha_analyzer
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors:
 - Matthieu Aussaguel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-13 00:00:00.000000000 Z
+date: 2014-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler