alma 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8abf09ab18832b9e07c6ff3f19f55579799558aeeb94434757f4295d3e15be1
-  data.tar.gz: aa9956de6794d3a2d7e1690aab759e80cb62dd1c6a4c6525132ff57b5f82d5d9
+  metadata.gz: ffe7f9e2bafe164f38d89d6ca0c4b97d13eb778e9e59dbe7995aa6622fe0dfb5
+  data.tar.gz: e887790912286f3750b83f34435a2e9870a57ca56f9cb85de971c64682967964
 SHA512:
-  metadata.gz: 27a32ba65c33fb1d78dfc9a0cf13b504661667ed4eacf3d80136cb0ad2eeedb1ef20bed4cc5a2109c75984b6f276443aee9de21561e845f5950f6ea0690a337a
-  data.tar.gz: 28b451a986c72c7e9564f0f1933f5ba356863c14871176a0da50a83ad4de9a38da7ec9c9466aeb172408f0331228dc756a66fec6fc7a509e03e5cc9b696d30b4
+  metadata.gz: 2e7d1d3246dda68dc81d5ab05356d73969421053b20a830181d937239d3e6446cba8f7e6f9ff805673693b287a0b6549a1f6c54ac0b11b172bcaa85449f844d6
+  data.tar.gz: cf3ba3362fd3809039df685cffe2b4b9d3b8a9f02bbd0968fca761c8d72bf3bb41e0be542574d6acef3bfc81e246b097596db26a974acb1f8fda444cb85a8257

data/lib/alma/loan_set.rb

@@ -39,8 +39,9 @@ module Alma
     def all
       Enumerator.new do |yielder|
         offset = 0
+        limit = 100
         loop do
-          extra_args = @search_args.merge({ limit: 100, offset: })
+          extra_args = @search_args.merge({ limit:, offset: })
           r = (offset == 0) ? self : single_record_class.where_user(user_id, extra_args)
 
           unless r.empty?
@@ -48,7 +49,11 @@ module Alma
             offset += 100
           end
 
-          if r.empty? || r.count < extra_args[:limit]
+          # TODO: r.count greater than "limit" doesn't make any sense unless the ALMA User/Loan API is broken.
+          # We should remove this qualification in October once Alma fixes the bug they introduced in their
+          # September release.
+          # @see https://developers.exlibrisgroup.com/forums/topic/limit-and-offset-not-being-applied-to-retrieve-user-loans-api/
+          if r.empty? || r.count < limit || r.count > limit
             raise StopIteration
           end
         end

data/lib/alma/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Alma
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alma
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Jennifer Anton