alma 0.3.1 → 0.3.2

data/lib/alma/bib.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 module Alma
   class  Bib
     extend Alma::ApiDefaults
     extend Forwardable
-    
+
     def self.find(ids, args)
       get_bibs(ids, args)
     end
 
-    def self.get_bibs(ids, args={})
+    def self.get_bibs(ids, args = {})
       response = HTTParty.get(
-        self.bibs_base_path, 
-        query: {mms_id: ids_from_array(ids) }.merge(args),
+        self.bibs_base_path,
+        query: { mms_id: ids_from_array(ids) }.merge(args),
         headers: headers,
         timeout: timeout
         )
@@ -19,12 +21,12 @@ module Alma
         Alma::BibSet.new(get_body_from(response))
       else
         raise StandardError, get_body_from(response)
-      end  
+      end
     end
 
 
-    def self.get_availability(ids, args={})
-      args.merge!({expand: 'p_avail,e_avail,d_avail'})
+    def self.get_availability(ids, args = {})
+      args.merge!({ expand: "p_avail,e_avail,d_avail" })
       bibs = get_bibs(ids, args)
 
       Alma::AvailabilityResponse.new(bibs)
@@ -39,31 +41,31 @@ module Alma
 
     def initialize(response_body)
       @response = response_body
-      @id = @response['mms_id'].to_s
+      @id = @response["mms_id"].to_s
     end
 
     # The raw MARCXML record, converted to a Hash
     def record
-      @record ||= XmlSimple.xml_in(response['anies'].first)
+      @record ||= XmlSimple.xml_in(response["anies"].first)
     end
 
 
       private
 
-      def bibs_base_path
-        self.class.bibs_base_path
-      end
+        def bibs_base_path
+          self.class.bibs_base_path
+        end
 
-      def headers
-        self.class.headers
-      end
+        def headers
+          self.class.headers
+        end
 
-      def self.get_body_from(response)
-        JSON.parse(response.body)
-      end
+        def self.get_body_from(response)
+          JSON.parse(response.body)
+        end
 
-      def self.ids_from_array(ids)
-        ids.map(&:to_s).map(&:strip).join(',')
-      end
+        def self.ids_from_array(ids)
+          ids.map(&:to_s).map(&:strip).join(",")
+        end
   end
 end

data/lib/alma/bib_holding.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module Alma
+  class BibHolding
+    extend Alma::ApiDefaults
+    extend Forwardable
+
+    def self.find(mms_id:, holding_id:)
+      url = "#{bibs_base_path}/#{mms_id}/holdings/#{holding_id}"
+      response = HTTParty.get(url, headers: headers, timeout: timeout)
+      new(response)
+    end
+
+    attr_reader :holding
+    def_delegators :holding, :[], :[]=, :has_key?, :keys, :to_json, :each
+
+    def initialize(holding)
+      @holding = holding
+    end
+
+    def holding_id
+      holding["holding_id"]
+    end
+  end
+end

data/lib/alma/bib_item.rb

@@ -1,4 +1,6 @@
-require 'alma/bib_item_set'
+# frozen_string_literal: true
+
+require "alma/bib_item_set"
 module Alma
   class BibItem
     extend Alma::ApiDefaults
@@ -7,17 +9,28 @@ module Alma
     attr_reader :item
     def_delegators :item, :[], :has_key?, :keys, :to_json
 
-    PERMITTED_ARGS  = [
+    PERMITTED_ARGS = [
       :limit, :offset, :expand, :user_id, :current_library,
       :current_location, :q, :order_by, :direction
     ]
 
-    def self.find(mms_id, options={})
+    def self.find(mms_id, options = {})
       holding_id = options.delete(:holding_id) || "ALL"
-      options.select! {|k,_| PERMITTED_ARGS.include? k }
+      options.select! { |k, _| PERMITTED_ARGS.include? k }
       url = "#{bibs_base_path}/#{mms_id}/holdings/#{holding_id}/items"
       response = HTTParty.get(url, headers: headers, query: options, timeout: timeout)
-      BibItemSet.new(response, options.merge({mms_id: mms_id, holding_id: holding_id}))
+      BibItemSet.new(response, options.merge({ mms_id: mms_id, holding_id: holding_id }))
+    end
+
+    def self.find_by_barcode(barcode)
+      response = HTTParty.get(items_base_path, headers: headers, query: { item_barcode: barcode }, timeout: timeout, follow_redirects: true)
+      new(response)
+    end
+
+    def self.scan(mms_id:, holding_id:, item_pid:, options: {})
+      url = "#{bibs_base_path}/#{mms_id}/holdings/#{holding_id}/items/#{item_pid}"
+      response = HTTParty.post(url, headers: headers, query: options)
+      new(response)
     end
 
     def initialize(item)
@@ -85,7 +98,7 @@ module Alma
     end
 
     def temp_call_number
-      holding_data.fetch("temp_call_number","")
+      holding_data.fetch("temp_call_number", "")
     end
 
     def has_temp_call_number?
@@ -96,7 +109,7 @@ module Alma
       if has_temp_call_number?
         holding_data.fetch("temp_call_number")
       else
-        holding_data.fetch("call_number","")
+        holding_data.fetch("call_number", "")
       end
     end
 
@@ -105,7 +118,7 @@ module Alma
     end
 
     def alt_call_number
-      item_data.fetch("alternative_call_number","")
+      item_data.fetch("alternative_call_number", "")
     end
 
     def has_process_type?
@@ -121,7 +134,7 @@ module Alma
     end
 
     def base_status
-      item_data.dig("base_status","value")|| ""
+      item_data.dig("base_status", "value") || ""
     end
 
     def in_place?

data/lib/alma/bib_item_set.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 module Alma
-
   class BibItemSet < ResultSet
+    ITEMS_PER_PAGE = 100
 
     class ResponseError < ::Alma::StandardError
     end
@@ -13,7 +13,7 @@ module Alma
     def_delegators :items, :[], :[]=, :empty?, :size, :each
     def_delegators :raw_response, :response, :request
 
-    def initialize(response, options={})
+    def initialize(response, options = {})
       @raw_response = response
       parsed = response.parsed_response
       @total_record_count = parsed["total_record_count"]
@@ -25,7 +25,7 @@ module Alma
     end
 
     def loggable
-      { total_record_count: @total_record_count,
+      { total_record_count: @total_record_count.to_s,
         mms_id: @mms_id,
         uri: @raw_response&.request&.uri.to_s
       }.select { |k, v| !(v.nil? || v.empty?) }
@@ -49,22 +49,29 @@ module Alma
     end
 
     def all
+      @last_page_index ||= false
       Enumerator.new do |yielder|
         offset = 0
-        loop do
-          r = (offset == 0) ? self : single_record_class.find(@mms_id, options=@options.merge({limit: 100, offset: offset}))
+        while (!@last_page_index || @last_page_index >= offset / items_per_page) do
+          r = (offset == 0) ? self : single_record_class.find(@mms_id, options = @options.merge({ limit: items_per_page, offset: offset }))
           unless r.empty?
             r.map { |item| yielder << item }
-            offset += 100
+            @last_page_index = (offset / items_per_page)
           else
-            raise StopIteration
+            @last_page_index = @last_page_index ? @last_page_index - 1 : -1
+          end
+
+          if r.size == items_per_page
+            @last_page_index += 1
           end
+
+          offset += items_per_page
         end
       end
     end
 
     def each(&block)
-       @items.each(&block)
+      @items.each(&block)
     end
 
     def success?
@@ -78,5 +85,9 @@ module Alma
     def single_record_class
       Alma::BibItem
     end
+
+    def items_per_page
+      ITEMS_PER_PAGE
+    end
   end
 end

data/lib/alma/config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Alma
   class << self
     attr_accessor :configuration
@@ -14,7 +16,7 @@ module Alma
 
     def initialize
       @apikey = "TEST_API_KEY"
-      @region = 'https://api-na.hosted.exlibrisgroup.com'
+      @region = "https://api-na.hosted.exlibrisgroup.com"
       @enable_loggable = false
       @timeout = 5
       @http_retries = 3

data/lib/alma/course.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module Alma
+  class Course
+    extend Alma::ApiDefaults
+    extend Forwardable
+
+    def self.all_courses(args: {})
+      response = HTTParty.get("#{courses_base_path}/courses",
+                              query: args,
+                              headers: headers,
+                              timeout: timeout)
+      if response.code == 200
+        Alma::CourseSet.new(get_body_from(response))
+      else
+        raise StandardError, get_body_from(response)
+      end
+    end
+
+    attr_accessor :response
+
+    # The Course object can respond directly to Hash like access of attributes
+    def_delegators :response, :[], :[]=, :has_key?, :keys, :to_json
+
+    def initialize(response_body)
+      @response = response_body
+    end
+
+    private
+
+      def self.get_body_from(response)
+        JSON.parse(response.body)
+      end
+
+      def self.courses_base_path
+        "https://api-na.hosted.exlibrisgroup.com/almaws/v1"
+      end
+
+      def courses_base_path
+        self.class.courses_base_path
+      end
+
+      def headers
+        self.class.headers
+      end
+  end
+end

data/lib/alma/course_set.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module Alma
+  class CourseSet < ResultSet
+    def key
+      "course"
+    end
+
+    def single_record_class
+      Alma::Course
+    end
+
+    def total_record_count
+      size
+    end
+  end
+end

data/lib/alma/electronic.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "httparty"
 require "active_support"
 require "active_support/core_ext"
@@ -7,7 +8,6 @@ require "alma/config"
 module Alma
   # Alma::Electronic APIs wrapper.
   class Electronic
-
     class ElectronicError < ArgumentError
     end
 

data/lib/alma/electronic/batch_utils.rb

@@ -81,12 +81,12 @@ module Alma
       end
 
       self.class.new(options.merge(
-        chain: chain,
-        ids: ids,
-        type: type,
-        tag: tag,
-        notes: notes,
-        logger: @@logger,
+                       chain: chain,
+                       ids: ids,
+                       type: type,
+                       tag: tag,
+                       notes: notes,
+                       logger: @@logger,
       ))
     end
 
@@ -179,11 +179,11 @@ module Alma
       end
 
       self.class.new(options.merge(
-        chain: chain,
-        notes: notes,
-        type: type,
-        tag: tag,
-        logger: @@logger,
+                       chain: chain,
+                       notes: notes,
+                       type: type,
+                       tag: tag,
+                       logger: @@logger,
       ))
     end
 

data/lib/alma/error.rb

@@ -1,15 +1,16 @@
-module Alma::Error
+# frozen_string_literal: true
 
+module Alma::Error
   def has_error?
     !error.empty?
   end
 
   def error_message
-    (has_error?) ? error['errorList']['error']['errorMessage'] : ''
+    (has_error?) ? error["errorList"]["error"]["errorMessage"] : ""
   end
 
   def error
-    @response.fetch('web_service_result', {})
+    @response.fetch("web_service_result", {})
   end
 end
 

data/lib/alma/fine.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 module Alma
   class Fine < AlmaRecord
     extend Alma::ApiDefaults
 
-    def self.where_user(user_id, args={})
-
+    def self.where_user(user_id, args = {})
       response = HTTParty.get("#{users_base_path}/#{user_id}/fees", query: args, headers: headers, timeout: timeout)
       if response.code == 200
         Alma::FineSet.new(response)

data/lib/alma/fine_set.rb

@@ -30,7 +30,7 @@ module Alma
     end
 
     def each(&block)
-       @results.each(&block)
+      @results.each(&block)
     end
 
     def success?

data/lib/alma/item_request_options.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 module Alma
   class ItemRequestOptions < RequestOptions
-
     class ResponseError < Alma::StandardError
     end
 
-    def self.get(mms_id, holding_id=nil, item_pid=nil, options={})
+    def self.get(mms_id, holding_id = nil, item_pid = nil, options = {})
       url = "#{bibs_base_path}/#{mms_id}/holdings/#{holding_id}/items/#{item_pid}/request-options"
-      options.select! {|k,_|  REQUEST_OPTIONS_PERMITTED_ARGS.include? k }
+      options.select! { |k, _|  REQUEST_OPTIONS_PERMITTED_ARGS.include? k }
       response = HTTParty.get(url, headers: headers, query: options, timeout: timeout)
       new(response)
     end