alma 0.2.6 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f8f97556fd38ab3e4b03c42ee739d1a8a878f997e1d2ee54fb5dd5017b3cd51
-  data.tar.gz: 1e5d6362f38d31fe538afe713b9b5ec87469f0364ddfde258e29a1c3b076cf88
+  metadata.gz: 210d45982a6c339d9b8c170a73077be4f56bcf4eaa989debe95d2f9d97897c0e
+  data.tar.gz: 1b988140c47bc0974e617cc1131aee0b82dfbcd50ce20d408fbd2a969cf180c7
 SHA512:
-  metadata.gz: 2e9e26c6789cf81b7d8390c56a42f6c422dffda52befa4b629873bfa7edc0a7974c20ed51c485f861809743e9fa9db988af4d4cbe4f63ee8b15b4371ee27f38c
-  data.tar.gz: ad6e0abc8e573bb1c02b34047eab1847e21ca858c6baa385b969c1faf45033151679201543f13ddc74d696035e234387e75eba7bfe4e046ff60231fc1e795b3b
+  metadata.gz: 1667314072be96beb05c3f389c5240142ff5e0f44be0eed44d2240653ad4dd38f07a221b2ab3235921e37e7620e4518128e1b8806880daadffc9f570bbccd773
+  data.tar.gz: b98783202cf24c6a33c0c249f70d9f55a715b611c89a3249d4cf14a1352f2dca476123315649f9d3f624b1533fa0547d285605af309cfab8c537a1b6d81db85b

data/.circleci/config.yml

@@ -0,0 +1,54 @@
+version: 2.1
+orbs:
+  ruby: circleci/ruby@1.2
+
+workflows:
+  version: 2
+  test-deploy:
+    jobs:
+      - build
+      - deploy:
+          filters:
+            tags:
+              only: /.*/
+            branches:
+              ignore: /.*/
+
+jobs:
+  build:
+    docker:
+      - image: cimg/ruby:2.7.2-browsers
+        auth:
+          username: $DOCKERHUB_USER
+          password: $DOCKERHUB_PASSWORD
+
+    executor: ruby/default
+    steps:
+      - checkout
+      - run:
+          name: Which bundler?
+          command: bundle -v
+      - run: bundle install
+      - run:
+          name: lint
+          command: bundle exec rubocop
+      - run:
+          name: test
+          command: bundle exec rake
+  deploy:
+    docker:
+      - image: cimg/ruby:2.7.2-browsers
+
+    working_directory: ~/repo
+
+    steps:
+      - checkout
+      - run:
+          name: Setup Rubygems
+          command: bash .circleci/setup-rubygems.sh
+
+      - run:
+          name: Publish to Rubygems
+          command: |
+            gem build alma.gemspec
+            gem push "$(ls alma-*.gem)"

data/.circleci/setup-rubygems.sh

@@ -0,0 +1,3 @@
+mkdir ~/.gem
+echo -e "---\r\n:rubygems_api_key: $ALMA_RUBYGEMS" > ~/.gem/credentials
+chmod 0600 /home/circleci/.gem/credentials

data/.github/dependabot.yml

@@ -0,0 +1,7 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+  open-pull-requests-limit: 10

data/.gitignore

@@ -7,3 +7,6 @@
 /pkg/
 /spec/reports/
 /tmp/
+.byebug_history
+.DS_Store
+spec/.DS_Store

data/.rubocop.yml

@@ -0,0 +1,134 @@
+require:
+  - rubocop-rails
+
+AllCops:
+  TargetRubyVersion: 2.7
+  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
+  # to ignore them, so only the ones explicitly set in this file are enabled.
+  DisabledByDefault: true
+  Exclude:
+    - 'node_modules/**/*'
+    - '**/templates/**/*'
+    - '**/vendor/**/*'
+    - 'actionpack/lib/action_dispatch/journey/parser.rb'
+    - 'bin/*'
+    - 'solr/**/*'
+
+# Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+# Align `when` with `case`.
+Layout/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular method definition, no empty lines around the body.
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+Layout/FirstArgumentIndentation:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Method definitions after `private` or `protected` isolated calls need one
+# extra level of indentation.
+Layout/IndentationConsistency:
+  Enabled: true
+  EnforcedStyle: indented_internal_methods
+
+# Two spaces, no tabs (for indentation).
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+    Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: always
+  Exclude:
+    - 'app/models/traject_indexer.rb'
+    - 'db/schema.rb'
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Use `{ a: 1 }` not `{a:1}`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Check quotes usage according to lint rule below.
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+# Detect hard tabs, no hard tabs.
+Layout/IndentationStyle:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingEmptyLines:
+  Enabled: true
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/RedundantPercentQ:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true

data/.ruby-version

@@ -1 +1 @@
-ruby-2.4.1
+ruby-2.7.2

data/CODE_OF_CONDUCT.md

@@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
 ## Enforcement
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at chad.nelson@temple.edu. All
+reported by contacting the project team at svc.libdev@temple.edu. All
 complaints will be reviewed and investigated and will result in a response that
 is deemed necessary and appropriate to the circumstances. The project team is
 obligated to maintain confidentiality with regard to the reporter of an incident.

data/Gemfile

@@ -1,7 +1,8 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
+
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in alma.gemspec
 gemspec
 
-gem 'simplecov', require: false, group: :test
-
+gem "simplecov", require: false, group: :test

data/Guardfile

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  # Rails files
+  rails = dsl.rails(view_extensions: %w(erb haml slim))
+  dsl.watch_spec_files_for(rails.app_files)
+  dsl.watch_spec_files_for(rails.views)
+
+  watch(rails.controllers) do |m|
+    [
+      rspec.spec.call("routing/#{m[1]}_routing"),
+      rspec.spec.call("controllers/#{m[1]}_controller"),
+      rspec.spec.call("acceptance/#{m[1]}")
+    ]
+  end
+
+  # Rails config changes
+  watch(rails.spec_helper)     { rspec.spec_dir }
+  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
+  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
+
+  # Capybara features specs
+  watch(rails.view_dirs)     { |m| rspec.spec.call("features/#{m[1]}") }
+  watch(rails.layouts)       { |m| rspec.spec.call("features/#{m[1]}") }
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
+    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
+  end
+
+  # Specific files when defaults don't work (for some reason):
+  watch("lib/alma.rb") { "spec/alma_spec.rb" }
+end

data/README.md

@@ -26,75 +26,81 @@ You'll need to configure the Alma gem to ensure you query the appropriate data.
 
 ```ruby
 Alma.configure do |config|
-  # You have to set te apikey 
+  # You have to set the apikey
   config.apikey     = 'EXAMPLE_EL_DEV_NETWORK_APPLICATION_KEY'
-  # Alma gem defaults to querying Ex Libris's North American  Api servers. You can override that here.
-  config.region   = "https://api-eu.hosted.exlibrisgroup.com
+  # Alma gem defaults to querying Ex Libris's North American API servers. You can override that here.
+  config.region   = "https://api-eu.hosted.exlibrisgroup.com"
+
+  # By default enable_loggable is set to false
+  config.enable_loggable = false
+
+  # By default timeout is set to 5 seconds; can only provide integers
+  config.timeout = 10
 end
 ```
 
 Now you can access those configuration attributes with `Alma.configuration.apikey`
 
 ### Making Requests
- 
+
 #### Get a Single user
 ```ruby
  user = Alma::User.find(123456789)
- 
+
  user.first_name
  > Chad
- 
+
  user.email
  > chad.nelson@fictional.edu
- 
+
  user.keys
  >{first_name: "Chad",
  ...}
 ```
- 
+
 #### Get details on a users fines
- 
+
 ```ruby
  fines = user.fines
  fines.sum
  > "20.0"
- 
+
  fines.total_record_count
  > "2"
- 
+
  fines
  > [#<Alma::AlmaRecord:0x000000038b7b50
     ...>,
     #<Alma::AlmaRecord:0x000000038b7b28
      ...>]
- 
+
  fines.first.title
  > "Practical Object Oriented Design with Ruby"
- 
+
 ```
 
 Each fine object reflects the available fields in the returned JSON,[as documented on the Ex Libris Api docs](https://developers.exlibrisgroup.com/alma/apis/xsd/rest_fees.xsd?tags=GET)
 
 #### Get details on a users loans
- 
+
 ```ruby
 loans = user.loans
 
 loans.total_record_count
 > "2"
- 
+
 loans
 > [#<Alma::Loan:0x000000038c6b79
   ...>,
   #<Alma::Loan:0x000000038c6b34
    ...>]
- 
+
 loans.first.title
  > "Javascript: The Good Parts"
- 
+
 loans.first.due_date
-"2016-12-26z
- 
+"2016-12-26z"
+
 ```
 Each loan object reflects the available fields in the returned XML,[as documented on the Ex Libris Api docs](https://developers.exlibrisgroup.com/alma/apis/xsd/rest_item_loans.xsd?tags=GET)
 
@@ -105,10 +111,10 @@ requests = user.requests
 
 requests.total_record_count
 > "1"
- 
+
 requests.list
 > [#<Alma::AlmaRecord:0x000000038c6b79...>]
- 
+
 requests.list.first.title
 > "Food in history / Reay Tannahill."
 
@@ -117,26 +123,131 @@ requests.list.first.pickup_location
 
 requests.list.first.request_status
 > "In Process"
- 
+
 ```
 Each request object reflects the available fields in the returned XML,[as documented on the Ex Libris Api docs](https://developers.exlibrisgroup.com/alma/apis/xsd/rest_user_requests.xsd?tags=GET)
 
  Loans, fines and Requests can also be accessed statically
-  
+
 ```ruby
 Alma::User.get_fines({:user_id => 123456789})
- 
+
 Alma::User.get_loans({:user_id => 123456789})
 
 Alma::User.get_requests({:user_id => 123456789})
- 
+
+```
+
+### Bib Records
+Wrappings for some of the API endpoints described by the [Bibliographic Records and Inventory
+](https://developers.exlibrisgroup.com/alma/apis/bibs) section of the Ex Libris Developers Network
+
+### All the items for a Bib Records
+Corresponds to the [Retrieve Items list](https://developers.exlibrisgroup.com/alma/apis/bibs/GET/gwPcGly021om4RTvtjbPleCklCGxeYAfEqJOcQOaLEvNcHQT0/ozqu3DGTurs/XxIP4LrexQUdc=/af2fb69d-64f4-42bc-bb05-d8a0ae56936e) api endpoint
+
+To get the list of items for all holdings of a bib record.
+`items = Alma::BibItem.find("EXAMPLE_MMS_ID")`
+
+You can also pass a holding ID as an option, if you only want that holdings items.
+`items = Alma::BibItem.find("EXAMPLE_MMS_ID", holding_id: EXAMPLE_HOLDING_ID)`
+
+
+The response is a BibItemSet which can be iterated over to access items:
+
+```ruby
+items.each { ... }
+
+items.total_record_count
+> 4
 ```
+
+You can remove items that are missing or lost from the result set
+` avail_items = items.filter_missing_and_lost
+`
+
+Items can be grouped by the library they are held at, which returns a hash with library codes as the keys and an array of items as the values.
+
+```ruby
+items.grouped_by_library
+{ "MAIN" =>
+  [#<Alma::BibItem:0x000000038c6b79...>],
+  "NOT_MAIN" =>
+  [#<Alma::BibItem:0x000000038c6b88...>, #<Alma::BibItem:0x000000038c6b94...>,],
+}
+```
+
+The data for each item can be accessed via hash representation of the [item structure](https://developers.exlibrisgroup.com/alma/apis/xsd/rest_item.xsd), e.g.:
+
+```ruby
+item = items.first
+
+item["holding_data"]["call_number"]
+"T385 .F79 2008"
+
+item["item_data"]["location"]["value"]
+"STACKS"
+
+```
+
+There are also numerous convenience methods
+
+```ruby
+# Boolean checks
+item.in_temp_location?
+item.in_place? # Basically, On Shelf or Not
+item.non_circulating?
+item.missing_or_lost?
+item.has_temp_call_number?
+item.has_alt_call_number?
+item.has_process_type?
+
+
+# Opinionated Accessors - return the value, or an empty string
+
+# Returns temp library/location if appropriate, else normal library/location
+item.library
+item.library_name
+item.location
+item.location_name
+
+# which use these methods under the hood
+item.holding_library
+item.holding_location
+
+item.temp_library
+item.temp_location
+
+
+# Looks for Temp call number, then alternate call number, then normal call number
+item.call_number
+
+# and which use
+item.temp_call_number
+item.alt_call_number
+
+
+# standard accessors
+item.process_type
+item.base_status
+item.circulation_policy
+item.description
+item.public_note
+
+```
+
+### Logging
+This gem exposes a loggable interface to responses.  Thus a response will respond to `loggable` and return a hash with state values that may be of use to log.
+
+As a bonus, when we enable this feature using the `enable_loggable` configuration, error messages will contain the loggable values and be formatted as JSON.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+Use `bundle exec guard` to continuously run specs while developing.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/tulibraries/alma_rb. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
@@ -145,4 +256,3 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/tulibr
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
-

data/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/alma.gemspec

@@ -1,16 +1,18 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'alma/version'
+require "alma/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "alma"
   spec.version       = Alma::VERSION
-  spec.authors       = ["Chad Nelson"]
-  spec.email         = ["chad.nelson@temple.edu"]
+  spec.authors       = ["Jennifer Anton", "David Kinzer", "Chad Nelson"]
+  spec.email         = ["jennifer.anton@temple.edu", "david.kinzer@temple.edu", "chad.nelson@temple.edu"]
 
-  spec.summary       = %q{Client for Ex Libris Alma Web Services}
-  spec.description   = %q{Client for Ex Libris Alma Web Services}
+  spec.summary       = "Client for Ex Libris Alma Web Services"
+  spec.description   = "Client for Ex Libris Alma Web Services"
   spec.homepage      = "https://github.com/tulibraries/alma_rb"
   spec.license       = "MIT"
 
@@ -21,16 +23,19 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'ezwadl'
-  spec.add_dependency 'httparty'
-  spec.add_dependency 'xml-simple'  
-
-  
-
+  spec.add_dependency "ezwadl"
+  spec.add_dependency "httparty"
+  spec.add_dependency "xml-simple"
+  spec.add_dependency "activesupport"
 
-  spec.add_development_dependency "bundler", "~> 1.13"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler", "~> 2.0"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency 'webmock'
-  spec.add_development_dependency 'pry'
+  spec.add_development_dependency "webmock"
+  spec.add_development_dependency "pry"
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "rubocop-rails"
+  spec.add_development_dependency "byebug"
+  spec.add_development_dependency "guard"
+  spec.add_development_dependency "guard-rspec"
 end

data/lib/alma/alma_record.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 module Alma
   class AlmaRecord
-
     def initialize(record)
       @raw_record = record
       post_initialize()
@@ -23,6 +24,5 @@ module Alma
       # Subclasses can define this method to perform extra initialization
       # after the super class init.
     end
-
   end
-end
+end