alma 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 205918f513cfea340ea21733aebf97f9028a87ac
-  data.tar.gz: c8e0ada2ffcdd3cd1742bf076be8ee8416ec9c76
+  metadata.gz: f6514577bde1155ebeaac6f1c1b0b6e18c615b32
+  data.tar.gz: 8fbceca83bc75f49fc1aa5890c84ce1c9b8944ec
 SHA512:
-  metadata.gz: b1e361f47c0f0b3feebf760111b3760ff7891aec3b040a697a79bbe827d5464a23d763350f04f14593c242bda1169713ff4a36d43140a6658969e8a5af7b8c97
-  data.tar.gz: 12b24d9df96c5c796324e4f3fee471883f77fd78079402e740b04b25a466d4fc2fa609fb7ef31ecb2ad7273af0517faa8739ac1881ec5fd6ae0f2985f5881522
+  metadata.gz: 30f11ef82444e7cbf6a581cd7ad8adbad12d795f67396331663cac62c2da58e873b043e8e5078c6163103fbc3b2363a139ddaf8dad0513b45ddf34caa01c01f0
+  data.tar.gz: c450a1b9be6e4c603b836d4b879fba1c90eee5d815fb2d98b8a8230038efbd10bdb7f5fb016f0694763d5c55753365f32b3b510ad482aac6966a69aee3d0a7d6

data/README.md

@@ -7,7 +7,7 @@ A client for Web Services provided by the Ex Libris's Alma Library System.
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'alma', :git => "https://github.com/tulibraries/alma_rb.git"
+gem 'alma'
 ```
 
 And then execute:
@@ -16,7 +16,7 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install alma_rb
+    $ gem install alma
 
 ## Usage
 

data/lib/alma/loan.rb

@@ -2,7 +2,7 @@ module Alma
   class Loan < AlmaRecord
 
     def renew
-      Alma::User.renew_loan({user_id: user_id, loan: self})
+      Alma::User.renew_loan({user_id: user_id, loan_id: loan_id})
     end
 
   end

data/lib/alma/renewal_response.rb

@@ -1,30 +1,34 @@
 module Alma
   class RenewalResponse
 
-    def initialize(response, loan=nil)
-      @loan     = loan
-      @success  = response.fetch('item_loan', nil)
-      @error    = response.fetch('web_service_result', nil)
-      @renewed  = @error.nil?
+    def initialize(response)
+      @success  = response.fetch('item_loan', {})
+      @error    = response.fetch('web_service_result', {})
+      @renewed  = @error.empty?
     end
 
     def renewed?
       @renewed
     end
 
-    def new_due_date
-      Time.parse(@success['due_date']).strftime('%m-%e-%y %H:%M')
+    def due_date
+      @success.fetch('due_date', '')
+    end
+
+
+    def due_date_pretty
+      Time.parse(due_date).strftime('%m-%e-%y %H:%M')
     end
 
     def error_message
-      @error['errorList']['error']['errorMessage']
+      (renewed?) ? '' : @error['errorList']['error']['errorMessage']
     end
 
     def item_title
-      if @loan
-        @loan.title
+      if @success
+        @success['title']
       else
-        "This Item"
+        'This Item'
       end
     end
 

data/lib/alma/user.rb

@@ -23,8 +23,8 @@ module Alma
       @loans
     end
 
-    def renew_loan(loan)
-      response = self.class.renew_loan({user_id: self.id, loan: loan})
+    def renew_loan(loan_id)
+      response = self.class.renew_loan({user_id: self.id, loan_id: loan_id})
       @recheck_loans = true if response.renewed?
       response
     end
@@ -95,21 +95,14 @@ module Alma
       # Attempts to renew a single item for a user
       # @param [Hash] args
       # @option args [String] :user_id The unique id of the user
-      # @option args [String] :loan_id The unique id of the loan - optional (either :loan_id or :loan must be present)
-      # @option args [String] :loan_id A loan object - optional (either :loan_id or :loan must be present)
-      # @option args [String] :user_id_type Type of identifier being used to search
+      # @option args [String] :loan_id The unique id of the loan
+      # @option args [String] :user_id_type Type of identifier being used to search. OPTIONAL
       # @return [RenewalResponse] Object indicating the renewal message
       def renew_loan(args)
         args.merge!({op: 'renew'})
-
-        # If a loan object is passed in args, us its id as loan_id
-        loan = args.delete(:loan)
-        if loan
-          args[:loan_id] = loan.loan_id
-        end
         params = query_merge args
         response = resources.almaws_v1_users.user_id_loans_loan_id.post(params)
-        RenewalResponse.new(response, loan)
+        RenewalResponse.new(response)
       end
 
 

data/lib/alma/version.rb

@@ -1,3 +1,3 @@
 module Alma
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alma
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Chad Nelson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-23 00:00:00.000000000 Z
+date: 2017-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ezwadl