allscripts_unity_client 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 37f39f6c94937da70a53192060bb913051b67197
-  data.tar.gz: ea1f2091395c1fde998e0eb599cddd9f37822c39
+  metadata.gz: 5af2ceca9d82117d1167e662511df55c3659629a
+  data.tar.gz: 428ce6f40066a7c5d15f045fd7d9d4620247eac1
 SHA512:
-  metadata.gz: d769e28f027e5bed0601ed9614c517a619966dfcb2b7c89fb93211d5819492fcde6811f1f6893e2c1c29ef6fa04da7a017a51c60a68d8404d37cf791ae392b53
-  data.tar.gz: 7a04ede9be73ddd21c15d441c3669969ca4474e595da7ded59d266ee2a07e3264c66b654d44073c3fcd4f0b8ef0bf045dce547dd5ef34d97c42a7cdbdc093214
+  metadata.gz: ea0bcdd635c8749437600fdc2d1f538be78bb112a34a2130b08fbde06eee79df11efb5f332287c9698cca8284386ac6b1b8a0b7eba8179c2fbb4c6150a42af47
+  data.tar.gz: ae7aae6d87dae173deda1e46c079a168ab40b764791c3032f0a49b16e02a34664e379d5578e893caabad4882e37e57e74b90a48b9f872d94d0e75aec6b0f9921

data/lib/allscripts_unity_client/client.rb

@@ -711,7 +711,7 @@ module AllscriptsUnityClient
 
     def save_task(userid, patientid, task_type = nil, target_user = nil, work_object_id = nil, comments = nil)
       if task_type.nil? && target_user.nil? && work_object_id.nil? && comments.nil?
-        raise ArugmentError, 'task_type, target_user, work_object_id, and comments can not all be nil'
+        raise ArgumentError, 'task_type, target_user, work_object_id, and comments can not all be nil'
       end
 
       magic_parameters = {
@@ -728,7 +728,7 @@ module AllscriptsUnityClient
 
     def save_task_status(userid, transaction_id = nil, status = nil, delegate_id = nil, comment = nil, taskchanges = nil, patient_id = nil)
       if transaction_id.nil? && delegate_id.nil? && comment.nil?
-        raise ArugmentError, 'transaction_id, delegate_id, and comment can not all be nil'
+        raise ArgumentError, 'transaction_id, delegate_id, and comment can not all be nil'
       end
 
       # Generate XML structure for rxxml
@@ -745,6 +745,13 @@ module AllscriptsUnityClient
         }
       end
 
+      new_status =
+        if taskchanges.nil?
+          ""
+        else
+          nokogiri_to_string(builder)
+        end
+
       magic_parameters = {
         action: 'SaveTaskStatus',
         userid: userid,
@@ -752,7 +759,7 @@ module AllscriptsUnityClient
         parameter2: status,
         parameter3: delegate_id,
         parameter4: comment,
-        parameter6: nokogiri_to_string(builder)
+        parameter6: new_status
       }
 
       if patient_id

data/lib/allscripts_unity_client/version.rb

@@ -1,3 +1,3 @@
 module AllscriptsUnityClient
-  VERSION = '4.0.0'.freeze
+  VERSION = '4.0.1'.freeze
 end

data/spec/allscripts_unity_client_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe AllscriptsUnityClient do
   subject { described_class }
 
-  describe '.create' do
+  describe '#create' do
     context 'when given mode: :json' do
       it 'returns a client with client_type :json' do
         parameters = build(:allscripts_unity_client_parameters, mode: :json)
@@ -27,4 +27,40 @@ describe AllscriptsUnityClient do
       end
     end
   end
+
+  describe '#save_task' do
+    it 'raises when each of transaction_id, delegate_id, and comment are nil' do
+      parameters = build(:allscripts_unity_client_parameters, mode: :json)
+
+      client = subject.create(parameters)
+
+      expect do
+        client.save_task(:user_id, :patient_id)
+      end.to raise_error(ArgumentError)
+    end
+  end
+
+  describe '#save_task_status' do
+    it 'raises when each of transaction_id, delegate_id, and comment are nil' do
+      parameters = build(:allscripts_unity_client_parameters, mode: :json)
+      client = subject.create(parameters)
+
+      expect do
+        client.save_task_status(:user_id, :patient_id)
+      end.to raise_error(ArgumentError)
+    end
+
+    it 'maintains a nil parameter6 whenever taskchanges is nil' do
+      parameters = build(:allscripts_unity_client_parameters, mode: :json)
+      client = subject.create(parameters)
+
+      def client.magic(params)
+        params
+      end
+
+      result = client.save_task_status(1, 1, :status, 1, :comment, nil, 1)
+
+      expect(result[:parameter6]).to eq("")
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: allscripts_unity_client
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - healthfinch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-22 00:00:00.000000000 Z
+date: 2018-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient