allscripts_unity_client 3.3.1 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26d2a1e44edd1f0566f998f0d6a0a458be686621
-  data.tar.gz: 8a8e6d47cdcba9fe7cd5bcf775d40055eca85d13
+  metadata.gz: 5b018d1ed24a0f4b028314d344ddda233cdae85e
+  data.tar.gz: a50e668f398d71abb9b9c2a634ece8009a97b929
 SHA512:
-  metadata.gz: 7caa5e1b1a0e0bc6fd40f5331cc48bbe4b4ba8421d795a873670cacd2742270889b611d5e0604a96ca09a3027324d771043036b18373e762b856af5376de14a6
-  data.tar.gz: 9115bca3320748180f5c39423763fc75e9c7e45c7032e3ebb45657795d7d899a0aacb51155147e4850afcfada554f0a2bd40ed7f3c502512670837a978adda5c
+  metadata.gz: f60b57a172e05271f9c68d9eeb4d9c04e10dbe17d16c9bba85e8e9a91f3435fd290b63d8d8d787a7f827489f0aa2caff61837c985f5e46dbf3451f622312bca4
+  data.tar.gz: c2e23be3758cce7f2568476132afafcc1140cea9b9453e225373fb0d4b61f9f383997405ab592a556412cbea4935cfa8816bd0faf137ece71fc51fa2a3652de2

data/lib/allscripts_unity_client/client_driver.rb

@@ -75,5 +75,15 @@ module AllscriptsUnityClient
       @end_time = Time.now.utc
       @timer = @end_time - @start_time
     end
+
+    # Initializes a `GetSecurityTokenError` with a default message.
+    #
+    # @return [GetSecurityTokenError]
+    def make_get_security_token_error
+      base_unity_url = self.options.base_unity_url.inspect
+      error_message = "Could not retrieve security token from #{base_unity_url}"
+
+      GetSecurityTokenError.new(error_message)
+    end
   end
 end

data/lib/allscripts_unity_client/json_client_driver.rb

@@ -12,7 +12,6 @@ module AllscriptsUnityClient
     def initialize(options)
       super
 
-
       @connection = HTTPClient.new(
         proxy: @options.proxy,
         default_header: {'Content-Type' => 'application/json'}
@@ -90,9 +89,13 @@ module AllscriptsUnityClient
       log_get_security_token
       log_info("Response Status: #{response.status}")
 
-      raise_if_response_error(response.body)
+      if response.status != 200
+        raise make_get_security_token_error
+      else
+        raise_if_response_error(response)
 
-      @security_token = response.body
+        @security_token = response.body
+      end
     end
 
     # See Client#retire_security_token!.
@@ -117,6 +120,14 @@ module AllscriptsUnityClient
 
     private
 
+    # @param [Array,String,nil] response
+    #
+    # @return [nil]
+    #
+    # @todo This method should be responsible creating an `APIError` not
+    # raising it. The sender should be responsible for raising the
+    # error so the stack trace starts in the method where the failure
+    # occured.
     def raise_if_response_error(response)
       if response.nil?
         raise APIError, 'Response was empty'

data/lib/allscripts_unity_client/version.rb

@@ -1,3 +1,3 @@
 module AllscriptsUnityClient
-  VERSION = '3.3.1'
+  VERSION = '3.4.0'
 end

data/lib/allscripts_unity_client.rb

@@ -17,6 +17,10 @@ module AllscriptsUnityClient
   class APIError < RuntimeError
   end
 
+  # Raised whenever the security token could not be retrieved Unity.
+  class GetSecurityTokenError < RuntimeError
+  end
+
   # Create an instance of the Unity client.
   #
   # options:: See ClientOptions.

data/spec/json_client_driver_spec.rb

@@ -102,6 +102,21 @@ describe AllscriptsUnityClient::JSONClientDriver do
 
       subject.get_security_token!
     end
+
+    it 'should fail when there is a problem retrieving the security token' do
+      stub_request(:post, 'http://www.example.com/Unity/UnityService.svc/json/GetToken')
+        .to_return(
+          {
+            body: "",
+            headers: {},
+            status: 503,
+          }
+        )
+
+      expect do
+        subject.get_security_token!
+      end.to raise_error(AllscriptsUnityClient::GetSecurityTokenError)
+    end
   end
 
   describe '#retire_security_token!' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: allscripts_unity_client
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.4.0
 platform: ruby
 authors:
 - healthfinch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-11 00:00:00.000000000 Z
+date: 2017-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -288,7 +288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Allscripts Unity API client