alipay 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76821d020f3247b02202d5253dae2df6a8ce1288
-  data.tar.gz: db6abc47a810d5390ddce5e2506c09bc2b11e0b4
+  metadata.gz: 88d669e91705790c16000241168d66901de8d477
+  data.tar.gz: 9c99d503d9f08840a5d4184a5eac0289e15bfe59
 SHA512:
-  metadata.gz: c6774216b77ea292b1169dfd3ca0ac9475e76881a66fb7ac824eb7cffcf2528215637114b527989b2d0a56187b8152c182e3fdaeeb4594f3920bccba2874b0a6
-  data.tar.gz: 42f41ead9ce83eaca5c30bd4cc477b3119ec4323190077b1387a729c2ad5e5c218ca542000c5bbeb9c1c816bcac969ec9b8d3610053b58a0f9b8cfd2ce4c1f8d
+  metadata.gz: 3f01a960ef34e8742828c63691ed400d96318585db592f03fae3d633d2b081a632764fc1c56a78852becba9239c64a5c53874b66ee49ebd9e46b0243b2c1a37d
+  data.tar.gz: 81b2d0743a4f7904002c523cf2a67196b1fe5615b59200808d910a719185b22a662ee3d26cb90f9545c8893d938bf7015c7628abc01283f5ba77fb474729f08e

data/README.md

@@ -6,14 +6,20 @@ It contain this API:
 
 * Generate payment url
 * Send goods
-* Verify when receive alipay notify
+* Verify notify
 
-Please read alipay official document first: https://b.alipay.com/order/techService.htm
+Please read alipay official document first: https://b.alipay.com/order/techService.htm .
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
+```ruby
+gem 'alipay', '~> 0.0.2'
+```
+
+or development version
+
 ```ruby
 gem 'alipay', :github => 'chloerei/alipay'
 ```
@@ -26,7 +32,7 @@ $ bundle
 
 ## Usage
 
-### Init
+### Config
 
 ```ruby
 Alipay.pid = 'YOUR_PID'
@@ -66,7 +72,7 @@ Current support three payment type:
 
 ```ruby
 options = {
-  :trade_no       => 'trade_no_id',
+  :trade_no       => 'TRADE_NO',
   :logistics_name => 'writings.io',
   :transport_type => 'DIRECT'
 }
@@ -75,13 +81,14 @@ Alipay::Service.send_goods_confirm_by_platform(options)
 # => '<!xml version="1.0" encoding="utf-8"?><alipay><is_success>T</is_success></alipay>'
 ```
 
-### Verify when receive alipay notify
+### Verify notify
 
 ```ruby
-# exxample in rails
+# example in rails
 # The notify url MUST be set when generate payment url
 def alipay_notify
-  notify_params = params.except(*request.path_parameters.keys) # except :controller_name, :action_name, :host
+  # except :controller_name, :action_name, :host, etc.
+  notify_params = params.except(*request.path_parameters.keys)
   if Alipay::Notify.verify?(notify_params)
     # valid notify, code your business logic.
     render :text => 'success'
@@ -93,7 +100,7 @@ end
 
 ## Contributing
 
-Bug report or pull request is welcome.
+Bug report or pull request are welcome.
 
 ### Make a pull request
 

data/alipay.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["chloerei@gmail.com"]
   spec.description   = %q{An unofficial simple alipay gem}
   spec.summary       = %q{An unofficial simple alipay gem}
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/chloerei/alipay"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)

data/lib/alipay/notify.rb

@@ -2,8 +2,8 @@ module Alipay
   class Notify
     def self.verify?(params)
       if Sign.verify?(params)
-        params = Utils.symbolize_keys(params)
-        open("https://mapi.alipay.com/gateway.do?service=notify_verify&partner=#{Alipay.pid}&notify_id=#{CGI.escape params[:notify_id].to_s}").read == 'true'
+        params = Utils.stringify_keys(params)
+        open("https://mapi.alipay.com/gateway.do?service=notify_verify&partner=#{Alipay.pid}&notify_id=#{CGI.escape params['notify_id'].to_s}").read == 'true'
       else
         false
       end

data/lib/alipay/service.rb

@@ -9,12 +9,12 @@ module Alipay
     # alipayescow
     def self.create_partner_trade_by_buyer_url(options)
       options = {
-        :service        => 'create_partner_trade_by_buyer',
-        :_input_charset => 'utf-8',
-        :partner        => Alipay.pid,
-        :seller_email   => Alipay.seller_email,
-        :payment_type   => '1'
-      }.merge(Utils.symbolize_keys(options))
+        'service'        => 'create_partner_trade_by_buyer',
+        '_input_charset' => 'utf-8',
+        'partner'        => Alipay.pid,
+        'seller_email'   => Alipay.seller_email,
+        'payment_type'   => '1'
+      }.merge(Utils.stringify_keys(options))
 
       check_required_options(options, TRADE_CREATE_BY_BUYER_REQUIRED_OPTIONS)
 
@@ -25,12 +25,12 @@ module Alipay
     # alipaydualfun
     def self.trade_create_by_buyer_url(options = {})
       options = {
-        :service        => 'trade_create_by_buyer',
-        :_input_charset => 'utf-8',
-        :partner        => Alipay.pid,
-        :seller_email   => Alipay.seller_email,
-        :payment_type   => '1'
-      }.merge(Utils.symbolize_keys(options))
+        'service'        => 'trade_create_by_buyer',
+        '_input_charset' => 'utf-8',
+        'partner'        => Alipay.pid,
+        'seller_email'   => Alipay.seller_email,
+        'payment_type'   => '1'
+      }.merge(Utils.stringify_keys(options))
 
       check_required_options(options, TRADE_CREATE_BY_BUYER_REQUIRED_OPTIONS)
 
@@ -41,16 +41,16 @@ module Alipay
     # direct
     def self.create_direct_pay_by_user_url(options)
       options = {
-        :service        => 'create_direct_pay_by_user',
-        :_input_charset => 'utf-8',
-        :partner        => Alipay.pid,
-        :seller_email   => Alipay.seller_email,
-        :payment_type   => '1'
-      }.merge(Utils.symbolize_keys(options))
+        'service'        => 'create_direct_pay_by_user',
+        '_input_charset' => 'utf-8',
+        'partner'        => Alipay.pid,
+        'seller_email'   => Alipay.seller_email,
+        'payment_type'   => '1'
+      }.merge(Utils.stringify_keys(options))
 
       check_required_options(options, CREATE_DIRECT_PAY_BY_USER_REQUIRED_OPTIONS)
 
-      if options[:total_fee].nil? and (options[:price].nil? || options[:quantity].nil?)
+      if options['total_fee'].nil? and (options['price'].nil? || options['quantity'].nil?)
         warn("Ailpay Warn: total_fee or (price && quantiry) must have one")
       end
 
@@ -60,14 +60,14 @@ module Alipay
     SEND_GOODS_CONFIRM_BY_PLATFORM_REQUIRED_OPTIONS = %w( service partner _input_charset trade_no logistics_name )
     def self.send_goods_confirm_by_platform(options)
       options = {
-        :service        => 'send_goods_confirm_by_platform',
-        :partner        => Alipay.pid,
-        :_input_charset => 'utf-8'
-      }.merge(Utils.symbolize_keys(options))
+        'service'        => 'send_goods_confirm_by_platform',
+        'partner'        => Alipay.pid,
+        '_input_charset' => 'utf-8'
+      }.merge(Utils.stringify_keys(options))
 
       check_required_options(options, SEND_GOODS_CONFIRM_BY_PLATFORM_REQUIRED_OPTIONS)
 
-      if options[:transport_type].nil? and options[:create_transport_type].nil?
+      if options['transport_type'].nil? and options['create_transport_type'].nil?
         warn("Ailpay Warn: transport_type or create_transport_type must have one")
       end
 
@@ -75,14 +75,14 @@ module Alipay
     end
 
     def self.query_string(options)
-      options.merge(:sign_type => 'MD5', :sign => Alipay::Sign.generate(options)).map do |key, value|
+      options.merge('sign_type' => 'MD5', 'sign' => Alipay::Sign.generate(options)).map do |key, value|
         "#{CGI.escape(key.to_s)}=#{CGI.escape(value.to_s)}"
       end.join('&')
     end
 
     def self.check_required_options(options, names)
       names.each do |name|
-        warn("Ailpay Warn: missing required option: #{name}") unless options.has_key?(name.to_sym)
+        warn("Ailpay Warn: missing required option: #{name}") unless options.has_key?(name)
       end
     end
   end

data/lib/alipay/sign.rb

@@ -11,9 +11,9 @@ module Alipay
     end
 
     def self.verify?(params)
-      params = Utils.symbolize_keys(params)
-      params.delete(:sign_type)
-      sign = params.delete(:sign)
+      params = Utils.stringify_keys(params)
+      params.delete('sign_type')
+      sign = params.delete('sign')
 
       generate(params) == sign
     end

data/lib/alipay/utils.rb

@@ -1,9 +1,9 @@
 module Alipay
   module Utils
-    def self.symbolize_keys(hash)
+    def self.stringify_keys(hash)
       new_hash = {}
       hash.each do |key, value|
-        new_hash[(key.to_sym rescue key) || key] = value
+        new_hash[(key.to_s rescue key) || key] = value
       end
       new_hash
     end

data/lib/alipay/version.rb

@@ -1,3 +1,3 @@
 module Alipay
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/test/alipay/utils_test.rb

@@ -1,8 +1,8 @@
 require 'test_helper'
 
 class Alipay::UtilsTest < Test::Unit::TestCase
-  def test_symbolize_keys
+  def test_stringify_keys
     hash = { 'a' => 1, :b => 2 }
-    assert_equal({ :a => 1, :b => 2 }.sort, Alipay::Utils.symbolize_keys(hash).sort)
+    assert_equal({ 'a' => 1, 'b' => 2 }.sort, Alipay::Utils.stringify_keys(hash).sort)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alipay
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Rei
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-02 00:00:00.000000000 Z
+date: 2013-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -76,7 +76,7 @@ files:
 - test/alipay/sign_test.rb
 - test/alipay/utils_test.rb
 - test/test_helper.rb
-homepage: ''
+homepage: https://github.com/chloerei/alipay
 licenses:
 - MIT
 metadata: {}