algoliasearch-rails 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 488ab2486b67c8317deadff4c549f647794104c6
-  data.tar.gz: 74d5cf101bf372f2a3f5fafadd9aa33fe453d5e6
+  metadata.gz: 870048b483ecc405daa61ebd24ef2624adeb48d0
+  data.tar.gz: daef90a5174d5424debf92a2301ea82a39a3d92f
 SHA512:
-  metadata.gz: f48a72b377a901ce37da8be9e3f2789d2e70c5913ef434d2f8ebea46d37d4e870e6284e6fdf510271ee8445055d20b41a66777518617a5000687b73fb8004c58
-  data.tar.gz: 0f232facf4c9bb579fa9a93ccfa60733a443c4b0c5b4680bd73681f4f46682c1912d21286e3d63e9ad5102a06f51d3384dfecff303c531bfd20db3e634a53fd7
+  metadata.gz: 9a72f0cab95ce45d1ab1a348c659944ce955a5738a6d48b3e3cc8fcfce7ba46e339e6a9ccfea0b582a10fe931b971780da0e0c8bad4c1229a8255238e57ec3ce
+  data.tar.gz: 08221737fd46c48e13a447e21270606ab3e18fa8fcb468d7bfdd60e48b5f55d646bbf12d63dc2d71f004149d6c556e93d768f4f8a6a40989472bafc834900fca

data/ChangeLog

@@ -0,0 +1,31 @@
+CHANGELOG
+
+2013-10-15  1.3.0
+
+      * synchronous flag is now false by default
+      * do not set settings if they didn't chang
+
+2013-10-15  1.2.1
+
+      * Updated deps, especially algoliasearch to 1.1.3 to solve thread-safety issues
+
+2013-10-14  1.2.0
+
+      * embeds a typeahead.js based UI
+
+2013-10-04  1.1.8
+
+      * Avoid concurrent access to the same index while running tests with TravisCI
+      * to check if the full-reindexing has been done, checking the last task is enough
+
+2013-10-02  1.1.7
+
+      * Updated environment variables
+      * Plug travis and various badges
+      * Fixed attribute changes detection
+      * Upgrade to algoliasearch-client-ruby 1.1.1
+
+2013-10-01  1.1.6
+
+      * Initial import
+

data/README.md

@@ -87,7 +87,7 @@ p Contact.search("jon doe")
 Options
 ----------
 
-Each time a record is saved; it will be - synchronously - indexed. In the other hand, each time a record is destroyed, it will be - synchronoulsy - removed from the index.
+Each time a record is saved; it will be - asynchronously - indexed. In the other hand, each time a record is destroyed, it will be - asynchronoulsy - removed from the index.
 
 You can disable auto-indexing and auto-removing setting the following options:
 
@@ -101,13 +101,13 @@ class Contact < ActiveRecord::Base
 end
 ```
 
-You can force indexing and removing to be asynchronous by setting the following option:
+You can force indexing and removing to be synchronous by setting the following option:
 
 ```ruby
 class Contact < ActiveRecord::Base
   include AlgoliaSearch
 
-  algoliasearch synchronous: false do
+  algoliasearch synchronous: true do
     attribute :first_name, :last_name, :email
   end
 end

data/VERSION

@@ -1 +1 @@
-1.2.1
+1.3.0

data/algoliasearch-rails.gemspec

@@ -5,14 +5,15 @@
 
 Gem::Specification.new do |s|
   s.name = "algoliasearch-rails"
-  s.version = "1.2.1"
+  s.version = "1.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Algolia"]
-  s.date = "2013-10-15"
+  s.date = "2013-10-16"
   s.description = "AlgoliaSearch integration to your favorite ORM"
   s.email = "contact@algolia.com"
   s.extra_rdoc_files = [
+    "ChangeLog",
     "LICENSE",
     "README.md"
   ]
@@ -20,6 +21,7 @@ Gem::Specification.new do |s|
     ".document",
     ".rspec",
     ".travis.yml",
+    "ChangeLog",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE",

data/lib/algoliasearch-rails.rb

@@ -87,7 +87,7 @@ module AlgoliaSearch
       @index_options = IndexOptions.new(block_given? ? Proc.new : nil)
       attr_accessor :highlight_result
 
-      unless options[:synchronous] == false
+      if options[:synchronous] == true
         before_save :mark_synchronous if respond_to?(:before_save)
       end
       unless options[:auto_index] == false
@@ -103,7 +103,7 @@ module AlgoliaSearch
       init
     end
 
-    def reindex!(batch_size = 1000, synchronous = true)
+    def reindex!(batch_size = 1000, synchronous = false)
       last_task = nil
       find_in_batches(batch_size: batch_size) do |group|
         objects = group.map { |o| attributes(o).merge 'objectID' => o.id.to_s }
@@ -112,7 +112,7 @@ module AlgoliaSearch
       @index.wait_task(last_task["taskID"]) if last_task and synchronous == true
     end
 
-    def index!(object, synchronous = true)
+    def index!(object, synchronous = false)
       if synchronous
         @index.add_object!(attributes(object), object.id.to_s)
       else
@@ -120,7 +120,7 @@ module AlgoliaSearch
       end
     end
 
-    def remove_from_index!(object, synchronous = true)
+    def remove_from_index!(object, synchronous = false)
       if synchronous
         @index.delete_object!(object.id.to_s)
       else
@@ -147,7 +147,8 @@ module AlgoliaSearch
     def init
       @index ||= Algolia::Index.new(@options[:index_name] || model_name)
       settings = @index_options.to_settings
-      @index.set_settings(settings) if !settings.empty?
+      prev_settings = @index.get_settings rescue nil # if the index doesn't exist
+      @index.set_settings(settings) if index_settings_changed?(prev_settings, settings)
     end
 
     def must_reindex?(object)
@@ -166,6 +167,14 @@ module AlgoliaSearch
       Hash[@index_options.attributes.map { |attr| [attr.to_s, object.send(attr)] }]
     end
 
+    def index_settings_changed?(prev, current)
+      return true if prev.nil?
+      current.each do |k, v|
+        return true if prev[k.to_s] != v
+      end
+      false
+    end
+
   end
 
   # these are the instance methods included
@@ -181,7 +190,7 @@ module AlgoliaSearch
     private
 
     def synchronous?
-      @synchronous.nil? || @synchronous == true
+      @synchronous == true
     end
 
     def mark_synchronous

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: algoliasearch-rails
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Algolia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-15 00:00:00.000000000 Z
+date: 2013-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -99,12 +99,14 @@ email: contact@algolia.com
 executables: []
 extensions: []
 extra_rdoc_files:
+- ChangeLog
 - LICENSE
 - README.md
 files:
 - .document
 - .rspec
 - .travis.yml
+- ChangeLog
 - Gemfile
 - Gemfile.lock
 - LICENSE