algolia 2.3.2 → 2.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1dfdc9659fd559dda96a6bac3df7d81f455fba723f835ee62213928bb2e1ba03
-  data.tar.gz: fd2abb719cc40db045c976e1183083986ebc13fff45a979bd6a0da4bb1cf68c1
+  metadata.gz: d62b0de820a85fc4e78522751cb8ebea6aae9ed3ec3093be279b1bc8e3c8b562
+  data.tar.gz: 25f6506b67a2331391bcb3cb5d59cefd65265c9c07d89b0d01cf208c743c9859
 SHA512:
-  metadata.gz: ed0f1ba2efdb129534b30ec41f381d9288685aa9f88beeaea813426ba40831c3c3691727fcfd52002a6db35a0f2c3218687b2687fb3e7b71e8ccfc655b27b920
-  data.tar.gz: 8df23199078a71911b108864b74e0c9431790fdb28cfd5cafdd811ecc31d9a860a53e9031b050b969ba73aaa49ac96555c564162fb766425c86683cc2dcfb74a
+  metadata.gz: 548d4e0344b4b7157d652ee0fa095735ee40d473c726c4e68149bdc0451088ea64cc1e857d369ca2e94a9ea2036ccb072e95774fc3e5fde71fc4d0d9cb07de36
+  data.tar.gz: 70297bf2011eeddbb2320cb44ede56fd55876268c9dc4e9edff2babb11c0b1ef5be44c18b175a59b3d4e7c1da1802c808858aa5ef715e0cd3f79a805809cf3ca

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## [Unreleased](https://github.com/algolia/algoliasearch-client-ruby/compare/2.3.2..master)
 
+## [2.3.4](https://github.com/algolia/algoliasearch-client-ruby/compare/2.3.3...2.3.4) (2023-11-27)
+### Fixed
+- Fixes issue with index name encoding for certain characters.
+
+## [2.3.3](https://github.com/algolia/algoliasearch-client-ruby/compare/2.3.2...2.3.3) (2023-11-14)
+### Fixed
+- Fixed issue with connection caching for faulty hosts that accept similar requests ([`#496`](https://github.com/algolia/algoliasearch-client-ruby/pull/496))
+
 ## [2.3.2](https://github.com/algolia/algoliasearch-client-ruby/compare/2.3.1...2.3.2) (2023-06-07)
 ### Fixed
 - Fixed issue with Request not taking timeouts into account ([`#493`](https://github.com/algolia/algoliasearch-client-ruby/pull/493))

data/lib/algolia/helpers.rb

@@ -44,7 +44,7 @@ module Helpers
   def path_encode(path, *args)
     arguments = []
     args.each do |arg|
-      arguments.push(CGI.escape(CGI.unescape(arg.to_s)))
+      arguments.push(CGI.escape(arg.to_s))
     end
 
     format(path, *arguments)

data/lib/algolia/http/http_requester.rb

@@ -65,7 +65,7 @@ module Algolia
       # @return [Faraday::Connection]
       #
       def connection(host)
-        @connections[host.accept] ||= Faraday.new(build_url(host)) do |f|
+        @connections[host.url] ||= Faraday.new(build_url(host)) do |f|
           f.adapter @adapter.to_sym
         end
       end

data/lib/algolia/version.rb

@@ -1,3 +1,3 @@
 module Algolia
-  VERSION = '2.3.2'.freeze
+  VERSION = '2.3.4'.freeze
 end

data/test/algolia/unit/helpers_test.rb

@@ -40,6 +40,10 @@ class HelpersTest
       deserialized_settings = deserialize_settings(old_settings, false)
       assert_equal new_settings, deserialized_settings
     end
+
+    def test_path_encode
+      assert_equal path_encode('/1/indexes/%s/settings', 'premium+ some_name'), '/1/indexes/premium%2B+some_name/settings'
+    end
   end
 
   describe 'test hash_includes_subset' do

data/test/algolia/unit/http_requester_test.rb

@@ -0,0 +1,27 @@
+require 'algolia'
+require 'test_helper'
+
+class HttpRequesterTest
+  describe 'connection' do
+    def test_caches_http_client_connections
+      requester = Algolia::Http::HttpRequester.new(Defaults::ADAPTER, nil)
+      host1     = Algolia::Transport::StatefulHost.new('host1')
+
+      # rubocop:disable Lint/UselessComparison
+      assert requester.connection(host1) == requester.connection(host1)
+      # rubocop:enable Lint/UselessComparison
+      assert_equal requester.connection(host1).url_prefix.host, 'host1'
+    end
+
+    def test_caches_hosts_independent_of_each_other
+      requester = Algolia::Http::HttpRequester.new(Defaults::ADAPTER, nil)
+      host1     = Algolia::Transport::StatefulHost.new('host1')
+      host2     = Algolia::Transport::StatefulHost.new('host2')
+
+      assert requester.connection(host1) != requester.connection(host2)
+
+      assert_equal requester.connection(host1).url_prefix.host, 'host1'
+      assert_equal requester.connection(host2).url_prefix.host, 'host2'
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: algolia
 version: !ruby/object:Gem::Version
-  version: 2.3.2
+  version: 2.3.4
 platform: ruby
 authors:
 - Algolia
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-07 00:00:00.000000000 Z
+date: 2023-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -306,6 +306,7 @@ files:
 - test/algolia/integration/search_index_test.rb
 - test/algolia/unit/algolia_config_test.rb
 - test/algolia/unit/helpers_test.rb
+- test/algolia/unit/http_requester_test.rb
 - test/algolia/unit/retry_strategy_test.rb
 - test/algolia/unit/user_agent_test.rb
 - test/test_helper.rb
@@ -349,6 +350,7 @@ test_files:
 - test/algolia/integration/search_index_test.rb
 - test/algolia/unit/algolia_config_test.rb
 - test/algolia/unit/helpers_test.rb
+- test/algolia/unit/http_requester_test.rb
 - test/algolia/unit/retry_strategy_test.rb
 - test/algolia/unit/user_agent_test.rb
 - test/test_helper.rb