alexandria-book-collection-manager 0.7.9 → 0.7.11

data/spec/alexandria/smart_library_spec.rb

@@ -16,8 +16,10 @@ RSpec.describe Alexandria::SmartLibrary do
     it "normalizes the encoding" do
       bad_name = (+"Prêts").force_encoding("ascii")
       lib = described_class.new(bad_name, [], :all)
-      expect(lib.name.encoding.name).to eq "UTF-8"
-      expect(bad_name.encoding.name).to eq "US-ASCII"
+      aggregate_failures do
+        expect(lib.name.encoding.name).to eq "UTF-8"
+        expect(bad_name.encoding.name).to eq "US-ASCII"
+      end
     end
   end
 
@@ -25,15 +27,15 @@ RSpec.describe Alexandria::SmartLibrary do
     let(:lib) { described_class.new("Hello", [], :all) }
 
     it "works when given no parameters" do
-      lib.update
+      expect { lib.update }.not_to raise_error
     end
 
     it "works when given a LibraryCollection" do
-      lib.update Alexandria::LibraryCollection.instance
+      expect { lib.update Alexandria::LibraryCollection.instance }.not_to raise_error
     end
 
     it "works when given a Library" do
-      lib.update Alexandria::Library.new("Hi")
+      expect { lib.update Alexandria::Library.new("Hi") }.not_to raise_error
     end
   end
 end

data/spec/alexandria/ui/about_dialog_spec.rb

@@ -7,8 +7,8 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::AboutDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 end

data/spec/alexandria/ui/acquire_dialog_spec.rb

@@ -7,8 +7,13 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::AcquireDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    described_class.new parent
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) { Alexandria::Library.new("Hi") }
+  let(:ui_manager) { instance_double(Alexandria::UI::UIManager) }
+
+  it "can be instantiated" do
+    allow(ui_manager).to receive :set_status_label
+    dialog = described_class.new parent, ui_manager, library
+    expect(dialog).to be_a described_class
   end
 end

data/spec/alexandria/ui/alert_dialog_spec.rb

@@ -7,10 +7,12 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::AlertDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
-    described_class.new(parent, "Hello",
-                        Gtk::Stock::DIALOG_QUESTION,
-                        [[Gtk::Stock::CANCEL, :cancel]], "Hi there")
+    expect do
+      described_class.new(parent, "Hello",
+                          Gtk::Stock::DIALOG_QUESTION,
+                          [[Gtk::Stock::CANCEL, :cancel]], "Hi there")
+    end.not_to raise_error
   end
 end

data/spec/alexandria/ui/bad_isbns_dialog_spec.rb

@@ -7,8 +7,8 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::BadIsbnsDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
-    described_class.new parent, "Careful", []
+    expect { described_class.new parent, "Careful", [] }.not_to raise_error
   end
 end

data/spec/alexandria/ui/book_properties_dialog_spec.rb

@@ -21,8 +21,8 @@ describe Alexandria::UI::BookPropertiesDialog do
     library << book
   end
 
-  it "works" do
-    described_class.new parent, library, book
+  it "can be instantiated" do
+    expect { described_class.new parent, library, book }.not_to raise_error
   end
 
   describe "#on_change_cover" do
@@ -39,21 +39,21 @@ describe Alexandria::UI::BookPropertiesDialog do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is reject" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::REJECT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is cancel" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
   end
 end

data/spec/alexandria/ui/confirm_erase_dialog_spec.rb

@@ -7,8 +7,24 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConfirmEraseDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    described_class.new parent, "foo-file"
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
+    expect { described_class.new parent, "foo-file" }.not_to raise_error
+  end
+
+  describe "erase?" do
+    let(:instance) { described_class.new parent, "foo-file" }
+    let(:dialog) { instance.dialog }
+
+    it "returns false when response is cancel" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      expect(instance.erase?).to be false
+    end
+
+    it "returns true when response is OK" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+      expect(instance.erase?).to be true
+    end
   end
 end

data/spec/alexandria/ui/conflict_while_copying_dialog_spec.rb

@@ -7,10 +7,10 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConflictWhileCopyingDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     library = instance_double(Alexandria::Library, name: "Bar Library")
     book = instance_double(Alexandria::Book, title: "Foo Book")
-    described_class.new parent, library, book
+    expect { described_class.new parent, library, book }.not_to raise_error
   end
 end

data/spec/alexandria/ui/error_dialog_spec.rb

@@ -7,8 +7,19 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ErrorDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    described_class.new parent, "Boom", "It went boom"
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
+    expect { described_class.new parent, "Boom", "It went boom" }.not_to raise_error
+  end
+
+  describe "display" do
+    let(:instance) { described_class.new parent, "Boom", "It went boom" }
+    let(:dialog) { instance.dialog }
+
+    it "works when response is OK" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+      expect { instance.display }.not_to raise_error
+    end
   end
 end

data/spec/alexandria/ui/export_dialog_spec.rb

@@ -11,8 +11,8 @@ describe Alexandria::UI::ExportDialog do
   let(:library) { Alexandria::Library.new "Bar Library" }
   let(:sort_order) { Alexandria::LibrarySortOrder::Unsorted.new }
 
-  it "works" do
-    described_class.new parent, library, sort_order
+  it "can be instantiated" do
+    expect { described_class.new parent, library, sort_order }.not_to raise_error
   end
 
   describe "#perform" do
@@ -21,14 +21,14 @@ describe Alexandria::UI::ExportDialog do
 
     it "works when response is cancel" do
       allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      export_dialog.perform
+      expect { export_dialog.perform }.not_to raise_error
     end
 
     it "works when response is OK" do
       dir = Dir.mktmpdir
-      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::OK)
-      allow(chooser).to receive(:filename).and_return File.join(dir, "export")
-      export_dialog.perform
+      allow(chooser).to receive_messages(run: Gtk::ResponseType::OK,
+                                         filename: File.join(dir, "export"))
+      expect { export_dialog.perform }.not_to raise_error
     ensure
       FileUtils.remove_entry dir
     end

data/spec/alexandria/ui/{iconview_spec.rb → icon_view_manager_spec.rb}

@@ -7,9 +7,9 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::IconViewManager do
-  it "works" do
+  it "can be instantiated" do
     iconview = instance_double(Gtk::IconView).as_null_object
     parent = instance_double(Alexandria::UI::UIManager, iconview: iconview).as_null_object
-    described_class.new iconview, parent
+    expect { described_class.new iconview, parent }.not_to raise_error
   end
 end

data/spec/alexandria/ui/import_dialog_spec.rb

@@ -10,12 +10,12 @@ describe Alexandria::UI::ImportDialog do
   let(:parent) { Gtk::Window.new :toplevel }
 
   it "can be instantiated" do
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 
   it "handles a selection change" do
     importdialog = described_class.new parent
-    importdialog.dialog.signal_emit "selection_changed"
+    expect { importdialog.dialog.signal_emit "selection_changed" }.not_to raise_error
   end
 
   describe "#acquire" do
@@ -32,7 +32,7 @@ describe Alexandria::UI::ImportDialog do
 
     it "works when response is cancel" do
       allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      import_dialog.acquire { nil }
+      expect { import_dialog.acquire { nil } }.not_to raise_error
     end
 
     it "works when response is OK" do

data/spec/alexandria/ui/keep_bad_isbn_dialog_spec.rb

@@ -7,11 +7,11 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::KeepBadISBNDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     book = instance_double(Alexandria::Book,
                            title: "Foo Book",
                            isbn: "98765432")
-    described_class.new parent, book
+    expect { described_class.new parent, book }.not_to raise_error
   end
 end

data/spec/alexandria/ui/main_app_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# frozen_string_literal: true
-
 # This file is part of Alexandria.
 #
 # See the file README.md for authorship and licensing information.

data/spec/alexandria/ui/new_book_dialog_manual_spec.rb

@@ -13,8 +13,8 @@ describe Alexandria::UI::NewBookDialogManual do
     store.load_library("Bar Library")
   end
 
-  it "works" do
-    described_class.new parent, library
+  it "can be instantiated" do
+    expect { described_class.new parent, library }.not_to raise_error
   end
 
   describe "#on_change_cover" do
@@ -31,21 +31,21 @@ describe Alexandria::UI::NewBookDialogManual do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is reject" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::REJECT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is cancel" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
   end
 end

data/spec/alexandria/ui/new_book_dialog_spec.rb

@@ -9,14 +9,17 @@ require "spec_helper"
 describe Alexandria::UI::NewBookDialog do
   let(:parent) { Gtk::Window.new :toplevel }
   let(:model) { Gtk::ListStore.new(String, String, GdkPixbuf::Pixbuf) }
+  let(:library) { Alexandria::Library.new("Hi") }
+  let(:ui_manager) { instance_double(Alexandria::UI::UIManager) }
 
-  it "works" do
-    described_class.new parent
+  it "can be instantiated" do
+    dialog = described_class.new parent, ui_manager, library
+    expect(dialog).to be_a described_class
   end
 
   it "can copy search results into result treeview" do
     results = [[an_artist_of_the_floating_world, "cover-url"]]
-    dialog = described_class.new parent
-    dialog.copy_results_to_treeview_model results, model
+    dialog = described_class.new parent, ui_manager, library
+    expect { dialog.copy_results_to_treeview_model results, model }.not_to raise_error
   end
 end

data/spec/alexandria/ui/new_provider_dialog_spec.rb

@@ -10,7 +10,7 @@ describe Alexandria::UI::NewProviderDialog do
   let(:parent) { Gtk::Window.new :toplevel }
 
   it "can be instantiated" do
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 
   describe "#acquire" do
@@ -19,12 +19,12 @@ describe Alexandria::UI::NewProviderDialog do
 
     it "works when response is cancel" do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      provider_dialog.acquire
+      expect { provider_dialog.acquire }.not_to raise_error
     end
 
     it "works when response is accept" do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
-      provider_dialog.acquire
+      expect { provider_dialog.acquire }.not_to raise_error
     end
   end
 end

data/spec/alexandria/ui/new_smart_library_dialog_spec.rb

@@ -10,30 +10,32 @@ describe Alexandria::UI::NewSmartLibraryDialog do
   let(:parent) { Gtk::Window.new :toplevel }
 
   it "can be instantiated" do
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 
   describe "#acquire" do
     let(:properties_dialog) { described_class.new parent }
     let(:gtk_dialog) { properties_dialog.dialog }
+    let(:rules_box) { properties_dialog.instance_variable_get(:@rules_box) }
+    let(:rule_entry) { rules_box.children.first.children[2] }
 
     it "works when response is cancel" do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      properties_dialog.acquire
+      expect { properties_dialog.acquire }.not_to raise_error
     end
 
     it "returns a smart library that can be saved when response is ok" do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
 
       # Make sure entered rule is valid
-      rules_box = properties_dialog.instance_variable_get(:@rules_box)
-      entry = rules_box.children.first.children[2]
-      entry.text = "foo"
+      rule_entry.text = "foo"
 
       result = properties_dialog.acquire
 
-      expect(result).to be_a Alexandria::SmartLibrary
-      expect { result.save }.not_to raise_error
+      aggregate_failures do
+        expect(result).to be_a Alexandria::SmartLibrary
+        expect { result.save }.not_to raise_error
+      end
     end
   end
 end

data/spec/alexandria/ui/preferences_dialog_spec.rb

@@ -7,8 +7,8 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::PreferencesDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
-    described_class.new(parent) { nil }
+    expect { described_class.new(parent) { nil } }.not_to raise_error
   end
 end

data/spec/alexandria/ui/provider_preferences_dialog_spec.rb

@@ -8,9 +8,13 @@ require_relative "../../spec_helper"
 
 describe Alexandria::UI::ProviderPreferencesDialog do
   let(:parent) { Gtk::Window.new :toplevel }
+  let(:variable) do
+    instance_double(Alexandria::BookProviders::Preferences::Variable,
+                    name: "foo-bar", description: "Foo Bar", possible_values: nil,
+                    value: "baz", mandatory?: false)
+  end
   let(:preferences) do
-    instance_double(Alexandria::BookProviders::Preferences,
-                    length: 0, read: [])
+    instance_double(Alexandria::BookProviders::Preferences, length: 0, read: [variable])
   end
   let(:provider) do
     instance_double(Alexandria::BookProviders::GenericProvider,
@@ -19,16 +23,27 @@ describe Alexandria::UI::ProviderPreferencesDialog do
   end
 
   it "can be instantiated" do
-    described_class.new parent, provider
+    expect { described_class.new parent, provider }.not_to raise_error
   end
 
   describe "#acquire" do
-    it "works" do
-      preferences_dialog = described_class.new parent, provider
-      gtk_dialog = preferences_dialog.dialog
-      allow(gtk_dialog).to receive(:run)
+    let(:preferences_dialog) { described_class.new parent, provider }
+
+    before do
+      allow(preferences_dialog.dialog).to receive(:run)
+      allow(variable).to receive(:new_value=)
+    end
+
+    it "runs the underlying Gtk+ dialog" do
+      preferences_dialog.acquire
+
+      expect(preferences_dialog.dialog).to have_received(:run)
+    end
 
+    it "updates variables" do
       preferences_dialog.acquire
+
+      expect(variable).to have_received(:new_value=).with "baz"
     end
   end
 end

data/spec/alexandria/ui/really_delete_dialog_spec.rb

@@ -7,10 +7,10 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ReallyDeleteDialog do
-  it "works" do
+  it "can be instantiated" do
     library = instance_double(Alexandria::Library,
                               name: "Bar Library", empty?: false, size: 12)
     parent = Gtk::Window.new :toplevel
-    described_class.new parent, library
+    expect { described_class.new parent, library }.not_to raise_error
   end
 end

data/spec/alexandria/ui/sidepane_manager_spec.rb

@@ -7,9 +7,9 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::SidepaneManager do
-  it "works" do
+  it "can be instantiated" do
     library_listview = instance_double(Gtk::TreeView).as_null_object
     parent = instance_double(Alexandria::UI::UIManager, main_app: nil, append_library: nil)
-    described_class.new library_listview, parent
+    expect { described_class.new library_listview, parent }.not_to raise_error
   end
 end

data/spec/alexandria/ui/skip_entry_dialog_spec.rb

@@ -7,8 +7,24 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::SkipEntryDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    described_class.new parent, "Foo"
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
+    expect { described_class.new parent, "Foo" }.not_to raise_error
+  end
+
+  describe "continue?" do
+    let(:instance) { described_class.new parent, "Foo" }
+    let(:dialog) { instance.dialog }
+
+    it "returns false when response is cancel" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      expect(instance.continue?).to be false
+    end
+
+    it "returns true when response is OK" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+      expect(instance.continue?).to be true
+    end
   end
 end

data/spec/alexandria/ui/smart_library_properties_dialog_spec.rb

@@ -18,12 +18,12 @@ describe Alexandria::UI::SmartLibraryPropertiesDialog do
   describe "#acquire" do
     it "works when response is cancel" do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      properties_dialog.acquire
+      expect { properties_dialog.acquire }.not_to raise_error
     end
 
     it "works when response is ok" do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
-      properties_dialog.acquire
+      expect { properties_dialog.acquire }.not_to raise_error
     end
   end
 

data/spec/alexandria/ui/ui_manager_spec.rb

@@ -9,12 +9,12 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::UIManager do
   let(:main_app) { instance_double(Alexandria::UI::MainApp) }
 
-  it "works" do
-    described_class.new main_app
+  it "can be instantiated" do
+    expect { described_class.new main_app }.not_to raise_error
   end
 
   describe "#on_new" do
-    it "works" do
+    it "adds one library" do
       ui = described_class.new main_app
       libraries = ui.instance_variable_get(:@libraries)
       libraries_count = libraries.all_libraries.count
@@ -41,12 +41,14 @@ describe Alexandria::UI::UIManager do
       regular_library.each { |book| ui.append_book book }
       # This makes the iconview model re-appear
       ui.iconview.unfreeze
-      expect(ui.model.iter_n_children).to eq regular_library.count
 
       # This triggers the #on_books_selection_changed callback
       ui.select_a_book regular_library.first
 
-      expect(ui.iconview.selected_items).not_to be_empty
+      aggregate_failures do
+        expect(ui.model.iter_n_children).to eq regular_library.count
+        expect(ui.iconview.selected_items).not_to be_empty
+      end
     end
   end
 

data/spec/end_to_end/basic_run_spec.rb

@@ -8,7 +8,8 @@ require "gnome_app_driver"
 require "tmpdir"
 
 describe "The Alexandria application" do
-  let(:driver) { GnomeAppDriver.new "alexandria" }
+  # TODO: Remove app_file argument once GnomeAppDriver is smart about executable location
+  let(:driver) { GnomeAppDriver.new "alexandria", app_file: "exe/alexandria" }
 
   before do
     ENV["HOME"] = Dir.mktmpdir