alexandria-book-collection-manager 0.7.9 → 0.7.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 680cc4d6ee5efa35b819f163452593c352c9323efcd06baad69458e46ac16dfc
-  data.tar.gz: a1153041ada7d8641d84d5b118209c05247d9651bcddc5f92164745f62f7289c
+  metadata.gz: 829e1e63ffab2d61ef2a83a75ac56bf393e503f45ef4ba6d7914ce1c5a38e845
+  data.tar.gz: 5732456488a3f7ad93a3ec2d35c0011a2155f32496397740f3262bfb7dadd463
 SHA512:
-  metadata.gz: c7b860e3c6726fcda6877d44a84d88a62daebdc768a4d4acc6756f2a712257b1eebc783a9a1f7d3ad81219c85f2b4c4a4a84d6e8cc4126bb6847109fa9da7020
-  data.tar.gz: 99e777a212dcad283f0e9722b2836b41c51442cb6153b5f76a0cd03ec87977733112bffc73899ca1c8081e32f68da50bace883b5c7eb0410174b8a0e05e2a6fe
+  metadata.gz: 128ded6fe79d486802a8790f557cd0a94cd32f6345a996827b7acd8171067be0146f5bdeec10c015c331b2e6b73cfdff877295c3dbfde60d726b53c6241d941c
+  data.tar.gz: 87675903b9ef31770693a072e832b798d4512d5f0ce9aac59d0dab3421f8974919d1ce4b67673f2fa5841da8e35d665ea83c04928befaa6b7b305a102c89e917

data/.github/workflows/ruby.yml

@@ -4,11 +4,11 @@
 
 name: CI
 
-on:
+"on":
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
   schedule:
     - cron: '16 4 12 * *'
 
@@ -19,10 +19,10 @@ jobs:
 
     strategy:
       matrix:
-        ruby: [2.6, 2.7, "3.0", "3.1"]
+        ruby: [2.6, 2.7, "3.0", "3.1", "3.2.0-preview2"]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Install non-ruby dependencies
         run: |
           sudo apt-get update
@@ -53,7 +53,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Install non-ruby dependencies
         run: |
           sudo apt-get update

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.24.1.
+# using RuboCop version 1.36.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,12 +12,12 @@ Lint/DuplicateBranch:
     - 'lib/alexandria/book_providers/sbn_provider.rb'
     - 'util/rake/fileinstall.rb'
 
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 111
+  Max: 109
 
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
-# IgnoredMethods: refine
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods, inherit_mode.
+# AllowedMethods: refine
 Metrics/BlockLength:
   Max: 64
 
@@ -29,11 +29,11 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 991
 
-# Configuration parameters: IgnoredMethods.
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 22
+  Max: 21
 
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/MethodLength:
   Max: 98
 
@@ -45,7 +45,7 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Max: 7
 
-# Configuration parameters: IgnoredMethods.
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 27
 
@@ -76,20 +76,7 @@ RSpec/FilePath:
     - 'spec/alexandria/ui/iconview_spec.rb'
     - 'spec/alexandria/ui/sound_spec.rb'
 
-RSpec/MultipleExpectations:
-  Max: 7
-
-# Cop supports --auto-correct.
-# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
-# SupportedStyles: inflected, explicit
-RSpec/PredicateMatcher:
-  Exclude:
-    - 'spec/alexandria/export_library_spec.rb'
-    - 'spec/alexandria/library_spec.rb'
-    - 'spec/alexandria/library_store_spec.rb'
-    - 'spec/alexandria/scanners/cue_cat_spec.rb'
-
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:
   Exclude:
     - 'Rakefile'
@@ -99,7 +86,7 @@ Rake/DuplicateTask:
   Exclude:
     - 'Rakefile'
 
-# Cop supports --auto-correct.
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
@@ -121,7 +108,8 @@ Style/ClassVars:
 Style/Documentation:
   Enabled: false
 
-# Configuration parameters: EnforcedStyle, MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns, IgnoredMethods.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Exclude:
@@ -133,7 +121,6 @@ Style/OptionalBooleanParameter:
   Exclude:
     - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/book_providers/worldcat.rb'
-    - 'lib/alexandria/console.rb'
     - 'lib/alexandria/execution_queue.rb'
     - 'lib/alexandria/export_format.rb'
     - 'lib/alexandria/library_sort_order.rb'

data/.simplecov

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 SimpleCov.start do
-  add_group "Main", "lib"
-  add_group "Specs", "spec"
+  add_group "Main", "lib/"
+  add_group "Specs", "spec/"
   enable_coverage :branch
 end

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.7.10 / 2022-10-14
+
+* Loosen dependency on the marc gem
+* Update dependency on the gtk3 and gstreamer gems
+* Make Alexandria's own MARC parser handle nil records ([#198] by [mvz])
+* Support upcoming Ruby 3.2
+
 ## 0.7.9 / 2022-02-04
 
 * Drop support for Ruby 2.5
@@ -135,6 +142,7 @@
 [HappyFacade]: https://github.com/HappyFacade
 
 <!-- issues and pull requests -->
+[#198]: https://github.com/mvz/alexandria-book-collection-manager/pull/198
 [#139]: https://github.com/mvz/alexandria-book-collection-manager/pull/139
 [#136]: https://github.com/mvz/alexandria-book-collection-manager/pull/136
 [#134]: https://github.com/mvz/alexandria-book-collection-manager/pull/134

data/Rakefile

@@ -15,12 +15,12 @@ require "omfgenerate"
 
 require_relative "lib/alexandria/version"
 
-stage_dir = ENV["DESTDIR"] || "tmp"
-prefix_dir = ENV["PREFIX"] || "/usr"
+stage_dir = ENV.fetch("DESTDIR", "tmp")
+prefix_dir = ENV.fetch("PREFIX", "/usr")
 
 PROJECT = "alexandria"
 PREFIX = prefix_dir
-share_dir = ENV["SHARE"] || "#{PREFIX}/share"
+share_dir = ENV.fetch("SHARE", "#{PREFIX}/share")
 SHARE = share_dir
 
 GettextGenerateTask.new(PROJECT) do |g|

data/alexandria-book-collection-manager.gemspec

@@ -47,23 +47,23 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.rdoc_options = ["--main", "README.md"]
 
-  spec.add_runtime_dependency("gettext", ["~> 3.1"])
-  spec.add_runtime_dependency("gstreamer", ["~> 3.5.0"])
-  spec.add_runtime_dependency("gtk3", ["~> 3.5.0"])
-  spec.add_runtime_dependency("htmlentities", ["~> 4.3"])
-  spec.add_runtime_dependency("image_size", ["~> 3.0"])
-  spec.add_runtime_dependency("marc", ">= 1.0", "< 1.2")
-  spec.add_runtime_dependency("nokogiri", ["~> 1.11"])
-  spec.add_runtime_dependency("psych", ">= 3.2", "< 4.1")
-  spec.add_runtime_dependency("zoom", ["~> 0.5.0"])
+  spec.add_runtime_dependency "gettext", ["~> 3.1"]
+  spec.add_runtime_dependency "gstreamer", ["~> 4.0.2"]
+  spec.add_runtime_dependency "gtk3", ["~> 4.0.2"]
+  spec.add_runtime_dependency "htmlentities", ["~> 4.3"]
+  spec.add_runtime_dependency "image_size", ["~> 3.0"]
+  spec.add_runtime_dependency "marc", ">= 1.0", "< 1.3"
+  spec.add_runtime_dependency "nokogiri", ["~> 1.11"]
+  spec.add_runtime_dependency "psych", ">= 3.2", "< 4.1"
+  spec.add_runtime_dependency "zoom", ["~> 0.5.0"]
 
-  spec.add_development_dependency("gnome_app_driver", "~> 0.3.0")
-  spec.add_development_dependency("rake", ["~> 13.0"])
-  spec.add_development_dependency("rspec", ["~> 3.0"])
-  spec.add_development_dependency("rubocop", "~> 1.25")
-  spec.add_development_dependency("rubocop-i18n", ["~> 3.0"])
-  spec.add_development_dependency("rubocop-performance", "~> 1.13")
-  spec.add_development_dependency("rubocop-rake", "~> 0.6.0")
-  spec.add_development_dependency("rubocop-rspec", "~> 2.7")
-  spec.add_development_dependency("webmock", "~> 3.9")
+  spec.add_development_dependency "gnome_app_driver", "~> 0.3.2"
+  spec.add_development_dependency "rake", ["~> 13.0"]
+  spec.add_development_dependency "rspec", ["~> 3.0"]
+  spec.add_development_dependency "rubocop", "~> 1.32"
+  spec.add_development_dependency "rubocop-i18n", ["~> 3.0"]
+  spec.add_development_dependency "rubocop-performance", "~> 1.13"
+  spec.add_development_dependency "rubocop-rake", "~> 0.6.0"
+  spec.add_development_dependency "rubocop-rspec", "~> 2.7"
+  spec.add_development_dependency "webmock", "~> 3.9"
 end

data/lib/alexandria/book_providers/z3950_provider.rb

@@ -5,7 +5,7 @@
 # See the file README.md for authorship and licensing information.
 
 require "zoom"
-require "alexandria/book_providers/pseudomarc"
+require "alexandria/pseudo_marc_parser"
 require "marc"
 
 module Alexandria

data/lib/alexandria/console.rb

@@ -5,14 +5,14 @@
 # See the file README.md for authorship and licensing information.
 
 module Alexandria
-  def self.list_books_on_console(_title = true, authors = true)
+  def self.list_books_on_console
     collection = Alexandria::LibraryCollection.instance
     collection.reload
     libraries = collection.all_regular_libraries
     output_string = ""
     @books = libraries.flatten
     @books.each do |book|
-      book_authors = book.authors.join(" & ") if authors
+      book_authors = book.authors.join(" & ")
       output_string += [book.title, book_authors].join(", ") + "\n"
     end
     output_string

data/lib/alexandria/export_library.rb

@@ -73,7 +73,7 @@ module Alexandria
     end
 
     def export_as_html(filename, theme)
-      FileUtils.mkdir(filename) unless File.exist?(filename)
+      FileUtils.mkdir_p(filename)
       Dir.chdir(filename) do
         copy_covers("pixmaps")
         FileUtils.cp_r(theme.pixmaps_directory, "pixmaps") if theme.has_pixmaps?
@@ -91,7 +91,7 @@ module Alexandria
     end
 
     def export_as_ipod_notes(filename, _theme)
-      FileUtils.mkdir(filename) unless File.exist?(filename)
+      FileUtils.mkdir_p(filename)
       tempdir = Dir.getwd
       Dir.chdir(filename)
       copy_covers("pixmaps")
@@ -211,8 +211,8 @@ module Alexandria
       doc = REXML::Document.new
       doc << REXML::XMLDecl.new
       doc << REXML::DocType.new("tellico",
-                                'PUBLIC "-//Robby Stephenson/DTD Tellico V7.0//EN"' \
-                                ' "http://periapsis.org/tellico/dtd/v7/tellico.dtd"')
+                                'PUBLIC "-//Robby Stephenson/DTD Tellico V7.0//EN" ' \
+                                '"http://periapsis.org/tellico/dtd/v7/tellico.dtd"')
       tellico = doc.add_element("tellico")
       tellico.add_attribute("syntaxVersion", "7")
       tellico.add_namespace("http://periapsis.org/tellico/")

data/lib/alexandria/import_library.rb

@@ -72,7 +72,7 @@ module Alexandria
       return nil unless system("unzip -qqt \"#{filename}\"")
 
       tmpdir = File.join(Dir.tmpdir, "tellico_export")
-      FileUtils.rm_rf(tmpdir) if File.exist?(tmpdir)
+      FileUtils.rm_rf(tmpdir)
       Dir.mkdir(tmpdir)
       Dir.chdir(tmpdir) do
         system("unzip -qq \"#{filename}\"")

data/lib/alexandria/library_store.rb

@@ -43,7 +43,7 @@ module Alexandria
       test = [0, nil]
       ruined_books = []
       library = Library.new(name, self)
-      FileUtils.mkdir_p(library.path) unless File.exist?(library.path)
+      FileUtils.mkdir_p(library.path)
       Dir.chdir(library.path) do
         Dir["*" + Library::EXT[:book]].sort.each do |filename|
           test[1] = filename if (test[0]).zero?

data/lib/alexandria/models/library.rb

@@ -20,7 +20,7 @@ module Alexandria
     attr_reader :name
     attr_accessor :ruined_books, :updating, :deleted_books
 
-    DEFAULT_DIR = File.join(ENV["HOME"], ".alexandria")
+    DEFAULT_DIR = File.join(Dir.home, ".alexandria")
     EXT = { book: ".yaml", cover: ".cover" }.freeze
 
     include GetText
@@ -379,7 +379,7 @@ module Alexandria
     end
 
     def copy_covers(somewhere)
-      FileUtils.rm_rf(somewhere) if File.exist?(somewhere)
+      FileUtils.rm_rf(somewhere)
       FileUtils.mkdir(somewhere)
       each do |book|
         next unless File.exist?(cover(book))

data/lib/alexandria/{book_providers/pseudomarc.rb → pseudo_marc_parser.rb}

@@ -124,7 +124,7 @@ module Alexandria
 
     def self.marc_text_to_details(marc)
       details = {}
-      marc.each_line do |line|
+      marc&.each_line do |line|
         if line =~ /(\d+)\s*(.+)/
           code = Regexp.last_match[1]
           data = Regexp.last_match[2]

data/lib/alexandria/smart_library.rb

@@ -148,7 +148,7 @@ module Alexandria
       if book
         @cache[book].save(book)
       else
-        FileUtils.mkdir_p(base_dir) unless File.exist? base_dir
+        FileUtils.mkdir_p(base_dir)
         File.open(yaml, "w") { |io| io.puts to_hash.to_yaml }
       end
     end
@@ -162,7 +162,7 @@ module Alexandria
     end
 
     def copy_covers(somewhere)
-      FileUtils.rm_rf(somewhere) if File.exist?(somewhere)
+      FileUtils.rm_rf(somewhere)
       FileUtils.mkdir(somewhere)
       each do |book|
         library = @cache[book]

data/lib/alexandria/ui/alert_dialog.rb

@@ -34,6 +34,8 @@ module Alexandria
         @dialog.child.pack_start(hbox)
       end
 
+      attr_reader :dialog
+
       def show_all
         dialog.show_all
       end
@@ -52,8 +54,6 @@ module Alexandria
 
       private
 
-      attr_reader :dialog
-
       def make_label(markup)
         label = Gtk::Label.new
         label.set_alignment(0, 0)

data/lib/alexandria/ui/book_properties_dialog_base.rb

@@ -151,7 +151,7 @@ module Alexandria
 
       def want_toggled; end
 
-      @@latest_filechooser_directory = ENV["HOME"]
+      @@latest_filechooser_directory = Dir.home
       def on_change_cover
         dialog = Gtk::FileChooserDialog.new(title: _("Select a cover image"),
                                             parent: @book_properties_dialog,
@@ -177,8 +177,8 @@ module Alexandria
               FileUtils.cp(dialog.filename, "#{@cover_file}.orig")
               new_width = cover.width / (cover.height / COVER_ABSOLUTE_MAXHEIGHT.to_f)
               log.info do
-                "Scaling large cover image to" \
-                  " #{new_width.to_i} x #{COVER_ABSOLUTE_MAXHEIGHT}"
+                "Scaling large cover image to " \
+                  "#{new_width.to_i} x #{COVER_ABSOLUTE_MAXHEIGHT}"
               end
               cover = cover.scale(new_width.to_i, COVER_ABSOLUTE_MAXHEIGHT)
               cover.save(@cover_file, "jpeg")

data/lib/alexandria/ui/icons.rb

@@ -35,8 +35,8 @@ module Alexandria
           return GdkPixbuf::Pixbuf.new(file: filename) if File.exist?(filename)
         rescue GdkPixbuf::PixbufError
           log.error do
-            "Failed to load GdkPixbuf::Pixbuf," \
-              " please ensure that #{filename} is a valid image file"
+            "Failed to load GdkPixbuf::Pixbuf, " \
+              "please ensure that #{filename} is a valid image file"
           end
         end
         BOOK_ICON

data/lib/alexandria/ui/init.rb

@@ -25,22 +25,28 @@ class Gtk::ActionGroup
 end
 
 module Alexandria::UI::FreezeThaw
+  def self.included(base)
+    base.class_eval do
+      attr_accessor :old_model
+    end
+  end
+
   def frozen?
-    @old_model && !model
+    old_model && !model
   end
 
   def freeze
     return if frozen?
 
-    @old_model = model
+    self.old_model = model
     self.model = nil
   end
 
   def unfreeze
     return unless frozen?
 
-    self.model = @old_model
-    @old_model = nil
+    self.model = old_model
+    self.old_model = nil
   end
 end
 

data/lib/alexandria/ui/ui_manager.rb

@@ -609,8 +609,8 @@ module Alexandria
 
       def handle_ruined_books
         new_message = _(
-          "The data files for the following books are malformed or empty. Do you wish to" \
-          " attempt to download new information for them from the online book providers?\n")
+          "The data files for the following books are malformed or empty. Do you wish to " \
+          "attempt to download new information for them from the online book providers?\n")
 
         @libraries.ruined_books.each do |bi|
           new_message += "\n#{bi[1] || bi[1].inspect}"
@@ -654,8 +654,8 @@ module Alexandria
                   end
 
                   log.debug do
-                    "Trying to add #{book.title}, #{cover_uri}" \
-                      " in library ''#{library.name}'"
+                    "Trying to add #{book.title}, #{cover_uri} " \
+                      "in library ''#{library.name}'"
                   end
                   library.save_cover(book, cover_uri) unless cover_uri.nil?
                   library << book

data/lib/alexandria/version.rb

@@ -5,7 +5,7 @@
 # See the file README.md for authorship and licensing information.
 
 module Alexandria
-  VERSION = "0.7.9"
+  VERSION = "0.7.10"
   DATA_VERSION = "0.6.3"
   DISPLAY_VERSION = VERSION
 end

data/lib/alexandria/web_themes.rb

@@ -39,7 +39,7 @@ module Alexandria
         File.join(Alexandria::Config::DATA_DIR, "web-themes"),
 
         # User dir
-        File.join(ENV["HOME"], ".alexandria", ".web-themes")
+        File.join(Dir.home, ".alexandria", ".web-themes")
       ]
       themes_dir.map { |x| load(x) }.flatten
     end

data/lib/alexandria.rb

@@ -21,10 +21,11 @@ require "alexandria/logging"
 require "alexandria/about"
 
 module Alexandria
-  def self.set_proxy
-    if !ENV["http_proxy"].nil? && URI.parse(ENV["http_proxy"]).userinfo.nil?
-      ENV["http_proxy"] = nil
-    end
+  def self.clear_invalid_proxy
+    current_proxy = ENV.fetch("http_proxy", nil)
+    return if current_proxy.nil?
+
+    ENV["http_proxy"] = nil if URI.parse(current_proxy).userinfo.nil?
   end
 
   def self.set_log_level
@@ -33,7 +34,7 @@ module Alexandria
   end
 
   def self.main
-    set_proxy
+    clear_invalid_proxy
     set_log_level
     Alexandria::UI.main
   end

data/spec/alexandria/book_providers/bl_provider_spec.rb

@@ -8,6 +8,6 @@ require "spec_helper"
 
 describe Alexandria::BookProviders::BLProvider do
   it "works" do
-    assert_correct_search_result(described_class, "9781853260803")
+    expect(described_class).to have_correct_search_result_for "9781853260803"
   end
 end

data/spec/alexandria/book_providers/loc_provider_spec.rb

@@ -8,10 +8,10 @@ require "spec_helper"
 
 describe Alexandria::BookProviders::LOCProvider do
   it "works for a book with ASCII title" do
-    assert_correct_search_result(described_class, "9780805335583")
+    expect(described_class).to have_correct_search_result_for "9780805335583"
   end
 
   it "works for a book with a title with non-ASCII letters" do
-    assert_correct_search_result(described_class, "9782070379248")
+    expect(described_class).to have_correct_search_result_for "9782070379248"
   end
 end

data/spec/alexandria/book_providers/sbn_provider_spec.rb

@@ -8,6 +8,6 @@ require "spec_helper"
 
 describe Alexandria::BookProviders::SBNProvider do
   it "works" do
-    assert_correct_search_result(described_class, "9788835926436")
+    expect(described_class).to have_correct_search_result_for "9788835926436"
   end
 end

data/spec/alexandria/book_providers/thalia_provider_spec.rb

@@ -114,6 +114,6 @@ RSpec.describe Alexandria::BookProviders::ThaliaProvider do
     stub_request(:get, "https://www.thalia.de/shop/home/artikeldetails/ID134292338.html")
       .to_return(status: 200, body: normal_people_details, headers: {})
 
-    assert_correct_search_result(described_class, "9780571334650")
+    expect(described_class).to have_correct_search_result_for "9780571334650"
   end
 end

data/spec/alexandria/book_providers/world_cat_provider_spec.rb

@@ -139,22 +139,34 @@ RSpec.describe Alexandria::BookProviders::WorldCatProvider do
                  "sky-catalogue-20000-ed-by-alan-hirshfeld-and-roger-w-sinnott" \
                  "/oclc/476534140&referer=brief_results")
       .to_return(status: 200, body: +sky_catalog_details, headers: {})
-    assert_correct_search_result(described_class, "9780521247108")
+    expect(described_class).to have_correct_search_result_for "9780521247108"
   end
 
   it "works with vernacular" do
     stub_request(:get, "https://www.worldcat.org/search?q=isbn:9785941454136&qt=advanced")
       .to_return(status: 200, body: +florence_ru_details, headers: {})
-    assert_correct_search_result(described_class, "9785941454136")
+    expect(described_class).to have_correct_search_result_for "9785941454136"
   end
 
-  it "works with multiple authors" do
-    stub_request(:get, "https://www.worldcat.org/search?q=isbn:9785941454136&qt=advanced")
-      .to_return(status: 200, body: +florence_ru_details, headers: {})
-    results = assert_correct_search_result(described_class,
-                                           "9785941454136")
-    this_book = results.first
-    expect(this_book.authors).to be_instance_of(Array), "Not an array!"
-    expect(this_book.authors.length).to eq(2), "Wrong number of authors for this book!"
+  context "when book has multiple authors" do
+    let(:search_result) do
+      described_class.instance.search("9785941454136",
+                                      Alexandria::BookProviders::SEARCH_BY_ISBN)
+    rescue SocketError
+      skip "Service is offline"
+    end
+
+    before do
+      stub_request(:get, "https://www.worldcat.org/search?q=isbn:9785941454136&qt=advanced")
+        .to_return(status: 200, body: +florence_ru_details, headers: {})
+    end
+
+    it "returns all authors" do
+      this_book, = search_result
+      aggregate_failures do
+        expect(this_book.authors).to be_instance_of(Array), "Not an array!"
+        expect(this_book.authors.length).to eq(2), "Wrong number of authors for this book!"
+      end
+    end
   end
 end

data/spec/alexandria/book_spec.rb

@@ -22,16 +22,18 @@ require "spec_helper"
 
 describe Alexandria::Book do
   it "is a thing" do
-    an_artist_of_the_floating_world
+    expect(an_artist_of_the_floating_world).to be_a described_class
   end
 
   it "establishes equality only with books with the same identity" do
     book = an_artist_of_the_floating_world
     same_book = an_artist_of_the_floating_world
-    expect(same_book).to eq book
     different_book = an_artist_of_the_floating_world
     different_book.isbn = "9780571147999"
-    expect(different_book).not_to eq book
+    aggregate_failures do
+      expect(same_book).to eq book
+      expect(different_book).not_to eq book
+    end
   end
 
   describe "#rating" do