alexandria-book-collection-manager 0.7.7 → 0.7.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88a834cc5346bc0704749533797d91e6ff2a04c372e066fe9f91ca239baa63f1
-  data.tar.gz: 4a68efa9e12431f6ea356325b4bcee4a702a7f1f49710860a399657866c158e6
+  metadata.gz: 86ff53adf7e1792c32534b149370ab80a99a24c8a363273a1ca3d3f83e2c73c0
+  data.tar.gz: 6a38d050f6cf13a9d86e0c387cdbe472442a02c33f74563f4902f4338deac228
 SHA512:
-  metadata.gz: 213ed219cd387370ff664b32b108aff3e6655e07579962f436f013616e02e423ef17afb6ed6bc6f036d2c5de863a9b51f8c5d5de5e8f33b9a51a0dff6522da61
-  data.tar.gz: c6440f573914defb43a7a9f451a4cf5e9091275039137c4dabd02d2290c72e87a17d35f62db08f7669d1a66f51ea53e5ef1b1e170cdd3beea237df1d3a1f5dd4
+  metadata.gz: fbd36ea7f9caaabff7979e3ab57471e27a6a1a5daa33ce140d4a8df590b07d91f4302267db64c601281f3513401e5726a1874dba622a4d9e72a361c7898c1284
+  data.tar.gz: 87c17e9d9bc4c4bd057a1013068d034a48ca38e3fcd5784a743a1c1d971671165df4347bcb2aa710dd4a636ecc3d1bfdbee1f0bfe7a4eb7fccd7d4fb8acddd77

data/.rubocop_todo.yml

@@ -21,7 +21,7 @@ Metrics/BlockNesting:
 
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 990
+  Max: 997
 
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
@@ -125,7 +125,6 @@ Style/OptionalBooleanParameter:
     - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/book_providers/barnes_and_noble.rb'
     - 'lib/alexandria/book_providers/siciliano.rb'
-    - 'lib/alexandria/book_providers/thalia.rb'
     - 'lib/alexandria/book_providers/worldcat.rb'
     - 'lib/alexandria/console.rb'
     - 'lib/alexandria/execution_queue.rb'

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.7.8 / 2020-11-29
+
+* Fix ThaliaProvider
+* Avoid warnings for calendar popup
+* Make Rename menu item work
+* Fix crash when changing covers
+* Make alerts show alert details if available
+
 ## 0.7.7 / 2020-11-15
 
 * Update Polish translation ([#88] by [Piotr Drąg][piotrdrag])

data/alexandria-book-collection-manager.gemspec

@@ -54,13 +54,13 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency("psych", ["~> 3.2.0"])
   s.add_runtime_dependency("zoom", ["~> 0.5.0"])
 
-  s.add_development_dependency("gnome_app_driver", ["~> 0.2.1"])
+  s.add_development_dependency("gnome_app_driver", "~> 0.3.0")
   s.add_development_dependency("minitest", ["~> 5.0"])
   s.add_development_dependency("rake", ["~> 13.0"])
   s.add_development_dependency("rspec", ["~> 3.0"])
   s.add_development_dependency("rubocop", "~> 0.93.1")
   s.add_development_dependency("rubocop-i18n", ["~> 2.0.2"])
-  s.add_development_dependency("rubocop-performance", ["~> 1.8.0"])
+  s.add_development_dependency("rubocop-performance", "~> 1.9.0")
   s.add_development_dependency("rubocop-rspec", "~> 1.44.1")
   s.add_development_dependency("webmock", "~> 3.9")
 

data/lib/alexandria/book_providers.rb

@@ -299,7 +299,7 @@ module Alexandria
     require "alexandria/book_providers/barnes_and_noble"
     require "alexandria/book_providers/proxis"
     require "alexandria/book_providers/siciliano"
-    require "alexandria/book_providers/thalia"
+    require "alexandria/book_providers/thalia_provider"
     require "alexandria/book_providers/worldcat"
 
     # Z39.50 based providers

data/lib/alexandria/book_providers/{thalia.rb → thalia_provider.rb}

@@ -1,27 +1,13 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2009 Cathal Mc Ginley
-# Copyright (C) 2014 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
 # http://de.wikipedia.org/wiki/Thalia_%28Buchhandel%29
 # Thalia.de bought the Austrian book trade chain Amadeus
 
-# New Tlalia provider, taken from Palatina MetaDataSource and modified
+# New Thalia provider, taken from Palatina MetaDataSource and modified
 # for Alexandria. (21 Dec 2009)
 
 require "net/http"
@@ -33,7 +19,7 @@ module Alexandria
     class ThaliaProvider < WebsiteBasedProvider
       include Logging
 
-      SITE = "http://www.thalia.de"
+      SITE = "https://www.thalia.de"
       BASE_SEARCH_URL = "#{SITE}/shop/bde_bu_hg_startseite/suche/?%s=%s" # type,term
 
       def initialize
@@ -80,40 +66,36 @@ module Alexandria
       def parse_search_result_data(html)
         doc = html_to_doc(html)
         book_search_results = []
-        results_divs = doc / "div.articlePresentationSearchCH"
-        results_divs.each do |div|
+
+        results_items = doc / "ul.weitere-formate li.format"
+
+        results_items.each do |item|
           result = {}
-          title_link = div % "div.articleText/h2/a"
-          result[:title] = title_link.inner_html
-          result[:lookup_url] = title_link["href"]
+          item_link = item % "a"
+          result[:lookup_url] = "#{SITE}#{item_link['href']}"
           book_search_results << result
         end
         book_search_results
       end
 
       def data_from_label(node, label_text)
-        label_node = node % "strong[text()*='#{label_text}']"
-        if (item_node = label_node.parent)
-          data = ""
-          item_node.children.each do |n|
-            data += n.to_html if n.text?
-          end
-          data.strip
-        else
-          ""
-        end
+        label_node = node % "th[text()*='#{label_text}']"
+        return "" unless label_node
+
+        item_node = label_node.parent % "td"
+        item_node.inner_text.strip
       end
 
       def get_book_from_search_result(result)
         log.debug { "Fetching book from #{result[:lookup_url]}" }
         html_data = transport.get_response(URI.parse(result[:lookup_url]))
-        parse_result_data(html_data.body, "noisbn", true)
+        parse_result_data(html_data.body, "noisbn", recursing: true)
       end
 
-      def parse_result_data(html, isbn, recursing = false)
+      def parse_result_data(html, isbn, recursing: false)
         doc = html_to_doc(html)
 
-        results_divs = doc / "div.articlePresentationSearchCH"
+        results_divs = doc / "ul.weitere-formate"
         unless results_divs.empty?
           if recursing
             # already recursing, avoid doing so endlessly second time
@@ -122,66 +104,48 @@ module Alexandria
             return
           end
 
-          # ISBN-lookup results in multiple results (trying to be
-          # useful, such as for new editions e.g. 9780974514055
-          # "Programming Ruby" )
+          # ISBN-lookup results in multiple results
           results = parse_search_result_data(html)
-          isbn10 = Library.canonicalise_isbn(isbn)
-          # e.g. .../dave_thomas/ISBN0-9745140-5-5/ID6017044.html
           chosen = results.first # fallback!
-          results.each do |rslt|
-            if rslt[:lookup_url] =~ %r{/ISBN(\d+[\d-]*)/} &&
-                (Regexp.last_match[1].delete("-") == isbn10)
-              chosen = rslt
-              break
-            end
-          end
           html_data = transport.get_response(URI.parse(chosen[:lookup_url]))
-          return parse_result_data(html_data.body, isbn, true)
+          return parse_result_data(html_data.body, isbn, recursing: true)
         end
 
         begin
-          if (div = doc % "div#contentFull")
-            title_img = ((div % :h2) / :img).first
-            title = title_img["alt"]
-
-            # note, the following img also has alt="von Author, Author..."
+          if (div = doc % "section#sbe-product-details")
+            title = div["data-titel"]
 
-            if (author_h = doc % 'h3[text()*="Mehr von"]') # "More from..." links
+            if (author_p = doc % "p.aim-author")
               authors = []
-              author_links = author_h.parent / :a
+              author_links = author_p / :a
               author_links.each do |a|
-                if a["href"].include? "BUCH/sa"
-                  # 'sa' means search author, there may also be 'ssw' (search keyword) links
-                  authors << a.inner_text[0..-2].strip
-                  # NOTE stripping the little >> character here...
-                end
+                authors << a.inner_text.strip
               end
             end
 
-            item_details = doc % "ul.itemDataList"
+            item_details = doc % "section.artikeldetails"
             isbns = []
             isbns << data_from_label(item_details, "EAN")
             isbns << data_from_label(item_details, "ISBN")
+            isbns.reject!(&:empty?)
 
             year = nil
-            date = data_from_label(item_details, "Erschienen:")
+            date = data_from_label(item_details, "Erscheinungsdatum")
             year = Regexp.last_match[1].to_i if date =~ /(\d{4})/
 
-            binding = data_from_label(item_details, "Einband")
+            book_binding = data_from_label(item_details, "Einband")
 
-            publisher = data_from_label(item_details, "Erschienen bei:")
+            publisher = data_from_label(item_details, "Verlag")
 
             book = Book.new(title, authors, isbns.first,
-                            publisher, year, binding)
+                            publisher, year, book_binding)
 
             image_url = nil
-            if (image_link = doc % "a[@id=itemPicStart]")
-              image_url = image_link["href"]
+            if (image = doc % "section.imagesPreview img")
+              image_url = image["src"]
             end
 
             [book, image_url]
-
           end
         rescue StandardError => ex
           trace = ex.backtrace.join("\n> ")

data/lib/alexandria/logging.rb

@@ -31,7 +31,7 @@ module Alexandria
       return super(severity, message, progname, &block) if source.nil?
 
       category = self.class.category(source)
-      return super(severity, progname, category) unless block_given?
+      return super(severity, progname, category) unless block
 
       category = "#{category} #{progname}" if progname
       super(severity, message, category, &block)

data/lib/alexandria/ui/alert_dialog.rb

@@ -4,6 +4,8 @@
 #
 # See the file README.md for authorship and licensing information.
 
+require "cgi"
+
 module Alexandria
   module UI
     class AlertDialog
@@ -26,7 +28,7 @@ module Alexandria
         vbox = Gtk::Box.new(:vertical, 6)
         vbox.homogeneous = false
         vbox.pack_start make_label("<b><big>#{title}</big></b>")
-        vbox.pack_start make_label(message.strip) unless message
+        vbox.pack_start make_label CGI.escapeHTML(message.strip) if message
         hbox.pack_start(vbox)
 
         @dialog.child.pack_start(hbox)

data/lib/alexandria/ui/book_properties_dialog.rb

@@ -9,7 +9,6 @@ require "alexandria/ui/error_dialog"
 module Alexandria
   module UI
     class BookPropertiesDialog < BookPropertiesDialogBase
-      include Logging
       include GetText
       extend GetText
       GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")

data/lib/alexandria/ui/book_properties_dialog_base.rb

@@ -12,6 +12,7 @@ module Alexandria
   module UI
     class BookPropertiesDialogBase < BuilderBase
       include CalendarPopup
+      include Logging
       include GetText
       extend GetText
       GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
@@ -156,14 +157,12 @@ module Alexandria
 
       @@latest_filechooser_directory = ENV["HOME"]
       def on_change_cover
-        backend = `uname`.chomp == "FreeBSD" ? "neant" : "gnome-vfs"
-        dialog = Gtk::FileChooserDialog.new(_("Select a cover image"),
-                                            @book_properties_dialog,
-                                            Gtk::FileChooser::ACTION_OPEN,
-                                            backend,
-                                            [_("No Cover"), Gtk::ResponseType::REJECT],
-                                            [Gtk::Stock::CANCEL, Gtk::ResponseType::CANCEL],
-                                            [Gtk::Stock::OPEN, Gtk::ResponseType::ACCEPT])
+        dialog = Gtk::FileChooserDialog.new(title: _("Select a cover image"),
+                                            parent: @book_properties_dialog,
+                                            action: :open,
+                                            buttons: [[_("No Cover"), :reject],
+                                                      [Gtk::Stock::CANCEL, :cancel],
+                                                      [Gtk::Stock::OPEN, :accept]])
         dialog.current_folder = @@latest_filechooser_directory
         response = dialog.run
         case response

data/lib/alexandria/ui/callbacks.rb

@@ -201,9 +201,9 @@ module Alexandria
 
       def on_rename(*)
         iter = @library_listview.selection.selected
-        @library_listview.set_cursor(iter.path,
-                                     @library_listview.get_column(0),
-                                     true)
+        column = @library_listview.get_column(0)
+        cell = column.cells.last
+        @library_listview.set_cursor_on_cell(iter.path, column, cell, true)
       end
 
       def on_delete(*)

data/lib/alexandria/ui/init.rb

@@ -24,28 +24,29 @@ class Gtk::ActionGroup
   end
 end
 
-class Gtk::IconView
-  def freeze
-    @old_model = model
-    self.model = nil
+module Alexandria::UI::FreezeThaw
+  def frozen?
+    @old_model && !model
   end
 
-  def unfreeze
-    self.model = @old_model
-  end
-end
-
-class Gtk::TreeView
   def freeze
+    return if frozen?
+
     @old_model = model
     self.model = nil
   end
 
   def unfreeze
+    return unless frozen?
+
     self.model = @old_model
+    @old_model = nil
   end
 end
 
+Gtk::IconView.include Alexandria::UI::FreezeThaw
+Gtk::TreeView.include Alexandria::UI::FreezeThaw
+
 class Alexandria::Library
   def action_name
     "MoveIn" + name.gsub(/\s/, "")

data/lib/alexandria/ui/sidepane_manager.rb

@@ -108,7 +108,9 @@ module Alexandria
           cell.editable = iter[2]
           # log.debug { "exit sidepane: editable #{cell}, #{iter}" }
         end
-        renderer.signal_connect("edited", &method(:on_edited_library))
+        renderer.signal_connect("edited") do |cell, path_string, new_text|
+          on_edited_library(cell, path_string, new_text)
+        end
         @library_listview.append_column(column)
 
         @library_listview.set_row_separator_func do |model, iter|

data/lib/alexandria/ui/ui_manager.rb

@@ -123,7 +123,9 @@ module Alexandria
 
       def setup_toolbar_filter_entry
         @filter_entry = Gtk::Entry.new
-        @filter_entry.signal_connect("changed", &method(:on_toolbar_filter_entry_changed))
+        @filter_entry.signal_connect("changed") do |entry|
+          on_toolbar_filter_entry_changed(entry)
+        end
         @toolitem = Gtk::ToolItem.new
         @toolitem.expand = true
         @toolitem.border_width = 5
@@ -149,7 +151,7 @@ module Alexandria
           cb.append_text(item)
         end
         cb.active = 0
-        cb.signal_connect("changed", &method(:on_criterion_combobox_changed))
+        cb.signal_connect("changed") { |combo| on_criterion_combobox_changed(combo) }
 
         # Put the combo box in a event box because it is not currently
         # possible assign a tooltip to a combo box.
@@ -167,8 +169,9 @@ module Alexandria
         @toolbar_view_as.append_text(_("View as Icons"))
         @toolbar_view_as.append_text(_("View as List"))
         @toolbar_view_as.active = 0
-        @toolbar_view_as_signal_hid = \
-          @toolbar_view_as.signal_connect("changed", &method(:on_toolbar_view_as_changed))
+        @toolbar_view_as_signal_hid = @toolbar_view_as.signal_connect("changed") do |combo|
+          on_toolbar_view_as_changed(combo)
+        end
 
         # Put the combo box in a event box because it is not currently
         # possible assign a tooltip to a combo box.
@@ -226,8 +229,12 @@ module Alexandria
 
       def setup_window_events
         log.debug { "setup_window_events" }
-        @main_app.signal_connect("window-state-event", &method(:on_window_state_event))
-        @main_app.signal_connect("destroy", &method(:on_window_destroy))
+        @main_app.signal_connect("window-state-event") do |window, event|
+          on_window_state_event(window, event)
+        end
+        @main_app.signal_connect("destroy") do |window|
+          on_window_destroy(window)
+        end
       end
 
       def setup_active_model
@@ -343,7 +350,7 @@ module Alexandria
           sensitize_library selected_library if library_already_selected
 
           GLib::Idle.add do
-            menu.popup(nil, nil, event.button, event.time)
+            menu.popup_at_pointer(event)
             false
           end
 
@@ -391,7 +398,7 @@ module Alexandria
         end
 
         menu = selected_books.empty? ? @nobook_popup : @book_popup
-        menu.popup(nil, nil, event.button, event.time)
+        menu.popup_at_pointer(event)
       end
 
       def get_library_selection_text(library)

data/lib/alexandria/version.rb

@@ -5,7 +5,7 @@
 # See the file README.md for authorship and licensing information.
 
 module Alexandria
-  VERSION = "0.7.7"
+  VERSION = "0.7.8"
   DATA_VERSION = "0.6.3"
-  DISPLAY_VERSION = "0.7.7"
+  DISPLAY_VERSION = VERSION
 end

data/spec/alexandria/book_providers/thalia_provider_spec.rb

@@ -0,0 +1,119 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "spec_helper"
+
+RSpec.describe Alexandria::BookProviders::ThaliaProvider do
+  let(:normal_people_main) do
+    +<<~HTML
+      <!DOCTYPE html>
+      <html lang="de" data-environment="prod">
+        <head>
+          <title>Artikel von 0571334652 ansehen | Thalia</title>
+        </head>
+        <body data-mandant="2" data-version="20201112100740_528b0df" data-environment="prod">
+          <main class="suche-grid--main nur-suchergebnis">
+            <section class="suchergebnis">
+              <ul class="suchergebnis-liste no-bullets">
+                <li class="suchergebnis" data-seite="1"
+                                         data-ean="9780571334650"
+                                         data-id="134292338"
+                                         data-preis="9.49"
+                                         data-preis-reduziert="false"
+                                         data-alterpreis="">
+                  <a href="/shop/home/artikeldetails/ID134292338.html" class="layered-link">Normal People von Sally Rooney</a>
+
+                  <ul class="weitere-formate no-bullets" impression="product-variant">
+                    <li class="format aktiv">
+                      <a href="/shop/home/artikeldetails/ID134292338.html">Buch (Taschenbuch)</a>
+                    </li>
+                    <li class="format">
+                      <a href="/shop/home/artikeldetails/ID95227195.html">Weitere: Buch (Taschenbuch)</a>
+                    </li>
+                  </ul>
+                </li>
+              </ul>
+            </section>
+          </main>
+        </body>
+      </html>
+    HTML
+  end
+  let(:normal_people_details) do
+    +<<~HTML
+      <!DOCTYPE html>
+      <html class="no-js" id="ID-2" lang="de">
+        <head>
+          <title>Normal People von Sally Rooney - Taschenbuch - 978-0-571-33465-0 | Thalia</title>
+        </head>
+        <body>
+          <section class="artikel-medien imagesPreview">
+            <img src="https://assets.thalia.media/img/artikel/ae9934c90f2c7d595146807ea6253c99532043ec-00-00.jpeg" class='largeImg'>
+          </section>
+
+          <section class="artikel-infos" id="sbe-product-details"
+                                         data-shopid="2"
+                                         data-id="A1051452169"
+                                         data-id-alt="134292338"
+                                         data-titel="Normal People"
+                                         data-verfuegbarkeit="Sofort lieferbar"
+                                         data-preis-netto="9.02"
+                                         data-preis-brutto="9.49"
+                                         data-ean="9780571334650"
+                                         data-reduziert="false"
+                                         data-waehrung="EUR"
+                                         data-preis-liste="9.49"
+                                         data-hersteller="Faber &amp; Faber"
+                                         data-form="Taschenbuch"
+                                         data-verkaufsrang="5"
+                                         data-anzahlbewertungen="19"
+                                         data-durchschnittsbewertung="4.5"
+                                         data-preisbindung="false"
+                                         data-mandant="2"
+                                         data-environment="prod"
+                                         component="artikeldetails-produktdetails">
+
+            <h1 class="ncTitle">
+              Normal People
+            </h1>
+
+            <p class="aim-author">
+            <a href="https://www.thalia.de/shop/home/mehr-von-suche/ANY/sp/suche.html?mehrVon=Sally%20Rooney" interaction="autor-klick">Sally Rooney</a>
+            </p>
+          </section>
+
+          <section class="artikeldetails">
+            <table>
+              <tr> <th> Einband </th> <td> Taschenbuch </td> </tr>
+              <tr> <th> Erscheinungsdatum </th> <td> 02.05.2019 </td> </tr>
+              <tr> <th> ISBN </th> <td> 978-0-571-33465-0 </td> </tr>
+            </table>
+            <table>
+              <tr>
+                <th> Verlag </th>
+                <td>
+                  <a href="https://www.thalia.de/shop/home/mehr-von-suche/ANY/sv/suche.html?mehrVon=Faber%20%26%20Faber" interaction="auswahl">
+                    Faber &amp; Faber
+                  </a>
+                </td>
+              </tr>
+            </table>
+          </section>
+        </body>
+      </html>
+    HTML
+  end
+
+  it "works when searching by ISBN" do
+    stub_request(:get,
+                 "https://www.thalia.de/shop/bde_bu_hg_startseite/suche/?sq=0571334652")
+      .to_return(status: 200, body: normal_people_main, headers: {})
+    stub_request(:get, "https://www.thalia.de/shop/home/artikeldetails/ID134292338.html")
+      .to_return(status: 200, body: normal_people_details, headers: {})
+
+    assert_correct_search_result(described_class, "9780571334650")
+  end
+end

data/spec/alexandria/book_providers_spec.rb

@@ -76,23 +76,6 @@ describe Alexandria::BookProviders do
     end
   end
 
-  describe Alexandria::BookProviders::ThaliaProvider do
-    before do
-      skip "Needs fixing"
-    end
-
-    it "works" do
-      # german book
-      assert_correct_search_result(described_class, "9783896673305")
-      # international book
-      assert_correct_search_result(described_class, "9780440241904")
-      # movie dvd
-      assert_correct_search_result(described_class, "4010232037824")
-      # music cd
-      assert_correct_search_result(described_class, "0094638203520")
-    end
-  end
-
   describe Alexandria::BookProviders::AdLibrisProvider do
     it "works" do
       skip "Needs fixing: site has changed"

data/spec/alexandria/ui/book_properties_dialog_spec.rb

@@ -7,11 +7,53 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::BookPropertiesDialog do
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) do
+    store = Alexandria::LibraryCollection.instance.library_store
+    store.load_library("Bar Library")
+  end
+  let(:book) do
+    Alexandria::Book.new("Foo Book", ["Jane Doe"], "98765432", "Bar Publisher",
+                         1972, "edition")
+  end
+
+  before do
+    library << book
+  end
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    library = instance_double(Alexandria::Library, name: "Bar Library", cover: "")
-    book = Alexandria::Book.new("Foo Book", ["Jane Doe"], "98765432", "Bar Publisher",
-                                1972, "edition")
     described_class.new parent, library, book
   end
+
+  describe "#on_change_cover" do
+    let(:dialog) { described_class.new parent, library, book }
+    let(:filechooser) { instance_double(Gtk::FileChooserDialog).as_null_object }
+
+    before do
+      allow(Gtk::FileChooserDialog).to receive(:new).and_return(filechooser)
+      allow(filechooser).to receive(:filename)
+        .and_return File.join(__dir__, "../../fixtures/cover.jpg")
+    end
+
+    it "works when response is accept" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is reject" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::REJECT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is cancel" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+
+      dialog.on_change_cover
+    end
+  end
 end

data/spec/alexandria/ui/new_book_dialog_manual_spec.rb

@@ -7,9 +7,45 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::NewBookDialogManual do
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) do
+    store = Alexandria::LibraryCollection.instance.library_store
+    store.load_library("Bar Library")
+  end
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    library = instance_double(Alexandria::Library)
     described_class.new parent, library
   end
+
+  describe "#on_change_cover" do
+    let(:dialog) { described_class.new parent, library }
+    let(:filechooser) { instance_double(Gtk::FileChooserDialog).as_null_object }
+
+    before do
+      allow(Gtk::FileChooserDialog).to receive(:new).and_return(filechooser)
+      allow(filechooser).to receive(:filename)
+        .and_return File.join(__dir__, "../../fixtures/cover.jpg")
+    end
+
+    it "works when response is accept" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is reject" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::REJECT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is cancel" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+
+      dialog.on_change_cover
+    end
+  end
 end

data/spec/alexandria/ui/ui_manager_spec.rb

@@ -39,6 +39,7 @@ describe Alexandria::UI::UIManager do
       # FIXME: This is needed because right now UIManager#refresh_books doesn't
       # work without Gtk loop.
       regular_library.each { |book| ui.append_book book }
+      # This makes the iconview model re-appear
       ui.iconview.unfreeze
       expect(ui.model.iter_n_children).to eq regular_library.count
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alexandria-book-collection-manager
 version: !ruby/object:Gem::Version
-  version: 0.7.7
+  version: 0.7.8
 platform: ruby
 authors:
 - Alexander McCormmach
@@ -25,10 +25,10 @@ authors:
 - Takayuki Kusano
 - Timothy Malone
 - Zachary P. Landau
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-15 00:00:00.000000000 Z
+date: 2020-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gettext
@@ -162,14 +162,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: 0.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -246,14 +246,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -282,7 +282,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
-description: 
+description:
 email:
 - matijs@matijs.net
 executables:
@@ -331,7 +331,7 @@ files:
 - lib/alexandria/book_providers/proxis.rb
 - lib/alexandria/book_providers/pseudomarc.rb
 - lib/alexandria/book_providers/siciliano.rb
-- lib/alexandria/book_providers/thalia.rb
+- lib/alexandria/book_providers/thalia_provider.rb
 - lib/alexandria/book_providers/web.rb
 - lib/alexandria/book_providers/worldcat.rb
 - lib/alexandria/book_providers/z3950.rb
@@ -555,6 +555,7 @@ files:
 - share/sounds/alexandria/good_scan.wav
 - share/sounds/alexandria/scanning.ogg
 - share/sounds/alexandria/scanning.wav
+- spec/alexandria/book_providers/thalia_provider_spec.rb
 - spec/alexandria/book_providers/world_cat_provider_spec.rb
 - spec/alexandria/book_providers_spec.rb
 - spec/alexandria/book_spec.rb
@@ -609,6 +610,7 @@ files:
 - spec/data/libraries/0.6.2/My Library/9780755322800.cover
 - spec/data/libraries/0.6.2/My Library/9780755322800.yaml
 - spec/end_to_end/basic_run_spec.rb
+- spec/fixtures/cover.jpg
 - spec/spec_helper.rb
 - tasks/setup.rb
 - tasks/spec.rake
@@ -619,7 +621,7 @@ homepage: http://www.github.com/mvz/alexandria-book-collection-manager
 licenses:
 - GPL-2
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--main"
 - README.md
@@ -636,8 +638,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: GNOME application for managing collections of books
 test_files: []