alexandria-book-collection-manager 0.7.2 → 0.7.7

data/TODO.md

@@ -1,7 +1,15 @@
 Alexandria's TODO list
 ======================
 
-This is an old list of TODO's.
+## New TODOs
+
+* [ ] Clean up broken providers
+* [ ] Add openlibrary provider
+* [ ] Allow searching for cover image for existing books
+
+## Old TODOs
+
+This is an old list of TODO's that should be cleaned up.
 
 For the next release:
 

data/alexandria-book-collection-manager.gemspec

@@ -1,61 +1,68 @@
 # frozen_string_literal: true
 
-require_relative 'lib/alexandria/version'
+require_relative "lib/alexandria/version"
 
 Gem::Specification.new do |s|
-  s.name = 'alexandria-book-collection-manager'
+  s.name = "alexandria-book-collection-manager"
   s.version = Alexandria::VERSION
 
-  s.summary = 'GNOME application for managing collections of books'
-  s.required_ruby_version = '>= 2.3.0'
+  s.summary = "GNOME application for managing collections of books"
+  s.required_ruby_version = ">= 2.5.0"
 
   s.authors = [
-    'Alexander McCormmach',
-    'Aymeric Nys',
-    'Cathal Mc Ginley',
-    'Claudio Belotti',
-    'Constantine Evans',
-    'Dafydd Harries',
-    'Javier Fernandez-Sanguino Pena',
-    'Joseph Method',
-    'Kevin Schultz',
-    'Laurent Sansonetti',
-    'Marco Costantini',
-    'Mathieu Leduc-Hamel',
-    'Matijs van Zuijlen',
-    'Owain Evans',
-    'Pascal Terjan',
-    'Rene Samselnig',
-    'Robby Stephenson',
-    'Sun Ning',
-    'Takayuki Kusano',
-    'Timothy Malone',
-    'Zachary P. Landau'
+    "Alexander McCormmach",
+    "Aymeric Nys",
+    "Cathal Mc Ginley",
+    "Claudio Belotti",
+    "Constantine Evans",
+    "Dafydd Harries",
+    "Javier Fernandez-Sanguino Pena",
+    "Joseph Method",
+    "Kevin Schultz",
+    "Laurent Sansonetti",
+    "Marco Costantini",
+    "Mathieu Leduc-Hamel",
+    "Matijs van Zuijlen",
+    "Owain Evans",
+    "Pascal Terjan",
+    "Rene Samselnig",
+    "Robby Stephenson",
+    "Sun Ning",
+    "Takayuki Kusano",
+    "Timothy Malone",
+    "Zachary P. Landau"
   ]
-  s.email = ['matijs@matijs.net']
-  s.homepage = 'http://www.github.com/mvz/alexandria-book-collection-manager'
+  s.email = ["matijs@matijs.net"]
+  s.homepage = "http://www.github.com/mvz/alexandria-book-collection-manager"
 
-  s.license = 'GPL-2'
+  s.license = "GPL-2"
 
   s.files = `git ls-files -z`.split("\0") |
-    ['lib/alexandria/default_preferences.rb']
+    ["lib/alexandria/default_preferences.rb"]
 
-  s.executables = ['alexandria']
+  s.executables = ["alexandria"]
 
-  s.rdoc_options = ['--main', 'README.md']
+  s.rdoc_options = ["--main", "README.md"]
 
-  s.add_runtime_dependency('gettext', ['~> 3.1'])
-  s.add_runtime_dependency('gstreamer', ['3.2.1'])
-  s.add_runtime_dependency('gtk3', ['3.2.1'])
-  s.add_runtime_dependency('hpricot', ['~> 0.8.5'])
-  s.add_runtime_dependency('htmlentities', ['~> 4.3'])
-  s.add_runtime_dependency('image_size', ['~> 1.5.0'])
-  s.add_runtime_dependency('marc', ['~> 1.0.0'])
-  s.add_runtime_dependency('zoom', ['~> 0.5.0'])
+  s.add_runtime_dependency("gettext", ["~> 3.1"])
+  s.add_runtime_dependency("gstreamer", ["~> 3.4.3"])
+  s.add_runtime_dependency("gtk3", ["~> 3.4.3"])
+  s.add_runtime_dependency("hpricot", ["~> 0.8.5"])
+  s.add_runtime_dependency("htmlentities", ["~> 4.3"])
+  s.add_runtime_dependency("image_size", ["~> 2.0"])
+  s.add_runtime_dependency("marc", ["~> 1.0.0"])
+  s.add_runtime_dependency("psych", ["~> 3.2.0"])
+  s.add_runtime_dependency("zoom", ["~> 0.5.0"])
 
-  s.add_development_dependency('minitest', ['~> 5.0'])
-  s.add_development_dependency('rake', ['~> 12.0'])
-  s.add_development_dependency('rspec', ['~> 3.0'])
+  s.add_development_dependency("gnome_app_driver", ["~> 0.2.1"])
+  s.add_development_dependency("minitest", ["~> 5.0"])
+  s.add_development_dependency("rake", ["~> 13.0"])
+  s.add_development_dependency("rspec", ["~> 3.0"])
+  s.add_development_dependency("rubocop", "~> 0.93.1")
+  s.add_development_dependency("rubocop-i18n", ["~> 2.0.2"])
+  s.add_development_dependency("rubocop-performance", ["~> 1.8.0"])
+  s.add_development_dependency("rubocop-rspec", "~> 1.44.1")
+  s.add_development_dependency("webmock", "~> 3.9")
 
-  s.require_paths = ['lib']
+  s.require_paths = ["lib"]
 end

data/bin/alexandria

@@ -1,56 +1,33 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-# Copyright (C) 2004-2006 Laurent Sansonetti
-# Copyright (C) 2007, 2008 Joseph Method
-# Copyright (C) 2007, 2009 Cathal Mc Ginley
-# Copyright (C) 2014, 2015 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
+
+require "gettext"
+require "alexandria"
+require "optparse"
+require "ostruct"
 
-require 'gettext'
-require 'alexandria'
-require 'optparse'
-require 'ostruct'
+store = Alexandria::LibraryStore.new(Alexandria::Library::DEFAULT_DIR)
+Alexandria::LibraryCollection.instance.library_store = store
 
 # options = OpenStruct.new
 OptionParser.new do |opts|
-  opts.banner = 'Usage: alexandria [options]'
-  opts.on('-l', '--list', 'List libraries in numbered format') do
+  opts.banner = "Usage: alexandria [options]"
+  opts.on("-l", "--list", "List libraries in numbered format") do
     puts Alexandria.list_books_on_console
     exit
   end
-  # opts.on("--output FORMAT",
-  #        "Output library as FORMAT: csv|xml|yaml; use with --library or omit for ALL") do |val|
-  #        options.format = val
-  #        exit
-  # end
-  # opts.on("--library LIBRARY",
-  #        "Used with --output to pick a library to output") do |val|
-  #        options.library = val
-  #        exit
-  # end
-  opts.on('-d', '--debug', 'Run in debug mode') do
+  opts.on("-d", "--debug", "Run in debug mode") do
     $DEBUG = true
   end
-  opts.on('-h', '--help', 'Show help options') do
+  opts.on("-h", "--help", "Show help options") do
     puts opts
     exit
   end
-  opts.on('-v', '--version', 'Get version number') do
+  opts.on("-v", "--version", "Get version number") do
     puts Alexandria::VERSION
     exit
   end
@@ -58,21 +35,21 @@ end.parse!
 
 begin
   Alexandria.main
-rescue => e
-  warn <<EOS
------------------------
-Alexandria just crashed
------------------------
-Timestamp: #{Time.now}
-Message: #{e.message}
-Backtrace:
-#{e.backtrace.join("\n")}
-Release: #{Alexandria::VERSION}(#{Alexandria::DISPLAY_VERSION})
-Uname -a: #{`uname -a`.chomp}
---
-Please report this dump to '#{Alexandria::BUGREPORT_URL}' with some additional
-information, such as the description of the crash and the steps to reproduce it
-(if it's possible).
-EOS
+rescue StandardError => ex
+  warn <<~EOS
+    -----------------------
+    Alexandria just crashed
+    -----------------------
+    Timestamp: #{Time.now}
+    Message: #{ex.message}
+    Backtrace:
+    #{ex.backtrace.join("\n")}
+    Release: #{Alexandria::VERSION}(#{Alexandria::DISPLAY_VERSION})
+    Uname -a: #{`uname -a`.chomp}
+    --
+    Please report this dump to '#{Alexandria::BUGREPORT_URL}' with some additional
+    information, such as the description of the crash and the steps to reproduce it
+    (if it's possible).
+  EOS
   exit 1
 end

data/doc/FAQ

@@ -159,8 +159,6 @@ for public libraries, and very unlikely for commercial booksellers.
 It is useful if you choose a provider that allows to specify the ISBN in 
 the address, such as 
 http://www.internetbookshop.it/ame/ser/serdsp.asp?e=0060748222&shop=1
-or
-http://www.deastore.com/product.asp?isbn=9780060748227
 
 It is necessary that the HTML page of each provider is easily parsable, 
 that is, that the computer can easily find title, author(s), ISBN, 
@@ -184,8 +182,7 @@ information: title, author(s), ISBN, publisher, year of publication,
 binding. In case that one of these is missing, Alexandria will not get 
 it.
 
-It is easier, if the provider doesn't use cookies (however, provider
-Deastore uses cookies and has been implemented).
+It is easier, if the provider doesn't use cookies.
 
 After the choice of the provider, try by yourself to modify the file for 
 an already implemented provider. Probably it may be only required that 
@@ -293,8 +290,7 @@ Question: I prefer to have the field "Author" as "Surname, Name" instead
 of "Name Surname".
 
 Answer: Alexandria relies on what the providers say: 
-some providers report "Surname, Name": Deastore, Renaud, Mcu,
-some "Surname Name": Webster.it, Ibs.it,
+some providers report "Surname Name": Webster.it, Ibs.it,
 some "Name Surname": Bn, Thalia, Bol.it, Adlibris, L Siciliano, Worldcat,
 and some without any rule: Amazon, Proxis.
 You can change, in the preferences, the order in which the providers are 

data/doc/dependency_decisions.yml

@@ -1,29 +1,29 @@
 ---
-- - :whitelist
+- - :permit
   - LGPL-3+
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:51:53.629753437 Z
-- - :whitelist
+- - :permit
   - LGPL-2.1+
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:52:02.088395832 Z
-- - :whitelist
+- - :permit
   - MIT
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:52:06.806192042 Z
-- - :whitelist
+- - :permit
   - LGPLv2+
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:52:24.618189811 Z
-- - :whitelist
+- - :permit
   - ruby
   - :who: 
     :why: 
@@ -53,9 +53,28 @@
     :why: 
     :versions: []
     :when: 2017-07-23 05:54:54.822319735 Z
-- - :approve
+- - :license
   - zoom
+  - LGPL-2.1
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2020-07-30 06:44:22.960902375 Z
+- - :permit
+  - Simplified BSD
   - :who: 
-    :why: Actually licensed under LGPL-2.1
+    :why: 
+    :versions: []
+    :when: 2020-07-30 06:45:58.599399721 Z
+- - :permit
+  - Apache 2.0
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2020-07-30 06:46:08.280121582 Z
+- - :permit
+  - LGPL-2.1
+  - :who: 
+    :why: 
     :versions: []
-    :when: 2017-07-23 06:00:43.594558953 Z
+    :when: 2020-07-30 06:46:32.729325577 Z

data/lib/alexandria.rb

@@ -1,24 +1,10 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2004-2006 Laurent Sansonetti
-# Copyright (C) 2011, 2016 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
-require 'gettext'
+require "gettext"
 
 # XXX: Gettext hotfix
 module Gem
@@ -30,18 +16,20 @@ module Gem
   end
 end
 
-require 'logger'
-require 'alexandria/logging'
-require 'alexandria/about'
+require "logger"
+require "alexandria/logging"
+require "alexandria/about"
 
 module Alexandria
   def self.set_proxy
-    ENV['http_proxy'] = nil if !ENV['http_proxy'].nil? && URI.parse(ENV['http_proxy']).userinfo.nil?
+    if !ENV["http_proxy"].nil? && URI.parse(ENV["http_proxy"]).userinfo.nil?
+      ENV["http_proxy"] = nil
+    end
   end
 
   def self.set_log_level
-    Alexandria.log.level = Logger::DEBUG if $DEBUG
-    Alexandria.log.debug { 'Initializing Alexandria...' }
+    log.level = Logger::DEBUG if $DEBUG
+    log.debug { "Initializing Alexandria" }
   end
 
   def self.main
@@ -53,8 +41,8 @@ end
 
 # lrz says 'macui' is obsolete (may be supported again some day)
 # unless $MACOSX
-require 'alexandria/config'
-require 'alexandria/version'
+require "alexandria/config"
+require "alexandria/version"
 
 # else
 #  module Alexandria
@@ -65,20 +53,22 @@ require 'alexandria/version'
 #  end
 # end
 
-require 'alexandria/models/book'
-require 'alexandria/models/library'
+require "alexandria/models/book"
+require "alexandria/library_store"
+require "alexandria/library_collection"
+require "alexandria/models/library"
 
-require 'alexandria/smart_library'
-require 'alexandria/execution_queue'
-require 'alexandria/import_library'
-require 'alexandria/export_library'
-require 'alexandria/book_providers'
-require 'alexandria/preferences'
-require 'alexandria/undo_manager'
-require 'alexandria/web_themes'
+require "alexandria/smart_library"
+require "alexandria/execution_queue"
+require "alexandria/import_library"
+require "alexandria/export_library"
+require "alexandria/book_providers"
+require "alexandria/preferences"
+require "alexandria/undo_manager"
+require "alexandria/web_themes"
 
 # lrz says 'macui' is obsolete (may be supported again some day)
 # require $MACOSX ? 'alexandria/macui' : 'alexandria/ui'
 
-require 'alexandria/ui'
-require 'alexandria/console'
+require "alexandria/ui"
+require "alexandria/console"

data/lib/alexandria/about.rb

@@ -20,64 +20,64 @@
 # Fifth Floor, Boston, MA 02110-1301 USA.
 
 module Alexandria
-  TITLE = 'Alexandria'
-  TEXTDOMAIN = 'alexandria'
+  TITLE = "Alexandria"
+  TEXTDOMAIN = "alexandria"
   extend GetText
-  bindtextdomain(Alexandria::TEXTDOMAIN, charset: 'UTF-8')
-  DESCRIPTION = _('A program to help you manage your book collection.')
+  bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
+  DESCRIPTION = _("A program to help you manage your book collection.")
   COPYRIGHT = "Copyright (C) 2004-2006 Laurent Sansonetti\n" \
-    'Copyright (C) 2007-2010,2014,2015 Alexandria Contributors'
+    "Copyright (C) 2007-2010,2014,2015 Alexandria Contributors"
   AUTHORS = [
-    'Alexander McCormmach <alexander@tunicate.org>',
-    'Aymeric Nys <aymeric@nnx.com>',
-    'Cathal Mc Ginley <cathal.alexandria@gnostai.org>',
-    'Claudio Belotti <bel8@lilik.it>',
-    'Constantine Evans <cevans@costinet.org>',
-    'Dafydd Harries <daf@muse.19inch.net>',
-    'Javier Fernandez-Sanguino Pena <jfs@debian.org>',
-    'Joseph Method <tristil@gmail.com>',
-    'Kevin Schultz <schultkl@ieee.org>',
-    'Laurent Sansonetti <lrz@gnome.org>',
-    'Marco Costantini <costanti@science.unitn.it>',
-    'Mathieu Leduc-Hamel <arrak@arrak.org>',
-    'Matijs van Zuijlen <matijs@matijs.net>',
-    'Owain Evans <o.evans@gmail.com>',
-    'Pascal Terjan <pterjan@linuxfr.org>',
-    'Rene Samselnig <sandman@sdm-net.org>',
-    'Robby Stephenson <robby@periapsis.org>',
-    'Sun Ning <classicning@gmail.com>',
-    'Takayuki Kusano <AE5T-KSN@asahi-net.or.jp>',
-    'Timothy Malone <timothy.malone@gmail.com>',
-    'Zachary P. Landau <kapheine@hypa.net>'
+    "Alexander McCormmach <alexander@tunicate.org>",
+    "Aymeric Nys <aymeric@nnx.com>",
+    "Cathal Mc Ginley <cathal.alexandria@gnostai.org>",
+    "Claudio Belotti <bel8@lilik.it>",
+    "Constantine Evans <cevans@costinet.org>",
+    "Dafydd Harries <daf@muse.19inch.net>",
+    "Javier Fernandez-Sanguino Pena <jfs@debian.org>",
+    "Joseph Method <tristil@gmail.com>",
+    "Kevin Schultz <schultkl@ieee.org>",
+    "Laurent Sansonetti <lrz@gnome.org>",
+    "Marco Costantini <costanti@science.unitn.it>",
+    "Mathieu Leduc-Hamel <arrak@arrak.org>",
+    "Matijs van Zuijlen <matijs@matijs.net>",
+    "Owain Evans <o.evans@gmail.com>",
+    "Pascal Terjan <pterjan@linuxfr.org>",
+    "Rene Samselnig <sandman@sdm-net.org>",
+    "Robby Stephenson <robby@periapsis.org>",
+    "Sun Ning <classicning@gmail.com>",
+    "Takayuki Kusano <AE5T-KSN@asahi-net.or.jp>",
+    "Timothy Malone <timothy.malone@gmail.com>",
+    "Zachary P. Landau <kapheine@hypa.net>"
   ].freeze
   DOCUMENTERS = [
-    'Cathal Mc Ginley <cathal.alexandria@gnostai.org>',
-    'Liam Davison <registrations@liamjdavison.info>'
+    "Cathal Mc Ginley <cathal.alexandria@gnostai.org>",
+    "Liam Davison <registrations@liamjdavison.info>"
   ].freeze
   TRANSLATORS = [
-    'Adrián Chaves Fernández <adriyetichaves@gmail.com> (gl)',
-    'Cathal Mc Ginley <cathal.alexandria@gnostai.org> (ga)',
-    'CHIKAMA Masaki <masaki.chikama@gmail.com> (ja)',
-    'Dafydd Harries <daf@muse.19inch.net> (cy)',
-    'Damjan Dimitrioski <damjandimitrioski@gmail.com> (mk)',
-    'Giacomo Margarito <giacomomargarito@gmail.com> (it)',
-    'Jack Myrseh <jack@enkom.no> (nb)',
-    'Joachim Breitner <mail@joachim-breitner.de> (de)',
-    'José Ling <jlgdot369@gmail.com> (zh_TW)',
-    'Lennart Karssen <lennart@karssen.org> (nl)',
-    'Lígia Moreira <ligia.moreira@netvisao.pt> (fr, pt, pt_BR)',
-    'Martin Karlsson <martinkarlsson81@hotmail.com> (sv)',
-    'Michael Kotsarinis <mkotsari1@pre.forthnet.gr> (el)',
-    'Miguel Ángel García <magmax@ieee.org> (es)',
-    'Peter Kováč <kovac.peter@fotopriestor.sk> (sk)',
-    'Petr Vanek <vanous@penguin.cz> (cs)',
-    'Piotr Drąg <piotrdrag@gmail.com> (pl)',
-    'Serhij Dubyk <dubyk@library.lviv.ua> (uk)'
+    "Adrián Chaves Fernández <adriyetichaves@gmail.com> (gl)",
+    "Cathal Mc Ginley <cathal.alexandria@gnostai.org> (ga)",
+    "CHIKAMA Masaki <masaki.chikama@gmail.com> (ja)",
+    "Dafydd Harries <daf@muse.19inch.net> (cy)",
+    "Damjan Dimitrioski <damjandimitrioski@gmail.com> (mk)",
+    "Giacomo Margarito <giacomomargarito@gmail.com> (it)",
+    "Jack Myrseh <jack@enkom.no> (nb)",
+    "Joachim Breitner <mail@joachim-breitner.de> (de)",
+    "José Ling <jlgdot369@gmail.com> (zh_TW)",
+    "Lennart Karssen <lennart@karssen.org> (nl)",
+    "Lígia Moreira <ligia.moreira@netvisao.pt> (fr, pt, pt_BR)",
+    "Martin Karlsson <martinkarlsson81@hotmail.com> (sv)",
+    "Michael Kotsarinis <mkotsari1@pre.forthnet.gr> (el)",
+    "Miguel Ángel García <magmax@ieee.org> (es)",
+    "Peter Kováč <kovac.peter@fotopriestor.sk> (sk)",
+    "Petr Vanek <vanous@penguin.cz> (cs)",
+    "Piotr Drąg <piotrdrag@gmail.com> (pl)",
+    "Serhij Dubyk <dubyk@library.lviv.ua> (uk)"
   ].freeze
   ARTISTS = [
-    'Andreas Nilsson <nisses.mail@home.se>',
-    'Stefanie Dijoux <stefanie.dijoux@gmail.com>'
+    "Andreas Nilsson <nisses.mail@home.se>",
+    "Stefanie Dijoux <stefanie.dijoux@gmail.com>"
   ].freeze
-  BUGREPORT_URL = 'http://www.github.com/mvz/alexandria-book-collection-manager/issues'
-  WEBSITE_URL = 'http://www.github.com/mvz/alexandria-book-collection-manager'
+  BUGREPORT_URL = "http://www.github.com/mvz/alexandria-book-collection-manager/issues"
+  WEBSITE_URL = "http://www.github.com/mvz/alexandria-book-collection-manager"
 end