alexandria-book-collection-manager 0.7.10 → 0.7.11

data/spec/alexandria/export_library_spec.rb

@@ -11,12 +11,11 @@ RSpec.describe Alexandria::ExportLibrary do
     loader = Alexandria::LibraryStore.new(TESTDIR)
     loader.load_library("My Library")
   end
-  let(:format) { Alexandria::ExportFormat.all.find { |it| it.message == message } }
+  let(:format) { Alexandria::ExportFormat.all.find { _1.message == message } }
   let(:outfile) do
     outfile_base = format.ext ? "my-library.#{format.ext}" : "my-library"
-    File.join(Dir.tmpdir, outfile_base)
+    File.join(Dir.mktmpdir, outfile_base)
   end
-  let(:unsorted) { Alexandria::LibrarySortOrder::Unsorted.new }
 
   before do
     test_library = File.join(LIBDIR, "0.6.2")
@@ -38,7 +37,7 @@ RSpec.describe Alexandria::ExportLibrary do
       sort_by_title = Alexandria::LibrarySortOrder.new(:title)
       format.invoke(my_library, sort_by_title, outfile)
       rows = load_rows_from_csv
-      titles = rows.map { |it| it["Title"] }
+      titles = rows.map { _1["Title"] }
       expect(titles).to eq titles.sort
     end
 
@@ -46,7 +45,7 @@ RSpec.describe Alexandria::ExportLibrary do
       sort_by_date_desc = Alexandria::LibrarySortOrder.new(:publishing_year, false)
       format.invoke(my_library, sort_by_date_desc, outfile)
       rows = load_rows_from_csv
-      dates = rows.map { |it| it["Year Published"] }
+      dates = rows.map { _1["Year Published"] }
       expect(dates).to eq dates.sort.reverse
     end
   end
@@ -55,7 +54,8 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_html }
 
     it "can export unsorted" do
-      format.invoke(my_library, unsorted, outfile, Alexandria::WebTheme.all.first)
+      format.invoke(my_library, Alexandria::LibrarySortOrder::Unsorted.new,
+                    outfile, Alexandria::WebTheme.all.first)
       index = File.join(outfile, "index.html")
 
       aggregate_failures do
@@ -70,7 +70,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_onix_xml_archive }
 
     it "can export unsorted" do
-      format.invoke(my_library, unsorted, outfile)
+      format.invoke(my_library, Alexandria::LibrarySortOrder::Unsorted.new, outfile)
       aggregate_failures do
         expect(outfile).to be_an_existing_file
         expect(File.size(outfile)).to be_nonzero
@@ -82,7 +82,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_tellico_xml_archive }
 
     it "can export unsorted" do
-      format.invoke(my_library, unsorted, outfile)
+      format.invoke(my_library, Alexandria::LibrarySortOrder::Unsorted.new, outfile)
       aggregate_failures do
         expect(outfile).to be_an_existing_file
         expect(File.size(outfile)).to be_nonzero
@@ -92,12 +92,58 @@ RSpec.describe Alexandria::ExportLibrary do
 
   describe "#export_as_bibtex" do
     let(:message) { :export_as_bibtex }
+    let(:expected_content) do
+      <<~BIBTEX
+        %Generated on #{Date.today} by: Alexandria #{Alexandria::DISPLAY_VERSION}
+        %
+
+        @BOOK{William1,
+        author = "William Gibson",
+        title = "Pattern Recognition",
+        publisher = "Penguin Books Ltd",
+        year = 2004
+        }
+
+        @BOOK{Francoise1,
+        author = "Francoise Sagan and Irene Ash",
+        title = "Bonjour Tristesse",
+        publisher = "Penguin Books Ltd",
+        OPTnote = "Essential penguin",
+        year = 1998
+        }
+
+        @BOOK{Kazuo1,
+        author = "Kazuo Ishiguro",
+        title = "An Artist of the Floating World",
+        publisher = "Faber and Faber",
+        year = 1999
+        }
+
+        @BOOK{Ursula1,
+        author = "Ursula Le Guin",
+        title = "The Dispossessed",
+        publisher = "Gollancz",
+        OPTnote = "Gollancz S.F.",
+        year = 2006
+        }
+
+        @BOOK{Neil1,
+        author = "Neil Gaiman",
+        title = "Neverwhere",
+        publisher = "Headline Review",
+        OPTnote = "The Author's Preferred Text",
+        year = 2005
+        }
+
+      BIBTEX
+    end
 
     it "can export unsorted" do
-      format.invoke(my_library, unsorted, outfile)
+      format.invoke(my_library, Alexandria::LibrarySortOrder::Unsorted.new, outfile)
       aggregate_failures do
         expect(outfile).to be_an_existing_file
         expect(File.size(outfile)).to be_nonzero
+        expect(File.read(outfile)).to eq expected_content
       end
     end
   end
@@ -106,7 +152,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_isbn_list }
 
     it "can export unsorted" do
-      format.invoke(my_library, unsorted, outfile)
+      format.invoke(my_library, Alexandria::LibrarySortOrder::Unsorted.new, outfile)
       aggregate_failures do
         expect(outfile).to be_an_existing_file
         expect(File.size(outfile)).to be_nonzero
@@ -118,7 +164,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_ipod_notes }
 
     it "can export unsorted" do
-      format.invoke(my_library, unsorted, outfile, nil)
+      format.invoke(my_library, Alexandria::LibrarySortOrder::Unsorted.new, outfile, nil)
       index = File.join(outfile, "index.linx")
 
       aggregate_failures do

data/spec/alexandria/library_collection_spec.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "spec_helper"
+
+RSpec.describe Alexandria::LibraryCollection do
+  describe "#ruined_books" do
+    before do
+      test_library = File.join(LIBDIR, "0.6.2")
+      FileUtils.cp_r(test_library, TESTDIR)
+    end
+
+    it "lists ISBNs of empty files with their libraries" do
+      FileUtils.touch File.join(TESTDIR, "My Library", "0740704923.yaml")
+      collection = described_class.instance
+      collection.reload
+      library = collection.all_libraries.first
+      expect(collection.ruined_books).to eq [[nil, "0740704923", library]]
+    end
+  end
+end

data/spec/alexandria/library_spec.rb

@@ -209,7 +209,8 @@ describe Alexandria::Library do
       my_library.each { |book| my_library.save(book, true) }
       my_library_reloaded = loader.load_all_libraries[0]
 
-      expect(my_library_reloaded.map(&:publisher)).to eq ["O'Reilley", "Addison Wesley"]
+      expect(my_library_reloaded.map(&:publisher))
+        .to contain_exactly("O'Reilley", "Addison Wesley")
     end
   end
 

data/spec/alexandria/library_store_spec.rb

@@ -34,4 +34,36 @@ RSpec.describe Alexandria::LibraryStore do
       end
     end
   end
+
+  describe "#load_all_libraries" do
+    before do
+      test_library = File.join(LIBDIR, "0.6.2")
+      FileUtils.cp_r(test_library, TESTDIR)
+    end
+
+    it "loads the libraries in the target directory" do
+      result = loader.load_all_libraries
+      aggregate_failures do
+        expect(result.count).to eq 1
+        expect(result.first.map(&:title))
+          .to contain_exactly("Pattern Recognition", "Bonjour Tristesse",
+                              "An Artist of the Floating World", "The Dispossessed",
+                              "Neverwhere")
+      end
+    end
+
+    it "lists ISBNs of empty files in ruined books" do
+      FileUtils.touch File.join(TESTDIR, "My Library", "0740704923.yaml")
+      result = loader.load_all_libraries
+      library = result.first
+      expect(library.ruined_books).to eq ["0740704923"]
+    end
+
+    it "skips empty files with names that are not valid ISBNs" do
+      FileUtils.touch File.join(TESTDIR, "My Library", "12345.yaml")
+      result = loader.load_all_libraries
+      library = result.first
+      expect(library.ruined_books).to be_empty
+    end
+  end
 end

data/spec/alexandria/scanners/keyboard_wedge_spec.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require_relative "../../spec_helper"
+
+describe Alexandria::Scanners::KeyboardWedge do
+  let(:scanner) { described_class.new }
+  let(:partials) do
+    ["9",
+     "978057507",
+     "97805711471"]
+  end
+  let(:scans) do
+    {
+      isbn: "978 05711 47168",
+      ib5: "978057 5079038 007 99"
+    }
+  end
+
+  it "is called KeyboardWedge" do
+    expect(scanner.name).to match(/KeyboardWedge/i)
+  end
+
+  it "refuses to detect incomplete scans" do
+    aggregate_failures do
+      partials.each { |scan| expect(scanner.match?(scan)).to be false }
+    end
+  end
+
+  it "detects complete scans" do
+    aggregate_failures do
+      expect(scanner.match?(scans[:isbn])).to be true
+      expect(scanner.match?(scans[:ib5])).to be true
+    end
+  end
+
+  it "decodes ISBN barcodes" do
+    expect(scanner.decode(scans[:isbn])).to eq("9780571147168")
+  end
+
+  it "decodes ISBN+5 barcodes" do
+    expect(scanner.decode(scans[:ib5])).to eq("9780575079038") # 00799
+  end
+end

data/spec/alexandria/ui/about_dialog_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::AboutDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     expect { described_class.new parent }.not_to raise_error
   end

data/spec/alexandria/ui/acquire_dialog_spec.rb

@@ -7,8 +7,13 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::AcquireDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    expect { described_class.new parent }.not_to raise_error
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) { Alexandria::Library.new("Hi") }
+  let(:ui_manager) { instance_double(Alexandria::UI::UIManager) }
+
+  it "can be instantiated" do
+    allow(ui_manager).to receive :set_status_label
+    dialog = described_class.new parent, ui_manager, library
+    expect(dialog).to be_a described_class
   end
 end

data/spec/alexandria/ui/alert_dialog_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::AlertDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     expect do
       described_class.new(parent, "Hello",

data/spec/alexandria/ui/bad_isbns_dialog_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::BadIsbnsDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     expect { described_class.new parent, "Careful", [] }.not_to raise_error
   end

data/spec/alexandria/ui/book_properties_dialog_spec.rb

@@ -21,7 +21,7 @@ describe Alexandria::UI::BookPropertiesDialog do
     library << book
   end
 
-  it "works" do
+  it "can be instantiated" do
     expect { described_class.new parent, library, book }.not_to raise_error
   end
 

data/spec/alexandria/ui/confirm_erase_dialog_spec.rb

@@ -9,7 +9,7 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::ConfirmEraseDialog do
   let(:parent) { Gtk::Window.new :toplevel }
 
-  it "works" do
+  it "can be instantiated" do
     expect { described_class.new parent, "foo-file" }.not_to raise_error
   end
 

data/spec/alexandria/ui/conflict_while_copying_dialog_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConflictWhileCopyingDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     library = instance_double(Alexandria::Library, name: "Bar Library")
     book = instance_double(Alexandria::Book, title: "Foo Book")

data/spec/alexandria/ui/error_dialog_spec.rb

@@ -9,7 +9,7 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::ErrorDialog do
   let(:parent) { Gtk::Window.new :toplevel }
 
-  it "works" do
+  it "can be instantiated" do
     expect { described_class.new parent, "Boom", "It went boom" }.not_to raise_error
   end
 

data/spec/alexandria/ui/export_dialog_spec.rb

@@ -11,7 +11,7 @@ describe Alexandria::UI::ExportDialog do
   let(:library) { Alexandria::Library.new "Bar Library" }
   let(:sort_order) { Alexandria::LibrarySortOrder::Unsorted.new }
 
-  it "works" do
+  it "can be instantiated" do
     expect { described_class.new parent, library, sort_order }.not_to raise_error
   end
 
@@ -26,8 +26,8 @@ describe Alexandria::UI::ExportDialog do
 
     it "works when response is OK" do
       dir = Dir.mktmpdir
-      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::OK)
-      allow(chooser).to receive(:filename).and_return File.join(dir, "export")
+      allow(chooser).to receive_messages(run: Gtk::ResponseType::OK,
+                                         filename: File.join(dir, "export"))
       expect { export_dialog.perform }.not_to raise_error
     ensure
       FileUtils.remove_entry dir

data/spec/alexandria/ui/{iconview_spec.rb → icon_view_manager_spec.rb}

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::IconViewManager do
-  it "works" do
+  it "can be instantiated" do
     iconview = instance_double(Gtk::IconView).as_null_object
     parent = instance_double(Alexandria::UI::UIManager, iconview: iconview).as_null_object
     expect { described_class.new iconview, parent }.not_to raise_error

data/spec/alexandria/ui/keep_bad_isbn_dialog_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::KeepBadISBNDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     book = instance_double(Alexandria::Book,
                            title: "Foo Book",

data/spec/alexandria/ui/main_app_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# frozen_string_literal: true
-
 # This file is part of Alexandria.
 #
 # See the file README.md for authorship and licensing information.

data/spec/alexandria/ui/new_book_dialog_manual_spec.rb

@@ -13,7 +13,7 @@ describe Alexandria::UI::NewBookDialogManual do
     store.load_library("Bar Library")
   end
 
-  it "works" do
+  it "can be instantiated" do
     expect { described_class.new parent, library }.not_to raise_error
   end
 

data/spec/alexandria/ui/new_book_dialog_spec.rb

@@ -9,14 +9,17 @@ require "spec_helper"
 describe Alexandria::UI::NewBookDialog do
   let(:parent) { Gtk::Window.new :toplevel }
   let(:model) { Gtk::ListStore.new(String, String, GdkPixbuf::Pixbuf) }
+  let(:library) { Alexandria::Library.new("Hi") }
+  let(:ui_manager) { instance_double(Alexandria::UI::UIManager) }
 
-  it "works" do
-    expect { described_class.new parent }.not_to raise_error
+  it "can be instantiated" do
+    dialog = described_class.new parent, ui_manager, library
+    expect(dialog).to be_a described_class
   end
 
   it "can copy search results into result treeview" do
     results = [[an_artist_of_the_floating_world, "cover-url"]]
-    dialog = described_class.new parent
+    dialog = described_class.new parent, ui_manager, library
     expect { dialog.copy_results_to_treeview_model results, model }.not_to raise_error
   end
 end

data/spec/alexandria/ui/preferences_dialog_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::PreferencesDialog do
-  it "works" do
+  it "can be instantiated" do
     parent = Gtk::Window.new :toplevel
     expect { described_class.new(parent) { nil } }.not_to raise_error
   end

data/spec/alexandria/ui/provider_preferences_dialog_spec.rb

@@ -8,9 +8,13 @@ require_relative "../../spec_helper"
 
 describe Alexandria::UI::ProviderPreferencesDialog do
   let(:parent) { Gtk::Window.new :toplevel }
+  let(:variable) do
+    instance_double(Alexandria::BookProviders::Preferences::Variable,
+                    name: "foo-bar", description: "Foo Bar", possible_values: nil,
+                    value: "baz", mandatory?: false)
+  end
   let(:preferences) do
-    instance_double(Alexandria::BookProviders::Preferences,
-                    length: 0, read: [])
+    instance_double(Alexandria::BookProviders::Preferences, length: 0, read: [variable])
   end
   let(:provider) do
     instance_double(Alexandria::BookProviders::GenericProvider,
@@ -23,12 +27,23 @@ describe Alexandria::UI::ProviderPreferencesDialog do
   end
 
   describe "#acquire" do
-    it "works" do
-      preferences_dialog = described_class.new parent, provider
-      gtk_dialog = preferences_dialog.dialog
-      allow(gtk_dialog).to receive(:run)
+    let(:preferences_dialog) { described_class.new parent, provider }
+
+    before do
+      allow(preferences_dialog.dialog).to receive(:run)
+      allow(variable).to receive(:new_value=)
+    end
+
+    it "runs the underlying Gtk+ dialog" do
+      preferences_dialog.acquire
+
+      expect(preferences_dialog.dialog).to have_received(:run)
+    end
+
+    it "updates variables" do
+      preferences_dialog.acquire
 
-      expect { preferences_dialog.acquire }.not_to raise_error
+      expect(variable).to have_received(:new_value=).with "baz"
     end
   end
 end

data/spec/alexandria/ui/really_delete_dialog_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ReallyDeleteDialog do
-  it "works" do
+  it "can be instantiated" do
     library = instance_double(Alexandria::Library,
                               name: "Bar Library", empty?: false, size: 12)
     parent = Gtk::Window.new :toplevel

data/spec/alexandria/ui/sidepane_manager_spec.rb

@@ -7,7 +7,7 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::SidepaneManager do
-  it "works" do
+  it "can be instantiated" do
     library_listview = instance_double(Gtk::TreeView).as_null_object
     parent = instance_double(Alexandria::UI::UIManager, main_app: nil, append_library: nil)
     expect { described_class.new library_listview, parent }.not_to raise_error

data/spec/alexandria/ui/skip_entry_dialog_spec.rb

@@ -9,7 +9,7 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::SkipEntryDialog do
   let(:parent) { Gtk::Window.new :toplevel }
 
-  it "works" do
+  it "can be instantiated" do
     expect { described_class.new parent, "Foo" }.not_to raise_error
   end
 

data/spec/alexandria/ui/ui_manager_spec.rb

@@ -9,12 +9,12 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::UIManager do
   let(:main_app) { instance_double(Alexandria::UI::MainApp) }
 
-  it "works" do
+  it "can be instantiated" do
     expect { described_class.new main_app }.not_to raise_error
   end
 
   describe "#on_new" do
-    it "works" do
+    it "adds one library" do
       ui = described_class.new main_app
       libraries = ui.instance_variable_get(:@libraries)
       libraries_count = libraries.all_libraries.count

data/spec/end_to_end/basic_run_spec.rb

@@ -8,7 +8,8 @@ require "gnome_app_driver"
 require "tmpdir"
 
 describe "The Alexandria application" do
-  let(:driver) { GnomeAppDriver.new "alexandria" }
+  # TODO: Remove app_file argument once GnomeAppDriver is smart about executable location
+  let(:driver) { GnomeAppDriver.new "alexandria", app_file: "exe/alexandria" }
 
   before do
     ENV["HOME"] = Dir.mktmpdir

data/spec/spec_helper.rb

@@ -7,7 +7,6 @@
 require "rspec"
 require "alexandria"
 require "webmock/rspec"
-require "pry"
 
 LIBDIR = File.expand_path("data/libraries", __dir__)
 TESTDIR = File.join(LIBDIR, "test")
@@ -26,6 +25,8 @@ RSpec::Matchers.define :have_correct_search_result_for do |query|
       results = provider.instance.search(query, Alexandria::BookProviders::SEARCH_BY_ISBN)
     rescue SocketError
       skip "Service is offline"
+    rescue Alexandria::BookProviders::ConnectionError
+      skip "Connection failed"
     end
 
     expect(results).to be_instance_of(Array)
@@ -38,7 +39,7 @@ RSpec::Matchers.define :have_correct_search_result_for do |query|
 
     canonical_query = Alexandria::Library.canonicalise_ean(query)
     canonical_result = Alexandria::Library.canonicalise_ean(book.isbn)
-    expect(canonical_query).to eq(canonical_result)
+    expect(canonical_result).to eq(canonical_query)
 
     expect(cover_url).to be_instance_of(String) if cover_url
 
@@ -62,6 +63,7 @@ RSpec.configure do |config|
 
   config.before do
     FileUtils.rm_rf(TESTDIR)
+    Alexandria.log.level = Logger::DEBUG if ENV["DEBUG"]
   end
 
   config.after do

data/tasks/setup.rb

@@ -28,5 +28,5 @@ require "rake/clean"
 
 # Load the other rake files in the tasks folder
 tasks_dir = __dir__
-rakefiles = Dir.glob(File.join(tasks_dir, "*.rake")).sort
+rakefiles = Dir.glob(File.join(tasks_dir, "*.rake"))
 import(*rakefiles)

data/util/rake/fileinstall.rb

@@ -29,7 +29,6 @@
 
 require "fileutils"
 require "pathname"
-require "set"
 require "rake/tasklib"
 
 # A file installer task, capable of installing into the system
@@ -77,10 +76,10 @@ class FileInstallTask < Rake::TaskLib
   # of the @file_groups list
   def make_tasks
     tasknames = {}
-    tasknames[:install] = "install_#{@taskname}".intern
-    tasknames[:uninstall] = "uninstall_#{@taskname}".intern
-    tasknames[:uninstall_files] = "uninstall_#{@taskname}_files".intern
-    tasknames[:uninstall_dirs] = "uninstall_#{@taskname}_dirs".intern
+    tasknames[:install] = :"install_#{@taskname}"
+    tasknames[:uninstall] = :"uninstall_#{@taskname}"
+    tasknames[:uninstall_files] = :"uninstall_#{@taskname}_files"
+    tasknames[:uninstall_dirs] = :"uninstall_#{@taskname}_dirs"
 
     # INSTALL TASK
 
@@ -197,7 +196,7 @@ class FileInstallTask < Rake::TaskLib
       part.gsub!("*", "[^\\/]*")
       part.gsub!("?", "[^\\/]")
     end
-    pattern = real_parts.join("([^\/]+\/)*")
+    pattern = real_parts.join("([^/]+/)*")
     /(#{pattern})/
   end
 

data/util/rake/omfgenerate.rb

@@ -68,7 +68,7 @@ class OmfGenerateTask < Rake::TaskLib
       path = File.join(@gnome_helpfiles_dir, @projectname,
                        locale_for(t.name), "#{@projectname}.xml")
       data = File.read(t.source)
-      data.sub!(/PATH_TO_DOC_FILE/, path)
+      data.sub!("PATH_TO_DOC_FILE", path)
       puts "Generating #{t.name}..."
       File.open(t.name, "w") { |io| io.puts data }
     end